jansvoboda11 added inline comments.

================
Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:36-38
+#if __has_include("d.h") // This should use 'd.modulemap' in order to 
determine that 'd.h'
+                         // doesn't exist for 'c' because of its 
'[no_undeclared_includes]'.
+#endif
----------------
dexonsmith wrote:
> Would it be useful to also add a `#error` or similar inside the `#if`?
Yes, that makes sense. I'll add it before comitting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120464/new/

https://reviews.llvm.org/D120464

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to