[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

2022-03-01 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added subscribers: libc++, libc++ vendors, rsmith, CaseyCarter. ldionne added a comment. Oops, this seems to have happened while I was on vacation. I wanted to have a wider discussion here before shipping the patch. Let's have it now and we can make post-commit changes depending on where

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

2022-03-01 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D120111#3351001 , @tmatheson wrote: > LGTM, please give @nickdesaulniers some time to respond though. I do agree > that iterating over the features repeatedly is less than ideal,

[PATCH] D120132: [HIP] Fix HIP include path

2022-03-01 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D120132#3351999 , @yaxunl wrote: > In D120132#3351853 , @tra wrote: > >> In D120132#3351391 , @yaxunl wrote: >> >>> >> >> >> >>> If any input file

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

2022-03-01 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Missing clang-side changes have landed. Please check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117887/new/ https://reviews.llvm.org/D117887 ___ cfe-commits mailing list cfe-comm

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:43 + + auto Res = ConjunctionVals.try_emplace( + std::move(Key), xazax.hun wrote: > As far as I understand, we need to do the double lookup (`find` and l

[PATCH] D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast

2022-03-01 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added a reviewer: opaque-pointers. ahatanak added a project: clang. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120757 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuilder.h

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

2022-03-01 Thread Florian Mayer via Phabricator via cfe-commits
fmayer updated this revision to Diff 412183. fmayer added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120437/new/ https://reviews.llvm.org/D120437 Files: clang/test/CodeGen/lifetime-sanitizer.c clang/test/CodeGenCXX/l

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

2022-03-01 Thread Florian Mayer via Phabricator via cfe-commits
fmayer marked 2 inline comments as done. fmayer added inline comments. Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress -mllvm -print-before=hwasan %s 2>&1 | \ // RU

[PATCH] D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast

2022-03-01 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lg if check-clang passes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120757/new/ https://reviews.llvm.org/D120757 ___

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

2022-03-01 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 412191. ldionne added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files: clang/cmake/caches/CrossWinToARMLinux.cmake libcxx/CMake

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

2022-03-01 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Thanks for implementing this @egorzhdan! Thanks @ldionne for the notification. `-funstable` is an option that controls multiple flags therefore I think it would be good to have a separate flag to opt-in for unstable/incomplete libc++ features. That makes it easier to _

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:480-482 +if (Tok->TokenText.size() == 1) + return false; return true; Maybe? Comment at:

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Herald added a project: All. In D120398#3352024 , @Quuxplusone wrote: > In D120398#3351998 , > @MyDeveloperDay wrote: > >> Before this lands can we have a discussion about wha

[PATCH] D120712: [clang-format][docs] handle explicit enum values

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Herald added a project: All. In D120712#3352051 , @MyDeveloperDay wrote: > Does it need to be so "cloak and dagger"? ;-) > > We always welcome patches, but please think about logging the idea in github > issues (and

[PATCH] D120712: [clang-format][docs] handle explicit enum values

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. This is just a formality for the hold back. I have no opinion on the actual change. (I keep myself out of the python stuff.) Repository: rG LLVM Github Mon

[PATCH] D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast

2022-03-01 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Herald added a project: All. Yes, check-clang passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120757/new/ https://reviews.llvm.org/D120757 ___ cfe-commits mailing list cfe

[PATCH] D120712: [clang-format][docs] handle explicit enum values

2022-03-01 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk added a comment. In D120712#3352051 , @MyDeveloperDay wrote: > Does it need to be so "cloak and dagger"? ;-) No, you're right it doesn't have to be this way. > We always welcome patches, but please think about logging the idea in github > issues

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

2022-03-01 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk added a comment. In D120398#3352436 , @HazardyKnusperkeks wrote: > > That being said, I don't care that much that we declare the enums with a > type. But I care about consistency. Either land this, or revert D93758 >

[PATCH] D120764: [C++20][Modules] Improve efficiency of isModuleParition method.

2022-03-01 Thread Iain Sandoe via Phabricator via cfe-commits
iains created this revision. Herald added a subscriber: dexonsmith. Herald added a project: All. iains added reviewers: urnathan, ChuanqiXu. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should improve t

[PATCH] D120511: [clang-format] Allow to set token types final

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e7cc72ac91d: [clang-format] Allow to set token types final (authored by HazardyKnusperkeks). Herald added a project: All. Repository: rG LLVM Git

[clang] 1e7cc72 - [clang-format] Allow to set token types final

2022-03-01 Thread Björn Schäpers via cfe-commits
Author: Björn Schäpers Date: 2022-03-01T21:55:31+01:00 New Revision: 1e7cc72ac91d524da80ec6e144dce925a27090fc URL: https://github.com/llvm/llvm-project/commit/1e7cc72ac91d524da80ec6e144dce925a27090fc DIFF: https://github.com/llvm/llvm-project/commit/1e7cc72ac91d524da80ec6e144dce925a27090fc.diff

[clang] 78ac867 - [clang-format] Fix requires related crash

2022-03-01 Thread Björn Schäpers via cfe-commits
Author: Björn Schäpers Date: 2022-03-01T21:55:31+01:00 New Revision: 78ac86701801663d700919e543f4e1129982993d URL: https://github.com/llvm/llvm-project/commit/78ac86701801663d700919e543f4e1129982993d DIFF: https://github.com/llvm/llvm-project/commit/78ac86701801663d700919e543f4e1129982993d.diff

[clang] d6daca2 - [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

2022-03-01 Thread Björn Schäpers via cfe-commits
Author: Björn Schäpers Date: 2022-03-01T21:55:32+01:00 New Revision: d6daca21738aed64837b825c32d4f1b4f54cec04 URL: https://github.com/llvm/llvm-project/commit/d6daca21738aed64837b825c32d4f1b4f54cec04 DIFF: https://github.com/llvm/llvm-project/commit/d6daca21738aed64837b825c32d4f1b4f54cec04.diff

[PATCH] D120512: [clang-format] Fix requires related crash

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78ac86701801: [clang-format] Fix requires related crash (authored by HazardyKnusperkeks). Herald added a project: All. Repository: rG LLVM Github

[PATCH] D120621: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6daca21738a: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs (authored by HazardyKnusperkeks). Herald added a project:

[clang] 5e51ace - [clang-format][docs] Fix a bad comment

2022-03-01 Thread Björn Schäpers via cfe-commits
Author: Krystian Kuzniarek Date: 2022-03-01T21:55:32+01:00 New Revision: 5e51ace4e86ddaec34b5641f28a0ecbb17c8b1f3 URL: https://github.com/llvm/llvm-project/commit/5e51ace4e86ddaec34b5641f28a0ecbb17c8b1f3 DIFF: https://github.com/llvm/llvm-project/commit/5e51ace4e86ddaec34b5641f28a0ecbb17c8b1f3.

[PATCH] D120618: [clang-format][docs] Fix a bad comment

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e51ace4e86d: [clang-format][docs] Fix a bad comment (authored by kuzkry, committed by HazardyKnusperkeks). Herald added a project: All. Repository:

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

2022-03-01 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson updated this revision to Diff 412229. royjacobson edited the summary of this revision. royjacobson set the repository for this revision to rG LLVM Github Monorepo. royjacobson added a comment. Herald added projects: clang, All. Updated test so it checks actual instantiation and update

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

2022-03-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Hmm... doing FileCheck in a Sema test is highly irregular. I would expect us to be able to test this in the type system in some way. Something like `A<3>::f()` is invalid (see -verify). Also, please add all the context (as requested above!) with the -U stuff.

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

2022-03-01 Thread Eric Schweitz via Phabricator via cfe-commits
schweitz added inline comments. Herald added a project: All. Comment at: flang/lib/Frontend/FrontendActions.cpp:561 + std::make_unique(triple); + CodeGenPasses.add(new llvm::TargetLibraryInfoWrapperPass(*TLII)); + Got jumbled around somehow. TLII is allocat

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

2022-03-01 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua updated this revision to Diff 412245. li.zhe.hua added a comment. Herald added a project: All. As discussed offline, switch to using a template instead of Any. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120360/new/ https://reviews.llv

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

2022-03-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, jyknight, rjmccall, rsmith. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: l

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

2022-03-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 412248. aaron.ballman added a comment. Added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, cjdb. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a s

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

2022-03-01 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a subscriber: craig.topper. erichkeane added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:65 bool isLong : 1; // This is *not* set for long long. bool isLongLong : 1; bool isSizeT : 1; // 1z, 1uz (C++2b)

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

2022-03-01 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson updated this revision to Diff 412252. royjacobson added a comment. Adding context. (Sorry - didn't realize you were speaking about the diff itself, thought you meant adding general context to the PR message...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 412256. sgatev added a comment. Herald added a project: All. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/include/clang/

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev marked 2 inline comments as done. sgatev added a comment. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:43 + + auto Res = ConjunctionVals.try_emplace( + std::move(Key), ymandel wrote: > xazax.hun wrote: > > As far

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

2022-03-01 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson added a comment. In D120255#3352755 , @erichkeane wrote: > Hmm... doing FileCheck in a Sema test is highly irregular. I would expect us > to be able to test this in the type system in some way. Something like > `A<3>::f()` is invalid (see

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

2022-03-01 Thread Florian Mayer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fmayer marked an inline comment as done. Closed by commit rG1d730d80ce59: [HWASAN] erase lifetime intrinsics if tag is outside. (authored by fmayer). Repository: rG

[clang] 1d730d8 - [HWASAN] erase lifetime intrinsics if tag is outside.

2022-03-01 Thread Florian Mayer via cfe-commits
Author: Florian Mayer Date: 2022-03-01T14:47:33-08:00 New Revision: 1d730d80ce592fde66b1ba6153f08f72778f94ce URL: https://github.com/llvm/llvm-project/commit/1d730d80ce592fde66b1ba6153f08f72778f94ce DIFF: https://github.com/llvm/llvm-project/commit/1d730d80ce592fde66b1ba6153f08f72778f94ce.diff

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

2022-03-01 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson updated this revision to Diff 412262. royjacobson added a comment. Slightly update the test command line (add -triple %itanium_abi_triple like in other similar tests). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120255/new/ https://r

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Thanks, this looks wonderful! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

2022-03-01 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. Can we use `int8_t` instead of `unsigned char` to keep the enum types signed (and update the changes made in D93758 )? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120398/new/ https://revi

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

2022-03-01 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray updated this revision to Diff 412289. lichray added a comment. Herald added a project: All. - Add a trigraph test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

2022-03-01 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Herald added a project: All. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:36 + llvm::erase_if(Args, [](const std::string &Arg) { +return Arg.find("-fmodules-cache-path=") == 0; + }); Is that t

[PATCH] D120465: [clang][deps] Generate necessary "-fmodule-map-file=" arguments, disable implicit module maps

2022-03-01 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Herald added a project: All. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:112 void dependencies::detail::collectPCMAndModuleMapPaths( llvm::ArrayRef Modules, Should this be renamed? ==

[PATCH] D120463: [clang][modules] NFC: Simplify and clarify test

2022-03-01 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120463/new/ https://reviews.llvm.org/D120463 _

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

2022-03-01 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM, with one test suggestion. Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:36-38 +#if __has_include("d.h") // This

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

2022-03-01 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Herald added a project: All. In D112349#3330918 , @pirama wrote: > Unrelated to missing resolver definition, this change doesn't accommodate > resolvers that take parameters. (Curiously, this verification only fails > with T

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

2022-03-01 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers marked an inline comment as done. vabridgers added a comment. Herald added a project: All. @NoQ - ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 _

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

2022-03-01 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Herald added a subscriber: manas. Herald added a project: All. @NoQ - ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 ___ cfe-

[clang] 44eee65 - [AST] Print NTTP args as string-literals when possible

2022-03-01 Thread Zhihao Yuan via cfe-commits
Author: Zhihao Yuan Date: 2022-03-01T19:34:27-06:00 New Revision: 44eee659f1c530a684fa2e57a983d962b5980620 URL: https://github.com/llvm/llvm-project/commit/44eee659f1c530a684fa2e57a983d962b5980620 DIFF: https://github.com/llvm/llvm-project/commit/44eee659f1c530a684fa2e57a983d962b5980620.diff L

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

2022-03-01 Thread Zhihao Yuan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44eee659f1c5: [AST] Print NTTP args as string-literals when possible (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D120764: [C++20][Modules] Improve efficiency of isModuleParition method.

2022-03-01 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120764/new/ https://reviews.llvm.org/D120764

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

2022-03-01 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. Herald added a project: All. @rsmith gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

2022-03-01 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. Herald added a project: All. ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

2022-03-01 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. Herald added a project: All. ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

2022-03-01 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 412300. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/Too

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

2022-03-01 Thread Peixin Qiao via Phabricator via cfe-commits
peixin added inline comments. Herald added a project: All. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1505 + /// valid in the condition block (i.e., defined in the preheader) and is + /// interpreted as an unsigned integer. + void setTripCount(Value *TripCoun

[clang] cb21607 - [nfc][codegen] Move RegisterBank[Info].h under CodeGen

2022-03-01 Thread Mircea Trofin via cfe-commits
Author: Mircea Trofin Date: 2022-03-01T21:53:25-08:00 New Revision: cb2160760e6768e306cf357be8dd5c4c007ef273 URL: https://github.com/llvm/llvm-project/commit/cb2160760e6768e306cf357be8dd5c4c007ef273 DIFF: https://github.com/llvm/llvm-project/commit/cb2160760e6768e306cf357be8dd5c4c007ef273.diff

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

2022-03-01 Thread Mircea Trofin via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mtrofin marked an inline comment as done. Closed by commit rGcb2160760e67: [nfc][codegen] Move RegisterBank[Info].h under CodeGen (authored by mtrofin). Herald added a

[PATCH] D120713: [clangd] Make dexp command line options sticky

2022-03-01 Thread Chris Lattner via Phabricator via cfe-commits
lattner resigned from this revision. lattner added a comment. Herald added a project: All. I'm not a competent reviewer for clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 _

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-03-01 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e38b295435b: [RISCV] add the MC layer support of Zfinx extension (authored by achieveartificialintelligence). Herald added a project: All. Reposito

[PATCH] D120713: [clangd] Make dexp command line options sticky

2022-03-01 Thread James Henderson via Phabricator via cfe-commits
jhenderson resigned from this revision. jhenderson added a comment. I don't know anything about clangd either. Not sure why I was added as a reviewer :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 __

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-03-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/zfinx-types.ll:5 +; RUN:| FileCheck --check-prefix=RV32IF %s +; RUN: llc -mtriple=riscv32 -mattr=+zfh -target-abi=ilp32f < %s \ +; RUN:| FileCheck --check-prefix=RV32IF %s craig.toppe

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

2022-03-01 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. Herald added a project: All. This patch is a correct implementation against to the abundoned https://reviews.llvm.org/D120475 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 __

[PATCH] D120793: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

2022-03-01 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, urnathan. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. The parameter of `Path` and `Partition` of ActOnModuleImport could be mer

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

2022-03-01 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + ---

[PATCH] D120713: [clangd] Make dexp command line options sticky

2022-03-01 Thread Yevgeny Rouban via Phabricator via cfe-commits
yrouban added subscribers: jhenderson, lattner. yrouban added a comment. In D120713#3353481 , @lattner wrote: > I'm not a competent reviewer for clangd > >> ! In D120713#3353532 , @jhenderson >> wrote: > > I don'

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

2022-03-01 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. More failing cases: `__alignof`, `alignof` (two different categories) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 ___ cfe-commits

[clang] 7a02abf - [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

2022-03-01 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-03-02T07:55:06Z New Revision: 7a02abf06ff94762d8cbce71d0249df25d64721b URL: https://github.com/llvm/llvm-project/commit/7a02abf06ff94762d8cbce71d0249df25d64721b DIFF: https://github.com/llvm/llvm-project/commit/7a02abf06ff94762d8cbce71d0249df25d64721b.diff LOG

[PATCH] D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

2022-03-01 Thread Saiyedul Islam via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a02abf06ff9: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous… (authored by saiislam). Herald added a project: All. R

<    1   2