[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

pengfei updated this revision to Diff 411334. pengfei added a comment. Disscussed with GCC folks. We think it's better to use the same way as D120411 that replacing it with short int. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 411336. Sockke added a comment. Removed the fix for the template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-to

[PATCH] D102555: [libclang] Enhance support for source-to-source rewriting

samvv added a comment. ggeorgakoudis no currently not. It has been stale for about a year. I also don't have a lot of time to to follow up right now, but I'll try to help if there is anything I can do. - Original Message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb updated this revision to Diff 411341. krisb added a comment. Add SM_70 requirement for 'match' builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 Files: clang/include/clang/Basic/BuiltinsNV

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske updated this revision to Diff 411340. balazske added a comment. Removed `isErrnoAvailable`, added test for `getErrnoValue`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 Files: clang/include/

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Errno.h:22 +namespace ento { +namespace errno_check { + steakhal wrote: > balazske wrote: > > steakhal wrote: > > > I think we can settle on s

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. Hm, it looks like enabling PIE has a pretty big negative compile-time impact, with a 20% regression on sqlite3: http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444bdd0e1fbe0a96f6e09779&to=3c4ed02698afec021c6bca80740d1e58e3ee019e&stat=instructions Cod

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

steakhal accepted this revision. steakhal added a comment. Looks great, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 ___ cfe-commits mailing list cfe

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2634-2647 +.. _alpha-unix-cstring-UninitializedRead: + +alpha.unix.cstring.UninitializedRead (C) +"" +Check for uninitialized read from source in memory copy function: ``

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3344938 , @nikic wrote: > Hm, it looks like enabling PIE has a pretty big negative compile-time impact, > with a 20% regression on sqlite3: > http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444bd

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

nikic added a comment. An alternative I suggested on https://github.com/llvm/llvm-project/issues/51165 was to overload these intrinsics by result/value type. I think that would be cleaner design-wise, but it also seems harder to implement (requires custom ISD nodes), so I'm okay with the elemen

[PATCH] D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.

hokein added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Templates.cpp:12 +// +// shouldVisitTemplateInstantiations() controls traversal of AST nodes that +// were created by instantiation, rather than by written code. This means: ---

[PATCH] D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default

hokein added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Templates.cpp:168 extern template int foo<3>(); // Explicit instantiation. Head traversed, body only with instantiations on. template int foo<4>(); What doe

[PATCH] D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default

hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2107 - if (CXXConstructorDecl *Ctor = dyn_cast(D)) { -// Constructor initializers. moving this part of code to `if (VisitBody)` seems like a different fix (and I think

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

curdeius added a comment. In D120445#3344594 , @penagos wrote: > I went ahead and did a git rebase but CI still appears to be failing (though > tests pass in my local clone). Also, I’ll need someone to commit this on my > behalf: > > - Luis Penagos > -

[clang] 6114491 - [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

Author: Iain Sandoe Date: 2022-02-25T09:33:14Z New Revision: 6114491441700cc8a614d284407e9a6e9bf74751 URL: https://github.com/llvm/llvm-project/commit/6114491441700cc8a614d284407e9a6e9bf74751 DIFF: https://github.com/llvm/llvm-project/commit/6114491441700cc8a614d284407e9a6e9bf74751.diff LOG: [

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG611449144170: [C++20][Modules][4/8] Handle generation of partition implementation CMIs. (authored by iains). Changed prior to commit: https://revi

[clang] 2e9439e - [flang][driver] Add support for `--target`/`--triple`

Author: Andrzej Warzynski Date: 2022-02-25T09:38:10Z New Revision: 2e9439e4891c3d427c0fed477b54f3da2ff8ec28 URL: https://github.com/llvm/llvm-project/commit/2e9439e4891c3d427c0fed477b54f3da2ff8ec28 DIFF: https://github.com/llvm/llvm-project/commit/2e9439e4891c3d427c0fed477b54f3da2ff8ec28.diff

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e9439e4891c: [flang][driver] Add support for `--target`/`--triple

[PATCH] D98152: [InstCombine] Canonicalize SPF to min/max intrinsics

nlopes added a comment. This fixed 9 bugs reports by Alive2: - Transforms/InstCombine/max-of-nots.ll - Transforms/InstCombine/max_known_bits.ll - Transforms/InstCombine/minmax-fold.ll - Transforms/InstCombine/saturating-add-sub.ll - Transforms/InstCombine/select-pr39595.ll - Transforms/InstCombin

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske updated this revision to Diff 411363. balazske added a comment. Fixed remaining problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 Files: clang/include/clang/StaticAnalyzer/Checkers/Chec

[clang] b48e3c8 - [OpenCL] opencl-c.h: Fix incorrect get_image_width guard

Author: Sven van Haastregt Date: 2022-02-25T11:05:56Z New Revision: b48e3c805c253d0a1194bede81b3f8e225f40824 URL: https://github.com/llvm/llvm-project/commit/b48e3c805c253d0a1194bede81b3f8e225f40824 DIFF: https://github.com/llvm/llvm-project/commit/b48e3c805c253d0a1194bede81b3f8e225f40824.diff

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 updated this revision to Diff 411368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 Files: clang/include/clang/Lex/Lexer.h clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatToken

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. Unfortunately after change there is lifetime issue in FormatTokenLexer because LangOpts received from getFormattingLangOpts has automatic storage duration and Lexer gets reference to it. Fix issue and poke CI to make sure clang-tools-extra tests on CI are passing. For

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. In D120334#3340639 , @cor3ntin wrote: > I like this approach. it seems a lot easier to maintain as people don't have > to remember to use LangOptionsBase to not degrade performance I like it either but we need to be careful abo

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:94 + // LangOpts enabled by this language. + const LangOptions &LangOpts; + cor3ntin wrote: > Should we add a comment to explain why this is a reference? Good idea. It will be added.

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

thakis added a comment. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120484/new/ https://reviews.llvm.org/D120484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

Sockke updated this revision to Diff 411372. Sockke added a comment. Removed the fix for the virtual function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116439/new/ https://reviews.llvm.org/D116439 Files: clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-t

[clang] 29b512b - [clang][analyzer] Add modeling of 'errno'.

Author: Balázs Kéri Date: 2022-02-25T12:42:55+01:00 New Revision: 29b512ba322cb6dd2c45d5e07645e20db47fad0d URL: https://github.com/llvm/llvm-project/commit/29b512ba322cb6dd2c45d5e07645e20db47fad0d DIFF: https://github.com/llvm/llvm-project/commit/29b512ba322cb6dd2c45d5e07645e20db47fad0d.diff L

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29b512ba322c: [clang][analyzer] Add modeling of 'errno'. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 411375. achieveartificialintelligence added a comment. Thanks for @craig.topper's patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D114425: [clang] Add __builtin_bswap128

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:64 +- Maximum _ExtInt size was decreased from 16,777,215 bits to 8,388,608 bits. + Motivation for this was discussed in PR51829. +- Configuration file syntax extended with token. This expands to ---

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit; can you also add a release note about the fix to clang-tools-extra/docs/ReleaseNotes.rst? Comment at: clang-tools-extra/clang-tidy/read

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

aaron.ballman added a comment. > Also implemented decltype(auto)(x) (https://wg21.link/p0849r2) as a Clang > extension. I'd like to better understand the use cases for this. WG21 considered this as part of the feature and ultimately rejected it (fairly strongly, according to the EWG polls). Fr

[clang] f9e8e92 - Revert "[clang][analyzer] Add modeling of 'errno'."

Author: Aaron Ballman Date: 2022-02-25T07:21:01-05:00 New Revision: f9e8e92cf586d9cf077139a338f062a91b8ce2d2 URL: https://github.com/llvm/llvm-project/commit/f9e8e92cf586d9cf077139a338f062a91b8ce2d2 DIFF: https://github.com/llvm/llvm-project/commit/f9e8e92cf586d9cf077139a338f062a91b8ce2d2.diff

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

aaron.ballman added a comment. Hello! I had to revert in f9e8e92cf586d9cf077139a338f062a91b8ce2d2 because this broke all of the builds on Windows. Here are some sample failures: https://lab.llvm.org/buildbot/#/builders/86/bui

[PATCH] D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.

sammccall added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Templates.cpp:12 +// +// shouldVisitTemplateInstantiations() controls traversal of AST nodes that +// were created by instantiation, rather than by written code. This means:

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 411379. achieveartificialintelligence added a comment. Ping & Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clan

[PATCH] D120504: [AST] RAV doesn't traverse explicitly instantiated function bodies by default

sammccall added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2107 - if (CXXConstructorDecl *Ctor = dyn_cast(D)) { -// Constructor initializers. hokein wrote: > moving this part of code to `if (VisitBody)` seems like a differen

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

melver requested changes to this revision. melver added a comment. This revision now requires changes to proceed. Looks good. Few minor changes. I did some more digging, and it's only fsanitize=local-bounds, so please verify this and also update the commit description. In fact, the Linux kernel

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

melver added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757 SanOpts.set(SanitizerKind::HWAddress, false); + if (mask & SanitizerKind::LocalBounds) +Fn->addFnAttr(llvm::Attribute::NoSanitizeBounds); These 2 checks can

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411383. xbolva00 added a comment. Herald added a subscriber: jdoerfert. Fixed tests. Addressed review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1764 +def NoInline : DeclOrStmtAttr { + let Spellings = [Clang<"noinline">, Declspec<"noinline">]; + let Documentation = [NoInlineDocs]; aaron.ballman wrote: > xbolva00 wrote: > > Wha

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

whisperity created this revision. whisperity added reviewers: aaron.ballman, steakhal. whisperity added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, martong, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun. whisperity requested review of this revision. Herald added a su

[PATCH] D120557: [HIP] File device library ABI version file name

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, jvesely. yaxunl requested review of this revision. It should be oclc_abi_version* instead of abi_version*. https://reviews.llvm.org/D120557 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

yaxunl added a comment. In D120366#3344428 , @shangwuyao wrote: > @yaxunl I saw that you added the test recently, could you provide some > context? I think this test is broken at HEAD as I saw it is broken for other > patches (see this build >

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

yaxunl added a comment. In D120366#3345401 , @yaxunl wrote: > In D120366#3344428 , @shangwuyao > wrote: > >> @yaxunl I saw that you added the test recently, could you provide some >> context? I think this test i

[PATCH] D120529: Disable broken hip test on Windows

yaxunl added a comment. Sorry I missed this failure. Thanks for disabling it. I will come up with a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120529/new/ https://reviews.llvm.org/D120529 ___ cf

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

steakhal added a comment. Reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120555/new/ https://reviews.llvm.org/D120555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D120563: [HIP] Fix test hip-link-bundled-archive.hip

yaxunl created this revision. yaxunl added reviewers: tra, shangwuyao. yaxunl requested review of this revision. match pattern should match lld.exe on windows https://reviews.llvm.org/D120563 Files: clang/test/Driver/hip-link-bundle-archive.hip Index: clang/test/Driver/hip-link-bundle-archi

[PATCH] D120529: Disable broken hip test on Windows

yaxunl added a comment. https://reviews.llvm.org/D120563 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120529/new/ https://reviews.llvm.org/D120529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 27d39e4 - Use function prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-02-25T09:08:27-05:00 New Revision: 27d39e4da0b45a93a16f932be66a3607cba1d116 URL: https://github.com/llvm/llvm-project/commit/27d39e4da0b45a93a16f932be66a3607cba1d116 DIFF: https://github.com/llvm/llvm-project/commit/27d39e4da0b45a93a16f932be66a3607cba1d116.diff

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, please add a release note for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120555/new/ https://reviews.llvm.org/D1

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske updated this revision to Diff 411398. balazske added a comment. Rename of "Errno.h", maybe fixes Windows build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 Files: clang/include/clan

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev updated this revision to Diff 411400. sgatev marked 5 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120289/new/ https://reviews.llvm.org/D120289 Files: clang/in

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev added a comment. > Are there plans to get a model/assignment of the variables from the solver? > That could be helpful for generating warning messages in the future :) Absolutely! That was only discussed briefly so far. One challenge would be distilling this model to present only relevan

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl planned changes to this revision. yaxunl added a comment. I just found one issue with the current patch. It adds HIP include path for non-HIP programs. We should only add HIP include path for JobAction with HIP offloading kind. However, AddClangSystemIncludeArgs is not per job action. I

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

cdevadas created this revision. cdevadas added reviewers: rjmccall, Anastasia, yaxunl, arsenm. Herald added subscribers: Naghasan, ldrumm, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. cdevadas requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a proj

[clang] 53dcd9e - [clang][dataflow] Add SAT solver interface and implementation

Author: Stanislav Gatev Date: 2022-02-25T14:46:52Z New Revision: 53dcd9efd16fc881b01470767ac17c4b221f3e08 URL: https://github.com/llvm/llvm-project/commit/53dcd9efd16fc881b01470767ac17c4b221f3e08 DIFF: https://github.com/llvm/llvm-project/commit/53dcd9efd16fc881b01470767ac17c4b221f3e08.diff LO

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53dcd9efd16f: [clang][dataflow] Add SAT solver interface and implementation (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tmatheson requested changes to this revision. tmatheson added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:269 success = getAArch64MicroArchFeaturesFromMcpu( -D, getAArch64TargetCPU(Args, Tri

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

aaron.ballman added reviewers: rjmccall, rsmith, erichkeane. aaron.ballman added a comment. In D120296#3343673 , @yonghong-song wrote: > @aaron.ballman ping, did you get time to look at this patch? Sorry, I was in C meetings all last week, still diggin

[PATCH] D120567: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein created this revision. ibookstein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The purpose of this change is to fix the following codegen bug: // main.c __attribute__((cpu_specific(generic))) int *foo(void) { static int

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

steakhal added a comment. In D120555#3345471 , @aaron.ballman wrote: > LGTM, please add a release note for the fix. That being said, should backport this to clang-14? @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

yaxunl added a comment. One of my concerns is that all kernels are duplicated which may cause code object size doubled. Do we need to make the clone always_inline and let the kernel call its clone to avoid duplicate function bodies? Or LLVM has some pass to do that? Another concern is that the

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:269 success = getAArch64MicroArchFeaturesFromMcpu( -D, getAArch64TargetCPU(Args, Triple, A), Args, Features); +D, getAArch64TargetCPU(Args, Triple, A), Args, Features, AF)

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

steakhal added a comment. according to the pre-merge checks it still fails on windows and Debian. https://buildkite.com/llvm-project/premerge-checks/builds/81130#ce8f3062-699e-4043-aed9-b891ec8ebee6 https://buildkite.com/llvm-project/premerge-checks/builds/81130#53beb4a2-2c53-4ff0-b60f-6130ed5d25c

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

aaron.ballman added a comment. In D120555#3345603 , @steakhal wrote: > In D120555#3345471 , @aaron.ballman > wrote: > >> LGTM, please add a release note for the fix. > > That being said, should backport this to c

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein updated this revision to Diff 411409. ibookstein edited the summary of this revision. ibookstein added a comment. Changed code to generating a function declaration and 'upgrading' it to an ifunc instead of generating and ifunc and 'downgrading' it to a function declaration. I decided ag

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

arsenm added a comment. In D120566#3345604 , @yaxunl wrote: > One of my concerns is that all kernels are duplicated which may cause code > object size doubled. Not really, the kernel should just be a stub that calls the real implementation function. In

[PATCH] D120566: [OpenCL][AMDGPU]: Do not allow a call to kernel

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9238 +static llvm::Function *getKernelClone(llvm::Function &F) { + llvm::Module *M = F.getParent(); I don't think we can really start with the function IR. The TargetABIInfo could be d

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

whisperity updated this revision to Diff 411413. whisperity added a comment. Added //Release notes// entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120555/new/ https://reviews.llvm.org/D120555 Files: clang-tools-extra/clang-tidy/readabilit

[clang-tools-extra] 416e689 - [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

Author: Whisperity Date: 2022-02-25T16:24:27+01:00 New Revision: 416e689ecda66616da855c82f7ec652657730c6a URL: https://github.com/llvm/llvm-project/commit/416e689ecda66616da855c82f7ec652657730c6a DIFF: https://github.com/llvm/llvm-project/commit/416e689ecda66616da855c82f7ec652657730c6a.diff LO

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG416e689ecda6: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments… (authored by whisperity). Repository: rG LLVM Github M

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein added a comment. Ah, I saw your comment just now, good thing I didn't continue down that plain-alias-name route then! The change now satisfies that requirement in a way that binding against the alias name indeed would not: TU1 will have the callsite in `caller` bind against `foo.ifun

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

erichkeane added a comment. In D120266#3345649 , @ibookstein wrote: > Ah, I saw your comment just now, good thing I didn't continue down that > plain-alias-name route then! > The change now satisfies that requirement in a way that binding against the >

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb updated this revision to Diff 411416. krisb added a comment. Fix a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Headers/__cl

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

whisperity added a comment. Thanks! I'll re-run the tests on top of **14.0** and do the backport too, soon. 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120555/new/ https://reviews.llvm.org/D120555 _

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski added a comment. Thank you all for taking a look! I've just realised this: "This revision was not accepted when it landed; it landed in state Needs Review." Just to clarify, I merged this as two reviewers accepted this in comments (with "LGTM"). Also, I believe that I addressed all

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

Quuxplusone added a comment. In D113393#3345275 , @aaron.ballman wrote: >> Also implemented decltype(auto)(x) (https://wg21.link/p0849r2) as a Clang >> extension. > > I'd like to better understand the use cases for this. WG21 considered this as > part

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

DavidTruby added a comment. In D120323#3341468 , @efriedma wrote: > Is there a corresponding ARM specification update for this? We are planning on updating the specification in future for this but are waiting on some other changes first. What we're inte

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske added a comment. The "hip-link-bundle-archive" test looks really unrelated, the others are fixed if we go back to `-DERRNO_VAR` (no `"` characters in command line, and probably `/` does not work too). There are Debian build errors but these look unrelated(?). Repository: rG LLVM Gi

[clang] 5048a58 - [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it

Author: Kristóf Umann Date: 2022-02-25T17:51:37+01:00 New Revision: 5048a58a6792ee7432b749a48c937cc9b6a9dc93 URL: https://github.com/llvm/llvm-project/commit/5048a58a6792ee7432b749a48c937cc9b6a9dc93 DIFF: https://github.com/llvm/llvm-project/commit/5048a58a6792ee7432b749a48c937cc9b6a9dc93.diff

[PATCH] D120325: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5048a58a6792: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not… (authored by Szelethus). Changed prior to commit: h

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

njames93 added a comment. In D120555#3345664 , @whisperity wrote: > Thanks! I'll re-run the tests on top of **14.0** and do the backport too, > soon. 🙂 If you backport, the release notes change on trunk should then be reverted. Repository: rG LLVM

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

aaron.ballman added a comment. In D113393#3345672 , @Quuxplusone wrote: > In D113393#3345275 , @aaron.ballman > wrote: > >>> Also implemented decltype(auto)(x) (https://wg21.link/p0849r2) as a Clang >>> extensi

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske updated this revision to Diff 411421. balazske added a comment. Another try to fix the test failures, rebased to current main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 Files: clang/inclu

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

steakhal added a comment. In D120310#3345696 , @balazske wrote: > The "hip-link-bundle-archive" test looks really unrelated, the others are > fixed if we go back to `-DERRNO_VAR` (no `"` characters in command line, and > probably `/` does not work too).

[clang] c5e1b5e - [Clang][Sema] Do not evaluate value-dependent immediate invocations

Author: Evgeny Shulgin Date: 2022-02-25T17:23:36+01:00 New Revision: c5e1b5e6a99f1ab78dafb54262d8f1fff998cb26 URL: https://github.com/llvm/llvm-project/commit/c5e1b5e6a99f1ab78dafb54262d8f1fff998cb26 DIFF: https://github.com/llvm/llvm-project/commit/c5e1b5e6a99f1ab78dafb54262d8f1fff998cb26.diff

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e1b5e6a99f: [Clang][Sema] Do not evaluate value-dependent immediate invocations (authored by Izaron, committed by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

cor3ntin added a comment. In D119375#3329014 , @Izaron wrote: > A friendly ping =) Seems like I don't have write access, so unfortunately I > have to ask people to merge commits on my behalf. Let me copy-paste the usual > comment of my reviews: I lande

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski created this revision. awarzynski added reviewers: rovka, clementval, schweitz, Leporacanthicus. Herald added subscribers: Chia-hungDuan, mehdi_amini, dang, rriddle, pengfei, kristof.beyls, mgorny. Herald added a reviewer: sscalpone. Herald added a project: Flang. awarzynski requested r

[PATCH] D120569: [clang] Improve laziness of resolving module map headers.

adamcz created this revision. adamcz added a reviewer: kadircet. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang has support for lazy headers in module maps - if size and/or modtime and provided in the cppmap file, headers are

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

cor3ntin added a comment. > This option sounds quite sensible to me! I'd like that too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 ___ cfe-commits mailing

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

RKSimon added a comment. @MaskRay The ppc buildbots have been red since these patches - please can you take a look? https://lab.llvm.org/buildbot/#/builders/57/builds/15454 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

schweitz added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:43 using namespace Fortran::frontend; +using namespace llvm; You'll want to keep in mind that some class names are overloaded between llvm and Fortran::xyz namespaces and even

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @aaron.ballman Thanks for suggestion. Agree that Having a new Type is a better idea. I guess, I will add BTFTagAttributeType which extends AttributeType to see whether it works or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

erichkeane added a comment. In D120296#3345831 , @yonghong-song wrote: > @aaron.ballman Thanks for suggestion. Agree that Having a new Type is a > better idea. I guess, I will add BTFTagAttributeType which extends > AttributeType to see whether it work

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @erichkeane Thanks for suggestion. I will add as an independent type then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 ___ cf

  1   2   >