[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

tyb0807 updated this revision to Diff 409796. tyb0807 added a comment. Remove reference to unused ACLE macro `__ARM_FEATURE_CRYPTO` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118757/new/ https://reviews.llvm.org/D118757 Files: clang/lib/Basic

[clang] 9ce0909 - Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments"

Author: Matthew Voss Date: 2022-02-17T14:32:10-08:00 New Revision: 9ce09099bba4be68d2a269b0bfd2b1dcc67f02d4 URL: https://github.com/llvm/llvm-project/commit/9ce09099bba4be68d2a269b0bfd2b1dcc67f02d4 DIFF: https://github.com/llvm/llvm-project/commit/9ce09099bba4be68d2a269b0bfd2b1dcc67f02d4.diff

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

pirama added subscribers: pirama, srhines, kongyi. pirama added a comment. Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters. (Curiously, this verification only fails with ThinLTO). // with -flto=full or without -flto=thin, below command

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

ormris added a comment. Hi Shangwu, I've reverted this change to unblock the buildbots and our internal CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207 ___

[clang] 0b5fe2c - [clang] Remove Address::deprecated() in emitVoidPtrDirectVAArg()

Author: Arthur Eubanks Date: 2022-02-17T15:05:50-08:00 New Revision: 0b5fe2c9f2e5bdfb111068fab1f6689c066422aa URL: https://github.com/llvm/llvm-project/commit/0b5fe2c9f2e5bdfb111068fab1f6689c066422aa DIFF: https://github.com/llvm/llvm-project/commit/0b5fe2c9f2e5bdfb111068fab1f6689c066422aa.diff

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry added a comment. First of all, thanks @MyDeveloperDay for the approval. In D119682#3321965 , @MyDeveloperDay wrote: > @HazardyKnusperkeks could you validate the `IndentRequiresClause` I know I > added `IndentRequires` in 13 but is this the same

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118525/new/ https://reviews.llvm.org/D118525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire added a comment. gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D112916: Confusable identifiers detection

rsmith added a comment. In D112916#3290365 , @serge-sans-paille wrote: > @rsmith : once the licensing issue has been fixed, can we merge that patch or > do you have any other thought? I have no concerns once the licensing question is resolved and the o

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

rsmith accepted this revision. rsmith added a comment. Looks good. Do you need someone to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___ c

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP. The run

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jdoerfert added a comment. I'd go with `config::mayRequireThreadSpecificState` or sth. Also some documentation there. you should be able to use assertions, like `ASSERT(false && "")`. Which gives us messages in assert mode if violated. Clang documentation should be something like `no thread

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409845. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409847. jhuber6 added a comment. Change name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 409849. keith added a comment. Update to read CPU from sysctl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp ll

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added a comment. Thanks for the tips! I left the default as generic here, but I totally take your point on defaulting to the newest and I'm happy to update if you feel strongly, lmk what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Last nit, otherwise LG Comment at: openmp/libomptarget/DeviceRTL/src/State.cpp:385 + if (!config::mayUseThreadStates()) +ASSERT(false && "Thread state modified whi

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409850. jhuber6 added a comment. Changing assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/include/cl

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

jrtc27 added inline comments. Comment at: llvm/lib/Support/Host.cpp:1320 + int Error = sysctlbyname("hw.cpufamily", &Family, &Length, NULL, 0); + assert(!Error && "Fetching hw.cpufamily failed"); Not sure this should be an assert? I think other implementation

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. In D99134#3331259 , @rsmith wrote: > Looks good. Do you need someone to land this for you? Yes, I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.ll

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

ye-luo added a comment. Change title threat state to thread state Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D120084: [clang][DOC] Document module mangler changes

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120084/new/ https://reviews.llvm.org/D120084 ___ cfe-commits mailing list cfe-co

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. Thanks for explanation. Now it looks good to me. Let's accept it formally after the series of partition landed and so that we could add test about partitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); iains wrote: > urnathan wrote: > > iains wrote: > > > ChuanqiXu wrote: > > > > I chose '-' i

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:527 +} +return StringRef(Name); + } Here we could return `Name` simply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/

[PATCH] D119998: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef-analysis`

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119998/new/ https://reviews.llvm.org/D119998 __

[PATCH] D119998: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef-analysis`

MaskRay added a comment. > enable_noundef_analysis `-enable-noundef-analysis` If there is a need for an alias `-disable-noundef-analysis`, we can add it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119998/new/ https://reviews.llvm.org/D1

<    1   2   3