[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG65aa47301372: [clang][utils] Remove StringRef lldb summary provider (authored by kastiglione). Repository: rG LLVM Gith

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added a comment. I haven't investigated the use case yet, just commented a few things. Please split the patch into 3: - BinaryFormat/ELF.h (see an inline comment) - lld/ELF - clang Comment at: lld/ELF/SyntheticSections.cpp:3842 +static constexpr char kMemtagAndroidN

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added inline comments. Comment at: lld/ELF/SyntheticSections.cpp:3871 + return sizeof(llvm::ELF::Elf64_Nhdr) + + /* namesz */ sizeof(kMemtagAndroidNoteName) + + /* descsz */ sizeof(uint32_t); `/*namesz=*/` Comment at: l

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 _

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 405820. steffenlarsen added a comment. Adjusted for comments and introduced common handling for creating attributes with delayed arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: c

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen marked 3 inline comments as done. steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:421-424 + // Parse variadic identifier arg. This can either consume identifiers or + // expressions. + // FIXME: Variadic identifier args

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118915/new/ https://reviews.llvm.org/D118915 _

[PATCH] D118890: [clang][deps] Disable global module index

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. I agree that testing this isn't really necessary given the difficulty of even constructing one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405827. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files:

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11206 +if (!E->isInstantiationDependent()) { + auto Type = E->getType(); + if (!Type->isScalarType()) { ABataev wrote: >

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. It looks like `_paravirt_ident_64()` is the problematic function. This diff on top of v5.17-rc2 allows me to boot: diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 4420499f7bb4..c1b68504136c 100644 --- a/arch/x86/kernel/paravirt.c +

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405837. tianshilei1992 added a comment. add final test and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/Diag

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3295477 , @nathanchance wrote: > It looks like `_paravirt_ident_64()` is the problematic function. This diff > on top of v5.17-rc2 allows me to boot: > > diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravi

[clang] 8cc4ca9 - [OpenMP] Add Cuda path to linker wrapper tool

Author: Joseph Huber Date: 2022-02-03T20:39:18-05:00 New Revision: 8cc4ca95b02bc5b5b668b3d537b45a6585575cba URL: https://github.com/llvm/llvm-project/commit/8cc4ca95b02bc5b5b668b3d537b45a6585575cba DIFF: https://github.com/llvm/llvm-project/commit/8cc4ca95b02bc5b5b668b3d537b45a6585575cba.diff

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc4ca95b02b: [OpenMP] Add Cuda path to linker wrapper tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked 9 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1536 +enum { + NT_TYPE_IDENT = 1, + NT_TYPE_KUSER = 3, MaskRay wrote: > If Android wants to define notes, can it use a namespace `NT_ANDROID_*`

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405839. hctim marked an inline comment as done. hctim added a comment. Address Ray's comments, and made it so that stack MTE doesn't imply heap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://r

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. In D110869#3295559 , @void wrote: > Weird. We generate similar code to GCC: > > Clang: > _paravirt_ident_64: # @_paravirt_ident_64 > movq%rdi, %rax > xorq%rdi, %rdi >

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. In D118948#3295321 , @MaskRay wrote: > I haven't investigated the use case yet, just commented a few things. Please > split the patch into 3: > > - BinaryFormat/ELF.h (see an inline comment) > - lld/ELF > - clang Can you clarify w

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405842. hctim added a comment. (forgot to add REQUIRES: aarch64 to the lld test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/Diag

[PATCH] D118949: [HIP] Support code object v5

yaxunl marked 2 inline comments as done. yaxunl added a comment. Will revise as recommended when committing. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118949/new/ https://reviews.llvm.org/D118949 ___ cfe-commits mailing list cfe-c

[PATCH] D118964: Fix broken 2-stage build when -tblgen tools may depend on runpath that is not yet built

arcivanov created this revision. arcivanov added reviewers: LLVM, clang. arcivanov added projects: clang, LLVM. Herald added a subscriber: mgorny. arcivanov requested review of this revision. Herald added a subscriber: cfe-commits. In my case `-tblgen` tools in the **second stage** end up being bu

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

kkwli0 created this revision. kkwli0 added reviewers: jhuber6, jdoerfert. Herald added subscribers: guansong, yaxunl. kkwli0 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add the search path for llvm-strip instead of solely relyi

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

owenpan created this revision. owenpan added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `l_brace` token in a macro definition s

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

Bhramar.vatsa added a comment. @dblaikie The condition "FieldClass->isPOD()" returns false for the following case (when considering field 'struct foo t' of 'struct foo1') : class foo { foo() = default; int _a; }; struct foo1 { struct foo t; } t1; The same code though

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. In D118104#3294883 , @LegalizeAdulthood wrote: > What is the feasibility of Python unit tests Instead of a heavy-weight `lit` > oriented test? I don't know the code-base well enough to answer that. Is python used for testing pu

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3295578 , @nickdesaulniers wrote: > In D110869#3295559 , @void wrote: > >> Weird. We generate similar code to GCC: >> >> Clang: >> _paravirt_ident_64: # @_

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

curdeius added a comment. Well, I thought about this approach but actually a macro line should never be merged together with a preceding line, so I went for a generic approach. That's because one never knows what's in a macro, it can well be a function brace after all depending on what goes befo

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

craig.topper added a comment. In D110869#3295906 , @void wrote: > In D110869#3295578 , > @nickdesaulniers wrote: > >> In D110869#3295559 , @void wrote: >> >>> Weird. We g

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. This seems OK. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118257/new/ https://reviews.llvm.org/D118257 __

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

linjamaki added a comment. Thanks for the review, @yaxunl. Could you push this to the LLVM? And to the LLVM 14 release branch too, if possible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876 ___

<    1   2   3