[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman added a comment. Ping @jyknight or @rsmith for any final thoughts or concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117238/new/ https://reviews.llvm.org/D117238 ___ cfe-commits mai

[PATCH] D117777: [OpenMP] Don't pass empty files to nvlink

jhuber6 updated this revision to Diff 401646. jhuber6 added a comment. Herald added a subscriber: asavonic. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files: clang/test/Driver/Inputs/op

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:468 + + // General case. Parse all available expressions. + CommaLocsTy CommaLocs; I think it'd be good to move this comment up closer to the `else` on line 461 so that it's

[PATCH] D117777: [OpenMP] Don't pass empty files to nvlink

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 ___

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { dexonsmith wrote: > aaron.ballman wrote: > > dexonsmith wrote

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

dmgreen added a comment. Thanks for the update. Same(ish) questions for the Arm side. Otherwise this LGTM Comment at: llvm/include/llvm/Support/ARMTargetParser.def:332 +ARM_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + ARM::AEK_RAS) ARM_CPU_NAM

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, fhahn. RKSimon requested review of this revision. Herald added a project: clang. D111986 added the generic `__builtin_elementwise_abs()` intrinsic with the same integer absolute beha

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

dmgreen added a comment. Oh, also is there an ID for this CPU that is worth adding to getHostCPUNameForARM in Host.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 ___

[PATCH] D117792: [clangd][Background] Make index validation logs verbose

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, kristof.beyls. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These errors are

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone updated this revision to Diff 401652. Quuxplusone added a comment. Clang-formatted. @mizvekov or @rsmith: ping? I'd like to get this in before Feb 1, which is the release/14.x branch date AFAIK; because it affects workarounds in libc++ and thus makes a difference whether we will be

[PATCH] D117304: [clang][dataflow] Remove TestingSupport's dependency on gtest

jyknight added a comment. Herald added a subscriber: steakhal. > Users outside of the clang repo may use different googletest versions. I don't understand what that means. Why does it matter what version outside users are using -- these are clang unit-tests, not a public API, right? Repositor

[PATCH] D117232: [clang] Improve -Wdeclaration-after-statement

melver updated this revision to Diff 401653. melver marked 4 inline comments as done. melver retitled this revision from "[clang] Respect -Wdeclaration-after-statement with C99 or later" to "[clang] Improve -Wdeclaration-after-statement". melver edited the summary of this revision. melver added a

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay added a comment. I think its been fixed, in the last but one diff. Generally speaking we simply cannot have --output-replacements-xml , -n or --dry-run show replacements that amount to nothing because this is the mechanism by which 100s of repos fail commits thinking their is a c

[PATCH] D117776: [clangd] Fail inlayHints requests on content changes

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems right for consistency with SemanticHighlights. However I don't think it will much improve the jumpiness you refer to - there's no time-based debounce here, so it only helps if

[clang] 990bab8 - [ScalableVectors] Warn instead of error for invalid size requests.

Author: Sander de Smalen Date: 2022-01-20T16:42:08Z New Revision: 990bab89fff75b9afb98762f6e90eb634afc6d42 URL: https://github.com/llvm/llvm-project/commit/990bab89fff75b9afb98762f6e90eb634afc6d42 DIFF: https://github.com/llvm/llvm-project/commit/990bab89fff75b9afb98762f6e90eb634afc6d42.diff L

[PATCH] D117795: [AArch64] Fixes for strict FP vector instructions

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added subscribers: hiraditya, kristof.beyls. john.brawn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Fix several thi

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401659. ksyx added a comment. Add unit test for formatting conflict CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/DefinitionBlockSeparator.cpp clang/lib/Format/DefinitionBlockSep

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, fhahn. RKSimon requested review of this revision. Herald added a project: clang. D111985 added the generic `__builtin_elementwise_max` and `__builtin_elementwise_min` intrinsics with

[PATCH] D117304: [clang][dataflow] Remove TestingSupport's dependency on gtest

gribozavr2 added a comment. > Why does it matter what version outside users are using -- these are clang > unit-tests, not a public API, right? clang/unittests/Analysis/FlowSensitive/TestingSupport.h is a public API for writing tests for dataflow analyses. Repository: rG LLVM Github Monorep

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

craig.topper added a comment. Just to confirm since I can't see the tests. builtin_elementwise_abs is not undefined for INT_MIN? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117791/new/ https://reviews.llvm.org/D117791 __

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117798/new/ https://reviews.llvm.org/D117798 ___

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1088 } + +SVal clang::ento::SValBuilder::simplifySymbolCast(nonloc::SymbolVal V, Notify the user about the contract. Comment at: clang/lib/StaticAna

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1088 } + +SVal clang::ento::SValBuilder::simplifySymbolCast(nonloc::SymbolVal V, ASDenysPetrov wrote: > Notify the user about the contract. Mistake. `CastTy`, not `Saf

[PATCH] D117232: [clang] Improve -Wdeclaration-after-statement

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit with the release notes. Comment at: clang/docs/ReleaseNotes.rst:61 +- Support -Wdeclaration-after-statement with C99 and later sta

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

dmgreen added inline comments. Comment at: clang/lib/Headers/arm_acle.h:736 +#define __arm_mops_memset_tag(tagged_address, value, size) \ + __builtin_arm_mops_memset_tag(tagged_address, value, size) +#endif The arguments are better named __v

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

dmgreen added inline comments. Comment at: clang/lib/Headers/arm_acle.h:736 +#define __arm_mops_memset_tag(tagged_address, value, size) \ + __builtin_arm_mops_memset_tag(tagged_address, value, size) +#endif dmgreen wrote: > The arguments are

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added a comment. Ping. Still waiting for a review on this check. The implementation isn't particularly long or complicated, so it should not take much time to review. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 ___

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401671. dgoldman marked 4 inline comments as done. dgoldman added a comment. Support private headers + private umbrellas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D1170

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:326 +auto Path = FE->getName(); +auto It = CachePathToFrameworkSpelling.find(Path); +if (It != CachePathToFrameworkSpelling.end()) sammccall wrote: > any re

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added a comment. In D117056#3256538 , @sammccall wrote: > This looks good now, only blocker is dropping the change to LookupFile > somehow. > > Is it valuable to land this before the imminent 14 branch cut? I think it's > OK but as an indexing

[clang] 5af2433 - [clang-cl] Support the /HOTPATCH flag

Author: Alexandre Ganea Date: 2022-01-20T12:57:19-05:00 New Revision: 5af2433e1794ebf7e58e848aa612c7912d71dc78 URL: https://github.com/llvm/llvm-project/commit/5af2433e1794ebf7e58e848aa612c7912d71dc78 DIFF: https://github.com/llvm/llvm-project/commit/5af2433e1794ebf7e58e848aa612c7912d71dc78.dif

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aganea marked 3 inline comments as done. Closed by commit rG5af2433e1794: [clang-cl] Support the /HOTPATCH flag (authored by aganea). Changed prior to commit: https:

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron updated this revision to Diff 401679. Izaron added a comment. Fixed: make docs more explicit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117613/new/ https://reviews.llvm.org/D117613 Files: clang/docs/LibASTMatchersReference.html clang

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

RKSimon added a comment. In D117791#3258602 , @craig.topper wrote: > Just to confirm since I can't see the test CHECK lines. > builtin_elementwise_abs is not undefined for INT_MIN? That's why I added a copy of the check (from llvm-project\clang\test\C

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron added a comment. Thanks! Let's see if docs are more explicit and nicer now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117613/new/ https://reviews.llvm.org/D117613 ___ cfe-commits mailing list

[PATCH] D117806: [OpenMP] Remove overriding visibility for device declarations

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ABataev. Herald added subscribers: asavonic, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch removes the speci

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Preprocessor/riscv-target-features.c:221 // RUN: -o - | FileCheck --check-prefix=CHECK-V-EXT %s -// CHECK-V-EXT: __riscv_v 1 +//

[PATCH] D117777: [OpenMP] Don't pass empty files to nvlink

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf5600420b93: [OpenMP] Don't pass empty files to nvlink (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llv

[clang] af56004 - [OpenMP] Don't pass empty files to nvlink

Author: Joseph Huber Date: 2022-01-20T13:12:02-05:00 New Revision: af5600420b93769a5c7981d247d37ac4d61cce54 URL: https://github.com/llvm/llvm-project/commit/af5600420b93769a5c7981d247d37ac4d61cce54 DIFF: https://github.com/llvm/llvm-project/commit/af5600420b93769a5c7981d247d37ac4d61cce54.diff

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401684. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401687. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron added a comment. In D117613#3258854 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? If so, what name and > email address would you like used for patch attribution? Sorry, I should have set the Author property of the

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

carlosgalvezp added a comment. Looks good! I need to familiarize myself better with the `Loc` manipulation code to be able to review the free-standing function but otherwise looks reasonable. Comment at: clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp:22 +

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

carlosgalvezp added a comment. There's also a negative vote from @alexfh , what about that? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] b80db15 - Add `isConsteval` matcher

Author: Evgeny Shulgin Date: 2022-01-20T13:35:10-05:00 New Revision: b80db150cdba17b3d4970389025f95b1c93482b8 URL: https://github.com/llvm/llvm-project/commit/b80db150cdba17b3d4970389025f95b1c93482b8 DIFF: https://github.com/llvm/llvm-project/commit/b80db150cdba17b3d4970389025f95b1c93482b8.diff

[PATCH] D117232: [clang] Improve -Wdeclaration-after-statement

melver updated this revision to Diff 401689. melver marked an inline comment as done. melver added a comment. Use ``..`` in ReleaseNotes.rst. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117232/new/ https://reviews.llvm.org/D117232 Files

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

aaron.ballman closed this revision. aaron.ballman added a comment. In D117613#3258886 , @Izaron wrote: > In D117613#3258854 , @aaron.ballman > wrote: > >> LGTM! Do you need someone to commit on your behalf? If so

[PATCH] D117808: [NFC][RISCV] Add end-of-line symbol in target-feature testcases

eopXD created this revision. eopXD added a reviewer: craig.topper. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw created this revision. Herald added subscribers: dang, mgorny. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the initial commit for the clang-extract-api RFC https://lists.llvm.org/pipermail/cfe-dev/2021-September/0687

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:221 // RUN: -o - | FileCheck --check-prefix=CHECK-V-EXT %s -// CHECK-V-EXT: __riscv_v 1 +// CHECK-V-EXT: __riscv_v 100 // CHECK-V-EXT: __risc

[PATCH] D117808: [NFC][RISCV] Add end-of-line symbol in target-feature testcases

eopXD added a comment. Missed test case for zfh is found by adding end-of-lines ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117808/new/ https://reviews.llvm.org/D117808 ___ cfe-commits mailing list

[PATCH] D117568: [Analyzer] Add docs to StdCLibraryFunctionArgsChecker

steakhal accepted this revision. steakhal added a comment. Looks great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117568/new/ https://reviews.llvm.org/D117568 ___ cfe-commits mailing list cfe-commits

[PATCH] D117808: [NFC][RISCV] Add end-of-line symbol in target-feature testcases

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117808/new/ https://reviews.llvm.org/D117808 ___

[clang] b58cc9f - [NFC][RISCV] Add end-of-line symbol in target-feature testcases

Author: eopXD Date: 2022-01-20T10:47:49-08:00 New Revision: b58cc9fb23486e73ad7502a451bf338df3b2d444 URL: https://github.com/llvm/llvm-project/commit/b58cc9fb23486e73ad7502a451bf338df3b2d444 DIFF: https://github.com/llvm/llvm-project/commit/b58cc9fb23486e73ad7502a451bf338df3b2d444.diff LOG: [N

[PATCH] D117808: [NFC][RISCV] Add end-of-line symbol in target-feature testcases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb58cc9fb2348: [NFC][RISCV] Add end-of-line symbol in target-feature testcases (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401700. eopXD marked an inline comment as done. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c

[PATCH] D117137: [Driver] Add CUDA support for --offline param

tra added a comment. LGTM in general, modulo few nits. Nit: looks like the changes need some clang-formatting. Comment at: clang/lib/Driver/Driver.cpp:112 default: - D.Diag(diag::err_drv_only_one_offload_target_supported_in) << "HIP"; + D.Diag(diag::err_drv_only_

[clang] c65186c - [clang] Improve -Wdeclaration-after-statement

Author: Marco Elver Date: 2022-01-20T19:56:34+01:00 New Revision: c65186c89f35b7b599c41183def666a2bde62ddd URL: https://github.com/llvm/llvm-project/commit/c65186c89f35b7b599c41183def666a2bde62ddd DIFF: https://github.com/llvm/llvm-project/commit/c65186c89f35b7b599c41183def666a2bde62ddd.diff L

[PATCH] D117232: [clang] Improve -Wdeclaration-after-statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc65186c89f35: [clang] Improve -Wdeclaration-after-statement (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[libunwind] df31ff1 - [cmake] Make include(GNUInstallDirs) always below project(..)

Author: John Ericson Date: 2022-01-20T18:59:17Z New Revision: df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4 URL: https://github.com/llvm/llvm-project/commit/df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4 DIFF: https://github.com/llvm/llvm-project/commit/df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4.diff LOG:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:135 +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names that may be +// used as ret

[clang] 5fa4cf8 - [Clang] Separate the 'debug-info-hotpatch' test in two parts: one for ARM and another for AArch64

Author: Alexandre Ganea Date: 2022-01-20T14:11:10-05:00 New Revision: 5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc URL: https://github.com/llvm/llvm-project/commit/5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc DIFF: https://github.com/llvm/llvm-project/commit/5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc.dif

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added a comment. In D111400#3246323 , @cor3ntin wrote: > In D111400#3243826 , @aaron.ballman > wrote: > >> In D111400#3172097 , @cor3ntin >> wrote: >> >>>

[clang] 493c856 - [clang][NFC] Small mangler cleanups

Author: Nathan Sidwell Date: 2022-01-20T11:20:15-08:00 New Revision: 493c856484015873737d7c995cac9e34101fb9e9 URL: https://github.com/llvm/llvm-project/commit/493c856484015873737d7c995cac9e34101fb9e9 DIFF: https://github.com/llvm/llvm-project/commit/493c856484015873737d7c995cac9e34101fb9e9.diff

[PATCH] D117799: [clang][NFC] Small mangler cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rG493c85648401: [clang][NFC] Small mangler cleanups (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D117799

[PATCH] D117806: [OpenMP] Remove overriding visibility for device declarations

jhuber6 updated this revision to Diff 401716. jhuber6 added a comment. Changing to use default `protected` instead of passing `-Bsymbolic` this should be more portable and make the intentions clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3255414 , @aaron.ballman wrote: > LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you > need someone to commit on your behalf? If so, what name and email address > would you like

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

craig.topper added a comment. In D117791#3258785 , @RKSimon wrote: > In D117791#3258602 , @craig.topper > wrote: > >> Just to confirm since I can't see the test CHECK lines. >> builtin_elementwise_abs is not und

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117791/new/ https://reviews.llvm.org/D117791 ___

[PATCH] D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis added a comment. Any other comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added a comment. In D117569#3258307 , @zahiraam wrote: > In D117569#3257121 , @majnemer > wrote: > >> I have a question regarding how this work with respect to the dllimport >> semantics known by the li

[PATCH] D117137: [Driver] Add CUDA support for --offline param

yaxunl added a comment. The title says `--offline` option, which should be `--offload`. Comment at: clang/include/clang/Driver/Options.td:1142 def offload_EQ : CommaJoined<["--"], "offload=">, Flags<[NoXarchOption]>, - HelpText<"Specify comma-separated list of offloading targ

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp:64 +SrcMgr::CharacteristicKind FileType) { + if (!SM.isInMainFile(HashLoc)) { +return; carlosgalvezp wrote: > I'm not familiar with `

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added a comment. > ! In D7982#325 , @carlosgalvezp > wrote: > I need to familiarize myself better with the `Loc` manipulation > code to be able to review the free-standing function but otherwise > looks reasonable. The "clang inter

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

dblaikie added a comment. > According to Debian Code Search, no project uses -gz=zlib-gnu (valgrind has a > configure to use -gz=zlib) Could you link to the queries you used to validate this? I'd be curious to take a look around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 8b4fa2c - clang: Auto-cleanup left-over file from before 3da69fb5a26c7b on bots

Author: Nico Weber Date: 2022-01-20T14:59:30-05:00 New Revision: 8b4fa2c98e07997469f53bee30c0d24a61dc7c8c URL: https://github.com/llvm/llvm-project/commit/8b4fa2c98e07997469f53bee30c0d24a61dc7c8c DIFF: https://github.com/llvm/llvm-project/commit/8b4fa2c98e07997469f53bee30c0d24a61dc7c8c.diff LO

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117806/new/ https://reviews.llvm.org/D117806 _

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3259305 , @dblaikie wrote: >> According to Debian Code Search, no project uses -gz=zlib-gnu (valgrind has >> a configure to use -gz=zlib) > > Could you link to the queries you used to validate this? I'd be curious to

[clang] 82452be - [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC.

Author: Marek Kurdej Date: 2022-01-20T21:16:17+01:00 New Revision: 82452be5cbd7fb48e36dd4f7b2b7eaf598d34bd6 URL: https://github.com/llvm/llvm-project/commit/82452be5cbd7fb48e36dd4f7b2b7eaf598d34bd6 DIFF: https://github.com/llvm/llvm-project/commit/82452be5cbd7fb48e36dd4f7b2b7eaf598d34bd6.diff

[PATCH] D117769: [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG82452be5cbd7: [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117

[PATCH] D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:57-60 if (const auto *FuncDecl = CExpr->getDirectCallee()) { if (FuncDecl->getDeclName().isIdentifier() && - FuncDecl->getName() == "__builtin_ex

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jdoerfert added a comment. Does this still work with AMDGPU as we need it to? Comment at: clang/test/OpenMP/declare_target_codegen.cpp:293 -}; -int SS::SSS = 1; #endif What happened here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jhuber6 added inline comments. Comment at: clang/test/OpenMP/declare_target_codegen.cpp:293 -}; -int SS::SSS = 1; #endif jdoerfert wrote: > What happened here? That was a special case I added that was only necessary when we were trying to remove things from bei

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, aaron.ballman, craig.topper. RKSimon requested review of this revision. Herald added a project: clang. Similar to the existing bitwise reduction builtins, these are lowered to the llvm.vector.reduce.add/mul intrinsic calls. F

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401746. dgoldman added a comment. Split up HeaderSearch change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollecto

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman created this revision. dgoldman added a reviewer: sammccall. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the Framework name was only set if the file came from a header mapped framework; now we'll always set

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jdoerfert added inline comments. Comment at: clang/test/OpenMP/declare_target_codegen.cpp:293 -}; -int SS::SSS = 1; #endif jhuber6 wrote: > jdoerfert wrote: > > What happened here? > That was a special case I added that was only necessary when we were trying >

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:149 RV64 = 1 << 5, + VectorMaxELen32 = 1 << 6, + VectorMaxELen64 = 1 << 7, Do we need VectorMaxELen32 isn't that the minimum? Comment at: clang/utils/Ta

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:14583 if (Second && Second->getObjectKind() == OK_ObjCProperty) { ExprResult Result = SemaRef.CheckPlaceholderExpr(Second); rjmccall wrote: > rnk wrote: > > This is also pseudo ob

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna updated this revision to Diff 401759. dcastagna marked an inline comment as done. dcastagna retitled this revision from "[Driver] Add CUDA support for --offline param" to "[Driver] Add CUDA support for --offload param". dcastagna added a comment. Address tra@ and yaxunl@ comments. Error

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna updated this revision to Diff 401760. dcastagna marked 2 inline comments as done. dcastagna added a comment. Address yaxunl@ comment in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna added a comment. In D117137#3259276 , @yaxunl wrote: > The title says `--offline` option, which should be `--offload`. Fixed that and addressed the other comments. The last patch also adds a check to error out if --offload is used in CUDA with

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 _

[libunwind] 4af1127 - [cmake] Duplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm

Author: John Ericson Date: 2022-01-20T21:18:42Z New Revision: 4af11272f57a4a6fed2932e9e0857b2c1a707c51 URL: https://github.com/llvm/llvm-project/commit/4af11272f57a4a6fed2932e9e0857b2c1a707c51 DIFF: https://github.com/llvm/llvm-project/commit/4af11272f57a4a6fed2932e9e0857b2c1a707c51.diff LOG:

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jhuber6 updated this revision to Diff 401766. jhuber6 added a comment. Changing to use '-fvisibility=protected' when we construct the job. This is much more transparent and leaves the option open for the user to override it if they need default visibility. Repository: rG LLVM Github Monorepo

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117181/new/ https://reviews.llvm.org/D117181 _

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. I should mention - according to https://clang.llvm.org/docs/LanguageExtensions.html `__builtin_reduce_add()` already exists, which I don't think is true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://r

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

Quuxplusone added a comment. What ever happened to this patch? @fanfuqiang, are you still around to rebase this? Do you need someone to commit it for you? (Not that I'm saying I think it's perfect as is — I haven't looked and don't know the code that well — but just wondering what kept this from

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, kiranchandramohan, peixin, clementval, Leporacanthicus, kiranktp, AMDChirag, fghanim, jdenny, MatsPetersson, ftynse. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong,

<    1   2   3   >