[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, this looks good (sorry, I missed this.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4811 + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[clang] 5c2e7c9 - [clang-format] Ensure we can correctly parse lambda in the template argument list

Author: mydeveloperday Date: 2022-01-10T08:29:35Z New Revision: 5c2e7c9ca043d92bed75b08e653fb47c384edd13 URL: https://github.com/llvm/llvm-project/commit/5c2e7c9ca043d92bed75b08e653fb47c384edd13 DIFF: https://github.com/llvm/llvm-project/commit/5c2e7c9ca043d92bed75b08e653fb47c384edd13.diff LOG

[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c2e7c9ca043: [clang-format] Ensure we can correctly parse lambda in the template argument… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D116806?vs=398124&id=398521#to

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build)\n", +

[clang] 4a4b8e4 - [AST] Add more source information for DecltypeTypeLoc.

Author: Haojian Wu Date: 2022-01-10T09:34:18+01:00 New Revision: 4a4b8e4f99e2a82286b0595d561a51e7ad1945d2 URL: https://github.com/llvm/llvm-project/commit/4a4b8e4f99e2a82286b0595d561a51e7ad1945d2 DIFF: https://github.com/llvm/llvm-project/commit/4a4b8e4f99e2a82286b0595d561a51e7ad1945d2.diff LO

[PATCH] D116793: [AST] Add more source information for DecltypeTypeLoc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG4a4b8e4f99e2: [AST] Add more source information for DecltypeTypeLoc. (authored by hokein). Changed prior to

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius added a comment. @GoBigorGoHome, are you still interested in this review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 ___ cfe-commits mailing list cf

[PATCH] D116713: [clangd] Support configuration of inlay hints.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:51 bool VisitCXXConstructExpr(CXXConstructExpr *E) { +if (!Cfg.InlayHints.DeducedTypes) + return true; ---

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116919 Files: cl

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius added a comment. @aybassiouny, still interested in working on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan, thakis. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/27037 Sorry its taken so long to g

[PATCH] D116921: [clangd] Enable expand-auto for decltype(auto).

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Based on https://reviews.llvm.org/D11691

[PATCH] D116922: [AST] Use recovery-expr to preserve incomplete-type-member-access expression.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116922 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/AST/ast-dump-recovery.cpp clang

[PATCH] D115490: [clangd] Include fixer for missing functions in C

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:14995 +DeclFilterCCC CCC{}; +Corrected = CorrectTypo(DeclarationNameInfo(&II, Loc), LookupOrdinaryName, +

[clang] 27ea0c4 - [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

Author: Sam McCall Date: 2022-01-10T10:38:27+01:00 New Revision: 27ea0c4e7234f3b15cbbb696e6c408af7141f342 URL: https://github.com/llvm/llvm-project/commit/27ea0c4e7234f3b15cbbb696e6c408af7141f342 DIFF: https://github.com/llvm/llvm-project/commit/27ea0c4e7234f3b15cbbb696e6c408af7141f342.diff LO

[clang-tools-extra] 16fd5c2 - [clangd] Support configuration of inlay hints.

Author: Sam McCall Date: 2022-01-10T10:49:35+01:00 New Revision: 16fd5c278488b3d3275afc381a00ba0b51b070ee URL: https://github.com/llvm/llvm-project/commit/16fd5c278488b3d3275afc381a00ba0b51b070ee DIFF: https://github.com/llvm/llvm-project/commit/16fd5c278488b3d3275afc381a00ba0b51b070ee.diff LO

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ea0c4e7234: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse (authored by sammccall). Changed prior to commit: ht

[PATCH] D116713: [clangd] Support configuration of inlay hints.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16fd5c278488: [clangd] Support configuration of inlay hints. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116713/new/ https://revi

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

kadircet added inline comments. Comment at: clang/lib/Parse/ParseCXXInlineMethods.cpp:153 + // probably truncated, so don't eat more tokens. + if (!Toks.back().is(tok::code_completion)) +SkipMalformedDecl(); i don't follow the logic here. maybe

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1729 } else if (Current.is(tok::r_paren)) { if (rParenEndsCast(Current)) Current.setType(TT_CastRParen); The current solution looks a bit like a hack to me. Unles

[PATCH] D116924: [clang-extdef-mapping] Allow clang-extdef-mapping tool to output customized filename for each index entry

OikawaKirie created this revision. OikawaKirie added reviewers: martong, NoQ, steakhal. OikawaKirie added a project: clang. Herald added subscribers: arphaman, rnkovacs. OikawaKirie requested review of this revision. Herald added a subscriber: cfe-commits. The clang-extdef-mapping tool can only ou

[PATCH] D116920: [clang-format] clang-format eats space in front of attributes for operator delete

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1729 } else if (Current.is(tok::r_paren)) { if (rParenEndsCast(Current)) Current.setType(TT_CastRParen); curdeius wrote: > The current solution looks a bit

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

hokein added a comment. Agree that __ reserved names are ugly, but I'm not sure this is a great improvement. I played around the patch locally, and found the new behavior being confused in some cases (mostly inconsistencies between deuglified places vs uglified places), and seems hard for rea

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall added a comment. In D116387#3230893 , @hokein wrote: > Agree that __ reserved names are ugly, but I'm not sure this is a great > improvement. > > I played around the patch locally, and found the new behavior being confused > in some cases (mo

[PATCH] D115490: [clangd] Include fixer for missing functions in C

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14995 +DeclFilterCCC CCC{}; +Corrected = CorrectTypo(DeclarationNameInfo(&II, Loc), LookupOrdinaryName, +S, nullptr, CCC, CTK_N

[clang-tools-extra] 1ab1379 - [clangd] Include fixer for missing functions in C

Author: Sam McCall Date: 2022-01-10T12:17:19+01:00 New Revision: 1ab13793beafd1db0159a410560b3ce998b15f5e URL: https://github.com/llvm/llvm-project/commit/1ab13793beafd1db0159a410560b3ce998b15f5e DIFF: https://github.com/llvm/llvm-project/commit/1ab13793beafd1db0159a410560b3ce998b15f5e.diff LO

[PATCH] D115490: [clangd] Include fixer for missing functions in C

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG1ab13793beaf: [clangd] Include fixer for missing functions in C (authored by sammccall). Changed prior t

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. Happy new year! - and a gentle ping ;) Afaict, there are only two smaller issues remaining (see non-closed inline comments): - do we want a test expectation to check for unmodified code - should we remove a couple of comments from the code Personally, I have no r

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/SpecialMembers.cpp:72 +// +// e.g. given `struct S{};`, produces: +// struct S { nit: add trigger points. Comment at: clang-tools-extra/clangd/refactor/tweaks/

[clang] d17fb46 - [Clang][AArch64][ARM] PMUv3.4 Option Added

Author: Mubashar Ahmad Date: 2022-01-10T11:28:19Z New Revision: d17fb46e894501568a1bf3b11a5d920817444630 URL: https://github.com/llvm/llvm-project/commit/d17fb46e894501568a1bf3b11a5d920817444630 DIFF: https://github.com/llvm/llvm-project/commit/d17fb46e894501568a1bf3b11a5d920817444630.diff LOG

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd17fb46e8945: [Clang][AArch64][ARM] PMUv3.4 Option Added (authored by mubashar_). Changed prior to commit: https://reviews.llvm.org/D116748?vs=397

[PATCH] D116906: [OpenMP][AMDGPU] Optimize the linked in math libraries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Using the optimiser to hide errors in how we're pulling in libm is clearly not right, but it leaves us less obviously broken than we are at present. Repository: rG LLVM Gi

Re: [clang] 80e2c58 - [clang] Remove redundant member initialization (NFC)

On Sun, 9 Jan 2022, Kazu Hirata via cfe-commits wrote: Author: Kazu Hirata Date: 2022-01-09T00:19:51-08:00 New Revision: 80e2c587498a7b2bf14dde47a33a058da6e88a9a URL: https://github.com/llvm/llvm-project/commit/80e2c587498a7b2bf14dde47a33a058da6e88a9a DIFF: https://github.com/llvm/llvm-proje

[clang] abe3003 - [AST] Use recovery-expr to preserve incomplete-type-member-access expression.

Author: Haojian Wu Date: 2022-01-10T12:45:20+01:00 New Revision: abe3003ead808518190d1e9717495735786938d3 URL: https://github.com/llvm/llvm-project/commit/abe3003ead808518190d1e9717495735786938d3 DIFF: https://github.com/llvm/llvm-project/commit/abe3003ead808518190d1e9717495735786938d3.diff LO

[PATCH] D116922: [AST] Use recovery-expr to preserve incomplete-type-member-access expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe3003ead80: [AST] Use recovery-expr to preserve incomplete-type-member-access expression. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Not sure it's OK to s

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

sammccall added a comment. I wasn't sure whether to suppress this in clang or clangd, wonder what you think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116925/new/ https://reviews.llvm.org/D116925 __

[clang] 55d96ac - [AST] Add RParen loc for decltype AutoTypeloc.

Author: Haojian Wu Date: 2022-01-10T12:46:27+01:00 New Revision: 55d96ac3dc56bdebea854952a724c2a50d96ce19 URL: https://github.com/llvm/llvm-project/commit/55d96ac3dc56bdebea854952a724c2a50d96ce19 DIFF: https://github.com/llvm/llvm-project/commit/55d96ac3dc56bdebea854952a724c2a50d96ce19.diff LO

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55d96ac3dc56: [AST] Add RParen loc for decltype AutoTypeloc. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added a comment. RFC to clang dev list: https://lists.llvm.org/pipermail/cfe-dev/2022-January/069658.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116266/new/ https://reviews.llvm.org/D116266 ___ cfe-commits mailing list cfe-c

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

ASDenysPetrov added a comment. Starting producing `SymbolCast` you should be careful. Please pay attention on my revision D105340 before doing this. I don't want you walk through the thing I fought. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

hokein added a comment. In D116925#3230991 , @sammccall wrote: > I wasn't sure whether to suppress this in clang or clangd, wonder what you > think. I think it is fine to do it in clang. `pp_pragma_once_in_main_file` is a similar diag, and clang has al

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:415-423 + // FIXME This should be done in getAsSymbol. But then getAsSymbol should be + // the member function of SValBuilder (?) + if (symRHS) +if (auto RLocAsInt = RHS.getAs())

[clang-tools-extra] 37ec65e - [clangd] Enable expand-auto for decltype(auto).

Author: Haojian Wu Date: 2022-01-10T13:46:56+01:00 New Revision: 37ec65e1d705f56fe5551de1dfcbac1e071588a2 URL: https://github.com/llvm/llvm-project/commit/37ec65e1d705f56fe5551de1dfcbac1e071588a2 DIFF: https://github.com/llvm/llvm-project/commit/37ec65e1d705f56fe5551de1dfcbac1e071588a2.diff LO

[PATCH] D116921: [clangd] Enable expand-auto for decltype(auto).

This revision was automatically updated to reflect the committed changes. Closed by commit rG37ec65e1d705: [clangd] Enable expand-auto for decltype(auto). (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116921/new/ https://review

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. I made some minor comments, that can be fixed before committing. Comment at: clang/docs/UsersManual.rst:3567 +Linking is done using `spirv-link` linker from `the SPI

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

mstorsjo added a comment. In D116503#3223094 , @MaskRay wrote: > But make sure to wait a bit to see what others think. Do you think it's ok to go ahead and land this change now, or should I wait a bit more? (I'd like to have it landed with enough margin

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:420 + auto FromTy = symRHS->getType(); + auto ToTy = RLocAsInt->getType(this->Context); + symRHS = this->getSymbolManager().getCastSymbol(symRHS, FromTy, ToTy); -

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

hokein updated this revision to Diff 398588. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116643/new/ https://reviews.llvm.org/D116643 Files: clang-tools-extra/c

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

hokein updated this revision to Diff 398589. hokein added a comment. remove accident changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116643/new/ https://reviews.llvm.org/D116643 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:171 +return true; + // FIXME: Remove this std symbol list, as they should be covered by the + // above isInSystemHeader check. kbobyrev wrote: > Any reason not to do this

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

aaron.ballman added inline comments. Comment at: clang/test/Modules/cxx20-export-import.cpp:1-2 + +// RUN: %clang_cc1 -std=c++20 -fmodules -fmodules-cache-path=%t -fimplicit-module-maps -I%S/Inputs -stdlib=libc++ -verify %s +export import dummy; // expected-error {{export declar

[clang] f282b68 - set __NO_MATH_ERRNO__ if -fno-math-errno

Author: Alex Xu (Hello71) Date: 2022-01-10T08:45:46-05:00 New Revision: f282b6809105075b65974989459ee420ecd406e9 URL: https://github.com/llvm/llvm-project/commit/f282b6809105075b65974989459ee420ecd406e9 DIFF: https://github.com/llvm/llvm-project/commit/f282b6809105075b65974989459ee420ecd406e9.d

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the patch! I've landed on your behalf in f282b6809105075b65974989459ee420ecd406e9 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116337/ne

[clang] d2cc6c2 - Use a sorted array instead of a map to store AttrBuilder string attributes

Author: Serge Guelton Date: 2022-01-10T14:49:53+01:00 New Revision: d2cc6c2d0c2f8a6e272110416a3fd579ed5a3ac1 URL: https://github.com/llvm/llvm-project/commit/d2cc6c2d0c2f8a6e272110416a3fd579ed5a3ac1 DIFF: https://github.com/llvm/llvm-project/commit/d2cc6c2d0c2f8a6e272110416a3fd579ed5a3ac1.diff

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2cc6c2d0c2f: Use a sorted array instead of a map to store AttrBuilder string attributes (authored by serge-sans-paille). Herald added a subscriber:

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/64726/step_8.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116919/new/ https://reviews.llvm.org/D116919 ___ cfe-commits

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

egorzhdan updated this revision to Diff 398601. egorzhdan added a comment. Diagnose mismatches between class property of a class and a class property of its superclass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/ https://reviews.llvm

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

hokein added a comment. In D116919#3231246 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/64726/step_8.txt sorry, looking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116919/ne

[clang] 7725331 - [CodeGen] Avoid some pointer element type accesses

Author: Nikita Popov Date: 2022-01-10T15:02:55+01:00 New Revision: 7725331ccdd82312e1ae82d4d634ee5d7dec2406 URL: https://github.com/llvm/llvm-project/commit/7725331ccdd82312e1ae82d4d634ee5d7dec2406 DIFF: https://github.com/llvm/llvm-project/commit/7725331ccdd82312e1ae82d4d634ee5d7dec2406.diff

[clang] 7b1cb72 - [SROA] Switch replacement of dead/UB/unreachable ops from undef to poison

Author: Nuno Lopes Date: 2022-01-10T14:04:26Z New Revision: 7b1cb72ad944b460c42adf6df635263064a457f3 URL: https://github.com/llvm/llvm-project/commit/7b1cb72ad944b460c42adf6df635263064a457f3 DIFF: https://github.com/llvm/llvm-project/commit/7b1cb72ad944b460c42adf6df635263064a457f3.diff LOG: [S

[PATCH] D116887: [SROA] Switch replacement of dead/UB/unreachable ops from undef to poison

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b1cb72ad944: [SROA] Switch replacement of dead/UB/unreachable ops from undef to poison (authored by nlopes). Herald added a project: clang. Herald a

[PATCH] D116792: [AST] lookup in parent DeclContext for transparent DeclContext

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D116792#3230478 , @ChuanqiXu wrote: > In D116792#3227379 , @erichkeane > wrote: > >> I had to do

[clang] c2293bc - Revert "[AST] Add RParen loc for decltype AutoTypeloc."

Author: Haojian Wu Date: 2022-01-10T15:18:41+01:00 New Revision: c2293bc17dd09d552c5fdd13ff2b7c5738c5a10a URL: https://github.com/llvm/llvm-project/commit/c2293bc17dd09d552c5fdd13ff2b7c5738c5a10a DIFF: https://github.com/llvm/llvm-project/commit/c2293bc17dd09d552c5fdd13ff2b7c5738c5a10a.diff LO

[PATCH] D116834: [clang][dataflow] Change `transfer` function to update lattice element in place.

ymandel updated this revision to Diff 398612. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116834/new/ https://reviews.llvm.org/D116834 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

erichkeane added a comment. LGTM other than the NIT found by @fhahn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116736/new/ https://reviews.llvm.org/D116736 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 398614. saiislam added a comment. Fixed the lit test failing in pre-check build bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/ https://reviews.llvm.org/D116549 Files: clang/include/clang/Bas

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

melver added a comment. Hello, We need a solution for this problem, and because I haven't heard any objections I'll assume the general approach is fine -- @jfb already kindly confirmed that "[...] patch you propose here is a good idea". Review of the implementation would still be much apprecia

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrai

[PATCH] D116834: [clang][dataflow] Change `transfer` function to update lattice element in place.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64f7b2d4bf92: [clang][dataflow] Change `transfer` function to update lattice element in place. (authored by ymandel). Repository: rG LLVM Github M

[clang] 64f7b2d - [clang][dataflow] Change `transfer` function to update lattice element in place.

Author: Yitzhak Mandelbaum Date: 2022-01-10T14:45:30Z New Revision: 64f7b2d4bf92eeb8f753f46d2a9499688b07293a URL: https://github.com/llvm/llvm-project/commit/64f7b2d4bf92eeb8f753f46d2a9499688b07293a DIFF: https://github.com/llvm/llvm-project/commit/64f7b2d4bf92eeb8f753f46d2a9499688b07293a.diff

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

glider accepted this revision. glider added a comment. This revision is now accepted and ready to land. FWIW the implementation looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115440/new/ https://reviews.llvm.org/D115440 __

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

martong added a comment. > I think for now it is enough to issue a warning of using these functions, and > not suggest a replacement. Should we add an option to the checker to also > check for these functions? IMHO, it is okay to start with just simply issuing the warning. Later we might add

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl added a comment. I think it will be cleaner to keep the original amdgpu-asan.cu unchanged whereas add amdgpu-asan-printf.cu which tests asan with printf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 _

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

jdoerfert added inline comments. Comment at: llvm/lib/Support/Triple.cpp:512 + .Case("oe", Triple::OpenEmbedded) + .Case("vgpu", Triple::OpenMP_VGPU) + .Default(Triple::UnknownVendor); Comment at: openmp/libomptarget/DeviceRTL/s

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 created this revision. Herald added subscribers: hiraditya, kristof.beyls. tyb0807 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces clang command line support for new Armv8.8-A and Armv9.3-A Hinted C

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrait

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 updated this revision to Diff 398623. tyb0807 edited the summary of this revision. tyb0807 added a comment. Remove Change-Id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib/Basi

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

awarzynski added a comment. @PeteSteinfeld , thank you for testing this change! I want to make sure that people who are just back from their breaks get a chance to take a look, so I'll wait another day or two before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 updated this revision to Diff 398624. tyb0807 edited the summary of this revision. tyb0807 added a comment. Add more context to the patch summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Fi

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

sgatev updated this revision to Diff 398629. sgatev marked 8 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116596/new/ https://reviews.llvm.org/D116596 Files: clang/in

[PATCH] D116596: [clang][dataflow] Add transfer functions for assignment

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:36 +/// FIXME: Consider replacing this with a model that is more aligned with C++ +/// value categories. +enum class SkipPast { xazax.hun wrote: > ymandel w

[PATCH] D116939: [AArch64] clang support for Armv8.8/9.3 HBC

tyb0807 updated this revision to Diff 398638. tyb0807 added a comment. Support for MOPS extension should be committed in a separate patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116939/new/ https://reviews.llvm.org/D116939 Files: clang/lib

[PATCH] D116840: [HIP] Fix device only linking for -fgpu-rdc

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3173 + AssociatedOffloadKind); +AL.clear(); +// Offload the host object to the host linker. tra wrote: > Doing `clear()` in a function intended to append looks

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

ahoppen added a comment. I like this a lot better. Some comments inline. Comment at: clang/include/clang/Lex/HeaderSearch.h:179 /// directory is suppressed. - std::vector SearchDirs; - /// Whether the DirectoryLookup at the corresponding index in SearchDirs has - /// been

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

nikic added a comment. In D116935#3231615 , @fhahn wrote: > In D116935#3231477 , @nikic wrote: > >> Why do we need / want to use the InstSimplifyFolder in SROA? > > I don't have any strong opinions either way. The

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

nikic accepted this revision. nikic added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116935/new/ https://reviews.llvm.org/D116935 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added a subscriber: mgrang. ahatanak requested review of this revision. Analyze the block captures just once before generating copy/dispose block helper functions and honor the inert `__un

[clang] 4e77868 - [SemaDecl] Use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-10T16:31:08Z New Revision: 4e77868c7c4ba79ed025b87f84ce66fc8dca25d6 URL: https://github.com/llvm/llvm-project/commit/4e77868c7c4ba79ed025b87f84ce66fc8dca25d6 DIFF: https://github.com/llvm/llvm-project/commit/4e77868c7c4ba79ed025b87f84ce66fc8dca25d6.diff LOG:

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:179 /// directory is suppressed. - std::vector SearchDirs; - /// Whether the DirectoryLookup at the corresponding index in SearchDirs has - /// been successfully used to lookup a file. -

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

AdamMagierFOSS added a comment. Thank you for the feedback - I've added responses inline and I'll update the change to reflect the feedback. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2247 // Otherwise, evaluate and record it. - if (const Expr *size = vat->g

[PATCH] D116840: [HIP] Fix device only linking for -fgpu-rdc

yaxunl updated this revision to Diff 398662. yaxunl added a comment. avoid clearing AL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116840/new/ https://reviews.llvm.org/D116840 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/hip-phases.hip clang/test/Driver/hip-toolchain-rd

[PATCH] D116921: [clangd] Enable expand-auto for decltype(auto).

thakis added a comment. This broke check-clangd: http://45.33.8.238/linux/64747/step_9.txt (maybe triggered by the revert for D116919 which broke check-clang-tools.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

DavidSpickett added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745 + IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>, + Requires<[IsThumb2]>, Sched<[WriteBrL]>; Should this require `IsMClass` instead/also? Thou

[clang-tools-extra] cf90b3c - Revert "[clangd] Enable expand-auto for decltype(auto)."

Author: Nico Weber Date: 2022-01-10T12:01:42-05:00 New Revision: cf90b3cf7e467db9052a2fd392faa68ef2f175d8 URL: https://github.com/llvm/llvm-project/commit/cf90b3cf7e467db9052a2fd392faa68ef2f175d8 DIFF: https://github.com/llvm/llvm-project/commit/cf90b3cf7e467db9052a2fd392faa68ef2f175d8.diff LO

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

chill added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745 + IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>, + Requires<[IsThumb2]>, Sched<[WriteBrL]>; DavidSpickett wrote: > Should this require `IsMClass` ins

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

DavidSpickett added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745 + IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>, + Requires<[IsThumb2]>, Sched<[WriteBrL]>; chill wrote: > DavidSpickett wrote: > > Should th

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

DavidSpickett added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745 + IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>, + Requires<[IsThumb2]>, Sched<[WriteBrL]>; DavidSpickett wrote: > chill wrote: > > DavidSpic

[clang] 7485e6c - Revert "[clang] Remove redundant member initialization (NFC)"

Author: Kazu Hirata Date: 2022-01-10T09:21:59-08:00 New Revision: 7485e6c7e9c7d484ba1faf2dc53c9b598286455b URL: https://github.com/llvm/llvm-project/commit/7485e6c7e9c7d484ba1faf2dc53c9b598286455b DIFF: https://github.com/llvm/llvm-project/commit/7485e6c7e9c7d484ba1faf2dc53c9b598286455b.diff L

  1   2   3   >