svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land.
LGTM. I made some minor comments, that can be fixed before committing. ================ Comment at: clang/docs/UsersManual.rst:3567 +Linking is done using `spirv-link` linker from `the SPIRV-Tools project +<https://github.com/KhronosGroup/SPIRV-Tools#linker>`_. Similar to other ---------------- (or: "+the spirv-link linker") ================ Comment at: clang/docs/UsersManual.rst:3569 +<https://github.com/KhronosGroup/SPIRV-Tools#linker>`_. Similar to other +linkers Clang will expect `spirv-link` to be installed separately and to be +present in the ``PATH`` environment variable. Please refer to `the build and ---------------- ================ Comment at: clang/lib/Driver/ToolChains/SPIRV.cpp:78 +void SPIRV::Linker::ConstructJob(Compilation &C, const JobAction &JA, + const InputInfo &Output, + const InputInfoList &Inputs, ---------------- Indentation seems to be slightly off? Can be fixed on commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116266/new/ https://reviews.llvm.org/D116266 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
