[PATCH] D115103: Leak Sanitizer port to Windows

MyDeveloperDay added inline comments. Comment at: compiler-rt/lib/lsan/lsan.h:20 +#elif SANITIZER_WINDOWS +# include "lsan_win.h" #endif vitalybuka wrote: > MyDeveloperDay wrote: > > clang-format? > @clemenswasser Can you please a separate tiny patch which cla

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

martong added a comment. In D115149#3175068 , @NoQ wrote: >> It can happen if the `Loc` was perfectly constrained to a concrete >> value (`nonloc::ConcreteInt`) > > This shouldn't happen. It should be `loc::ConcreteInt` which is, well, a > `Loc`. I see

[PATCH] D115103: Leak Sanitizer port to Windows

MyDeveloperDay added a subscriber: kuhnel. MyDeveloperDay added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.h:48 +#elif SANITIZER_NETBSD || SANITIZER_FUCHSIA || SANITIZER_WINDOWS +# define CAN_SANITIZE_LEAKS 1 #else vitalybuka wrote: > MyDevel

[PATCH] D114938: [Analyzer][NFCi] SValBuilder: Simlify a SymExpr to the absolute simplest form

martong added a comment. In D114938#3174331 , @steakhal wrote: > You mentioned in the summary that there are different places where > simplification-like machinary kicks in, which hindered the test case > synthesis. What places did you refer to exactly?

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll updated this revision to Diff 392297. simoll added a comment. Formatting / Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115045/new/ https://reviews.llvm.org/D115045 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:724 + "attribute %0 does not support pack expansion in the last argument">; +def err_attribute_parm_pack_last_argument_only : Error< + "pack expansion in attributes is restricted

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu updated this revision to Diff 392302. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Use `llvm.coro.end(frame, /*InUnwindPath=*/true)` instead of new coroutine intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek added a comment. I don't think the updated logic is correct. For example, in the case of Fuchsia we don't want to take `CLANG_DEFAULT_LINKER` into account, that's why we override `getDefaultLinker`. I assume it's the same for other toolchains that override `getDefaultLinker`. The issue

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu added a comment. In D115219#3175582 , @rjmccall wrote: > I agree that you shouldn't call `suspend`, but doesn't `coro.end` have the > behavior of marking the coroutine done? Should we just be calling `coro.end` > on this path? @rjmccall grea

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek added a comment. In D115045#3175648 , @phosek wrote: > I don't think the updated logic is correct. For example, in the case of > Fuchsia we don't want to take `CLANG_DEFAULT_LINKER` into account, that's why > we override `getDefaultLinker`. I ass

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

pengfei created this revision. pengfei added reviewers: skan, xiangzhangllvm, craig.topper, coby. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. D113096

[clang] 978431e - [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form

Author: Gabor Marton Date: 2021-12-07T10:02:32+01:00 New Revision: 978431e80b6155878d8d5b4fc7a67c90af317c01 URL: https://github.com/llvm/llvm-project/commit/978431e80b6155878d8d5b4fc7a67c90af317c01 DIFF: https://github.com/llvm/llvm-project/commit/978431e80b6155878d8d5b4fc7a67c90af317c01.diff

[PATCH] D114938: [Analyzer][NFCi] SValBuilder: Simlify a SymExpr to the absolute simplest form

This revision was automatically updated to reflect the committed changes. Closed by commit rG978431e80b61: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

mstorsjo added a comment. In D115045#3175648 , @phosek wrote: > Rather, we shouldn't consider `-DCLANG_DEFAULT_LINKER=lld` as a valid value. > Instead AMDGPU bot should use `-DCLANG_DEFAULT_LINKER=ld.lld`. I think this would be a kinda disruptive change

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

phosek added a comment. In D115045#3175760 , @mstorsjo wrote: > In D115045#3175648 , @phosek wrote: > >> Rather, we shouldn't consider `-DCLANG_DEFAULT_LINKER=lld` as a valid value. >> Instead AMDGPU bot should u

[clang] 698584f - [IR] Remove unbounded as possible value for vscale_range minimum

Author: Cullen Rhodes Date: 2021-12-07T09:52:21Z New Revision: 698584f89b8f8bd7f6c2d2cd61efb5548857da2a URL: https://github.com/llvm/llvm-project/commit/698584f89b8f8bd7f6c2d2cd61efb5548857da2a DIFF: https://github.com/llvm/llvm-project/commit/698584f89b8f8bd7f6c2d2cd61efb5548857da2a.diff LOG:

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG698584f89b8f: [IR] Remove unbounded as possible value for vscale_range minimum (authored by c-rhodes). Changed prior to commit: https://reviews.ll

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. > Frontends not written in C++ will always be going through the > AttributeKey::get() API, which will be slower than the initial state (I think > -- we still have to calculate the hash dynamically, but now we also need to > intern an AttributeKey by performing

[PATCH] D115228: [Clang] Do not check if we are in a discared context in non-immediate contexts

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes in a regression introduced by 6eeda06c1 . When deducing the return ty

[PATCH] D115228: [Clang] Do not check if we are in a discared context in non-immediate contexts

cor3ntin updated this revision to Diff 392319. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115228/new/ https://reviews.llvm.org/D115228 Files: clang/include/clang/Sema/Sema.h clang/test/CXX/stmt.stmt/st

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

ChuanqiXu added a comment. In D115222#3175577 , @rjmccall wrote: > I imagine Gor hoped for this optimization to be implemented someday, assuming > it's still allowed by the language specification. Maybe you would be > interested in pursuing that? It s

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire created this revision. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements __builtin_reduce_xor as specified in D111529 . Repository: rG LLVM Github Monorepo https://

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll added a comment. In D115045#3175648 , @phosek wrote: > I don't think the updated logic is correct. For example, in the case of > Fuchsia we don't want to take `CLANG_DEFAULT_LINKER` into account, that's why > we override `getDefaultLinker`. I ass

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

DavidSpickett added a comment. Since this change we've had check-2 timeouts on our 2 stage v7 bots https://lab.llvm.org/buildbot/#/builders/190/builds/513 (we have one building thumb and one Arm) These bots run on v7 hardware as opposed to some of our others that actually run on v8 hardware, t

[PATCH] D115232: [clangd] WIP various stdlib indexing stuff

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang, javed.absar, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. To be split Repository:

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

bader added a comment. In D110622#3174113 , @tra wrote: > The patch looks OK for the time being. That said, I do have concerns that we > may be organically growing something that will be troublesome to deal with > long-term. > > TBH, I still can't quite

[PATCH] D114522: [clangd] Add desugared type to hover

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! (& Sorry for the delay, have been sick) LG with the understanding we may have to iterate on behavior/configurability. As noted below I'd suggest either disabling aka for params

[PATCH] D114522: [clangd] Add desugared type to hover

sammccall added a comment. In D114522#3156167 , @kadircet wrote: > Have a list of user-configurable FQNs that AKA printing would be disabled for > (and provide a good set of defaults inside clangd for STL) BTW this seems hard to implement well without i

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:463 + if (const Optional RV = rhs.getAs()) { +const auto IsCommutative = [](BinaryOperatorKind Op) { + return Op == BO_Mul || Op == BO_Add || Op == BO_And || Op == BO_Xor || -

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

DavidSpickett added a comment. Done in https://reviews.llvm.org/rG6bfbb89e96fa. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112091/new/ https://reviews.llvm.org/D112091 ___ cfe-commits mailing list cfe

[PATCH] D115107: [clang][clangd] Desugar array type.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/AST/ASTDiagnostic.cpp:134 +if (const auto *CAT = dyn_cast(Ty)) { + QualType ElementTy = this doesn't directly ex

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

sgatev created this revision. sgatev added reviewers: ymandel, NoQ, xazax.hun, gribozavr2. Herald added subscribers: rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A datafl

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Sorry about all the boilerplate for adding config, I think I should probably add some tablegen magic to cover everything except Config.h) Comment at: clang-tools-extr

[PATCH] D115108: [clangd] Print type for VarTemplateDecl in hover.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115108/new/ https://reviews.llvm.org/D115108 __

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen updated this revision to Diff 392340. steffenlarsen added a comment. The new revision does the following: 1. Revisits the diagnostics. Now parameter packs will cause the same error on attributes that do not support parameter packs in arguments, while attributes that support it wil

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

sgatev updated this revision to Diff 392346. sgatev added a comment. Minor changes to parameter names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115235/new/ https://reviews.llvm.org/D115235 Files: clang/include/clang/Analysis/FlowSensitive/D

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/test/Parser/cxx0x-attributes.cpp:268 + void faz [[clang::annotate("B", (Is + ...))]] (); // expected-warning {{pack fold expression is a C++17 extension}} + void foz [[clang::annotate("C", Is...)]] (); }

[clang] 7d5315f - Fix Sphinx formatting in release notes

Author: Aaron Ballman Date: 2021-12-07T07:56:40-05:00 New Revision: 7d5315fc4c4836dbc51e471f2544e8cdec452405 URL: https://github.com/llvm/llvm-project/commit/7d5315fc4c4836dbc51e471f2544e8cdec452405 DIFF: https://github.com/llvm/llvm-project/commit/7d5315fc4c4836dbc51e471f2544e8cdec452405.diff

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: wenlei, usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. New values: - Split

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay! Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:46 // not available then 0 is stored. - std::vector> Next(LowercaseIdentifier.size

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

asavonic accepted this revision. asavonic added a comment. This revision is now accepted and ready to land. LGTM. The new diagnostic is not generic, but it is probably fine as long as x86_64 is the only target that needs this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

thakis added a comment. In D114885#3174152 , @jamesfarrell wrote: > In D114885#3174074 , @thakis wrote: > >> Oh, it's already reverted, apologies. We'll know if that fixed that bot in >> 15 min or so then. Somet

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { So I was thinking about this overnight... I wonder if this logic

[PATCH] D115248: [clang] Fix Bug 28101

rZhBoYao created this revision. rZhBoYao added reviewers: rsmith, aaron.ballman, erichkeane, v.g.vassilev, rnk. rZhBoYao added a project: clang. rZhBoYao requested review of this revision. Herald added a subscriber: cfe-commits. This should fix Bug 28101

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

Naghasan added a comment. Just a few comments Comment at: clang/include/clang/Basic/AttrDocs.td:411-413 +The ``__attribute__((sycl_special_class))`` attribute is used in SYCL +headers to indicate that a class or a struct needs additional implementation when +it is passed from

[PATCH] D115103: Leak Sanitizer port to Windows

MyDeveloperDay added a comment. oh! gosh I'm sorry I didn't realize that `lsan` has this non standard LLVM style .clang-format, my apologies! D100238: [sanitizer] Set IndentPPDirectives: AfterHash in .clang-format kind of surprised TBH, doesn't feel the inde

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 392380. kbobyrev marked an inline comment as done. kbobyrev added a comment. No problem, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-to

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 392382. glider added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Addressed the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.l

TCE target nonconforming definition of long long and intmax_t

Hello! I was digging around in stdint.h to do some implementation work on C2x and I noticed that the TCE target seems to be nonconforming. In C17, the implementation limits for intmax_t and uintmax_t are specified by 7.20.2.5 as: — minimum value of greatest-width signed integer type INTMAX_MIN -(

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 392389. glider added a comment. Updated asan-globals.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 Files: clang/docs/AddressSanitizer.rst clang/lib/CodeGen/C

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider added a comment. > Should we have in AddressSanitizer.cpp the following for consistency with > other sanitizers? Good catch, without that disable_sanitizer_instrumentation could not override sanitize_address. I fixed this and added a test. Comment at: clang/test/CodeG

[clang-tools-extra] 976a74d - [clangd] Dex Trigrams: Improve query trigram generation

Author: Kirill Bobyrev Date: 2021-12-07T15:46:13+01:00 New Revision: 976a74d7d2dbd19670614f603caf490cca892fdc URL: https://github.com/llvm/llvm-project/commit/976a74d7d2dbd19670614f603caf490cca892fdc DIFF: https://github.com/llvm/llvm-project/commit/976a74d7d2dbd19670614f603caf490cca892fdc.diff

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

This revision was automatically updated to reflect the committed changes. Closed by commit rG976a74d7d2db: [clangd] Dex Trigrams: Improve query trigram generation (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ http

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei added a comment. Gentle reminder for reviewers. -- This PR is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114564/new/ https://reviews.llvm.org/D114564 ___ cfe-commits mai

[PATCH] D115248: [clang] Fix Bug 28101

rZhBoYao updated this revision to Diff 392399. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/Sema/SemaDeclCXX.cpp Index: clang/lib/Sema/SemaDeclCXX.cpp ==

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2113 + case Builtin::BI__builtin_reduce_xor: if (SemaBuiltinReduceMath(TheCall)) return ExprError(); I think `reduce_xor` is only specified for integer types, so I think we need

[PATCH] D115248: [clang] Fix Bug 28101

erichkeane added a comment. Can you add some tests please? Additionally, we don't typically use LLVM_UNLIKELY like you did there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 ___ cfe-commits mai

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added inline comments. Comment at: compiler-rt/lib/lsan/lsan.h:20 +#elif SANITIZER_WINDOWS +# include "lsan_win.h" #endif MyDeveloperDay wrote: > clang-format? Yes, this is caused by clang-format. What should I do about it? Comm

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added a comment. Thanks for the update, it looks like it should be in line with @aaron.ballman's suggestions! I think it might be good to split off the refactoring of `SemaBuiltinElementwiseMathOneArg`-> `PrepareBuiltinElementwiseMathOneArgCall` and the update for `BI__builtin_elementwis

[PATCH] D115249: Clang-Tidy implicit bool conversion check use upercase suffixes

kili created this revision. Herald added a subscriber: carlosgalvezp. kili requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Make the type suffix of the implicit bool conversion check upercase. So that the result does not fail th

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap created this revision. catap added a reviewer: chandlerc. catap added projects: clang, LLVM. Herald added subscribers: dexonsmith, JDevlieghere. catap requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. The first version of macOS which had TLV inside DYLD

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 392405. junaire added a comment. Fix typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include

[PATCH] D115252: Add note about inlining dllimport functions to the attribute docs

hans created this revision. hans added a reviewer: rnk. Herald added a reviewer: aaron.ballman. hans requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115252 Files: clang/include/clang/Basic/AttrDocs.td Index: cl

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, jfb, jyknight, erichkeane. Herald added subscribers: mstorsjo, fedor.sergeev, dschuff. aaron.ballman requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. This completes the

[PATCH] D115252: Add note about inlining dllimport functions to the attribute docs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115252/new/ https://reviews.llvm.org/D115252 _

[PATCH] D115254: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "

jamesfarrell created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya. jamesfarrell requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 63a6348cad6caccf285c1661bc60d8ba5a40c972

[PATCH] D115254: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "

jamesfarrell added a comment. Only change from previous attempt is to call rtrim() on the output of the commands in the unit tests, since the new version parsing code fails if there are leftover characters like \n. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D114688#3176433 , @fhahn wrote: > I think it might be good to split off the refactoring of > `SemaBuiltinElementwiseMathOneArg`-> >

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

aaron.ballman edited reviewers, added: joerg, rjmccall; removed: aaron.ballman. aaron.ballman added a comment. Removing myself as a reviewer because this is just far enough outside my expertise to feel uncomfortable reviewing it, but added a few trusted folks who have expressed opinions in this

[PATCH] D115103: Leak Sanitizer port to Windows

MyDeveloperDay added inline comments. Comment at: compiler-rt/lib/lsan/lsan.h:20 +#elif SANITIZER_WINDOWS +# include "lsan_win.h" #endif MyDeveloperDay wrote: > clemenswasser wrote: > > vitalybuka wrote: > > > clemenswasser wrote: > > > > MyDeveloperDay wrote:

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

erichkeane added a comment. A few nits, but not nearly 'expert' enough to approve without giving everyone else some time to look this over. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:260 DefineFmt(Prefix + Twine(TypeWidth), Ty, TI, Builder); + DefineTypeWidth(Pref

[PATCH] D115248: [clang] Fix Bug 28101

aaron.ballman added a comment. FWIW, this appears to cause quite a few failures in precommit CI that should be addressed as well: https://buildkite.com/llvm-project/premerge-checks/builds/68803#45a9b858-fa66-4a4b-8c4a-20c2cef820e5 Failed Tests (11): Clang :: CXX/basic/basic.lookup/basic.l

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:260 DefineFmt(Prefix + Twine(TypeWidth), Ty, TI, Builder); + DefineTypeWidth(Prefix + Twine(TypeWidth) + "_WIDTH__", Ty, TI, Builder); } -

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman updated this revision to Diff 392424. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115253/new/ https://reviews.llvm.org/D115253 Files: clang/docs/ReleaseNot

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

gribozavr2 added a comment. LGTM but deferring approval to @xazax.hun . Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:30 +public: + void run(const ast_matchers::MatchFinder::MatchResult &Result) override { +const auto *Func = Result

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

erichkeane added inline comments. Comment at: clang/test/Headers/limits.cpp:33 -const bool char_is_signed = (char)-1 < (char)0; -_Static_assert(CHAR_MIN == (char_is_signed ? -CHAR_MAX-1 : 0), ""); -_Static_assert(CHAR_MAX == (char_is_signed ? -(CHAR_MIN+1) : (char)~0ULL), "");

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf updated this revision to Diff 392429. brunodf added a comment. New version of patch to address problems detected by buildbots. (Will describe in more detail in follow-up comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111639/new/ h

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1271 OS << " = " << *P.Default; + if (P.Type && P.Type->AKA) +OS << llvm::formatv(" (aka {0})", *P.Type->AKA); sammccall wrote: > kadircet wrote: > > sammccall wrote: > > > Hmm,

[clang] a18632a - Add diagnostic groups for attribute extensions

Author: Aaron Ballman Date: 2021-12-07T11:49:53-05:00 New Revision: a18632adc884397e0cd7f27bdb8ea3a822b63000 URL: https://github.com/llvm/llvm-project/commit/a18632adc884397e0cd7f27bdb8ea3a822b63000 DIFF: https://github.com/llvm/llvm-project/commit/a18632adc884397e0cd7f27bdb8ea3a822b63000.diff

[PATCH] D113115: Add diagnostic groups for attribute extensions

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed (with a release note) in a18632adc884397e0cd7f27bdb8ea3a822b63000 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman added a comment. In D112616#3106436 , @aaron.ballman wrote: > Ping Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112616/new/ https://reviews.llvm.org/D112616 _

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm about as confident as _I_ could be on this one, so between that and the time, I think my LGTM now carries a bit of weight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. sammccall wrote: > One question is wh

[PATCH] D115228: [Clang] Do not check if we are in a discared context in non-immediate contexts

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM me, I'll land shortly on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115228/new/ https://reviews.llvm.org/D115228

[clang] 2334314 - Do not check if we are in a discared context in non-immediate contexts

Author: Corentin Jabot Date: 2021-12-07T12:13:35-05:00 New Revision: 2334314550724812bb94e36c6b5df7d665bdbd9d URL: https://github.com/llvm/llvm-project/commit/2334314550724812bb94e36c6b5df7d665bdbd9d DIFF: https://github.com/llvm/llvm-project/commit/2334314550724812bb94e36c6b5df7d665bdbd9d.diff

[PATCH] D115228: [Clang] Do not check if we are in a discared context in non-immediate contexts

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the quick fix! I've landed on your behalf in 2334314550724812bb94e36c6b5df7d665bdbd9d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D115199: [WIP][X86][AMX] Support amxpreserve attribute in clang.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2895 +def AMXPreserve : InheritableAttr, TargetSpecificAttr { + let Spellings = [GCC<"amxpreserve">, Declspec<"amxpreserve">]; Inherited on what? This attribute needs a `Subject

[PATCH] D115108: [clangd] Print type for VarTemplateDecl in hover.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51dc466642c5: [clangd] Print type for VarTemplateDecl in hover. (authored by lh123). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115108/new/ https://revie

[clang-tools-extra] 51dc466 - [clangd] Print type for VarTemplateDecl in hover.

Author: lh123 Date: 2021-12-08T01:20:14+08:00 New Revision: 51dc466642c5566c289468b269a8c69b0e447720 URL: https://github.com/llvm/llvm-project/commit/51dc466642c5566c289468b269a8c69b0e447720 DIFF: https://github.com/llvm/llvm-project/commit/51dc466642c5566c289468b269a8c69b0e447720.diff LOG: [c

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

kadircet added a comment. I think we also need to update `index/remote/Server.cpp` && `FileSymbols` (and `FileIndex` too). Regarding updates to `loadIndex`, I actually think it makes sense for that index the always retrieve symbols as `Static` origin, then whoever makes use of that (we always

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. *comment removed, I've been doing more detailed benchmark that imply a rework of the patch* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___ cfe-commits mailing

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman added a comment. In D00#3162293 , @vtjnash wrote: > There is clearly some more work to do to get the cmake file to be correct, > but was hoping to check this looked like the direction you thought looked > right for adding this test, si

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij added a comment. @danielkiss Yes that needs to be addressed, but we are doing that in another patch that will (hopefully) cover all permutations of architecture and branch protection values on both the cmdline and as function attributes. So this patch is just about not having logic in the

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. lh123 wrote: > sammccall wrote: > > One question is whether the setting sh

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

yaxunl added a comment. >> So, the question is -- what's the right way to specify something like this >> in a consistent manner? >> `--offload` option proposed here does not seem to be a good fit. It was >> intended as a more flexible way to create a single `-cc1` sub-compilation >> and we're

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad abandoned this revision. foad added a comment. Abandoned in favour of D115032 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114957/new/ https://reviews.llvm.org/D114957 _

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. This patch looks good to me, most of my comments are things to consider in follow-up patches. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.c

[PATCH] D115254: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "

dexonsmith added a comment. In D115254#3176564 , @jamesfarrell wrote: > Only change from previous attempt is to call rtrim() on the output of the > commands in the unit tests, since the new version parsing code fails if there > are leftover characters

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114908/new/ https://reviews.llvm.org/D114908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 392444. clemenswasser added a comment. Split this patch up into multiple smaller ones: - D115186 - D115204 - D115262 CHANGES SINCE LAST ACTION h

  1   2   >