[PATCH] D114583: [clang-format] Adjust braced list detection

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the update. (You forgot to add the context, but since it was already accepted it's okay.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114583/new/

[clang] 3666cd0 - [Coroutines] Make suspend_always in test noexcept (NFC)

Author: Chuanqi Xu Date: 2021-12-01T16:16:36+08:00 New Revision: 3666cd0216b85ef962e92a5e19dea2215559b48a URL: https://github.com/llvm/llvm-project/commit/3666cd0216b85ef962e92a5e19dea2215559b48a DIFF: https://github.com/llvm/llvm-project/commit/3666cd0216b85ef962e92a5e19dea2215559b48a.diff LO

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

shraiysh updated this revision to Diff 390935. shraiysh added a comment. Thanks for the review @Meinersbur . Rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.org/D114143 Files: clang/test/OpenMP/ca

[PATCH] D114583: [clang-format] Adjust braced list detection

curdeius accepted this revision. curdeius added a comment. Thanks! Do you need someone to land this on your behalf? If yes, don't forget to send here your name and email. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114583/new/ https://reviews.llvm.org/D114583 ___

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

kadircet added a comment. | 1658 | remove | NULL | | 1731 | std::__u::remove | llvm/include/c++/v1/__algorithm/remove.h | | for whatever reason I remembered the std::remove to have been referenced ~17k. looks like these two are much closer. I don't t

[PATCH] D111566: [SYCL] Fix function pointer address space

dylanmckay added a comment. This will product correct code from an AVR perspective where (before this patch it would have failed codegen). It is consistent with how we construct function pointers in LLVM core as well. I'm not very familiar with Clang internals, one thing that stick out to me:

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 390946. lichray added a comment. - revert the tentative parsing fix - warn in -Wpre-c++2b-compat and -Wdecltype-auto-cast (ExtWarn) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm

[PATCH] D111566: [SYCL] Fix function pointer address space

dylanmckay accepted this revision. dylanmckay added a comment. By the way, as this has already been approved by one, and you rightly applied the "speak now or forever hold your peace" principle re. OpenCL, and this clearly works better from my point of view than the old code, I wouldn't want to

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray marked an inline comment as done. lichray added a comment. I reverted the attempt to fix `auto(&a)->n = 0;` in this revision. The fix is definitely not 3 lines and does not fit in this patch. Long story short, our tentative parsing code does not look at trailing return types and fails to

[clang] ec97e12 - [OpenMP][IRBuilder] Fix createSections

Author: Shraiysh Vaishay Date: 2021-12-01T15:11:54+05:30 New Revision: ec97e1206abd6f30a1b549db62e87bea8dee0082 URL: https://github.com/llvm/llvm-project/commit/ec97e1206abd6f30a1b549db62e87bea8dee0082 DIFF: https://github.com/llvm/llvm-project/commit/ec97e1206abd6f30a1b549db62e87bea8dee0082.di

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

This revision was automatically updated to reflect the committed changes. Closed by commit rGec97e1206abd: [OpenMP][IRBuilder] Fix createSections (authored by shraiysh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge_cg.def:37 +SVEMAP2(svdup_neonq_f64, 3), +SVEMAP2(svdup_neonq_bf16, 1), +#endif The second argument is a 'flags' field and these values don't look right. Ref

[clang] 0c047a8 - [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

Author: Jeroen Dobbelaere Date: 2021-12-01T11:02:28+01:00 New Revision: 0c047a8e13320fb8e9dabbf7a3c6a00fe81198c7 URL: https://github.com/llvm/llvm-project/commit/0c047a8e13320fb8e9dabbf7a3c6a00fe81198c7 DIFF: https://github.com/llvm/llvm-project/commit/0c047a8e13320fb8e9dabbf7a3c6a00fe81198c7.d

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c047a8e1332: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template… (authored by jeroen.dobbelaere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

rtrieu added inline comments. Comment at: clang/test/Modules/odr_hash.cpp:4288 S s; +// expected-error@first.h:* {{'ParameterTest::S::Foo' has different definitions in different modules; definition in module 'FirstModule' first difference is 1st parameter with name ''}} +/

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 390958. stuij added a comment. rebased and resolved merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files: clang/include/clang/Basic/DiagnosticDriverKi

[clang] a4fbae2 - Revert "[Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation"

Author: Jeroen Dobbelaere Date: 2021-12-01T11:18:30+01:00 New Revision: a4fbae268f67a6737b86c47f555f95a4a44462d2 URL: https://github.com/llvm/llvm-project/commit/a4fbae268f67a6737b86c47f555f95a4a44462d2 DIFF: https://github.com/llvm/llvm-project/commit/a4fbae268f67a6737b86c47f555f95a4a44462d2.d

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

jeroen.dobbelaere added a comment. A number of buildbots started failing after submission. Reverted for now so we can investigate if the new produced errors are valid or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111639/new/ https://review

[clang] 5978842 - Fix clang-format bug when handling conflict markers.

Author: Manuel Klimek Date: 2021-12-01T11:23:04+01:00 New Revision: 59788422609433c50c3d3c16ca531fa56b9acb4f URL: https://github.com/llvm/llvm-project/commit/59788422609433c50c3d3c16ca531fa56b9acb4f DIFF: https://github.com/llvm/llvm-project/commit/59788422609433c50c3d3c16ca531fa56b9acb4f.diff

[clang] e3b2f02 - [clang][ARM] PACBTI-M frontend support

Author: Ties Stuij Date: 2021-12-01T10:37:16Z New Revision: e3b2f0226bc09f16d5cdba9b94d1db3f15ee7d4a URL: https://github.com/llvm/llvm-project/commit/e3b2f0226bc09f16d5cdba9b94d1db3f15ee7d4a DIFF: https://github.com/llvm/llvm-project/commit/e3b2f0226bc09f16d5cdba9b94d1db3f15ee7d4a.diff LOG: [c

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b2f0226bc0: [clang][ARM] PACBTI-M frontend support (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] ab2611d - [clang][ARM] emit PACBTI-M feature defines

Author: Ties Stuij Date: 2021-12-01T10:46:29Z New Revision: ab2611d0998c7acade219f1ccb511d3a7e76a681 URL: https://github.com/llvm/llvm-project/commit/ab2611d0998c7acade219f1ccb511d3a7e76a681 DIFF: https://github.com/llvm/llvm-project/commit/ab2611d0998c7acade219f1ccb511d3a7e76a681.diff LOG: [c

[PATCH] D112422: [clang][ARM] emit PACBTI-M feature defines

This revision was automatically updated to reflect the committed changes. Closed by commit rGab2611d0998c: [clang][ARM] emit PACBTI-M feature defines (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112422/new/ https://reviews.llvm

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

steakhal added a comment. In D114454#3162490 , @stevewan wrote: >> setting a bunch of target triples and letting gtest to run each one to see >> if it still passes on all triples. > > Did you mean adding all the triples that we're interested in to > `al

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, Quuxplusone, ChuanqiXu, EricWF. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. Responding to a Discord call to help D113977: [Coroutine] Warn

[clang] d688b31 - Fix segfault in clang-format.

Author: Manuel Klimek Date: 2021-12-01T11:57:41+01:00 New Revision: d688b31628004ed9e109e63c2b43701f97252ff3 URL: https://github.com/llvm/llvm-project/commit/d688b31628004ed9e109e63c2b43701f97252ff3 DIFF: https://github.com/llvm/llvm-project/commit/d688b31628004ed9e109e63c2b43701f97252ff3.diff

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. LGTM, nice work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112113/new/ https://reviews.llvm.org/D112113 ___

[PATCH] D114859: [clang-format] Add better support for co-routinues

ChuanqiXu added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22735 + verifyFormat("co_await a; // comment"); + verifyFormat("void test0() { co_await a; }"); +} It may be worth to add following tests: ``` co_await co_await co_await foo(); c

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11337 +def err_builtin_float_invalid_arg_type: Error < + "%ordinal0 argument must be a " There's no need to add a new error message here. `err_builtin_invalid_arg_type`

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

RKSimon added a comment. @stuij This is causing buildbot failures, please can you take a look? https://lab.llvm.org/buildbot/#/builders/139 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 ___

[clang] 5b4746f - [clang][ARM] removing branch protection error cmdline test

Author: Ties Stuij Date: 2021-12-01T12:09:08Z New Revision: 5b4746f94aed5548cd918357299c585a89e3b524 URL: https://github.com/llvm/llvm-project/commit/5b4746f94aed5548cd918357299c585a89e3b524 DIFF: https://github.com/llvm/llvm-project/commit/5b4746f94aed5548cd918357299c585a89e3b524.diff LOG: [c

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. @Anastasia, Could you please commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-co

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. @tra, gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij added a comment. Yes, pushed a temporary fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will mark more headers that

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay updated this revision to Diff 390980. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114859/new/ https://reviews.llvm.org/D114859 Files: clang/docs/ReleaseNotes.rst clang/l

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22748-22749 +TEST_F(FormatTest, CoRoutinereturn) { + verifyFormat("int x = co_return foo();"); + verifyFormat("int x = (co_return foo());"); + verifyFormat("co_return (42);"); -

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kadircet added a comment. I can't fully remember the discussion but what about the case in which we don't have a declaration in the main file, but see a definition and multiple forward declarations. Is there a good reason to still include re-decls in this case? Comment at: cl

[PATCH] D114859: [clang-format] Add better support for co-routinues

ChuanqiXu added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22748-22749 +TEST_F(FormatTest, CoRoutinereturn) { + verifyFormat("int x = co_return foo();"); + verifyFormat("int x = (co_return foo());"); + verifyFormat("co_return (42);"); M

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

aaron.ballman added a comment. Thanks for your patience! Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:198 +for (const ParmVarDecl *ParmDecl : collectParamDecls(Ctor, ParamDecl)) { + auto ParamTL = ParmDecl->getTypeSourceInfo()->getTypeLoc();

[PATCH] D114823: Filter string_view from the nullptr diagnosis of bugprone-string-constructor to prevent duplicate warnings with bugprone-stringview-nullptr

ymandel added a comment. CJ -- please mention "bugprone-stringview-nullptr" explicitly and explain that it will cover those features, etc. so that the description will be clear on its own. Thanks! Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

pdhaliwal created this revision. pdhaliwal added reviewers: arsenm, JonChesterfield. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you add a release note about the bug fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113828/new/ https://reviews.llvm

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); + E

[clang] 4dcfae6 - Fix a violated precondition in clang-format.

Author: Manuel Klimek Date: 2021-12-01T14:39:00+01:00 New Revision: 4dcfae6a003aa541600e5af42c0bec5d8e1abef0 URL: https://github.com/llvm/llvm-project/commit/4dcfae6a003aa541600e5af42c0bec5d8e1abef0 DIFF: https://github.com/llvm/llvm-project/commit/4dcfae6a003aa541600e5af42c0bec5d8e1abef0.diff

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. MSVC says this should be 202002L for /std:c++20, and of VS16.11 that's indeed the case (older versions warn that they don't understand /std:c++20, and then cl.exe defaults to C++14 and sets _MSVC

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

thakis added a comment. For reference: https://godbolt.org/z/3rnKovjTG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114867/new/ https://reviews.llvm.org/D114867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114867/new/ https://reviews.llvm.org/D114867 ___ cfe-commits mailing list cfe-commits@lists

[clang] 3f643f1 - [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

Author: Nico Weber Date: 2021-12-01T08:54:41-05:00 New Revision: 3f643f166494826144bad05eaa3ae14508788df6 URL: https://github.com/llvm/llvm-project/commit/3f643f166494826144bad05eaa3ae14508788df6 DIFF: https://github.com/llvm/llvm-project/commit/3f643f166494826144bad05eaa3ae14508788df6.diff LO

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f643f166494: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20 (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. I have a patch to enable this by default and I do not want to spread uses of this flag around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

aaron.ballman added a comment. Hmm, the test case you added passes without the patch applied: https://godbolt.org/z/T9TerMYGz I think the issue is that the class needs to be an instantiated template type: https://godbolt.org/z/bhznPdsvf, and a second (interesting but contrived) test case would

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kbobyrev updated this revision to Diff 390999. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comments, add justification in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114864/new/ https://reviews.llvm.

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. In D114099#3148665 , @zahiraam wrote: > In D114099#3148631 , > @sylvestre.ledru wrote: > >> Actually, it breaks on all Debian. >> Could you please revert it? > > Done. I have reverted t

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

sammccall added a comment. In D114724#3163579 , @kadircet wrote: > for whatever reason I remembered the std::remove to have been referenced > ~17k. looks like these two are much closer. I don't think it makes sense to > prefer one or the other here. Ag

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield accepted this revision. JonChesterfield added a comment. This would unblock a patch that has been waiting for us since May (D102107 ). Once your patches land and make the flag unnecessary we can take it back out. I asked for this because I need t

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield added a comment. Fixed abi was set to true in D96340 . At that point, indirect calls probably worked. This was replaced with some dubious fine grain attribute handling in D99347 , at which point indirect calls are

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added a comment. In D111400#3088321 , @aaron.ballman wrote: > In D111400#3088133 , > @hubert.reinterpretcast wrote: > >> In D111400#3087877 , >> @aaron.ba

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. In D111400#3164249 , @aaron.ballman wrote: > In D111400#3088321 , @aaron.ballman > wrote: > >> In D111400#3088133 , >> @hubert.reinterpretcast

[PATCH] D114849: [AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgcn-non-temporal-store.cl:9 +} \ No newline at end of file pls add newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114849/new/ https://r

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391016. junaire marked an inline comment as done. junaire added a comment. Apply some awesome suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1300-1301 +bool InDiscardedStatement : 1; +bool InImmediateFunctionContext : 1; + No real benefit to making these bit-fields, and it'd be good to add some documentation ab

[PATCH] D114859: [clang-format] Add better support for co-routinues

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. LGTM % comments. I agree with all the formatting decisions shown in the new tests. Comment at: clang/docs/ReleaseNotes.rst:270 +- Improved Coroutinues support. +

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSimdDirective(const OMPSimdDirective &S) { + + bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder; + if (UseOMPIRBuilder) { Meinersbur

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2104 +TheCall, [this](QualType ArgTy, SourceLocation ArgLoc) -> bool { + QualType EltTy = ArgTy; + if (auto *VecTy = EltTy->getAs()) Could you add a com

[PATCH] D114849: [AMDGPU][clang] Fix __builtin_nontemporal_store() failure on AMDGPU

skc7 updated this revision to Diff 391023. skc7 added a comment. added new life at eof amdgcn-non-temporal-store.cl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114849/new/ https://reviews.llvm.org/D114849 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGenOpenCL/amdgcn-non-

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

cor3ntin updated this revision to Diff 391030. cor3ntin marked an inline comment as done. cor3ntin added a comment. Add and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113749/new/ https://reviews.llvm.org/D113749 Files: clang/incl

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

cor3ntin updated this revision to Diff 391032. cor3ntin added a comment. Remove bitfields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113749/new/ https://reviews.llvm.org/D113749 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:16575-16578 + ExprEvalContexts[ExprEvalContexts.size() - 2] + .isDiscardedStatementContext(); + ExprEvalContexts.back().InImmediateFunctionContext = + ExprEvalContexts[ExprEvalContexts.siz

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske updated this revision to Diff 391035. balazske added a comment. Improved the test. Added another test to show effect of import in different order. Updated the comment in ASTImporter.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114418/

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:649 BUILTIN(__builtin_elementwise_min, "v.", "nct") +BUILTIN(__builtin_elementwise_ceil, "v.", "nct") BUILTIN(__builtin_reduce_max, "v.", "nct") If we're doing ceil, should

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16727-16728 QualType TyA = A.get()->getType(); - if (checkMathBuiltinElementType(*this, ArgLoc, TyA)) + if (checkMathBuiltinElementType(*this, ArgLoc, TyA) || + ExtraCheck(TyA, ArgLoc)) return

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fix! Comment at: clang/lib/Sema/SemaExpr.cpp:16575-16578 + ExprEvalContexts[ExprEvalContexts.size() - 2] + .isDiscardedSta

[PATCH] D114823: Filter string_view from the nullptr diagnosis of bugprone-string-constructor to prevent duplicate warnings with bugprone-stringview-nullptr

CJ-Johnson updated this revision to Diff 391040. CJ-Johnson marked an inline comment as done. CJ-Johnson added a comment. Switch to early return for the filter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114823/new/ https://reviews.llvm.org/D1148

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 391037. Anastasia retitled this revision from "[SPIR-V] Add a tool chain for SPIR-V (incomplete)" to "[SPIR-V] Add a toolchain for SPIR-V in clang". Anastasia edited the summary of this revision. Anastasia added reviewers: svenvh, azabaznov. Anastasia added

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske added a comment. The new tests produce some -Wodr warnings. The reason is that all deduction guides for the same class `B` are in the `ASTImporterLookupTable` with the same name "deduction guide for B". The message may come from the import of the function template declaration, when an

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added a comment. Aaron is way more familiar with this code than I am, but I've got some suggestions for more tests in the parsing, we need to make sure that we handle pack expansion completely here. Comment at: clang/lib/Parse/ParseDecl.cpp:447 + } +

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

erichkeane added a comment. I just found that build failure in our downstream, and did a little investigation. Running the clang-invocations directly resulted in : [ekeane1@scsel-clx-24 llvm]$ /localdisk2/ekeane1/workspaces/xmain-web/builds/xmainefi2linux_debug/llvm/bin/clang -target arm-ar

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya. jamesfarrell requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 40d5eeac6cd89a2360c3ba997cbaa816abca828c

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

nathanchance added a comment. I tested the problematic Linux kernel configuration that uncovered this issue with this patch and the issue was resolved. I tested an x86_64 allmodconfig build and did not see any warnings. Comment at: clang/lib/Analysis/UninitializedValues.cpp:5

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell added inline comments. Comment at: llvm/lib/MC/MCStreamer.cpp:1343 LinkedTargetVersion.getMajor(), -*LinkedTargetVersion.getMinor(), -*LinkedTargetVersion.getSubminor(), SDKVersion);

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay updated this revision to Diff 391054. MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114859/new/ https://reviews.llvm.org/D114859 Files: clang/docs/ReleaseNotes.rst

[PATCH] D114859: [clang-format] Add better support for co-routinues

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22727 + +TEST_F(FormatTest, CoRoutineawait) { + verifyFormat("int x = co_await foo();"); Quuxplusone wrote: > naming of the tests is to allow easy running of all CoRoutine t

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested review of

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

avogelsgesang updated this revision to Diff 391059. avogelsgesang marked 4 inline comments as done. avogelsgesang added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112648/new/ https://reviews.llvm.org/D112648 F

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

avogelsgesang added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:198 +for (const ParmVarDecl *ParmDecl : collectParamDecls(Ctor, ParamDecl)) { + auto ParamTL = ParmDecl->getTypeSourceInfo()->getTypeLoc(); + auto RefTL = Pa

[clang] 6dd0bfa - [Clang][VE] Fix toolchain test when -DCLANG_DEFAULT_LINKER=lld in use

Author: Simon Moll Date: 2021-12-01T18:26:23+01:00 New Revision: 6dd0bfad0d3c7bfaa3442ad2382ce3bd8ad94be3 URL: https://github.com/llvm/llvm-project/commit/6dd0bfad0d3c7bfaa3442ad2382ce3bd8ad94be3 DIFF: https://github.com/llvm/llvm-project/commit/6dd0bfad0d3c7bfaa3442ad2382ce3bd8ad94be3.diff LO

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSimdDirective(const OMPSimdDirective &S) { + + bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder; + if (UseOMPIRBuilder) { arnamoy10

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

reames abandoned this revision. reames added a comment. I'm stopping work on this. This has already exceeded the amount of work which is worthwhile for me, and it seems there is yet more work needed. On @nikic's prompting, I finally went ahead and got the test-suite setup and tested a clang ve

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 391064. Anastasia added a comment. - Exported full diff. - Added forgotten test cases. - Fixed typo in docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/ https://reviews.llvm.org/D112410 Files: clang/docs/UsersManual.rst clang/in

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 391065. keith marked an inline comment as done. keith added a comment. Remove lld/lib directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 391067. mbenfield added a comment. Revert spurious whitespace change. assert(D) No else after return. Allow attribute to be applied to static member functions and test this. Document that it can't be applied to a non-static member function. Repository:

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 391068. CJ-Johnson added a comment. Add missing comment lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/Bugpro

[libunwind] fa1c077 - [runtimes] Remove support for GCC-style 32 bit multilib builds

Author: Louis Dionne Date: 2021-12-01T12:57:01-05:00 New Revision: fa1c077b41ae1335332d65399802f2c68e82ca7b URL: https://github.com/llvm/llvm-project/commit/fa1c077b41ae1335332d65399802f2c68e82ca7b DIFF: https://github.com/llvm/llvm-project/commit/fa1c077b41ae1335332d65399802f2c68e82ca7b.diff

[libunwind] dc1244d - [runtimes] Move WARNING to FATAL_ERROR for folks using FOO_BUILD_32_BITS

Author: Louis Dionne Date: 2021-12-01T12:57:30-05:00 New Revision: dc1244dc4e76316ab24596545951d3dc47359875 URL: https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875 DIFF: https://github.com/llvm/llvm-project/commit/dc1244dc4e76316ab24596545951d3dc47359875.diff

[clang] 6eeda06 - [Clang] Fix nesting of discarded and immediate contexts.

Author: Corentin Jabot Date: 2021-12-01T12:58:32-05:00 New Revision: 6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880 URL: https://github.com/llvm/llvm-project/commit/6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880 DIFF: https://github.com/llvm/llvm-project/commit/6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880.diff

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG wit a nit Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1567 +} else + AggregatePtr = llvm::Constant::getNullValue(OMPBuilder.VoidPtr); ---

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 6eeda06c1d22da2b9fe96a2569a8a0f8e4f36880 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D114890: [OpenMP] Make the new device runtime the default

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992. Herald added subscribers: dang, kerbowa, guansong, yaxunl, nhaehnle, jvesely. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang

  1   2   >