peterwaller-arm added inline comments.
================ Comment at: clang/include/clang/Basic/BuiltinsAArch64NeonSVEBridge_cg.def:37 +SVEMAP2(svdup_neonq_f64, 3), +SVEMAP2(svdup_neonq_bf16, 1), +#endif ---------------- The second argument is a 'flags' field and these values don't look right. Refs: * [[ https://github.com/llvm/llvm-project/blob/84b978da3b80b986327a830c01e32f12cefe86b3/clang/utils/TableGen/SveEmitter.cpp#L1339 | SVEMAP2 emitted by tablegen ]] * [[ https://github.com/llvm/llvm-project/blob/84b978da3b80b986327a830c01e32f12cefe86b3/clang/include/clang/Basic/arm_sve.td#L137-L149 | Element types ]] * [[ https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGBuiltin.cpp#L9070 | Flags used in CGBuiltin ]] The flags are a generated enum and live in `clang/include/clang/Basic/arm_sve_typeflags.inc` -- I think you'll need to #include this with `LLVM_GET_SVE_ELTTYPES` defined, and then you can write it symbolically rather than using a literal numeric value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
