[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Just a comment on the ECX bit, otherwise this patch looks fine to me. Someone with more x86 knowledge may want to take a look though. Thanks for the patch!

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added a subscriber: abrachet. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting cortex-a53, set this linker flag rather than relying on

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3135461 , @hans wrote: > We're seeing a diagnostic change in Chromium which looks funny. For the > following code (span<> is our own class): > > the diagnostic changes from: > > fatal error: no viable conversio

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

mcgrathr added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:91 +std::string CPU = getCPUName(D, Args, Triple); +if (CPU.empty() || CPU == "generic" || CPU == "cortex-a53") + CmdArgs.push_back("--fix-cortex-a53-843419"); How do

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, dcoughlin, quinnp. ZarkoCA added a project: clang. Herald added subscribers: dexonsmith, martong. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Rewording of comments to avoid using `sanity t

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers added a comment. It might be nice to add an `llvm-link` test that produces an error when this module metadata doesn't match. Basically, it would be nice to error if during LTO we link together two modules that differ in their use of `-mskip-rax-setup` since that has ABI implica

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/X86/pr23258.ll:22 + +declare dso_local void @bar(i32, ...) + nickdesaulniers wrote: > Is there anything one the callee side that we should check? I assume the > callee does some check of `%al`

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

ZarkoCA created this revision. ZarkoCA added reviewers: klimek, akyrtzi, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits. Herald added a project: LLDB. Rename function to more inclusive name. Repository: rG

[PATCH] D114031: Full matching for version numbers.

jamesfarrell created this revision. jamesfarrell requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114031 Files: clang/test/Sema/attr-availability-android.c Index: clang/te

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax added a comment. > My reading of > https://clang.llvm.org/docs/LanguageExtensions.html#specifying-an-attribute-for-multiple-declarations-pragma-clang-attribute > suggests that any() /could/ apply to everything. (`The any rule applies > attributes to all declarations that are matched by

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 387759. michaelrj marked an inline comment as done. michaelrj added a comment. update the set type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 Files: clang-to

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. The clang-tidy/infrastructure/pr37091.cpp

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley added a subscriber: dstenb. mattbeardsley added a comment. @dstenb - wanted to check with you too to make sure that this change to pr37091.cpp seems like it won't interfere with the original intent of the test (https://reviews.llvm.org/D45686 ) The lingering file issue you'd fixed

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

sugak added a comment. ping @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112481/new/ https://reviews.llvm.org/D112481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

jamesfarrell created this revision. Herald added a subscriber: danielkiss. jamesfarrell requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114036 Files: clang/test/Sema/attr-a

[PATCH] D113943: Add `withTag` matcher.

jcking1034 updated this revision to Diff 387769. jcking1034 added a comment. Improve wrapping of PolymorphicMatchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113943/new/ https://reviews.llvm.org/D113943 Files: clang/include/clang/ASTMatcher

[PATCH] D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

srhines accepted this revision. srhines added a comment. Thanks for the expanded (and more specific) tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114036/new/ https://reviews.llvm.org/D114036 ___

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

ASDenysPetrov updated this revision to Diff 387773. ASDenysPetrov added a comment. Fixed failed unittest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114006/new/ https://reviews.llvm.org/D114006 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h clang/

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

ASDenysPetrov added a comment. In D114006#3135456 , @steakhal wrote: > Sweet! > I think commit titles are not punctuated, even though they start with an > uppercase letter. Thanks! That depends on the mood at the particular moment :) But seriously, it'

[PATCH] D106756: Added l16/l32 length modifiers for char16_t/char32_t

MarcusJohnson91 updated this revision to Diff 387788. MarcusJohnson91 added a comment. Clang-FormatDiff.py; Still waiting for the UTFConvert patch to land first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106756/new/ https://reviews.llvm.org/D106756 Files: clang/include/clang/AST/

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

NoQ added a comment. Taking advantage of strict aliasing is good as long as it produces strictly smaller analysis space (less paths, more constrained states). I.e., we can use it for eliminating possibilities, but not for discovering possibilities. If we ever prove that strict aliasing is viola

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Does GCC actually change the formal types of expressions to `float`, or is it doing this "no intermediate casts thing" as some sort of fp_contract-style custom emission of trees of expressions that involve `_Float16`? In any case, doing operation-by-operation emulation

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu updated this revision to Diff 387811. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.llvm.org/D113977 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu marked 5 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/co_await-range-for-exp-namespace.cpp:54 for -co_await(auto i : arr) {} +co_await(auto i : arr) {} // expected-warning {{Found deprecated std::experimental}}

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. --

[PATCH] D114051: Illustrate an alternative for tracking includes per submodule.

vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Aggregated transitive includes are stored in SubmoduleState, includes per submodule for subsequent serialization are

[PATCH] D112915: [clang][modules] Track number of includes per submodule

vsapsai added a comment. Didn't go in-depth for serialization/deserialization. When we add tracking `isImport` on per-submodule basis, do you think AST reading/writing would change significantly? Comment at: clang/include/clang/Lex/ExternalPreprocessorSource.h:45 + /// Retur

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf added a comment. In D109751#3131169 , @nemanjai wrote: > Please provide a description for this patch which includes justification for > why we want to allow conversion between the two types. > I am of the impression that allowing the two types to c

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf updated this revision to Diff 387819. qiucf added a comment. Disallow conversion in compound and conditional CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109751/new/ https://reviews.llvm.org/D109751 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp clan

[clang] 73c9cf8 - [X86][FP16] add alias for f*mul_*ch intrinsics

Author: Freddy Ye Date: 2021-11-17T13:26:11+08:00 New Revision: 73c9cf820409834b134a8c8c8039efe4113845d9 URL: https://github.com/llvm/llvm-project/commit/73c9cf820409834b134a8c8c8039efe4113845d9 DIFF: https://github.com/llvm/llvm-project/commit/73c9cf820409834b134a8c8c8039efe4113845d9.diff LOG

[PATCH] D112777: [X86][FP16] add alias for f*mul_*ch intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG73c9cf820409: [X86][FP16] add alias for f*mul_*ch intrinsics (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://revie

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. In D51650#3127097 , @aaron.ballman wrote: > In D51650#3126569 , @akuegel wrote: > >> Since it is not clear whether the semantic change was intended, I think it >> makes sense to revert

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu updated this revision to Diff 387828. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Use `-Wno-coroutine` instead of `-Wno-deprectated-experimental-coroutine` to keep CI stable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.

[PATCH] D114051: Illustrate an alternative for tracking includes per submodule.

vsapsai updated this revision to Diff 387834. vsapsai added a comment. Handle `BuildingSubmoduleStack` not storing the top-level module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114051/new/ https://reviews.llvm.org/D114051 Files: clang/incl

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

FreddyYe created this revision. Herald added a subscriber: pengfei. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114059 Files: clang/lib/Headers/avx512vlbf16int

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc created this revision. sheldonneuberger-sc added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet. sheldonneuberger-sc added a reviewer: erichkeane. sheldonneuberger-sc edited the summary of this revision. sheldonneuberger-sc published this revision for review.

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:429 +///A 128-bit vector of [4 x bfloat]. +/// \returns A 128-bit vector of [4 x float] come from convertion of __A +static __inline__ __m128 __DEFAULT_FN_ATTRS128 _mm_cvtpbh_ps(__m128bh __

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki added a comment. Hi @Anastasia and @bader, This patch should be ready to land, I think. Could you please push it to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 ___

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

FreddyYe updated this revision to Diff 387845. FreddyYe added a comment. convertion -> conversion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114059/new/ https://reviews.llvm.org/D114059 Files: clang/lib/Headers/avx512bf16intrin.h clang/lib

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114059/new/ https://reviews.llvm.org/D114059 ___

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

mstorsjo created this revision. mstorsjo added a reviewer: rnk. mstorsjo requested review of this revision. Herald added a project: clang. Clang has custom handling of --no-demangle, where it is removed from the input -Wl and -Xlinker options, and readded specifically by the drivers where it's kno

<    1   2