nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land.
Just a comment on the ECX bit, otherwise this patch looks fine to me. Someone with more x86 knowledge may want to take a look though. Thanks for the patch! ================ Comment at: llvm/lib/Target/X86/X86CallingConv.td:279 + CCIfNotSubtarget<"hasX87()", + CCIfType<[f32], CCAssignToReg<[EAX, EDX, ECX]>>>, CCIfType<[f16], CCAssignToReg<[XMM0,XMM1,XMM2]>>, ---------------- Is there a test case that exercises the assignment to %ecx? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112143/new/ https://reviews.llvm.org/D112143 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
