[PATCH] D113917: Add infrastructure to support matcher names.

ymandel added a comment. For a little more context: we're working to improve the debuggability of matchers. The first step in that direction seems to be a change of this sort that provides some (dynamic) introspection so that a tool, library, etc. can see some basic information about the matche

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113575/new/ https://reviews.llvm.org/D113575 ___ cfe-commits mailing list cfe-comm

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#3130696 , @whisperity wrote: > In D64454#3124312 , @aaron.ballman > wrote: > >> Yeah, I was worried this would get out of sycn and it really did not take >> long for that t

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc added a comment. In D108479#3129577 , @rjmccall wrote: > In D108479#3129571 , @jrtc27 wrote: > >> For CHERI there's the added complication that descriptors and trampolines >> can exist for security reasons wh

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 created this revision. gandhi21299 added reviewers: yaxunl, b-sumner, t-tye, tra, rjmccall. Herald added subscribers: dexonsmith, Anastasia. gandhi21299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an AtomicScopeModel for

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. This also leaks out to users via __builtin_dump_struct (https://godbolt.org/z/vx3rjdPdq), and of course the DWARF having the namespace in it will result in users debugging plain C seeing C++ namespaces. ASTDiagnostic's Desugar happens to special-case va_list so it doesn'

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam updated this revision to Diff 387337. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst === --- clan

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

wristow added a comment. Thanks @zahiraam ! The updated ReleaseNote LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] 95edd7f - Making the code compliant to the documentation about Floating Point

Author: Zahira Ammarguellat Date: 2021-11-15T15:30:10-05:00 New Revision: 95edd7f53e77415ca30abefdcdc5ce723c292ebd URL: https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd DIFF: https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

aprantl added a comment. This looks reasonable to me. Thanks! Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:234 + if (!LexicalBlockStack.empty()) +LexicalBlockMap[&D] = LexicalBlockStack.back(); +} maybe use `LexicalBlockMap.insert({&D, LexicalBlockStack.b

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff updated this revision to Diff 387377. fwolff added a comment. Thanks for your suggestions @whisperity! I have fixed both of them now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 Files: clang-tools-extra/clang-tidy/modernize/UseUsi

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis updated this revision to Diff 387381. thakis added a comment. - rebase on top of recent (partially still pending) llvm patches - use `{...|...}` in intrinsic headers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.org/D113707 Files: clang/include

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, that is certainly not a place where one would put `throw`. :-D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113585/new/ htt

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

fwolff added a comment. Thanks for reviewing this! Can you also commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113585/new/ https://reviews.llvm.org/D113585 ___ cfe-commits mailing list c

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

aaron.ballman added a comment. In D113585#3132793 , @fwolff wrote: > Thanks for reviewing this! Can you also commit it for me? Sure can! What name and email address would you like used for patch attribution? I'm in C standards meetings all this week so

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. Fairly big update. I'd like to punt on the pragma for now since this became a lot more involved than expected already (see dependent patches; several of them have already landed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.or

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

aaron.ballman added reviewers: aaron.ballman, whisperity, hokein. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. In D112648#3132157 , @avogelsgesang wrote: > @ymandel, @whisperity, @aaron.ballman could one of you review this/point m

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff updated this revision to Diff 387384. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113863/new/ https://reviews.llvm.org/D113863 Files: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp clang-tools-extra/test/clang-tidy/checkers/readability-container-data

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

fwolff marked an inline comment as done. fwolff added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:20-23 +static const char ContainerExprName[] = "container-expr"; +static const char DerefContainerExprName[] = "deref-contain

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

aaron.ballman added reviewers: alexfh, whisperity. aaron.ballman added a comment. In D112646#3132141 , @avogelsgesang wrote: > @xazax.hun / @whisperity could you review this change for me, please :) > Or, alternatively: can you direct me to somebody who

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 387389. mbenfield added a comment. s/requires/takes in diagnostic message. Test case with a non-template overloaded function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.or

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

fwolff added a comment. In D113585#3132810 , @aaron.ballman wrote: > In D113585#3132793 , @fwolff wrote: > >> Thanks for reviewing this! Can you also commit it for me? > > Sure can! What name and email address wo

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 387387. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp clang/test/CodeGen/X86/Float16-aritmetic

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-complex.c:123 // X86-NOT: fdiv - // X86: call {{.*}} @__divhc3( + // X86: call {{.*}} @__divsc3( // X86: ret zahiraam wrote: > pengfei wrote: > > andrew.w.kaylor wrote: > > > Wh

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 updated this revision to Diff 387395. gandhi21299 added a comment. clang-formatted code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://reviews.llvm.org/D113925 Files: clang/include/clang/AST/Expr.h clang/include/

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 updated this revision to Diff 387396. gandhi21299 added a comment. reapplied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113925/new/ https://reviews.llvm.org/D113925 Files: clang/include/clang/AST/Expr.h clang/includ

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/address-safety-attr.cpp:9 -// RUN: echo "fun:*BlacklistedFunction*" > %t.func.blacklist -// RUN: %clang_cc1 -std=c++11 -triple x86_64-

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis updated this revision to Diff 387399. thakis added a comment. minor test expectations update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.org/D113707 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOption

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

fwolff updated this revision to Diff 387401. fwolff added a comment. Thanks again for your feedback @salman-javed-nz! I think I've addressed all of your comments now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113830/new/ https://reviews.llvm.org/D113830 Files: clang-tools-extra/

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 387404. mizvekov added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. - Add `libcxx/DELETE.ME` to trigger libcxx CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D113942: [NFC] Inclusive language: replace master with main in convert_arm_neon.py

quinnp created this revision. Herald added a subscriber: kristof.beyls. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project and to match the renamed master branch, this pa

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

rnk added a comment. In D113707#3132812 , @thakis wrote: > Fairly big update. I'd like to punt on the pragma for now since this became a > lot more involved than expected already (see dependent patches; several of > them have already landed). No proble

[PATCH] D113943: Add withTag matcher.

jcking1034 created this revision. jcking1034 added reviewers: ymandel, tdl-g, aaron.ballman. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a `withTag` matcher which outputs contextual information for better debugging. This

[clang] 19867de - [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

Author: Arthur Eubanks Date: 2021-11-15T14:44:53-08:00 New Revision: 19867de9e79327207796a16c1c24ac5d2cafecf9 URL: https://github.com/llvm/llvm-project/commit/19867de9e79327207796a16c1c24ac5d2cafecf9 DIFF: https://github.com/llvm/llvm-project/commit/19867de9e79327207796a16c1c24ac5d2cafecf9.diff

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19867de9e793: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on… (authored by aeubanks). Changed prior to commit: htt

[PATCH] D113944: [CodeGenAction][NFC] Remove empty comment

JOE1994 created this revision. JOE1994 requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113944 Files: clang/lib/CodeGen/CodeGenAction.cpp Index: clang/lib/CodeGen/CodeGenAction.cpp ==

[clang] 9809c6c - Add `isInitCapture` and `forEachLambdaCapture` matchers.

Author: James King Date: 2021-11-15T22:55:28Z New Revision: 9809c6c61cebbfcd100a3afd30fc9009f68d4678 URL: https://github.com/llvm/llvm-project/commit/9809c6c61cebbfcd100a3afd30fc9009f68d4678 DIFF: https://github.com/llvm/llvm-project/commit/9809c6c61cebbfcd100a3afd30fc9009f68d4678.diff LOG: Ad

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9809c6c61ceb: Add `isInitCapture` and `forEachLambdaCapture` matchers. (authored by jcking1034, committed by ymandel). Repository: rG LLVM Github

[PATCH] D113530: [wip] [analyzer] support use-after-free checking with parameter annotation

chrisdangelo added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2383 +def OwnershipParam : InheritableParamAttr { + let Spellings = [Clang<"ownership_takes_param">]; + let Subjects = SubjectList<[ParmVar]>; I've discussed this a bit with Artem

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj created this revision. michaelrj added reviewers: sivachandra, lntue. Herald added subscribers: libc-commits, carlosgalvezp, ecnelises, tschuett, xazax.hun. Herald added a project: libc-project. michaelrj requested review of this revision. Herald added a project: clang-tools-extra. Heral

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

lntue added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:59 +llvm::StringRef(FUNCTIONS_TO_IGNORE_NAMESPACE[i]))) { + printf("String found %s\n", FuncDecl->getName().str().c_str()); + return; Loo

[PATCH] D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename `IsPossiblyOpaquelyQualifiedType` overload taking a Type* as `IsPossiblyOpaquelyQualifiedTypeInternal` instead. Signed-off-by: Matheus Izvekov

[PATCH] D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

mizvekov updated this revision to Diff 387449. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113954/new/ https://reviews.llvm.org/D113954 Files: clang/lib/Sema/SemaTemplateDeduction.cpp Index: clang/lib/Sema/SemaTem

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. (Here are a few revisions I read through while researching this patch: da081a8e1f295ffdd670f87dba19f470a9a5acaa and fc416faaa07c5 (and 4f2791617e2fa) and aa23fa9f435d2 1778831a3d1d2 split the "ms" inline asm out isSimple added in 19fe116fc0b35, meaningfully used in b737b

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Can we split the patch which changes what types are enabled for various x86 sub-targets out from the patch that changes the semantics of operations on `_Float16`? Or is there a good reason it's disabled currently, namely because the semantics are wrong? ===

[clang] 21ed00b - [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

Author: Matheus Izvekov Date: 2021-11-16T03:09:50+01:00 New Revision: 21ed00bc1bfd2b0b81d288f7f096a31079c24c4a URL: https://github.com/llvm/llvm-project/commit/21ed00bc1bfd2b0b81d288f7f096a31079c24c4a DIFF: https://github.com/llvm/llvm-project/commit/21ed00bc1bfd2b0b81d288f7f096a31079c24c4a.dif

[PATCH] D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG21ed00bc1bfd: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload (authored by mizvekov). Repository:

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. Do any of the proposed use cases actually require this to be a constant expression? Some of these patterns can be cheaply implemented with code generation even if the target doesn't otherwise support constants; for example, we could just mask the THUMB bit off on 32-b

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. If we do need to support constant expressions of this, I think we should have the constant evaluator produce an expression rather than an l-value, the way we do with some other builtin calls. That should stop the comparison problem more generally. Repository: rG L

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai updated this revision to Diff 387472. HsiangKai added a comment. Herald added subscribers: VincentWu, luke957, mgrang. Restructure the data structure to reuse information between C intrinsics. In this way, we can have a smaller binary size and speed up the lookup for the C intrinsics.

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ahatanak added a comment. @ille, are you still working on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90434/new/ https://reviews.llvm.org/D90434 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

salman-javed-nz accepted this revision. salman-javed-nz added a comment. This revision is now accepted and ready to land. LGTM. Nothing more to suggest from my side. Can we allow a few days for the other reviewers to put in their 2c. As for the Bugzilla ticket

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai updated this revision to Diff 387488. HsiangKai added a comment. Check required extensions when adding the declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/cl

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai updated this revision to Diff 387489. HsiangKai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/clang/Basic/CMakeLists.txt clang/include/clang/B

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1313 + !CGF.getContext().getTargetInfo().hasFeature("avx512fp16") && + (TT.isX32() || TT.isX86()); + if ((SrcType->isHalfType() || iSFloat16Allowed) && We don't need to check

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:13 +#include + Should be `` and without newline separation form rest of headers. Comment at: clang-tools-extra/clang-tidy/llvml

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

sivachandra added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:1 //===-- CalleeNamespaceCheck.cpp --===// // You should add tests for this exception check. See https://gith

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. -

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. --

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki updated this revision to Diff 387499. linjamaki marked an inline comment as done. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 Files: clang/lib/Driver/CMa

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 387500. linjamaki added a comment. Rebase, add asserts and move address space map reset for HIP from SPIRVTargetInfo to BaseSPIRTargetInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://re

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. Anastasia wrote: > linjamaki wro

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

This revision was automatically updated to reflect the committed changes. Closed by commit rG9699c0fea355: [clang-tidy][NFC] Simplify ClangTidyStats (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113847/new/ https://revie

[clang-tools-extra] 9699c0f - [clang-tidy][NFC] Simplify ClangTidyStats

Author: Carlos Galvez Date: 2021-11-16T07:36:05Z New Revision: 9699c0fea3552f687f8357032199890633d58fe2 URL: https://github.com/llvm/llvm-project/commit/9699c0fea3552f687f8357032199890633d58fe2 DIFF: https://github.com/llvm/llvm-project/commit/9699c0fea3552f687f8357032199890633d58fe2.diff LOG:

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. @tstellar @tonic I have finally received an answer from AUTOSAR. Let me know if you'd like me to CC you the mail chain to see the exact discussion. > The AUTOSAR confidential statement states that these documents are considered > under the license of AUTOSAR, thus

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. In D112730#3133822 , @carlosgalvezp wrote: > @tstellar @tonic I have finally received an answer from AUTOSAR. Let me know > if you'd like me to CC you the mail chain to see the exact discussion. Can you cc bo...@llvm.org on th

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

JonChesterfield added a comment. Please change the commit message to say why this change is necessary / an improvement on what we have now. My recollection is that the amdgpu backend crashes on some IR and this decreases the probability of that IR pattern occuring, which still sounds like fixi

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a reviewer: scanon. rjmccall added a comment. + Steve Canon Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic i

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

JonChesterfield added a comment. Please update the documentation with this new constraint. It would be helpful to know exactly when we now require alloca instructions to be adjacent to one another. If you wish to avoid other passes breaking the invariant in future, I think it needs to be added

<    1   2