[PATCH] D113145: Mark virtual method declaration in union as invalid

ychen updated this revision to Diff 384975. ychen added a comment. - Mark virtual function in union invalid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113145/new/ https://reviews.llvm.org/D113145 Files: clang/lib/Sema/SemaDecl.cpp clang/te

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen created this revision. ychen added reviewers: rsmith, Mordante. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Down the path, if there is a implicit instantiation, this may trigger the assertion "Member specialization must be a

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

lebedev.ri resigned from this revision. lebedev.ri added a comment. I will not be part of this language policing. -10 to any changes that break existing external interface (that is, it is not okay to just rename externally-visible command-line flags, config options, etc.) Repository: rG LLVM

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

steakhal added a comment. In D111654#3109585 , @ASDenysPetrov wrote: > @steakhal Thank you for your suggestion. I'll make corresponding changes. > >> I'm still worried about the fact that you assume that there is a >> correspondence between `ElementRegi

[PATCH] D113246: [clang][tests] Fix expected output of plugin-attribute test

tbaeder created this revision. tbaeder added a reviewer: psionic12. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The output contains "const char[11]", not "const char [11]". I don't think this test is being run in CI at all beca

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:320 // linear structure. static const llvm::GlobalValue *getAliasedGlobal(const llvm::GlobalValue *GV) { + const llvm::Constant *C; erichkeane wrote: > Can you explain a bit bett

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 384981. khchen added a comment. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Fil

[clang] f95bd18 - Revert "[Attr] support btf_type_tag attribute"

Author: Martin Storsjö Date: 2021-11-05T10:36:40+02:00 New Revision: f95bd18b5faa6a5af4b5786312c373c5b2dce687 URL: https://github.com/llvm/llvm-project/commit/f95bd18b5faa6a5af4b5786312c373c5b2dce687 DIFF: https://github.com/llvm/llvm-project/commit/f95bd18b5faa6a5af4b5786312c373c5b2dce687.diff

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

mstorsjo added a comment. I went ahead and reverted this, as it caused crashes when compiling a number of projects. The most reduced testcase is this: $ cat reduced.c void a(*); void a() {} $ clang -c reduced.c -O2 -g A full case (which reduces into this) is this, https://martin.st/te

[PATCH] D108567: Implement #pragma clang final extension

sberg added a comment. > Final macros will always warn on redefinition, including situations with > identical bodies and in system headers. But #define NULL syntax error #pragma clang final(NULL) #include void * p = NULL; does not produce any warnings/errors for me and indicates that

[PATCH] D113249: Bump CUDA version to 11.5

carlosgalvezp created this revision. Herald added subscribers: asavonic, dexonsmith, hiraditya, yaxunl, jholewinski. carlosgalvezp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Following the pattern used for 11.4: https:

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

Hahnfeld added a comment. I'm not sure if it's actually correct to advertise full support for CUDA 11.5, but I didn't look into exact changes since 11.4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://reviews.llvm.org/D113249 __

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

carlosgalvezp added a comment. In D113249#3110954 , @Hahnfeld wrote: > I'm not sure if it's actually correct to advertise full support for CUDA > 11.5, but I didn't look into exact changes since 11.4 Good point. I was confused about the fact that 11.4 i

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder created this revision. Herald added a subscriber: dang. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. >From GCC's manpage: -fplugin-arg-name-key=value Define an argument called key with a value of value for the plugin

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. gamesh411 requested rev

[PATCH] D113254: [clang] Fix a misadjusted path style comparison in a unittest

mstorsjo created this revision. mstorsjo added a reviewer: dexonsmith. mstorsjo requested review of this revision. Herald added a project: clang. This was changed incorrectly by accident in 99023627010bbfefb71e25a2b4d056de1cbd354e

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

kristof.beyls added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics"

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

mubashar_ created this revision. mubashar_ added reviewers: dmgreen, lenary. Herald added subscribers: hiraditya, kristof.beyls. mubashar_ requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong added a comment. There are no runtime or peak memory usage growth with this patch (actually, the runtime decreases with a few %). I am attaching the measurements results of the latest Diff.F20089096: stats.html Repository: rG LLVM Github Monorepo

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. In D108482#3108013 , @ricejasonf wrote: > In D108482#3105889 , @tambre wrote: > >> I presume you lack the permissions to push this to the main repo yourself. >> Would you like me to do th

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I believe you are planning an update for this patch. Requesting changes to take it off the queue until you have uploaded the updated version. Repository: rG LLVM Github Monore

[clang] 737f540 - [Sema][NFC] Add tests for builtin spaceship operator.

Author: Clement Courbet Date: 2021-11-05T11:44:19+01:00 New Revision: 737f540abd578df094f04f690a9b5b52028374b4 URL: https://github.com/llvm/llvm-project/commit/737f540abd578df094f04f690a9b5b52028374b4 DIFF: https://github.com/llvm/llvm-project/commit/737f540abd578df094f04f690a9b5b52028374b4.dif

[PATCH] D113261: [analyzer][solver] Remove reference to RangedConstraintManager

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong req

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

asb added a comment. In D112359#3098960 , @eopXD wrote: > > Add version numbers for test case in `attribute-arch.s` Thanks for updating the patch. Why change this test case? I thought those lines were verifying that .attribute arch without a version

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev planned changes to this revision. kbobyrev added a comment. This is POC, I need to deal with forward decls and definitions from D112707 firs. Otherwise, this introduces too much noise (LLVM really has *lots* of forward decls that make almost no sense).

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than a number of stylistic changes. Feel free to address those on the commit. You also might want to give @amyk a bit of time to ensure her comments were adequately addressed.

[PATCH] D111866: [RISCV] Support Zfhmin extension

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, modulo one tiny nit on a comment. Thanks! Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td:253 def PseudoFSH : PseudoStore<"fsh", FPR16>; } // Predicates = [HasStdEx

[PATCH] D51650: Implement target_clones multiversioning

danielkiss added a comment. In D51650#3096487 , @erichkeane wrote: > This needs rebasing/probably some cleanup, plus code review. If you have > active/proficient CFE code reviewers who could take a look, I'd be willing to > spend some time rebasing. Th

[PATCH] D113264: [clang] [DirectoryWatcher] Remove leading \\?\ from GetFinalPathNameByHandleW

mstorsjo created this revision. mstorsjo added a reviewer: aaron.ballman. mstorsjo requested review of this revision. Herald added a project: clang. This is needed for the paths to work when using forward slashes; this fixes the DirectoryWatcherTests unit tests. Also allocate missing space for th

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo created this revision. mstorsjo added reviewers: sammccall, aaron.ballman. Herald added subscribers: usaxena95, kadircet, arphaman. mstorsjo requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. If running on Window

[PATCH] D113269: [clang-move] Fix unit tests with forward slash as separator on windows

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, sammccall. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113269 Files: clang-tools-extra/unittests/clang-move/ClangM

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

ZarkoCA added a comment. In D113211#3110171 , @jkorous wrote: > Hi! Thank you for the clean-up :) > > I feel there might be a bit of work still left. While renaming filenames and > function names should be mostly inconsequential renaming command line opt

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3109994 , @ibookstein wrote: > I see. What is the guiding principle there, though? Generating correct IR "up > front" / "the first time" rather than "fixing it up as you go via > manipulations"? (could you give a

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

erichkeane added a comment. Explanations make sense to me, I'm generally in favor with the 1 concern. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:397 +bool IsIFunc = isa(Alias); llvm::Constant *Aliasee = ibookstein wrote: > erichkeane wrote: > >

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:159-160 AArch64::AEK_RCPC | AArch64::AEK_SSBS)) +AARCH64_CPU_NAME("cortex-a710", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_MTE | AArch64::AEK_PAU

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Kindly ping. @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push? Here are the commit details: C. Rayroud - rayro...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 _

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90/new/ https://reviews.llvm.org/D90 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. TL;DR: clangd is unsupported/broken on mingw, this patch only makes the tests pass. The current maintainers don't plan to invest in this, or accept much extra complexity to support it. If you or someone wants to find a clean way to support the configuration, it'd be g

[PATCH] D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111262/new/ https://reviews.llvm.org/D111262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

steakhal added subscribers: whisperity, steakhal. steakhal added a comment. Herald added a subscriber: carlosgalvezp. It seems like the checker is documented as `readability-data-pointer` but in the tests it reports issues under the `readability-container-data-pointer` name. Shouldn't they be the

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a subscriber: rnk. mstorsjo added a comment. FWIW, this change is not about mingw, it's about making the windows-with-forward-slashes configuration usable. The windows-with-forward-slashes configuration works just as fine in MSVC configurations, and that's where I've tested it. A

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz updated this revision to Diff 385071. adamcz added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/ https://reviews.llvm.org/D111318 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-too

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz added a comment. Sorry for delay, I got distracted with other stuff. I addressed your comment, partially, and also added more tests and fixed one more issue (see the FunctionType test, it would've failed before). Comment at: clang/lib/Sema/SemaOverload.cpp:6460 // l

[PATCH] D112913: Misleading bidirectional detection

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:105 + + Inspect string literal and comments for unterminated bidirectional Unicode + characters. Nit: Inspects CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11291

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a reviewer: kadircet. sammccall added a comment. Ooh sorry, I was missing some context. I see now that LLVM_WINDOWS_PREFER_FORWARD_SLASH, `windows_backslash` etc are new work. And maybe buildbots are coming? It's possible that the combination of our windows support plus improved

[clang] a00944e - [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

Author: Alex Lorenz Date: 2021-11-05T07:48:07-07:00 New Revision: a00944ebeab1b0adbce606cde4d2410fcbb3f440 URL: https://github.com/llvm/llvm-project/commit/a00944ebeab1b0adbce606cde4d2410fcbb3f440 DIFF: https://github.com/llvm/llvm-project/commit/a00944ebeab1b0adbce606cde4d2410fcbb3f440.diff L

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa00944ebeab1: [clang] 'unused-but-set-variable' warning should not apply to __block objective… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. I forgot to add - I agree with the general sentiment though, that it’s not worth bending over backwards to make tests pass in a setup that’s known not to work in real use though. Then again, if someone were to want to actually step up to make it work in mingw setups,

Re: [PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

On 11/5/21 1:40 AM, Martin Storsjö via Phabricator wrote: mstorsjo added a comment. I went ahead and reverted this, as it caused crashes when compiling a number of projects. The most reduced testcase is this: $ cat reduced.c void a(*); void a() {} $ clang -c reduced.c -O2 -g A f

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. @asb Thanks for the reply. To clarify the question, the 2 inconsistencies are: - Test cases with `clang -cc1` originally don't do dependency check to target feature specified (handled by `parseFeatures`) - Clang driver's -march enforces version to be specified, while llvm

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. In D113268#3111709 , @mstorsjo wrote: > FWIW, this change is not about mingw, it's about making the > windows-with-forward-slashes configuration usable. OK - can I ask why the windows-with-forward-slashes configuration is valu

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. And how is Cling expecting CFE to deal with partial knowledge situations at the implementation level? To deal with exactly the non-local cases that the current violations address? If there's no prescriptive way forward to dealing with these cases (so they're tech deb

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 385083. hliao marked an inline comment as done. hliao added a comment. Rebase to the main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files: clang/test/Co

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk accepted this revision. amyk added a comment. Aside from Nemanja's comments, this patch LGTM. Thanks for addressing the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112285/new/ https://reviews.llvm.org/D112285

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3111873 , @ibookstein wrote: > And how is Cling expecting CFE to deal with partial knowledge situations at > the implementation level? To deal with exactly the non-local cases that the > current violations address

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. Oh, I realized that issues relating to “mingw” probably are from msys (which often is used together, but is an entirely different thing) - yeah I can see that there’d be lots of unfixable issues with that, and I’m not signing up for looking into that… Msys is the unix

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

sammccall added a comment. Thanks, this looks nice! Since the code is in Sema, we'd should (also) test this in `clang/test/CodeCompletion/` if possible. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:928 +// FIXME: Add support for per-signature activeParameter

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp index ea3e5bdbc754..826c6d36e1b1 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp +++ b/compiler-rt/lib/sanitizer_common/s

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

lenary added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:159-160 AArch64::AEK_RCPC | AArch64::AEK_SSBS)) +AARCH64_CPU_NAME("cortex-a710", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_MTE | AArch64::AEK_PAUT

[PATCH] D51650: Implement target_clones multiversioning

erichkeane updated this revision to Diff 385089. erichkeane added a comment. Another rebase, as requested. I am not particularly familiar with this code anymore, so my responses to reviews might not be particularly well informed, but I'm hoping that rust shakes off through the review :) CHANG

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

lenary added a comment. I'm happy with these changes, and with the comments from @dmgreen - as I'm away next week, don't wait for my approval to land this if David has given his approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113256/new/

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

sammccall added a comment. This is cool! I think it will interact with other features (stdlib, exported headers), and so whatever lands second is going to have to eat the complexity of that interaction. I think both stdlib and exported headers are more critical and more essentially complex, so

[PATCH] D51650: Implement target_clones multiversioning

echristo added a comment. FWIW I'm a bit rusty in this area myself, but thanks for doing this. Let's see if we can't get Aaron to continue reviewing :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/ https://reviews.llvm.org/D51650

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. Sadly, I think _I_ am the multiversioning expert (or at least, past-me was), so I'm hoping some of the reviewers @danielkiss can get to join will be able to read/understand this stuff for a quality review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. In D113268#3111798 , @sammccall wrote: > In D113268#3111709 , @mstorsjo > wrote: > >> FWIW, this change is not about mingw, it's about making the >> windows-with-forward-slashes configu

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov updated this revision to Diff 385096. ASDenysPetrov added a comment. Updated according to @steakhal's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/ https://reviews.llvm.org/D111654 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/A

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks added a comment. In D113210#3110780 , @Meinersbur wrote: > This change caused the Polly build to fail: > https://lab.llvm.org/buildbot/#/builders/10/builds/7501 > > opt: > /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.src/llvm/

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ddpagan updated this revision to Diff 385098. ddpagan added a comment. Successfully rebased, built, and tested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112577/new/ https://reviews.llvm.org/D112577 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Recursive

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

tschuett added a comment. If you look at the `immintrin.h` header, the access too many builtins is guarded by ifdefs. ` #if defined(__SSSE3__)` The builtin `__builtin_ia32_reduce_smin_d512` is useless on aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. In D113268#3111995 , @mstorsjo wrote: >> I think the biggest testing problem we have though is that we don't have a >> good way of defining integration tests with paths set up the right way >> (since we can't really use absolu

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. Thanks Denys for the update! Very good! However, I think maybe we could make the code a bit more simpler. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:229-233 +// We want to keep the following invariant at all times: +//

[clang] a83a6c2 - [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

Author: Zarko Todorovski Date: 2021-11-05T12:27:05-04:00 New Revision: a83a6c22e63ad84e9c210c71b36413bed72ac23c URL: https://github.com/llvm/llvm-project/commit/a83a6c22e63ad84e9c210c71b36413bed72ac23c DIFF: https://github.com/llvm/llvm-project/commit/a83a6c22e63ad84e9c210c71b36413bed72ac23c.di

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

This revision was automatically updated to reflect the committed changes. Closed by commit rGa83a6c22e63a: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path=… (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D112591?vs=383507&id=385099#toc Rep

Re: [PATCH] D51650: Implement target_clones multiversioning

I think you are these days too :) My offer was "past-past-me". I think you're probably ok here, I did a rough scan, but getting someone like Aaron for the attribute support would be good. On Fri, Nov 5, 2021 at 12:00 PM Erich Keane via Phabricator < revi...@reviews.llvm.org> wrote: > erichkeane a

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz updated this revision to Diff 385102. adamcz marked an inline comment as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/ https://reviews.llvm.org/D113120 Files: clang/lib/AST/ExprCon

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10617 +// copying the data, which is wasteful. +for (const unsigned N : {1u, FinalSize}) { + unsigned OldElts = Value->getArrayInitializedElts(); kadircet wrote: > maybe unroll

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks added a comment. fixed with 7f62759697762473 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113210/new/ https://reviews.llvm.org/D113210 ___

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D106823#3109469 , @martong wrote: >> As of diff 5, line 1767 and all the code in the block at line 2184 are >> uncovered by the tests you provi

[PATCH] D113261: [analyzer][solver] Remove reference to RangedConstraintManager

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Yey, it looks good. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1608 LLVM_NODISCARD static ProgramStateRef - assign(ProgramStateRef State, Ra

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, bsmith, paulwalker-arm. Herald added subscribers: ctetreau, dexonsmith, dang, jdoerfert, hiraditya. c-rhodes requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The defau

[clang] 1b75285 - [AIX][Clang] Fix XL product name in AIX XL compatibility warning

Author: Zarko Todorovski Date: 2021-11-05T13:17:30-04:00 New Revision: 1b7528554f835d58036543de1e8839ba1ac29f1f URL: https://github.com/llvm/llvm-project/commit/1b7528554f835d58036543de1e8839ba1ac29f1f DIFF: https://github.com/llvm/llvm-project/commit/1b7528554f835d58036543de1e8839ba1ac29f1f.di

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7528554f83: [AIX][Clang] Fix XL product name in AIX XL compatibility warning (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. I think we're missing few more changes here: - The driver needs to enable ptx75 when it constructs cc1 command line in clang/lib/Driver/ToolChains/Cuda.cpp - We also need to handle PTX75 i

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 385121. achieveartificialintelligence added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/test/Driver/riscv-arch

[PATCH] D113231: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385122. aeubanks added a comment. Herald added subscribers: cfe-commits, wenlei, steven_wu. Herald added a project: clang. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113231/new/ https://reviews

[clang] 5c3d718 - [RISCV] Support Zfhmin extension

Author: Shao-Ce SUN Date: 2021-11-06T01:41:02+08:00 New Revision: 5c3d7184b43575e4cbf1da2fa6ba88485eaca4e3 URL: https://github.com/llvm/llvm-project/commit/5c3d7184b43575e4cbf1da2fa6ba88485eaca4e3 DIFF: https://github.com/llvm/llvm-project/commit/5c3d7184b43575e4cbf1da2fa6ba88485eaca4e3.diff L

[PATCH] D111866: [RISCV] Support Zfhmin extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c3d7184b435: [RISCV] Support Zfhmin extension (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence added a comment. In D111866#3111243 , @asb wrote: > LGTM, modulo one tiny nit on a comment. Thanks! Thank you for your detailed suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

steakhal added a comment. Excellent work. Don't be afraid of the number of nits I dump on you! Good job. Comment at: clang/docs/analyzer/checkers.rst:2338 +Default sources defined by `GenericTaintChecker`: +``fdopen``, ``fopen``, ``freopen``, ``getch``, ``getchar``, ``getcha

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

Hahnfeld added a comment. Experimental support for `__int128` is new in CUDA 11.5, not sure if Clang enables this for CUDA. The release notes also specify > `builtin_assume` can now be used to specify address space to allow for > efficient loads and stores. The docs are very scarce on this, I

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385130. CJ-Johnson added a comment. Remove double brackets for list initialization and use default initialization to avoid most vexing parse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https:/

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

v.g.vassilev added a comment. In D112349#3111927 , @erichkeane wrote: > In D112349#3111873 , @ibookstein > wrote: > >> And how is Cling expecting CFE to deal with partial knowledge situations at >> the implemen

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Feel free to commit your change given that you fix my final nits. Yeah, I'm soo bad in review. I should have proposed these previously. Sorry. Comment at: clang/lib/Stati

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385133. CJ-Johnson added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp cl

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aprantl added a comment. In D106585#3110131 , @glandium wrote: > This broke determinism when building Firefox. I'm curious: can you share an example dwarfdump diff that shows what is non-deterministic? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

tra added a comment. In D113249#3112279 , @Hahnfeld wrote: > Experimental support for `__int128` is new in CUDA 11.5, not sure if Clang > enables this for CUDA. I think we've added support for i128 a while back: https://godbolt.org/z/18bEbhMYb > The r

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

shafik added a comment. How does it handle this case: struct A {int x;}; struct A f(void) { struct A{} a; return a; and this case: struct b{}; struct a {int x;} // visible outside of f f(struct b {int x; } b1) { // not visibile out of f return (stru

[clang] 3466e00 - Reland "[Attr] support btf_type_tag attribute"

Author: Yonghong Song Date: 2021-11-05T11:25:17-07:00 New Revision: 3466e00716e12e32fdb100e3fcfca5c2b3e8d784 URL: https://github.com/llvm/llvm-project/commit/3466e00716e12e32fdb100e3fcfca5c2b3e8d784 DIFF: https://github.com/llvm/llvm-project/commit/3466e00716e12e32fdb100e3fcfca5c2b3e8d784.diff

  1   2   >