[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield added a comment. In D112159#3075703 , @jdoerfert wrote: > This makes sense, any reason we don't remove the check at the call sites > right away? There are ~85 of them, will start looking through now. Repository: rG LLVM Github Monore

[clang] 2caf757 - [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from

Author: Alfonso Gregory Date: 2021-10-20T10:32:46-07:00 New Revision: 2caf7571e1020ae1024ab3f2d52ecc9aea85687d URL: https://github.com/llvm/llvm-project/commit/2caf7571e1020ae1024ab3f2d52ecc9aea85687d DIFF: https://github.com/llvm/llvm-project/commit/2caf7571e1020ae1024ab3f2d52ecc9aea85687d.dif

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

This revision was automatically updated to reflect the committed changes. Closed by commit rG2caf7571e102: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from (authored by gAlfonso-bit, committed by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

rampitec added a comment. In D112041#3074418 , @hliao wrote: > In D112041#3073676 , @rampitec > wrote: > >> In D112041#3073637 , @hliao wrote: >> >>> In D112041#3073560 <

[PATCH] D112157: [clang] Disallow mixing SEH and Objective-C exceptions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112157/new/ https://reviews.llvm.org/D112157 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rnk added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:14576 !Second->getType()->isOverloadableType()) return getSema().CreateBuiltinArraySubscriptExpr( First, Callee->getBeginLoc(), Second, OpLoc); Can we come here to su

[clang] fb88297 - [clang] Disallow mixing SEH and Objective-C exceptions

Author: Nico Weber Date: 2021-10-20T14:18:12-04:00 New Revision: fb8829768d774689c368c49cb3ca17339378cd91 URL: https://github.com/llvm/llvm-project/commit/fb8829768d774689c368c49cb3ca17339378cd91 DIFF: https://github.com/llvm/llvm-project/commit/fb8829768d774689c368c49cb3ca17339378cd91.diff LO

[PATCH] D112157: [clang] Disallow mixing SEH and Objective-C exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb8829768d77: [clang] Disallow mixing SEH and Objective-C exceptions (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield updated this revision to Diff 381037. JonChesterfield added a comment. - fix up call sites Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112159/new/ https://reviews.llvm.org/D112159 Files: clang/lib/AST/ExprConstant.cpp clang/t

[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield updated this revision to Diff 381039. JonChesterfield added a comment. - fix up call sites Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112159/new/ https://reviews.llvm.org/D112159 Files: clang/lib/AST/ExprConstant.cpp clang/l

[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield updated this revision to Diff 381040. JonChesterfield added a comment. - drop spurious nl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112159/new/ https://reviews.llvm.org/D112159 Files: clang/lib/AST/ExprConstant.cpp clang/li

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. @aaron.ballman ping. Did you get time to look at this patch? Esp. any comments on this approach with a subclass AttributedBTF vs. putting a StringRef directly in Attributed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield added a comment. Patched up the call sites that are straightforward. There are ~4 calls in SemaOpenMP where an `!isValueDependent()` could be dropped if it is safe to call PerformContextualImplicitConversion on such a value, which it probably is, but it's hard to be certain. The

[PATCH] D110127: [Clang] Support typedef with btf_decl_tag attributes

yonghong-song added a comment. @aaron.ballman ping. This patch just implemented a btf_decl_tag for typedef. There is no type attribute involved here. Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/ https://reviews.

[PATCH] D112159: Relax assert in ExprConstant to a return None.

JonChesterfield added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:2137 // // Let's see if this is a constant < 0. If so, we reject it out of hand, // per CWG1464. Otherwise, if it's not a constant, we must have an Shame about the wh

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:67 + if (auto *GA = dyn_cast(Op.getGlobal())) +return cast(GA->getOperand(0)); return cast(Op.getGlobal()); arsenm wrote: > I thought aliases could inclu

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:67 + if (auto *GA = dyn_cast(Op.getGlobal())) +return cast(GA->getOperand(0)); return cast(Op.getGlobal()); gandhi21299 wrote: > arsenm wrote: > > I thought a

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:67 + if (auto *GA = dyn_cast(Op.getGlobal())) +return cast(GA->getOperand(0)); return cast(Op.getGlobal()); arsenm wrote: > gandhi21299 wrote: > > arsenm

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added subscribers: aaron.ballman, rsmith. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1302 // in case the function pointer is referenced somewhere. - if (FD->isInlineBuiltinDeclaration() && Fn) { + if (Fn) { s

[PATCH] D112135: [ARM] Fix inline assembly referencing floating point registers on soft-float targets

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112135/new/ https://reviews.llvm.org/D112135 _

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rjmccall added inline comments. Comment at: clang/test/SemaCXX/PR51855.cpp:71 +// CHECK: call void @_ZN1S4putMEs +// CHECK: call {{(signext )?i16}} @_ZN1S4getMEv rnk wrote: > Please add test coverage for the interesting operators in the code under > edit: OO_Sub

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

tra added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:856-860 // If any updates are made, grabs its users to the worklist because // their address spaces can also be possibly updated. LLVM_DEBUG(dbgs() << " to " << NewAS.getValue

[clang] 4e21cae - Update ext-int test to have x86 linux/windows before ABI Impl

Author: Erich Keane Date: 2021-10-20T12:27:22-07:00 New Revision: 4e21caece0dd72450b6ac72d1bcedd697c666efc URL: https://github.com/llvm/llvm-project/commit/4e21caece0dd72450b6ac72d1bcedd697c666efc DIFF: https://github.com/llvm/llvm-project/commit/4e21caece0dd72450b6ac72d1bcedd697c666efc.diff L

[clang] 35037ae - Make dr177x.cpp test work with Windows-32 bit platfroms with 'thiscall'.

Author: Erich Keane Date: 2021-10-20T12:38:36-07:00 New Revision: 35037ae1971a92b07783339ee9d7a5da50a2ab4b URL: https://github.com/llvm/llvm-project/commit/35037ae1971a92b07783339ee9d7a5da50a2ab4b DIFF: https://github.com/llvm/llvm-project/commit/35037ae1971a92b07783339ee9d7a5da50a2ab4b.diff L

[clang] 8dc44d8 - Remove include of 'type_info' from ext-int test.

Author: Erich Keane Date: 2021-10-20T12:53:51-07:00 New Revision: 8dc44d8dd872eadf112c43fa7784110a43ccb683 URL: https://github.com/llvm/llvm-project/commit/8dc44d8dd872eadf112c43fa7784110a43ccb683 DIFF: https://github.com/llvm/llvm-project/commit/8dc44d8dd872eadf112c43fa7784110a43ccb683.diff L

[PATCH] D112177: [clang] Do not duplicate "EnableSplitLTOUnit" module flag

greened created this revision. greened added reviewers: noajshu, phosek, eli.friedman, tejohnson. greened added a project: LLVM. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. greened requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D112177: [clang] Do not duplicate "EnableSplitLTOUnit" module flag

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112177/new/ https://reviews.llvm.org/D112177 _

[PATCH] D112030: [docs] Remove Makefile.sphinx files

tstellar added a comment. In D112030#3071393 , @sylvestre.ledru wrote: > I am using them but I can move to sphinx calls. How much time do you need to transition? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

fmayer added inline comments. Comment at: clang/test/CodeGen/asan-stack-safety-analysis.c:1 +// REQUIRES: x86-registered-target + Should this file be in llvm/test/Instrumentation/ instead? Also consider porting some of the tests from HWASan (https://github.com/

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. I don't need any time, please land it when you want, I will adjust later :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112030/new/ https://reviews.llvm.org/D112030 ___

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

fmayer added inline comments. Comment at: clang/test/CodeGen/asan-stack-safety-analysis.c:1 +// REQUIRES: x86-registered-target + fmayer wrote: > Should this file be in llvm/test/Instrumentation/ instead? Also consider > porting some of the tests from HWASan >

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. Herald added a reviewer: MaskRay. tstellar requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added a subscriber: cfe-commits. This updates all the non-r

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

george.burgess.iv accepted this revision. george.burgess.iv added a comment. LGTM. Thanks again! Comment at: clang/lib/Sema/SemaChecking.cpp:735 + +auto *FormatExpr = TheCall->getArg(FormatIndex)->IgnoreParenImpCasts(); + nit: const auto if possible (and be

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

alexfh added a comment. Reduced test case: template void b(a); template class d { public: class e { public: c *f(); }; e *g(); }; template class j; template class j { public: class k { public: k(int *); ~k(); }; int n(); d l;

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

Meinersbur added a comment. Changes in Polly LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/ https://reviews.llvm.org/D112181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[libunwind] 070a2dd - [libunwind] Revert "Use the from-scratch testing configuration by default"

Author: Louis Dionne Date: 2021-10-20T17:40:23-04:00 New Revision: 070a2ddcb6657f1b497b8003384bae31e27e497d URL: https://github.com/llvm/llvm-project/commit/070a2ddcb6657f1b497b8003384bae31e27e497d DIFF: https://github.com/llvm/llvm-project/commit/070a2ddcb6657f1b497b8003384bae31e27e497d.diff

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian created this revision. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. Add i32x4.relaxed_trunc_f32x4_s,

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian added a subscriber: tlively. ngzhian added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18262-18267 +case WebAssembly::BI__builtin_wasm_relaxed_trunc_zero_s_i32x4_f64x2: + IntNo = Intrinsic::wasm_relaxed_trunc_zero_signed; + break; +case

[PATCH] D110436: Add %n format specifier warning to clang-tidy

Jaysonyan updated this revision to Diff 381103. Jaysonyan retitled this revision from "Add %n format specifier warning" to "Add %n format specifier warning to clang-tidy". Jaysonyan added a comment. Herald added a subscriber: mgorny. Herald added a project: clang-tools-extra. Move check for `%n`

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. Sorry for the delay, I haven't finished testing more projects yet but here are my preliminary numbers | **File**| **Baseline (s)** | **Set Dedupe (s)** | **No external (s)** | **Set Dedupe (percentage of baseline)** | **No external (percentage of baseline)** |

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/initialization.c:103 +void glob_arr_index4() { + clang_analyzer_eval(glob_arr_no_init[2]); // expected-warning{{UNKNOWN}} +} steakhal wrote: > martong wrote: > > ASDenysPetrov wrote: > > > stea

[PATCH] D106681: [analyzer][NFCI] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/initialization.c:103 +void glob_arr_index4() { + clang_analyzer_eval(glob_arr_no_init[2]); // expected-warning{{UNKNOWN}} +} ASDenysPetrov wrote: > steakhal wrote: > > martong wrote: > > > ASDe

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Downstream users may have Clang plugins. By default these plugins run after the main action if they are specified on the command line. Since these plu

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

aeubanks updated this revision to Diff 381112. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112190/new/ https://reviews.llvm.org/D112190 Files: clang/lib/Frontend/FrontendAction.cpp clang/test/Misc/clear-ast-b

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3076586 , @vsapsai wrote: > Methodology: clear a modules cache, compile a file once to pre-populate the > cache, compile file 8 times and measure elapsed time, take the time average. This is the same approach I used, alt

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

alexfh added a comment. Reduced the test further to: struct k { ~k() __attribute__((annotate(""))) {} }; void m() { k(); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 __

[clang] cb9a0dc - [ARM] Fix inline assembly referencing floating point registers on soft-float targets

Author: Pavel Kosov Date: 2021-10-21T02:39:10+03:00 New Revision: cb9a0dc293cf4ca451d625c6a54e491d8c11e591 URL: https://github.com/llvm/llvm-project/commit/cb9a0dc293cf4ca451d625c6a54e491d8c11e591 DIFF: https://github.com/llvm/llvm-project/commit/cb9a0dc293cf4ca451d625c6a54e491d8c11e591.diff L

[PATCH] D112135: [ARM] Fix inline assembly referencing floating point registers on soft-float targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb9a0dc293cf: [ARM] Fix inline assembly referencing floating point registers on soft-float… (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. And for the empty module cache the numbers are | **File**| **Baseline (s)** | **Set Dedupe (s)** | **No external (s)** | **Set Dedupe (percentage of baseline)** | **No external (percentage of baseline)** | | Project1. File1 | 14.080673| 13.6296118

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. In D109632#3076648 , @rmaz wrote: > In D109632#3076586 , @vsapsai wrote: > >> I'm curious to get the results for an empty module cache because clean >> builds are also important for us. >

[PATCH] D110287: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.

vsapsai added a comment. Thanks for the review! I'll commit this and other changes in the stack after testing with the current "main" and making sure the bots on other platforms are happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110287/new/

[PATCH] D110287: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.

vsapsai added a comment. In D110287#3075590 , @dblaikie wrote: > In D110287#3074175 , @vsapsai wrote: > >> What would be a better way to deal with changes in areas where I'm more >> experienced in (Obj-C decl mer

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 34188f2 - [Driver][OpenBSD] Some improvements to the external assembler handling

Author: Brad Smith Date: 2021-10-20T21:05:14-04:00 New Revision: 34188f237f2574dda2447d85fe2b1aa65b5321ce URL: https://github.com/llvm/llvm-project/commit/34188f237f2574dda2447d85fe2b1aa65b5321ce DIFF: https://github.com/llvm/llvm-project/commit/34188f237f2574dda2447d85fe2b1aa65b5321ce.diff LO

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. In D111863#3074404 , @housel wrote: > To be clear, this new code parses exactly as much of each FDE as the existing > `__register_frame`/`__unw_add_dynamic_fde` does, including doing the same > work to compute the record length.

[clang] c593126 - [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.

Author: Volodymyr Sapsai Date: 2021-10-20T18:48:29-07:00 New Revision: c5931267db26d71351c634df06006d9c818ff158 URL: https://github.com/llvm/llvm-project/commit/c5931267db26d71351c634df06006d9c818ff158 DIFF: https://github.com/llvm/llvm-project/commit/c5931267db26d71351c634df06006d9c818ff158.di

[PATCH] D110287: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl contexts too.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5931267db26: [modules] While merging ObjCInterfaceDecl definitions, merge them as decl… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D110452: [modules] Fix tracking ObjCInterfaceType decl when there are multiple definitions.

vsapsai updated this revision to Diff 381130. vsapsai added a comment. Rebase and trigger a new round of pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110452/new/ https://reviews.llvm.org/D110452 Files: clang/include/clang/AST/

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei planned changes to this revision. pengfei added a comment. Found a mistake, working on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112143/new/ https://reviews.llvm.org/D112143 ___ cfe-com

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added a comment. In D112102#3075400 , @craig.topper wrote: > In D112102#3074656 , @frasercrmck > wrote: > >> Minor typo in the description: `differnet` >> >> Does this help with compile times, binary s

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/n

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

rogfer01 added a comment. In D111617#3060377 , @HsiangKai wrote: > Although it reduces the header size, this patch will increase the binary size > of clang. Options we can consider to mitigate this: - See if we can be more economical reprenting the tab

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal updated this revision to Diff 381150. ortogonal added a comment. Just refactor it to latest main. I hope this will re-trigger a new build so I can investigate if there are still tests that fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

balazske updated this revision to Diff 381154. balazske added a comment. Improved test, set of TypeSourceInfo is not needed any more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112013/new/ https://reviews.llvm.org/D112013 Files: clang/lib/AST

<    1   2