[PATCH] D111993: [libomptarget][WIP] Patch amdgpu DeviceRTL until it compiles

JonChesterfield planned changes to this revision. JonChesterfield added a comment. Needs manual rebase on trunk + clang patch to delay checking the arguments to amdgcn intrinsics until template instantiation time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

MyDeveloperDay added a comment. The following fix should resolve this $ git diff git-clang-format diff --git a/clang/tools/clang-format/git-clang-format b/clang/tools/clang-format/git-clang-format index 40e848d55a8c..c7e15eb7b483 100755 --- a/clang/tools/clang-format/git-clang-format +

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

steakhal added a comment. So, you return `None` instead of returning `UndefinedVal`. All in all, it looks good, aside from a couple stuff inline. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1636 + + // Array should be immutable. + const VarDecl *VD = VR->getDecl

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

qiucf created this revision. qiucf added reviewers: nemanjai, PowerPC, jsji, shchenz. Herald added subscribers: dexonsmith, kbarton, hiraditya. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Gi

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 380598. fhahn marked an inline comment as done. fhahn added a comment. Thanks @kito-cheng, the example should use `__builtin_reduce_add` instead of `_fadd`! Fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111

[PATCH] D112056: [clang-format] git-clang-format throws an assertion when removing files as part of the commit

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, krasimir, HazardyKnusperkeks. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. Following a change D111273: [clang-format-diff] Fix missing formatting for zero lengt

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

steakhal added a comment. Good job. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6180 + ASSERT_FALSE(FromCtor->getTypeSourceInfo()); + // Set a TypeSourceInfo for the function, this state may occur in reality. + TypeSourceInfo *FromTSI = FromTU->getASTContext().getTri

[clang] 408e6de - [Driver][Gnu] Support -shared -static: pass -shared to ld and use crtbeginS.o

Author: Fangrui Song Date: 2021-10-19T01:09:41-07:00 New Revision: 408e6de8c09fc7e71329199947e977fe1c40caf1 URL: https://github.com/llvm/llvm-project/commit/408e6de8c09fc7e71329199947e977fe1c40caf1 DIFF: https://github.com/llvm/llvm-project/commit/408e6de8c09fc7e71329199947e977fe1c40caf1.diff

[PATCH] D111529: Specify Clang vector builtins.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:579 + NaNs, fmax() return a NaN. + ET __builtin_reduce_add(VT a) \+

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1969 + auto Content = llvm::StringRef(ParseInput.Contents).take_front(*Offset); + if (Preamble) { +

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 380612. fhahn marked an inline comment as done. fhahn added a comment. Following feedback from D111986 , explicitly spell out abs behavior of most negative integer as undefined. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

dim added a subscriber: emaste. dim added a comment. In D111863#3072023 , @housel wrote: > It's also worth noting that FreeBSD's version of libgcc exception handling is > actually based on the libunwind code, with a local patch >

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn updated this revision to Diff 380618. fhahn added a comment. Pass is_int_min_poison=true to llvm.abs.* to reflect latest update to the specification to make taking abs of the most negative integer undefined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3109 + Result = Builder.CreateBinaryIntrinsic( + llvm::Intrinsic::abs, Op0, Builder.getFalse(), nullptr, "elt.abs"); +else craig.top

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille created this revision. serge-sans-paille added reviewers: nickdesaulniers, manojgupta. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Basically, inline builtin definition are shadowed by externally visib

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille added a comment. https://reviews.llvm.org/D112059 should address the issue pointed by @manojgupta and @nickdesaulniers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009 __

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

zixuan-wu added inline comments. Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp:107 + for (auto Feature : RISCVFeatureKV) { +if (FeatureBits[Feature.Value] && +llvm::RISCVISAInfo::isSupportedExtensionFeature(Feature.Key)) If Subtarg

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 380636. adamcz marked an inline comment as done. adamcz added a comment. final review comment (dropped Preamble check) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1963 +auto OffsetBeforeComment = *Offset - 2; +return codeCompleteComment(FileName, OffsetBeforeComment, Preamble, + ParseInput); kadircet wr

[clang-tools-extra] 8fbac4e - [clangd] Add code completion of param name on /* inside function calls.

Author: Adam Czachorowski Date: 2021-10-19T12:49:46+02:00 New Revision: 8fbac4e88ac3dde30310bb63b234045075cd338b URL: https://github.com/llvm/llvm-project/commit/8fbac4e88ac3dde30310bb63b234045075cd338b DIFF: https://github.com/llvm/llvm-project/commit/8fbac4e88ac3dde30310bb63b234045075cd338b.d

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fbac4e88ac3: [clangd] Add code completion of param name on /* inside function calls. (authored by adamcz). Repository: rG LLVM Github Monorepo C

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 380649. david-arm added a comment. - Added release notes for both clang and llvm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/Clang.

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

sdesmalen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:185-188 +architectural features. For example, we can compile code with +"-mcpu=generic -mtune=cortex-a57" where the architectural features are +defined according to a "generic" CPU, but we use the scheduling

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG0567f0333176: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added inline comments. Comment at: clang/test/Driver/aarch64-mtune.c:5 +// RUN: %clang -target aarch64-unknown-unknown -c -### %s 2>&1 \ +// RUN: | FileCheck %s -check-prefix=notune +// notune-NOT: "-tune-cpu" "generic" sdesmalen wrote: > nit: Did you

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. Thanks. I'm happy as soon as everyone else is happy with the wording. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:229 +/// used to create an empty shell onto which attributes can be added using the +/// \c setX(...) methods. The +/// No idea what clang-format wants done here, but there's a st

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added reviewers: jranieri-grammatech, tra. aaron.ballman added a comment. Adding some more reviewers who may have an interest in SARIF as an exchange format and know more about the use cases that are important to them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 380663. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/aarch64-mtune.c llvm/docs/ReleaseNotes.rst llvm/

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks @david-arm, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 ___ cfe-commits m

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 380665. kbobyrev marked 16 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: clang

[clang] e1e2635 - [HWASan] Use tagged-globals feature on x86.

Author: Matt Morehouse Date: 2021-10-19T05:56:50-07:00 New Revision: e1e2635327d74b6404d30521f9e09928e3919cec URL: https://github.com/llvm/llvm-project/commit/e1e2635327d74b6404d30521f9e09928e3919cec DIFF: https://github.com/llvm/llvm-project/commit/e1e2635327d74b6404d30521f9e09928e3919cec.diff

[PATCH] D111344: [HWASan] Use tagged-globals feature on x86.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1e2635327d7: [HWASan] Use tagged-globals feature on x86. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111344/new/ https://reviews

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:352 + // Allow specifying a few checks with a glob expression, ignoring + // negative globs (which would effectively disable the suppression) + GlobList Gl

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

joerg added a comment. In D111863#3071651 , @lhames wrote: > In D111863#3071353 , @joerg wrote: > >> I would strongly prefer if ORCv2 doesn't depend on this. It essentially >> forces libunwind to parse the whole

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

joerg added a comment. In D111863#3072023 , @housel wrote: > It's also worth noting that FreeBSD's version of libgcc exception handling is > actually based on the libunwind code, with a local patch >

[clang] 607fb1b - [AArch64] Always add -tune-cpu argument to -cc1 driver

Author: David Sherwood Date: 2021-10-19T14:57:51+01:00 New Revision: 607fb1bb8c91a2f284d8c63f3066ab8cc1a66955 URL: https://github.com/llvm/llvm-project/commit/607fb1bb8c91a2f284d8c63f3066ab8cc1a66955 DIFF: https://github.com/llvm/llvm-project/commit/607fb1bb8c91a2f284d8c63f3066ab8cc1a66955.diff

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG607fb1bb8c91: [AArch64] Always add -tune-cpu argument to -cc1 driver (authored by david-arm). Changed prior to commit: https://reviews.llvm.org/D1

[clang] 5eaf5b9 - [PowerPC] Restrict various P10 options to P10 only.

Author: Amy Kwan Date: 2021-10-19T09:01:01-05:00 New Revision: 5eaf5b916146dff0a02d8d937e88d8fb128640d2 URL: https://github.com/llvm/llvm-project/commit/5eaf5b916146dff0a02d8d937e88d8fb128640d2 DIFF: https://github.com/llvm/llvm-project/commit/5eaf5b916146dff0a02d8d937e88d8fb128640d2.diff LOG:

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaf5b916146: [PowerPC] Restrict various P10 options to P10 only. (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D109652?vs

[clang] 23db763 - Fix documentation errors introduced by 607fb1bb8c91a2f284d8c63f3066ab8cc1a66955

Author: David Sherwood Date: 2021-10-19T15:12:03+01:00 New Revision: 23db763b7dadbf99cb46c66c855651ac760e56db URL: https://github.com/llvm/llvm-project/commit/23db763b7dadbf99cb46c66c855651ac760e56db DIFF: https://github.com/llvm/llvm-project/commit/23db763b7dadbf99cb46c66c855651ac760e56db.diff

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

alexfh added a comment. It looks like this patch causes clang to crash on valid code with the following stack trace: #0 0x560442f12f45 SignalHandler(int) #1 0x7ffac7c789a0 __restore_rt #2 0x560440083992 llvm::LazyCallGraph::Node::populateSlow() #3 0x560440082a60 llvm:

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 380693. carlosgalvezp marked 3 inline comments as done. carlosgalvezp added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/D111208 Files: clang-tools-extra/clang-tidy/ClangT

[PATCH] D111986: [Clang] Add elementwise abs builtin.

scanon added a comment. What's the rationale for making abs undefined on the minimum value? AFAIK every actual simd implementation defines the result and they agree (and even if one didn't, it would be pretty easy to get the "right" result. Introducing UB here just seems like punishing users fo

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but if someone can verify we aren't introducing dueling diagnostics with cpplint before we land this, that would be appreciated. CHANGES SINCE LAST ACTION https://review

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 380702. kbobyrev added a comment. Rebase on top of main, revert unwanted formatting change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: clang-tools-extr

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6180 + ASSERT_FALSE(FromCtor->getTypeSourceInfo()); + // Set a TypeSourceInfo for the function, this state may occur in reality. + TypeSourceInfo *FromTSI = FromTU->getASTContext().getTrivialType

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

hans created this revision. hans added reviewers: aaron.ballman, rnk. hans requested review of this revision. Herald added a project: clang. MSVC's libc doesn't provide thread.h, so we should set the macro to indicate that. We could just set it in C mode, but I noticed that Darwin sets it uncon

[clang] cf68e1b - [Driver, Frontend] Use StringRef::contains (NFC)

Author: Kazu Hirata Date: 2021-10-19T08:54:02-07:00 New Revision: cf68e1b2fb4f6172b08f3430b2530dc2d193ab60 URL: https://github.com/llvm/llvm-project/commit/cf68e1b2fb4f6172b08f3430b2530dc2d193ab60 DIFF: https://github.com/llvm/llvm-project/commit/cf68e1b2fb4f6172b08f3430b2530dc2d193ab60.diff L

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

aaron.ballman added a comment. Thanks for this! Should we similarly handle `__STDC_NO_ATOMICS__`, `__STDC_NO_COMPLEX__`, et al at the same time? Also, how should we handle `__STDC_VERSION__`? We set that in all C modes, but MSVC only sets it when passed /std:c11, etc explicitly. Repository:

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112081/new/ https://reviews.llvm.org/D112081 ___ cfe-c

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

aaron.ballman added reviewers: rsmith, jyknight, rjmccall. aaron.ballman added a comment. Also, one concern I have for this is what to do if/when the Microsoft CRT gets any of these features. Clang will be unconditionally setting `__STDC_NO_WHATEVER__`, which we can correct for newer versions of

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6180 + ASSERT_FALSE(FromCtor->getTypeSourceInfo()); + // Set a TypeSourceInfo for the function, this state may occur in reality. + TypeSourceInfo *FromTSI = FromTU->getASTContext().getTrivialTy

[libunwind] 6fd55bb - [libunwind] Add a from-scratch config for running libunwind tests

Author: Louis Dionne Date: 2021-10-19T12:03:58-04:00 New Revision: 6fd55bba61bb4df98f9485b8d3cfc9e956d992b8 URL: https://github.com/llvm/llvm-project/commit/6fd55bba61bb4df98f9485b8d3cfc9e956d992b8 DIFF: https://github.com/llvm/llvm-project/commit/6fd55bba61bb4df98f9485b8d3cfc9e956d992b8.diff

[PATCH] D111534: [analyzer][NFC] Refactor CallEvent::isCalled()

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1289 + /// E.g. { "std", "vector", "data" } -> "vector", "std" + auto begin_qualified_name_parts() const { +return std::next(QualifiedName.rbegin());

[PATCH] D112056: [clang-format] git-clang-format throws an assertion when removing files as part of the commit

lhames added a comment. I think that this should fix the issue I saw, but `clang-format` will still crash when passed a `-lines=0:X` option. Would it make sense to either error out in that tool, or teach the tool to ignore `-lines=0:0` options if they're guaranteed to be no-ops for formatting?

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added a comment. Actually, `cpplint` is never compatible with `clang-tidy` regardless. The following code: struct Foo { Foo(int) {} // NOLINT(google-explicit-constructor) }; Triggers: ../test.cpp:3: Unknown NOLINT error category: google-explicit-constructor [re

[clang-tools-extra] bf6b0d1 - [clang-tidy] Support globbing in NOLINT* expressions

Author: Carlos Galvez Date: 2021-10-19T16:30:51Z New Revision: bf6b0d16747f6d1107de1a51d42ae3b0bf904537 URL: https://github.com/llvm/llvm-project/commit/bf6b0d16747f6d1107de1a51d42ae3b0bf904537 DIFF: https://github.com/llvm/llvm-project/commit/bf6b0d16747f6d1107de1a51d42ae3b0bf904537.diff LOG:

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6b0d16747f: [clang-tidy] Support globbing in NOLINT* expressions (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ ht

[clang-tools-extra] 7812cb7 - Use reference type in for loop

Author: Carlos Galvez Date: 2021-10-19T16:37:56Z New Revision: 7812cb72a321c392a3b91b45b4780a0987818a36 URL: https://github.com/llvm/llvm-project/commit/7812cb72a321c392a3b91b45b4780a0987818a36 DIFF: https://github.com/llvm/llvm-project/commit/7812cb72a321c392a3b91b45b4780a0987818a36.diff LOG:

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added a comment. A bit annoying about the build bot, fixed in a separate commit. Do you know if we can run these jobs pre-pushing? Seems rather unlikely to have them all pass the first time, especially for larger commits... Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

aaron.ballman added a comment. In D111208#3073144 , @carlosgalvezp wrote: > Actually, `cpplint` is never compatible with `clang-tidy` regardless. The > following code: > > struct Foo > { > Foo(int) {} // NOLINT(google-explicit-constructor) >

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. In D111863#3072829 , @joerg wrote: > Are you mixing up of `__register_frame` and `__register_frame_info`? No? FreeBSD doesn't patch `__register_frame_info`, and so (like base libunwind) it does nothing in the code I linked. Rep

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added a comment. > Unfortunately, precommit CI is pretty limited and extremely flakey, so the > only real way to know right now is to push and see how the bot farm likes it. > (There are a lot of bots we don't want to use for precommit CI because they > take a long time to run, us

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6180 + ASSERT_FALSE(FromCtor->getTypeSourceInfo()); + // Set a TypeSourceInfo for the function, this state may occur in reality. + TypeSourceInfo *FromTSI = FromTU->getASTContext().getTrivialType

[PATCH] D112059: Fix inline builtin handling in case of redefinition

manojgupta added a comment. thanks, I can verify that it fixes the crash we were seeing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 ___ cfe-commits mailing

[PATCH] D74130: [clang] fix consteval call in default arguments

aaron.ballman added a comment. @Tyker -- are you planning to pick this review back up again sometime in the near future? If not, do you care if the review gets commandeered? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74130/new/ https://reviews.

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

hans added a comment. In D112081#3073067 , @aaron.ballman wrote: > Thanks for this! Should we similarly handle `__STDC_NO_ATOMICS__`, > `__STDC_NO_COMPLEX__`, et al at the same time? I'll look into those, thanks. > Also, how should we handle `__STDC_V

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

tra resigned from this revision. tra added a comment. I'm not sure how/why I ended up as a reviewer here as I don't have much to do with diags, other than adding one now and then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://r

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

rjmccall added a comment. The standard answer is that compilers are designed to work with a specific set of system headers. In the Clang-on-Windows case, that's complicated by the fact that many people acquire Clang separately from the rest of the build environment (although Microsoft does dis

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. 🙄 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:800-801 + // (!is_share(p) && !is_private(p)). + // FIXME: Even though there is no distinguish between CONSTANT and GLOBAL in + // the backend, it may still benefit by telling them from ea

[PATCH] D112053: [cuda] Add address space predicate funuctions.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:691-694 +BUILTIN(__nvvm_isspacep_const, "bvC*", "nc") +BUILTIN(__nvvm_isspacep_global, "bvC*", "nc") +BUILT

[PATCH] D112088: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

saudi created this revision. saudi added reviewers: dexonsmith, jansvoboda11, Bigcheese. saudi added a project: clang. Herald added a subscriber: jeroen.dobbelaere. saudi requested review of this revision. Herald added a subscriber: cfe-commits. The `#pragma` directives `push_macro`/`pop_macro` an

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. In D111863#3072827 , @joerg wrote: > `__register_frame` requires parsing the CIE header, but not the whole FDE > program. E.g. that's the `findPCRange` logic. After that, the FDE is just > added to the internal block list. Parsin

[clang] dc8a5f9 - [RISCV] Use llvm::stable_sort instead of std::stable_sort. NFC

Author: Craig Topper Date: 2021-10-19T11:37:40-07:00 New Revision: dc8a5f9419f5cc35fc3c9e8698ba3ebb6a3f974f URL: https://github.com/llvm/llvm-project/commit/dc8a5f9419f5cc35fc3c9e8698ba3ebb6a3f974f DIFF: https://github.com/llvm/llvm-project/commit/dc8a5f9419f5cc35fc3c9e8698ba3ebb6a3f974f.diff

[PATCH] D76169: [WIP][AST] Allow ExprConstant to evaluate structs in C.

tomhughes added a comment. I took the tests from https://reviews.llvm.org/D76096 and combined it with this change. As mentioned in the last comment 606a734755d1fb6c35a17680d0c251f834b79334 causes conflicts, so I tried apply

[PATCH] D112089: consteval if does not form a discarded statement

aaron.ballman created this revision. aaron.ballman added reviewers: cor3ntin, erichkeane, rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. When we added support for `if consteval`, we accidentally formed a discarded statement evaluation context for the branc

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh updated this revision to Diff 380718. shraiysh added a comment. Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Rebase with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ https://reviews.llvm.or

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

tra added inline comments. Comment at: llvm/include/llvm/Analysis/AssumptionCache.h:109 /// its instructions. - AssumptionCache(Function &F) : F(F) {} + AssumptionCache(Function &F, TargetTransformInfo *TTI) : F(F), TTI(TTI) {} Perhaps this should have a d

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.c:24 +// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename: "{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}", +// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "") +// CHECK-NO-MAIN-FILE-NAME: !DIFile(f

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

nikic added a comment. Is it actually necessary to thread this through AssumptionCache, given how InferAddressSpaces is the only place that looks at these assumes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

mstorsjo added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.c:24 +// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename: "{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}", +// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "") +// CHECK-NO-MAIN-FILE-NAME: !DIFil

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 380755. fhahn added a comment. As @scanon pointed out in D111986 , most simd implementations should handle abs(INT_MIN) consistently by returngin INT_MIN. It's therefore better to avoid defining abs(INT_MIN) as UB, which would

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn updated this revision to Diff 380756. fhahn added a comment. In D111986#3072946 , @scanon wrote: > What's the rationale for making abs undefined on the minimum value? AFAIK > every actual simd implementation defines the result and they agree (and e

[clang] 57553ce - Revert "Reland [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()"

Author: Zequan Wu Date: 2021-10-19T12:39:34-07:00 New Revision: 57553ce43281a7c379e375161320cc09d8236839 URL: https://github.com/llvm/llvm-project/commit/57553ce43281a7c379e375161320cc09d8236839 DIFF: https://github.com/llvm/llvm-project/commit/57553ce43281a7c379e375161320cc09d8236839.diff LOG

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson added a comment. The test is failing for a different reason (that I'd forgotten I worked around locally). I'll look into fixing that first. Sorry for noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112049/new/ https://reviews.llv

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

manojgupta created this revision. manojgupta added a reviewer: metzman. Herald added subscribers: kristof.beyls, mgorny. manojgupta requested review of this revision. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. We need libfuzzer libraries on Arm32 so that we can fuzz

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

rampitec added a comment. Is there anything to remove assume() call after address space is inferred? We do not need it anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 ___

[PATCH] D112056: [clang-format] git-clang-format throws an assertion when removing files as part of the commit

MyDeveloperDay added a comment. In D112056#3073142 , @lhames wrote: > I think that this should fix the issue I saw, but `clang-format` will still > crash when passed a `-lines=0:X` option. Would it make sense to either error > out in that tool, or teach

[PATCH] D111986: [Clang] Add elementwise abs builtin.

scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. Two minor questions, but also LGTM as is. Comment at: clang/lib/Sema/SemaChecking.cpp:16667 + + if (!TyA->getAs() && !ConstantMatrixType::isValidElementType(TyA)) +retu

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, if you expand the comment (see inline). Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58 + // Ensure the reported context hash is

[clang] 6fe902d - [cuda] Add address space predicate funuctions.

Author: Michael Liao Date: 2021-10-19T16:20:14-04:00 New Revision: 6fe902daf931dedf6e958b43c043cb57bb612daf URL: https://github.com/llvm/llvm-project/commit/6fe902daf931dedf6e958b43c043cb57bb612daf DIFF: https://github.com/llvm/llvm-project/commit/6fe902daf931dedf6e958b43c043cb57bb612daf.diff

[PATCH] D112053: [cuda] Add address space predicate funuctions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fe902daf931: [cuda] Add address space predicate funuctions. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112053/new/ https://reviews.

[PATCH] D112053: [cuda] Add address space predicate funuctions.

hliao added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:691-694 +BUILTIN(__nvvm_isspacep_const, "bvC*", "nc") +BUILTIN(__nvvm_isspacep_global, "bvC*", "nc") +BUILTIN(__nvvm_isspacep_local, "bvC*", "nc") +BUILTIN(__nvvm_isspacep_shared, "bvC*", "nc") -

[PATCH] D112053: [cuda] Add address space predicate funuctions.

hliao added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:691-694 +BUILTIN(__nvvm_isspacep_const, "bvC*", "nc") +BUILTIN(__nvvm_isspacep_global, "bvC*", "nc") +BUILTIN(__nvvm_isspacep_local, "bvC*", "nc") +BUILTIN(__nvvm_isspacep_shared, "bvC*", "nc") -

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Otherwise it looks good. Comment at: clang/include/clang/Format/Format.h:245 + /// \version 14 + bool AlignConsecutiveMacrosIgnoreMax; + ---

[clang] 91e19f6 - [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

Author: Volodymyr Sapsai Date: 2021-10-19T13:30:26-07:00 New Revision: 91e19f66e51ac3fda2309f5e67b02fcccd4d58a0 URL: https://github.com/llvm/llvm-project/commit/91e19f66e51ac3fda2309f5e67b02fcccd4d58a0 DIFF: https://github.com/llvm/llvm-project/commit/91e19f66e51ac3fda2309f5e67b02fcccd4d58a0.di

[PATCH] D111205: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91e19f66e51a: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D111205: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111205/new/ https://reviews.llvm.org/D111205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

  1   2   >