[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks updated this revision to Diff 377333. aeubanks added a comment. update test I checked to make sure that we're not accepting -clear-ast-before-backend as a driver flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://revie

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377335. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update some clang uses to fix errors/warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/

[clang] 1ddcb80 - Update the release notes for consteval if support; NFC

Author: Aaron Ballman Date: 2021-10-05T16:39:23-04:00 New Revision: 1ddcb804f7e4883bda1877d0e5f9cfda70edc803 URL: https://github.com/llvm/llvm-project/commit/1ddcb804f7e4883bda1877d0e5f9cfda70edc803 DIFF: https://github.com/llvm/llvm-project/commit/1ddcb804f7e4883bda1877d0e5f9cfda70edc803.diff

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks accepted this revision. aeubanks added a comment. lg, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110891/new/ https://reviews.llvm.org/D110891 ___ cfe-commits mailing list cfe-commits@

[clang] 9397127 - Fix some Sphinx warnings in the static analyzer docs

Author: Aaron Ballman Date: 2021-10-05T16:43:55-04:00 New Revision: 939712734a563dd4d12b88f875d9c8e2b0fa6219 URL: https://github.com/llvm/llvm-project/commit/939712734a563dd4d12b88f875d9c8e2b0fa6219 DIFF: https://github.com/llvm/llvm-project/commit/939712734a563dd4d12b88f875d9c8e2b0fa6219.diff

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. The change looks ok to me, but I think it'd be good to have a testcase for finding these paths (IIRC there are a bunch of simulated sysroots under clang/test/Driver). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377344. jyu2 added a comment. Address Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/Open

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8451-8454 + ArrayRef MapModifiers; + ArrayRef MotionModifiers; + return getMapTypeBits( + I->getSecond(), MapModifiers, MotionModifiers, false, ABataev wrote:

[clang] 7d541eb - [inliner] Mandatory inlining decisions produce remarks

Author: Mircea Trofin Date: 2021-10-05T14:01:25-07:00 New Revision: 7d541eb4d49b6a51a3568b9214fd8691e2d3 URL: https://github.com/llvm/llvm-project/commit/7d541eb4d49b6a51a3568b9214fd8691e2d3 DIFF: https://github.com/llvm/llvm-project/commit/7d541eb4d49b6a51a3568b9214fd8691e2d3.diff

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

This revision was automatically updated to reflect the committed changes. mtrofin marked an inline comment as done. Closed by commit rG7d541eb4d49a: [inliner] Mandatory inlining decisions produce remarks (authored by mtrofin). Changed prior to commit: https://reviews.llvm.org/D110891?vs=377091&

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we're limited to 32 bit ints in diagnostics. With support for 4GB alignments coming soon, we need to report 4GB as the max alignment allowed

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

saudi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + Hello, I encountered crashes on Windows targets, related to this line, when rebasing https://reviews

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377357. jyu2 added a comment. Thanks Alexey! Fix missing Modifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clan

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added a comment. Tests with modifiers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D111187: [Clang] Add information about partially implemented features

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Desccribe in cxx_status.html the missing parts of the partially implemented proposals described in cxx_status.html. Uses blocks so the information ap

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

aaronpuchert created this revision. aaronpuchert added reviewers: gribozavr2, Mordante. Herald added a subscriber: arphaman. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These should be all the commands from [1] except those

[PATCH] D110436: Add %n format specifier warning

Jaysonyan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning< aaron.bal

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

aaronpuchert added a comment. In D110216#3041117 , @mizvekov wrote: > In D110216#3040748 , @craig.topper > wrote: > >> Looks like this fixes PR51282. > > I guess it does fix it, but the underlying implementation

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

NoQ added a comment. Hey, I brought you some regressions! const int arr[]; const int arr[3] = {1, 2, 3}; void foo() { if (arr[0] < 3) { } } test.c:6:14: warning: The left operand of '<' is a garbage value [core.UndefinedBinaryOperatorResult] if (arr[0] < 3) {

[PATCH] D110436: Add %n format specifier warning

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning< Jaysony

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 created this revision. jeremyd2019 added reviewers: mstorsjo, rsmith. jeremyd2019 added a project: clang. jeremyd2019 requested review of this revision. Herald added a subscriber: cfe-commits. Previously it only used Windows command lines for MSVC triples, but this was causing issues

[libunwind] 54a8a0d - [runtimes] Allow FOO_TEST_CONFIG to be a relative path

Author: Louis Dionne Date: 2021-10-05T19:45:50-04:00 New Revision: 54a8a0d09a572a0581c0755541847e016274e15c URL: https://github.com/llvm/llvm-project/commit/54a8a0d09a572a0581c0755541847e016274e15c DIFF: https://github.com/llvm/llvm-project/commit/54a8a0d09a572a0581c0755541847e016274e15c.diff

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Note that I found this due to a report of a crash in clangd , but I don't actually use that so just looked through the code for what was messing with paths. Users on that bug report confirmed that this fixed thei

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei commandeered this revision. haowei added a reviewer: leonardchan. haowei added a comment. Herald added a subscriber: abrachet. I am commandeering this work as original author stopped working this project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377389. haowei edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basi

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Also, I don't have push access so someone would need to push this for me assuming it is approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. Herald added subscribers: dexonsmith, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Commit [1] introduced btf_t

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. @aaron.ballman We discussed internally and I think your concern of mixing type attribute and decl attribute is valid. In the long run, having two separate attributes, one for type (btf_type_tag) and another for decl (btf_decl_tag) seems clean and better. I have cr

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

HsiangKai added a comment. Herald added a subscriber: achieveartificialintelligence. I think we could restart to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://reviews.llvm.org/D105690

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D05#3043734 , @aeubanks wrote: > update test > I checked to make sure that we're not accepting -clear-ast-before-backend as > a driver flag

[PATCH] D111205: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

vsapsai created this revision. vsapsai added a reviewer: benlangmuir. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Representation of the file's last modification time depends on the file system and isn't guaranteed to be in seconds.

[PATCH] D109967: Simplify handling of builtin with inline redefinition

rnk added a comment. Thanks for doing this, this approach looks like it incorporated my feedback on the previous approach. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3177 + // PR9614. Avoid cases where the source code is lying to us. An available // externally funct

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377421. jyu2 added a comment. Adding check for map type in test. Thanks Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRunti

[clang] edfff2f - [clang] Allow printing 64 bit ints in diagnostics

Author: Arthur Eubanks Date: 2021-10-05T22:07:16-07:00 New Revision: edfff2f8b0435bc4af94bd3b41bf57244d84d993 URL: https://github.com/llvm/llvm-project/commit/edfff2f8b0435bc4af94bd3b41bf57244d84d993 DIFF: https://github.com/llvm/llvm-project/commit/edfff2f8b0435bc4af94bd3b41bf57244d84d993.diff

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedfff2f8b043: [clang] Allow printing 64 bit ints in diagnostics (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D111178: Fix clang postMerge logic based on System V ABI Standard

pengfei added a comment. Testcase? Can this patch fix the problem in D107965 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78/new/ https://reviews.llvm.org/D78 __

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

tstellar added a comment. This patch should depend on D109837 , otherwise clang builds will be broken on SUSE if you don't pass -DLLVM_DEFAULT_TARGET_TRIPLE to cmake when configuring, and I don't think we should require users to pass this option. Repository:

[clang] cb89d37 - Revert "[clang] Allow printing 64 bit ints in diagnostics"

Author: Arthur Eubanks Date: 2021-10-05T22:24:16-07:00 New Revision: cb89d3739db746ea50eb50b7208e689126394391 URL: https://github.com/llvm/llvm-project/commit/cb89d3739db746ea50eb50b7208e689126394391 DIFF: https://github.com/llvm/llvm-project/commit/cb89d3739db746ea50eb50b7208e689126394391.diff

[PATCH] D111207: Driver: Add a gcc equivalent triple to the list of triples to search

tstellar created this revision. tstellar added reviewers: aaronpuchert, hvdijk, MaskRay. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. There are some gcc triples, like x86_64-redhat-linux, that provide the same behavior as a clang tr

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. In D109967#3044464 , @rnk wrote: > Thanks for doing this, this approach looks like it incorporated my feedback > on the previous approach. Yeah, listened to the wise men... and struggled a lot doing so ;-) =

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

mstorsjo added a subscriber: rnk. mstorsjo added a comment. This looks ok to me I guess. Technically in this case, this is pretty much equivalent to `#ifdef _WIN32`, i.e. any form when running on windows, where the process considers itself windows (cygwin doesn't define `_WIN32`), but I guess k

<    1   2