yonghong-song added a comment. @aaron.ballman We discussed internally and I think your concern of mixing type attribute and decl attribute is valid. In the long run, having two separate attributes, one for type (btf_type_tag) and another for decl (btf_decl_tag) seems clean and better. I have crafted one POC patch https://reviews.llvm.org/D111199, could you take a look at the approach? Also, the D111199 <https://reviews.llvm.org/D111199> has hack about storing btf_type_tag string in the AST, I would really appreciate if you can give some advice how to deal with it. Thanks!
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/ https://reviews.llvm.org/D110127 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
