[clang] db4ff98 - DebugInfo: Add support for template parameters with qualifiers

Author: David Blaikie Date: 2021-09-14T00:04:40-07:00 New Revision: db4ff98bf9733605c713e75ab6677523e6d267cb URL: https://github.com/llvm/llvm-project/commit/db4ff98bf9733605c713e75ab6677523e6d267cb DIFF: https://github.com/llvm/llvm-project/commit/db4ff98bf9733605c713e75ab6677523e6d267cb.diff

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry, I thought I've already LGTM'd it in previous iteration. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://rev

[PATCH] D108045: [clangd] Fix clangd crash when including a header

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks a lot, LGTM! Do you want me to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 _

[clang] e4b9f5e - DebugInfo: Add support for template parameters with reference qualifiers

Author: David Blaikie Date: 2021-09-14T00:39:47-07:00 New Revision: e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e URL: https://github.com/llvm/llvm-project/commit/e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e DIFF: https://github.com/llvm/llvm-project/commit/e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e.diff

[clang] 13e34f9 - Fixup some formatting from a recent commit

Author: David Blaikie Date: 2021-09-14T00:41:19-07:00 New Revision: 13e34f9fc13fbe08af69b206eacac2e0008dd126 URL: https://github.com/llvm/llvm-project/commit/13e34f9fc13fbe08af69b206eacac2e0008dd126 DIFF: https://github.com/llvm/llvm-project/commit/13e34f9fc13fbe08af69b206eacac2e0008dd126.diff

[clang] 9aeecdf - Check supported architectures in sseXYZ/avxXYZ headers

Author: serge-sans-paille Date: 2021-09-14T09:57:54+02:00 New Revision: 9aeecdfa8e9104392b435444a5f978d2eb71e51a URL: https://github.com/llvm/llvm-project/commit/9aeecdfa8e9104392b435444a5f978d2eb71e51a DIFF: https://github.com/llvm/llvm-project/commit/9aeecdfa8e9104392b435444a5f978d2eb71e51a.d

[PATCH] D109686: Check supported architectures in sseXYZ/avxXYZ headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9aeecdfa8e91: Check supported architectures in sseXYZ/avxXYZ headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal added a comment. Even with declare variant separated using ifdef's, the error is still there. So I don't think we have workaround for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 _

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 372430. MyDeveloperDay added a comment. Allow more QualifierFixer functions to be directly tested, remove some older commented code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/doc

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2101 +**CVQualifierAlignment** (``CVQualifierAlignmentStyle``) + Different ways to arrange const/volatile qualifiers. curd

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov updated this revision to Diff 372434. mizvekov edited the summary of this revision. mizvekov added a comment. include repro for analyzer crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654 Fil

[clang] ad88632 - [OpenCL] Tests C++ for OpenCL version macros

Author: Justas Janickas Date: 2021-09-14T09:49:20+01:00 New Revision: ad88632b650325af755ae42ff29114c1f6eb2841 URL: https://github.com/llvm/llvm-project/commit/ad88632b650325af755ae42ff29114c1f6eb2841 DIFF: https://github.com/llvm/llvm-project/commit/ad88632b650325af755ae42ff29114c1f6eb2841.dif

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGad88632b6503: [OpenCL] Tests C++ for OpenCL version macros (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109366/new/ https://reviews

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea added a comment. @ostannard, can you explain what you meant with supporting LTO? I didn't quite undestand. Are you happy with the rest of the changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109157/new/ https://reviews.llvm.org/D109157 __

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d6829bbbe68: [clang] disable implicit moves when not in CPlusPLus (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https:/

[clang] 2d6829b - [clang] disable implicit moves when not in CPlusPLus

Author: Matheus Izvekov Date: 2021-09-14T11:29:47+02:00 New Revision: 2d6829bbbe6877920d9be1db93b9f3fc85b43d10 URL: https://github.com/llvm/llvm-project/commit/2d6829bbbe6877920d9be1db93b9f3fc85b43d10 DIFF: https://github.com/llvm/llvm-project/commit/2d6829bbbe6877920d9be1db93b9f3fc85b43d10.dif

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:656-671 +// Helper for chaining together multiple imports. If an error is detected, +// subsequent imports will return default constructed nodes, so that failure +// can be detected with a sing

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf created this revision. qiucf added reviewers: PowerPC, hubert.reinterpretcast, nemanjai, jsji. Herald added a subscriber: shchenz. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://re

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes characterizing top-level unwrapped l

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. Hi @Szelethus A couple of tests fail for me on trunk with this patch: Failed Tests (3): Clang-Unit :: StaticAnalyzer/./StaticAnalysisTests/FalsePositiveRefutationBRVisitorTestBase.UnSatAtErrorNodeDueToRefinedConstraintNoReport Clang-Unit :: StaticAnalyzer/./S

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. @tejohnson would you be able to take another look at this again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 ___ cfe-commits mail

RE: [clang] bdce8d4 - Revert "[X86] Adjust Keylocker handle mem size"

Sorry, I’ll keep in mind. This revert is just for “wrong patch ID in commit comment” it should be D109488 not D109354. Sorry for my mistake! Thank you so much! From: Craig Topper Sent: Tuesday, September 14, 2021 5:52 AM To: Zhang, Xiang1 ; Xiang1 Zhang Cc: cfe-commits Subject: Re: [clang] bdc

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added a comment. I'll attend to this ASAP. Thanks for the heads up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108695/new/ https://reviews.llvm.org/D108695 ___ cfe-commits mailing list cfe-c

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

steakhal added a comment. In D108695#2999378 , @uabelho wrote: > Hi @Szelethus > A couple of tests fail for me on trunk with this patch Uh, that's my unittest :D I suspect you are running some sort of CI where you set up Z3. I suspect we should slightl

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2998372 , @ye-luo wrote: > the modf test still doesn't work. The issue was from unbundle. > case 1 works. > > clang++ -fopenmp -fopenmp-targets=nvptx64 modf.cpp -c > clang++ -fopenmp -fopenmp-targets=nvptx64 modf.o

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. In D108695#2999432 , @steakhal wrote: > In D108695#2999378 , @uabelho wrote: > >> Hi @Szelethus >> A couple of tests fail for me on trunk with this patch > > Uh, that's my unittest :D > I

[clang] 09dc454 - [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-14T13:05:42+01:00 New Revision: 09dc454b00b8ed0a19f766f760fa19e86a0b9059 URL: https://github.com/llvm/llvm-project/commit/09dc454b00b8ed0a19f766f760fa19e86a0b9059 DIFF: https://github.com/llvm/llvm-project/commit/09dc454b00b8ed0a19f766f760fa19e86a0b9059.dif

[PATCH] D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

This revision was automatically updated to reflect the committed changes. Closed by commit rG09dc454b00b8: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109370/new

[PATCH] D109721: [IR] Reduce max supported integer from 2^24-1 to 2^23.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109721/new/ https://reviews.llvm.org/D109721 ___ cfe-commits mailing list cfe-comm

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. LGTM modulo the testing request (I forgot to mention that when marking it yesterday, oops!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 ___

[PATCH] D105701: [clang-format] test revision (NOT FOR COMMIT) to demonstrate east/west const fixer capability

MyDeveloperDay updated this revision to Diff 372460. MyDeveloperDay added a comment. Herald added subscribers: dexonsmith, jdoerfert, sstefan1, mgrang, martong, aheejin, dschuff. Herald added a reviewer: shafik. Herald added a reviewer: jdoerfert. Further Demonstration of D69764: [clang-format] A

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:6 + +// NOLINTEND +class B1 { B1(int i); }; salman-javed-nz wrote: > aaron.ballman wrote: > > Do you think this should be diagnosed as a sign of

[clang] 601102d - Cleanup identifier parsing; NFC

Author: Corentin Jabot Date: 2021-09-14T09:12:22-04:00 New Revision: 601102d282d5e9a1429fea52ee17303aec8a7c10 URL: https://github.com/llvm/llvm-project/commit/601102d282d5e9a1429fea52ee17303aec8a7c10 DIFF: https://github.com/llvm/llvm-project/commit/601102d282d5e9a1429fea52ee17303aec8a7c10.diff

[PATCH] D108308: Cleanup identifier parsing.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the cleanup! I've landed in 601102d282d5e9a1429fea52ee17303aec8a7c10 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

arichardson added a comment. Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We use addrspace(200) for *all* globals (including vtables). It would have been nice if I had been added to this review considering that I added line you are changing here. If vtables are no

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 372473. vhscampos marked 3 inline comments as done. vhscampos added a comment. 1. Enable the SVE2 extension as default. 2. Remove out of date comments in tests. 3. Remove unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. yeluo@epyc-server:~/opt/openmp-target/tests/math$ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_80 modf.cpp -c yeluo@epyc-server:~/opt/openmp-target/tests/math$ clang-offload-bundler -type=o --inputs=modf.o --list openmp-nvptx64 host-

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:413 - auto V8_6Pos = llvm::find(Features, "+v8.6a"); - if (V8_6Pos != std::end(Features)) -V8_6Pos = Features.insert(std::next(V8_6Pos), {"+i8mm", "+bf16"}); + const char *Archs[] =

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Eugene.Zelenko added a comment. What about adding `modernize`/`bugprone` aliases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 ___ cfe-commits mailing list c

[clang-tools-extra] 8401713 - [clangd] Ignore ObjC `id` and `instancetype` in FindTarget

Author: David Goldman Date: 2021-09-14T09:53:42-04:00 New Revision: 8401713b3ef1456a603874d96a99b2d5953df49c URL: https://github.com/llvm/llvm-project/commit/8401713b3ef1456a603874d96a99b2d5953df49c DIFF: https://github.com/llvm/llvm-project/commit/8401713b3ef1456a603874d96a99b2d5953df49c.diff

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8401713b3ef1: [clangd] Ignore ObjC `id` and `instancetype` in FindTarget (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ h

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999645 , @Eugene.Zelenko wrote: > What about adding `modernize`/`bugprone` aliases? I'd be fine if we wanted to add aliases, but I'd sort of expect some extra functionality out of a check in those modules. I t

[clang] fb4d590 - Fix a unittest file after D108695 when Z3 is enabled

Author: Kristóf Umann Date: 2021-09-14T16:11:11+02:00 New Revision: fb4d590a622f4031900516360c07ee6ace01c5e6 URL: https://github.com/llvm/llvm-project/commit/fb4d590a622f4031900516360c07ee6ace01c5e6 DIFF: https://github.com/llvm/llvm-project/commit/fb4d590a622f4031900516360c07ee6ace01c5e6.diff

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added a comment. rGfb4d590a622f4031900516360c07ee6ace01c5e6 should sort this out! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108695/new/ https://reviews.llvm.org/D

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Eugene.Zelenko added a comment. In D108893#2999654 , @aaron.ballman wrote: > In D108893#2999645 , > @Eugene.Zelenko wrote: > >> What about adding `modernize`/`bugprone` aliases? > > I'd be fine if we wanted to a

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. Looking at the common code parts, it seems the behavior of MM_GOFF is actually identical to MM_ELF. Is this correct? If so, do we really need a different format type here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372479. quinnp added a comment. Fixing failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/SemaChe

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999681 , @Eugene.Zelenko wrote: > In D108893#2999654 , @aaron.ballman > wrote: > >> In D108893#2999645 , >> @Eugene.Zelenko w

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Eugene.Zelenko added a comment. > So you'd like to see that extra functionality added now? (I don't think it > makes sense to have the check as-is in both `readability` and `modernize`.) There are plenty of other cross-module aliases al

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999698 , @Eugene.Zelenko wrote: >> So you'd like to see that extra functionality added now? (I don't think it >> makes sense to have the check as-is in both `readability` and `modernize`.) > > There are plenty

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#2991995 , @hjl.tools wrote: >>> The choice that high bits are unspecified rather than extended is an >>> interesting one. Can you speak to that? That's good for +, -, *, &, |, ^, >>> <<, and narrowing conversi

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl added a comment. In D103835#2999545 , @arichardson wrote: > Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We > use addrspace(200) for *all* globals (including vtables). It would have been > nice if I had been added t

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

arichardson added a comment. In D103835#2999731 , @yaxunl wrote: > In D103835#2999545 , @arichardson > wrote: > >> Merging this change broke our out-of-tree CHERI targets (and Arm Morello). >> We use addrspace(2

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

hjl.tools added a comment. In D108643#2999724 , @aaron.ballman wrote: > In D108643#2991995 , @hjl.tools > wrote: > The choice that high bits are unspecified rather than extended is an interesting one.

[clang] 2fd180b - [IR] Reduce max supported integer from 2^24-1 to 2^23.

Author: Craig Topper Date: 2021-09-14T07:52:10-07:00 New Revision: 2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433 URL: https://github.com/llvm/llvm-project/commit/2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433 DIFF: https://github.com/llvm/llvm-project/commit/2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433.diff

[PATCH] D109721: [IR] Reduce max supported integer from 2^24-1 to 2^23.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd180bbb9a7: [IR] Reduce max supported integer from 2^24-1 to 2^2

[clang-tools-extra] d0d9e6f - clang-tidy: introduce readability-containter-data-pointer check

Author: Saleem Abdulrasool Date: 2021-09-14T08:12:10-07:00 New Revision: d0d9e6f0849b2e76e980e2edf365302f47f4e35f URL: https://github.com/llvm/llvm-project/commit/d0d9e6f0849b2e76e980e2edf365302f47f4e35f DIFF: https://github.com/llvm/llvm-project/commit/d0d9e6f0849b2e76e980e2edf365302f47f4e35f.

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGd0d9e6f0849b: clang-tidy: introduce readability-containter-data-pointer check (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D108893

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @Eugene.Zelenko - sorry, I didn't see the additional comments before the commit. I'm happy to do a follow up depending on the resolution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999763 , @compnerd wrote: > @Eugene.Zelenko - sorry, I didn't see the additional comments before the > commit. I'm happy to do a follow up depending on the resolution. If there's a follow-up to add this to mod

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. > ! In D108643#2965852 , @rjmccall > wrote: > > The choice that high bits are unspecified rather than extended is an > interesting one. Can you speak to that? That's good for +, -, *, &, |, ^, > <<, and narrowing conversion

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:704 +C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) { + Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling(); + return; tra wrote: > I

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:704 +C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) { + Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling(); + return; yaxunl wrote: > t

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. This breaks tests: http://45.33.8.238/linux/55784/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

yaxunl updated this revision to Diff 372495. yaxunl added a comment. revise diag message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109718/new/ https://reviews.llvm.org/D109718 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/Driver.cpp clang/test/Dri

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#2997588 , @JDevlieghere wrote: > Keith and I discussed this offline. My suggestion was to do the following: > > 1. Check the overlay for the canonicalized path > 2. Check the fall-through for the canonicalized pat

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru added a comment. Yes please land this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

jdoerfert added a comment. I'm fixing this, nothing to do with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 ___ cfe-commits mailing list cfe-commi

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. (BTW, does this problem affect OverlayFileSystem as well?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing l

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

jdoerfert created this revision. jdoerfert added reviewers: pdhaliwal, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. A declare variant template is only

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Ah, nice! Thanks for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109770/new/ https://reviews.llvm.org/D109770 _

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict qualified pointers

saghir updated this revision to Diff 372505. saghir added a comment. update test case name to be consistent with existing ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/Sema

[clang-tools-extra] 76dc8ac - Revert "clang-tidy: introduce readability-containter-data-pointer check"

Author: Nico Weber Date: 2021-09-14T12:37:10-04:00 New Revision: 76dc8ac36d07cebe8cfe8fe757323562bb36df94 URL: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94 DIFF: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94.diff LO

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. Reverted in 76dc8ac36d07 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 ___

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl added a comment. I am concerned that there may be more places which need handling, and passing exec config expr by function arguments may not scale. Is it possible to represent the kernel call expr by a derived class of call expr and add the exec config expr as member to it? Repository

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: David Blaikie > Date: 2021-09-13T19:17:05-07:00 > New Revision: 2bd84938470bf2e337801faafb8a67710f46429d > > URL: > https://github.com/llvm/llvm-project/commit/2bd84938470bf2e337801faafb8a

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

[PATCH] D109632: [clang] de-duplicate methods from AST files

manmanren added a comment. @dexonsmith @bruno: are you okay with this change? It looks good to me :] Thanks, Manman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 ___

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra added a comment. In D108787#243 , @yaxunl wrote: > I am concerned that there may be more places which need handling, and passing > exec config expr by function arguments may not scale. > Is it possible to represent the kernel call expr by a deri

[PATCH] D109772: [clangd] Print current request context along with the stack trace

0x1eaf created this revision. 0x1eaf added reviewers: sammccall, ilya-biryukov, nridge. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. 0x1eaf requested review of this revision. Herald added subscribers: cfe-commits, Mas

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf updated this revision to Diff 372510. 0x1eaf added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 Files: clang-tools-extra/clangd/JSONTransport.cpp clang-t

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 372514. saiislam added a comment. Rebase and a minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp cla

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added a reviewer: vsapsai. dexonsmith added a subscriber: vsapsai. dexonsmith added a comment. Thanks for looking at this! I have a couple of comments inline. @vsapsai, can you also take a look? Comment at: clang/lib/Serialization/ASTReader.cpp:8188-8190 + for (aut

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 372515. 0x1eaf retitled this revision from "[RFC] Print current request context along with the stack trance in clangd" to "[clangd] Print current request context along with the stack trace". 0x1eaf edited the summary of this revision. 0x1eaf added a comment.

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @thakis - thanks, seems that I had a part of the change sitting in my stash ... I had added a `-NOT` to verify the behaviour, and forgot to remove it. I'll revert the revert with the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] 49992c0 - Revert "Revert "clang-tidy: introduce readability-containter-data-pointer check""

Author: Saleem Abdulrasool Date: 2021-09-14T10:52:35-07:00 New Revision: 49992c04148e5327bef9bd2dff53a0d46004b4b4 URL: https://github.com/llvm/llvm-project/commit/49992c04148e5327bef9bd2dff53a0d46004b4b4 DIFF: https://github.com/llvm/llvm-project/commit/49992c04148e5327bef9bd2dff53a0d46004b4b4.

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I've tried making an integration test in addition to the unit test, but I couldn't find a way to make lit ignore the crashed process exit status: FAIL: Clangd :: crash.test (1049 of 1049) TEST 'Clangd :: crash.test' FAILED S

[clang] 66c6bbe - Put code that avoids heapifying local blocks behind a flag

Author: Walter Lee Date: 2021-09-14T14:06:05-04:00 New Revision: 66c6bbe7ff56441706d6cbb349fde9a02e248c9a URL: https://github.com/llvm/llvm-project/commit/66c6bbe7ff56441706d6cbb349fde9a02e248c9a DIFF: https://github.com/llvm/llvm-project/commit/66c6bbe7ff56441706d6cbb349fde9a02e248c9a.diff LO

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66c6bbe7ff56: Put code that avoids heapifying local blocks behind a flag (authored by waltl). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

sfertile added a comment. I suggest we separate the clang change and testing into a standalone patch, and the llvm backend tests into a standalone patch which we can commit separately. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4646 + if (const ComplexType *CTy = Ty->getAs(

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

HazardyKnusperkeks added a comment. If there are no new tests, what went wrong before? Said invalid code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109752/new/ https://reviews.llvm.org/D109752 ___ cf

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2998727 , @csmulhern wrote: > In D109557#2998213 , > @HazardyKnusperkeks wrote: > >> With context he meant the diff context. >> https://llvm.org/docs/Phabricator.ht

[PATCH] D109128: [VFS] Use original path when falling back to external FS

JDevlieghere added a comment. Yes, Keith and I came to the same conclusion yesterday. I was worried about tracking both paths at all times, but I like your suggestion of only changing the path when requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:8188-8190 + for (auto *L = &List; L; L = L->getNext()) { +seen.insert(L->getMethod()); + } dexonsmith wrote: > I find quadratic algorithms a bit scary, even when current benchmark

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#2999776 , @erichkeane wrote: >> ! In D108643#2965852 , @rjmccall >> wrote: >> >> The choice that high bits are unspecified rather than extended is an >> interesting one. Ca

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

MaskRay added a comment. 49992c04148e5327bef9bd2dff53a0d46004b4b4 relanded the change. It is useful to attach the original `Differential Revision: ` so that it is connected to this Differential. Repository: rG LLVM Github

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#3000157 , @JDevlieghere wrote: > Yes, Keith and I came to the same conclusion yesterday. I was worried about > tracking both paths at all times, but I like your suggestion of only changing > the path when requeste

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372529. cchen added a comment. Fix based on feedback (wait for comment about moving ConstructTrait to IRBuilder) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files:

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Thanks for your reply and sorry about my very sluggish reply! I am looking into updating the docs as you suggested, and that got me looking at this doc page . Interestingly, that

  1   2   >