[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal created this revision. pdhaliwal added reviewers: ye-luo, jdoerfert, ronlieb, JonChesterfield. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a comment. Sorry, I happened to find that the list in `lib/Driver/ToolChains/AVR.cpp` also needs update. {"at90s1200", "", "avr1", 0}, {"attiny11", "", "avr1", 0}, {"attiny12", "", "avr1", 0}, {"attiny15", "", "avr1", 0}, {"attiny28", "", "avr1", 0},

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a comment. Please tell me your email address which will be shown in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___ cfe-

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex:48 +#ifdef __NVPTX__ #pragma omp begin declare variant match( \ device = {arch(nvptx, nvptx64)}, \

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal updated this revision to Diff 371008. pdhaliwal added a comment. Add amdgcn to the same arch list as nvptx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 Files: clang/lib/Headers/openmp_wrapp

[PATCH] D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109328/new/ https://reviews.llvm.org/D109328 _

[clang] c33e296 - [OpenCL] Disallows static kernel functions in C++ for OpenCL

Author: Justas Janickas Date: 2021-09-07T10:23:50+01:00 New Revision: c33e296be1daa621f5933f3729a0ce51172f1505 URL: https://github.com/llvm/llvm-project/commit/c33e296be1daa621f5933f3729a0ce51172f1505 DIFF: https://github.com/llvm/llvm-project/commit/c33e296be1daa621f5933f3729a0ce51172f1505.dif

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rGc33e296be1da: [OpenCL] Disallows static kernel functions in C++ for OpenCL (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109150/new/

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nlopes added a comment. (repost my message from llvm-dev) I can add one thought regarding why this direction makes sense and why it doesn't constrain optimizations. Traditionally we don't want to mark too many things as UB as it restricts code movement and thus limits optimizations. That's why

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Topotuna added a comment. Overall, I think the release notes accurately describe tasks I have been working on. A couple of suggestions and minor grammatical changes provided. Comment at: clang/docs/ReleaseNotes.rst:159 + +- All builtin types, macros and functions declarations

[PATCH] D109349: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD.

fcambus created this revision. fcambus added a reviewer: brad. Herald added a subscriber: krytarowski. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The default was gcc/g++ for all platforms other than Darwin, but most OpenBSD pl

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea updated this revision to Diff 371028. labrinea added a comment. Changes in this revision: - pass the -arm-fix-cmse-cve-2021-35465 option once - document -m(no)fix-cmse-cve-2021-35465 in ClangCommandLineReference.rst - add clang tests with the mitigation expicitely disabled on affected cp

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

SjoerdMeijer added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1646 - if (Args.getLastArg(options::OPT_mcmse)) + bool fix_cve_2021_35465 = false; + if (Args.getLastArg(options::OPT_mcmse)) { Nit: capital F in variable name. =

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 370957. gAlfonso-bit added a comment. Rebase to Main @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

Mordante added a comment. Since @ldionne approved this patch it's good to land. If you don't have commit access, can you provide "Your name" , then somebody can commit the change for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 _

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

thopre added a comment. Is there no way to split this patch further? It's going to be hard finding someone who can review something so big. If there's no way to split it in incremental changes, you could perhaps split per subsystem only for review and refer to this diff for CI as well as when l

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371036. sherwin-dc edited the summary of this revision. sherwin-dc added a comment. [PGO] Change tests to look at which passes were run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://revie

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

hans added a comment. Somehow this seems to have broken the `--driver-mode=` flag when passed to clang-cl. The flag is supposed to override the mode inferred from the filename, but it's not working anymore. For example: Before: $ bin/clang-cl --driver-mode=gcc -target x86_64 -c /tmp/a.c -###

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. I have changed the unroll and icp tests to instead look at the passes that were run, which are shown with the `-mllvm -opt-bisect-limit=-1` flag. This should allow checking that the Loop Unrolling and Indirect Call Promotion passes are run with samplepgo but not thin

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371040. sherwin-dc added a comment. [PGO] Change tests to look at passes run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-sample

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109320/new/ https://reviews.llvm.org/D109320 ___ cfe-commits mailing lis

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea marked 4 inline comments as done and 6 inline comments as done. labrinea added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1666 +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) + CmdArgs

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

SjoerdMeijer added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1666 +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) + CmdArgs.push_back("-arm-fix-cmse-cve-2021-35465=1"); labrin

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

kadircet created this revision. kadircet added reviewers: hans, sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was an accidental behaviour change in D106789 and this patch restor

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet added a comment. Argh, sorry for the mess, sent out D109361 . FYI, before this patch clang preferred the last `--driver-mode` in case of multiple ones and started preferring the first one with this patch. In https://github.com/llvm/llvm-project/blob/ma

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin added a comment. $ clang++ -fopenmp simd.cpp -O1 -Xclang -disable-llvm-passes && ./a.out 0 1 2 3 4 5 6 7 8 9 $ clang++ -fopenmp simd.cpp -O2 && ./a.out 0 1 2 3 4 5 6 7 8 9 $ clang++ -fopenmp simd.cpp -O3 && ./a.out 0 1 2 3 4 5 6 7 8 9 This bug is not in

[clang] 73c00d4 - [clang][Driver] Pick the last --driver-mode in case of multiple ones

Author: Kadir Cetinkaya Date: 2021-09-07T15:33:45+02:00 New Revision: 73c00d40bd49ae022f6fbba7200f05facb533e3b URL: https://github.com/llvm/llvm-project/commit/73c00d40bd49ae022f6fbba7200f05facb533e3b DIFF: https://github.com/llvm/llvm-project/commit/73c00d40bd49ae022f6fbba7200f05facb533e3b.dif

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73c00d40bd49: [clang][Driver] Pick the last --driver-mode in case

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

hans added a comment. Thanks! I tried this locally and it fixes the issue I mentioned on D109361 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109361/new/ https://reviews.llvm.org/D109361 ___

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

kadircet added a comment. FYI, I've also requested cherry-pick into 13 release in https://bugs.llvm.org/show_bug.cgi?id=51779. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109361/new/ https://reviews.llvm.org/D109361

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-int128.c:4 +// RUN: -triple powerpc64-unknown-unknown -target-cpu pwr8 \ +// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s +// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108302/new/ https://reviews.llvm.org/D108302 ___

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4747-4748 +The ``suppress`` attribute can be applied to variable declarations and statements +to suppess warnings from the Clang Static Analyzer. The analyzer will not report +any issues on t

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp created this revision. Herald added subscribers: dexonsmith, jdoerfert, hiraditya. anirudhp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - This patch adds in the GOFF mangling support to the LLVM data layout st

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:148 +// Check if the last option before any colon is a triple field or a GPU name +if (TripleOrGPU.second.startswith("gfx") || +TripleOrGPU.second.startswith("sm_"

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

nemanjai added a comment. It is not clear what this patch will do with `vector [[un]signed] long`. This is currently deprecated but still works - and we don't want it to work with no VSX. Comment at: clang/lib/Headers/altivec.h:8881 } #endif This file is

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

yaxunl added a comment. I agree with Johannes and Alexey that deferred diags are only needed when LangOpts.OMPTargetTriples.empty(). However, I am not sure whether it is only needed in device compilation. For other offloading languages like CUDA/HIP it is needed in both device and host compila

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. SystemZ specific parts LGTM, but it would be good to have someone else review the common code / IR changes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 _

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

aaron.ballman added a comment. Some minor drive-by nits, but this looks sensible to me. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimens

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:82 + +// CHECK-MESSAGES: Suppressed 12 warnings (12 NOLINT) I'd like to see some additional test coverage that shows improper use and what happe

[clang] 5e71839 - [MC] Add MCSubtargetInfo to MCAlignFragment

Author: Peter Smith Date: 2021-09-07T15:46:19+01:00 New Revision: 5e71839f7793b3ab94e928654a493cb3d7216176 URL: https://github.com/llvm/llvm-project/commit/5e71839f7793b3ab94e928654a493cb3d7216176 DIFF: https://github.com/llvm/llvm-project/commit/5e71839f7793b3ab94e928654a493cb3d7216176.diff L

[PATCH] D45961: [MC] Add MCSubtargetInfo to MCAlignFragment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e71839f7793: [MC] Add MCSubtargetInfo to MCAlignFragment (authored by psmith). Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:240-242 + case ToolChain::CST_Libstdcxx: +llvm::report_fatal_error( +"picking up libstdc++ headers is unimplemented on AIX"); ZarkoCA wrote: > nit: it would be my prefere

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 371078. daltenty added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea updated this revision to Diff 371083. labrinea added a comment. Changes in this revision: - renamed fix_cve_2021_35465 to Fix_CVE_2021_35465 - added more Driver tests to cover the use of -mfix-cmse-cve-2021-35465 with -mno-fix-cmse-cve-2021-35465 - fixed code indentation CHANGES SINCE

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL 2021 version macros

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Version macro definitions are tested for C++ for OpenCL 2021. Reposit

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a226529e2cf: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields (authored by NeHuang). Repository: rG LLVM Github Monorepo

[PATCH] D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `.rgba` vector extension setting in C++ for OpenCL 2021 is now performe

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

jdoerfert added a comment. In D109175#2986782 , @yaxunl wrote: > I agree with Johannes and Alexey that deferred diags are only needed when > LangOpts.OMPTargetTriples.empty(). However, I am not sure whether it is only > needed in device compilation. > >

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

SjoerdMeijer added a comment. The driver part looks good to me. I will let Oli do the approval as he also looked at the codegen (and I didn't). Comment at: clang/include/clang/Driver/Options.td:3274 + Group, + HelpText<"Work around VLLDM erratum CVE-2021-35465 (Arm only)">;

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman updated this revision to Diff 371103. dgoldman added a comment. Update comment + remove un-needed code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 Files: clang-tools-extra/clangd/FindTarget

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:188 if (const TypedefNameDecl *TND = dyn_cast(D)) { + if (shouldSkipTypedef(TND)) +return; kadircet wrote: > why do we

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. In D109345#2986297 , @thopre wrote: > Is there no way to split this patch further? It's going to be hard finding > someone who can review something so big. If there's no way to split it in > incremental changes, you could perha

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 371106. anirudhp added a comment. - Condensed the lit test a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 Files: clang/lib/Basic/Targets/SystemZ.h clang/

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

Kai accepted this revision. Kai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the documentation update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits ma

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones created this revision. Herald added subscribers: vkmr, frasercrmck, dexonsmith, dang, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, simoncook, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. Any update on this review? Our builds are still broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 ___ cfe-commits mailing list cfe

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen added a comment. In D102531#2987367 , @gulfem wrote: > Any update on this review? Our builds are still broken. I'll commit this by the end of the day if @rsmith wasn't able to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. I don't see anything giving an error if you try and use the new badly-named option for an architecture other than RISC-V (beyond the usual unused argument warning that's only an error with -Werror)? Comment at: clang/include/clang/Basic/Attr.td:348 +//

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

MaskRay added a comment. The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and overlayfs, I am thinking whether this has anything to do with `OVERLAY` description in a linker script: https://sourceware.org/binutils/docs/ld/Overlay-Description.html#Overlay-Description > whi

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. > I'll commit this by the end of the day if @rsmith wasn't able to take a look. Sounds good, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 _

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. In D109372#2987405 , @MaskRay wrote: > The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and > overlayfs, I am thinking whether this has anything to do with `OVERLAY` > description in a linker script: > http

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1793-1795 +// This is not marked as a TargetSpecificAttr because that would trigger +// an 'attribute ignored' warning, but we want to check it explicitly and +// trigger an error.

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam updated this revision to Diff 371133. saiislam marked 2 inline comments as done. saiislam added a comment. 1. Added tests for empty and incompatible archives. 2. Improved identification of GPUArch in Bundle Entry ID using CudaArch. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

Jake-Egan updated this revision to Diff 371137. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Added lit.local.cfg and unsupported z/OS as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.ll

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. This seems like the right direction to me! Especially like the look-through-the-ErrorInfo change for `FileError` -- I hit this before and found it annoying. IMO, it'd be valuable to split out the consequential functional changes: - Improvements/changes you made to F

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

jhuber6 updated this revision to Diff 371153. jhuber6 added a comment. Adding `no_openmp` assumption as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108958/new/ https://reviews.llvm.org/D108958 Files: clang/lib/Headers/__clang_cuda_libdev

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wlei created this revision. Herald added subscribers: hoy, wenlei, lxfind. wlei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109386 Files: clang/lib/CodeGen/CodeGenModul

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current check for typedef is naive and doesn't deal with any convoluted cases. This patch makes use of the new 'AlignRequirement' enum field from

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.llvm.org/D109060 _

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. Ideally, we probably need something like isValidOffloadArch(Triple, OffloadArch) or getTargetTriple(OffloadArch). However, I think the current patch is good enough for its own purpose. Repos

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

grokos accepted this revision. grokos added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

jhuber6 updated this revision to Diff 371162. jhuber6 added a comment. Fixing end assumes using wrong syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108958/new/ https://reviews.llvm.org/D108958 Files: clang/lib/Headers/__clang_cuda_libdev

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan updated this revision to Diff 371163. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER_RT_USE_BUILTINS_LIBRARY ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_RT_BUILD_BUILTINS ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir updated this revision to Diff 371164. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.org/D109126 Files: clang/test/CodeGen/builtins-ppc-pair-mma.c clang/

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan updated this revision to Diff 371165. Jake-Egan added a comment. Fixed ExtDebugInfo.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.llvm.org/D109060 Files: clang/test/CodeGenObjC/lit.local.cfg clang/test

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir marked an inline comment as done. saghir added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE -

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, except it's missing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109387/new/ https://reviews.llvm.org/D109387 ___

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

jdoerfert requested changes to this revision. jdoerfert added a comment. As noted before, this is not the right fix. Not inlining should not cause a semantic difference here, the problem is something else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

jhuber6 added a comment. In D109321#2986678 , @peixin wrote: > $ clang++ -fopenmp simd.cpp -O1 -Xclang -disable-llvm-passes && ./a.out > 0 1 2 3 4 5 6 7 8 9 > $ clang++ -fopenmp simd.cpp -O2 && ./a.out > 0 1 2 3 4 5 6 7 8 9 > $ c

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer updated this revision to Diff 371176. justinlatimer added a comment. Update target-invalid-cpu-note.c test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 Files: clang/lib/Basic/Targets/A

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a comment. For the commit message, my name is Justin Latimer and my email is justinlati...@gmail.com. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 _

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan added a comment. In D109387#2987780 , @rjmccall wrote: > LGTM, except it's missing tests. Thanks. This is an NFC patch, the tests added in https://reviews.llvm.org/D107598 should still suffice IMHO. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D109387: [NFC][AIX] Check for typedef properly when getting preferred type align

rjmccall added a comment. Oh, no, I don't think this is NFC. It seems very likely that there's some case where the behavior is distinguishable. Maybe a typedef of a record with an alignment attribute? __attribute__((aligned(2), packed)) struct float4 { float x, y, z, w; }; typedef struct

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, sc

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `ninja clang` on Windows works. `check-llvm-tools` has a few `REQUIRES: system-windows` tests and I am running them. Test invocation is bit slow. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

mnadeem added a comment. In D108881#2973735 , @steven_wu wrote: > In D108881#2973719 , @mnadeem wrote: > >> In D108881#2973516 , @steven_wu >> wrote: >> >>> I will do a c

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2987990 , @mnadeem wrote: > In D108881#2973735 , @steven_wu > wrote: > >> In D108881#2973719 , @mnadeem >> wrote: >> >>> In D108881

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

NoQ added a comment. It looks like this commit causes unexpected changes in non-C++ code. Eg., in this tiny reproducer (that uses the non-standard "blocks" feature but is otherwise plain C): typedef struct { int x; } S; void foo() { ^{ S s; return s; }; } I'm

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. If you didn't quite get what I mean, I am suggesting to cleanup all the reference to the old flag. Since `-flto` is rewrite by the driver to `-flto=full`, clang should not query `OPT_flto` anymore. All references to the old flag needs to be audited and removed while p

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

tejohnson added a comment. In D108881#2988016 , @steven_wu wrote: > In D108881#2987990 , @mnadeem wrote: > >> In D108881#2973735 , @steven_wu >> wrote: >> >>> In D108881#

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2988026 , @tejohnson wrote: > In D108881#2988016 , @steven_wu > wrote: > >> In D108881#2987990 , @mnadeem >> wrote: >> >>> In D1088

[clang-tools-extra] dcde8fd - [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

Author: Artem Dergachev Date: 2021-09-07T15:10:46-07:00 New Revision: dcde8fdeeb3ebda6fe6a23d933fbe5caee01c088 URL: https://github.com/llvm/llvm-project/commit/dcde8fdeeb3ebda6fe6a23d933fbe5caee01c088 DIFF: https://github.com/llvm/llvm-project/commit/dcde8fdeeb3ebda6fe6a23d933fbe5caee01c088.dif

[PATCH] D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcde8fdeeb3e: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile… (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D108808?vs=369040&id=371202#toc Reposi

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

arphaman created this revision. arphaman added reviewers: tmatheson, ravikandhadai. Herald added a subscriber: ributzka. arphaman requested review of this revision. This change fixes a crash where a NULL fd was used to emit a diagnostic. Instead of crashing, just avoid printing the declaration nam

[clang] 61d1cce - PR45881: Properly use CXXThisOverride for templated lambda

Author: Yuanfang Chen Date: 2021-09-07T17:02:24-07:00 New Revision: 61d1cce2f83571c00f76144d42a2dea2cb3ab1ca URL: https://github.com/llvm/llvm-project/commit/61d1cce2f83571c00f76144d42a2dea2cb3ab1ca DIFF: https://github.com/llvm/llvm-project/commit/61d1cce2f83571c00f76144d42a2dea2cb3ab1ca.diff

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG61d1cce2f835: PR45881: Properly use CXXThisOverride for templated lambda (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ http

  1   2   >