[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370495. jozefl added a comment. Fix the msp430-toolchain.c test by adding some more Windows path separators to the match patterns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.o

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370507. jozefl added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Basic/T

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

kadircet added a comment. Hmm, it sounds like you want them to be treated one way during semantic highlighting and another during other features, which is fine but somewhat confusing. (e.g. we want to surface hover/goto on these identifiers, but we're making them less visible by encouraging edi

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

uabelho added a comment. This patch makes several libcxx tests fail due to the new warning. See e.g. http://lab.llvm.org:8011/#/builders/60/builds/4632 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann added a comment. @whisperity Thanks a lot for helping me out! Name: Marco Gartmann E-Mail: gartmannma...@hotmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102325/new/ https://reviews.llvm.org/D102325 _

[PATCH] D108045: [clangd] Fix clangd crash when including a header

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:148 bool operator==(const TextualPPDirective &RHS) const { -return std::tie(DirectiveLine, Text) == - std::tie(RHS.DirectiveLine, RHS.Text); +return std::tie(DirectiveLine, Text

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

blackgnezdo updated this revision to Diff 370515. blackgnezdo edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109051/new/ https://reviews.llvm.org/D109051 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp Index: clang/lib/Driver/ToolChains/OpenBSD.cpp

[clang] bd74f4b - [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-03T10:58:05+01:00 New Revision: bd74f4b108346deb37f305690f164181df2e8602 URL: https://github.com/llvm/llvm-project/commit/bd74f4b108346deb37f305690f164181df2e8602 DIFF: https://github.com/llvm/llvm-project/commit/bd74f4b108346deb37f305690f164181df2e8602.dif

[PATCH] D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd74f4b10834: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D108972: [clangd] Omit type hints that are too long

kadircet accepted this revision. kadircet added a subscriber: sammccall. kadircet added a comment. This revision is now accepted and ready to land. Thanks! I was having some discussions with @sammccall about what we really want here. We think folding the arguments & dropping qualifiers until hint

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

whisperity added a comment. Uuuh.. I get the sentiment, but this change breaks the very essence of the joke that the default generated code wants to pass on. It also does not showcase that we can emit notes, not just warnings. How about `function %0 is insufficiently awesome, mark it as 'awesom

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

blackgnezdo updated this revision to Diff 370540. blackgnezdo added a comment. Addressed the clang-tidy complaint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109051/new/ https://reviews.llvm.org/D109051 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp Index: clang/lib/Driver/ToolC

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki updated this revision to Diff 370541. linjamaki added a comment. Remove unused triple, reduce tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 Files: clang/include/clang/Basic/DiagnosticG

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam created this revision. saiislam added reviewers: sylvestre.ledru, ye-luo, jdoerfert. Herald added a subscriber: arphaman. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add documentation of clang-nvlink-wrapper t

[PATCH] D106681: [analyzer] Retrieve a value from list initialization of constant multi-dimensional array.

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. This patch is currently irrelevant after last changes in the parent revision. It's going to be reworked or permanently abandoned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106681/new/ https://reviews.llvm.org/D10

[PATCH] D107073: [analyzer] Disable direct binding from list initialization for constant arrays of local storage duration.

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. This patch is currently irrelevant after last changes in the parent revision. It's going to be reworked or permanently abandoned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107073/new/ https://reviews.llvm.org/D10

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added a comment. How about this patch and the entire stack? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam updated this revision to Diff 370543. saiislam added a comment. Added MSVC warning fix also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109225/new/ https://reviews.llvm.org/D109225 Files: clang/docs/ClangNvlinkWrapper.rst clang/doc

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam added a comment. In D108291#2980737 , @sylvestre.ledru wrote: > Maybe add this to the release notes of clang 14? @sylvestre.ledru and @aaron.ballman please have a look at D109225 . I have made the suggested ch

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

jansvoboda11 updated this revision to Diff 370545. jansvoboda11 added a comment. Resolve test failing on Windows by re-setting the VFS on `FileManager`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108979/new/ https://reviews.llvm.org/D108979 Files: clang/lib/Tooling/DependencyScann

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:19 + +During linking of heterogenous device archive libraries with an OpenMP program, +the `Clang Offload Bundler `_ hetero

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam updated this revision to Diff 370547. saiislam added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109225/new/ https://reviews.llvm.org/D109225 Files: clang/docs/ClangNvlinkWrapper.rst clang/docs/ReleaseNotes.rst

[clang] a375bfb - [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Author: Kristóf Umann Date: 2021-09-03T13:50:18+02:00 New Revision: a375bfb5b729e0f3ca8d5e001f423fa89e74de87 URL: https://github.com/llvm/llvm-project/commit/a375bfb5b729e0f3ca8d5e001f423fa89e74de87 DIFF: https://github.com/llvm/llvm-project/commit/a375bfb5b729e0f3ca8d5e001f423fa89e74de87.diff

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

This revision was automatically updated to reflect the committed changes. Closed by commit rGa375bfb5b729: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D108695?vs=370274&id=370549#toc Repo

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:1 += +Clang Nvlink Wrapper please remove one "=" rst expects alignment Comment at: clang/docs/ClangNvlinkWrapper.rst:52 + Output file gen

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with only minor nits from me, thank you! Comment at: clang/docs/ClangNvlinkWrapper.rst:13 + +This tool works as a wrapper over nvlink program. It is requir

[clang] 6fe2beb - Reland "[clang-repl] Re-implement clang-interpreter as a test case."

Author: Vassil Vassilev Date: 2021-09-03T12:02:58Z New Revision: 6fe2beba7d2a41964af658c8c59dd172683ef739 URL: https://github.com/llvm/llvm-project/commit/6fe2beba7d2a41964af658c8c59dd172683ef739 DIFF: https://github.com/llvm/llvm-project/commit/6fe2beba7d2a41964af658c8c59dd172683ef739.diff LO

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 _

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

Szelethus updated this revision to Diff 370553. Szelethus added a comment. indent->intent CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108753/new/ https://reviews.llvm.org/D108753 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Checkers/Mall

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Kindly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam updated this revision to Diff 370559. saiislam marked 14 inline comments as done. saiislam added a comment. 1. Fixed wording as suggested. 2. Replaced hyperlink to generate html, using the :doc: tag as used in other places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus updated this revision to Diff 370561. Szelethus added a comment. Fixes according to reviewer comments, cheers! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108912/new/ https://reviews.llvm.org/D108912 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus added a comment. In D108912#2972167 , @steakhal wrote: > Maybe a couple other noteworthy commits: > efa7df1682c2859dabe3646ee7dc01e68629417f > : better > R-value tracking. >

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

RedDocMD added a comment. I suppose that the `SmartPtrModelling` patches from GSoC this year shouldn't be added since they only involve an alpha checker. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108912/new/ https://reviews.llvm.org/D108912

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

whisperity added inline comments. Comment at: clang/docs/ReleaseNotes.rst:300-304 +.. 90377308de6c [analyzer] Support allocClassWithName in OSObjectCStyleCast checker + +- Add support for ``allocClassWithName`` in OSObjectCStyleCast checker. + +.. cad9b7f708e2b2d19d7890494980c5e

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus updated this revision to Diff 370564. Szelethus added a comment. In D108912#2982169 , @RedDocMD wrote: > I suppose that the `SmartPtrModelling` patches from GSoC this year shouldn't > be added since they only involve an alpha checker. It would

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus marked an inline comment as done. Szelethus added a comment. Comment at: clang/docs/ReleaseNotes.rst:300-304 +.. 90377308de6c [analyzer] Support allocClassWithName in OSObjectCStyleCast checker + +- Add support for ``allocClassWithName`` in OSObjectCStyleCast checke

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus added a comment. In D108912#2982169 , @RedDocMD wrote: > I suppose that the `SmartPtrModelling` patches from GSoC this year shouldn't > be added since they only involve an alpha checker. Actually, you also patched the enabled-by-default modeli

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. Thanks for fixing! Intel macs are happy now. But the test is still failing on arm macs: http://45.33.8.238/macm1/17292/step_7.txt FAIL: Clang-Unit :: Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests/InterpreterTest.CatchException (28440 of 28440) ***

[clang] 8859640 - Revert "Reland "[clang-repl] Re-implement clang-interpreter as a test case.""

Author: Vassil Vassilev Date: 2021-09-03T13:18:09Z New Revision: 8859640461149065ece1fbcdfed78f17f04a4926 URL: https://github.com/llvm/llvm-project/commit/8859640461149065ece1fbcdfed78f17f04a4926 DIFF: https://github.com/llvm/llvm-project/commit/8859640461149065ece1fbcdfed78f17f04a4926.diff LO

[PATCH] D109232: [CUDA][NFC] Fix a wrong assert message

benshi001 created this revision. benshi001 added reviewers: tra, Hahnfeld, fodinabor, yaxunl. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109232 Files: clang/

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#2982224 , @thakis wrote: > Thanks for fixing! Intel macs are happy now. > > But the test is still failing on arm macs: > http://45.33.8.238/macm1/17292/step_7.txt > > FAIL: Clang-Unit :: > Interpreter/Exception

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

RedDocMD added a comment. In D108912#2982201 , @Szelethus wrote: > In D108912#2982169 , @RedDocMD > wrote: > >> I suppose that the `SmartPtrModelling` patches from GSoC this year shouldn't >> be added since they

[PATCH] D109234: Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc created this revision. Herald added subscribers: ormris, wenlei, pengfei, steven_wu, hiraditya, inglorion. sherwin-dc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I am working on a target in a downstream LLVM repo, and it see

[PATCH] D109232: [CUDA][NFC] Fix a wrong assert message

fodinabor accepted this revision. fodinabor added a comment. This revision is now accepted and ready to land. LGTM, guess this can be commited right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109232/new/ https://reviews.llvm.org/D109232 _

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-int128.c:4 +// RUN: -triple powerpc64-unknown-unknown -target-cpu pwr8 \ +// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s +// RUN: %clang_cc1 -target-feature +altivec -target-feature +

[clang] 12fee64 - [CUDA][NFC] Fix wrong assert information

Author: Ben Shi Date: 2021-09-03T22:35:42+08:00 New Revision: 12fee64daf576c9f4a91fab8ddd5eb512fa14307 URL: https://github.com/llvm/llvm-project/commit/12fee64daf576c9f4a91fab8ddd5eb512fa14307 DIFF: https://github.com/llvm/llvm-project/commit/12fee64daf576c9f4a91fab8ddd5eb512fa14307.diff LOG:

[PATCH] D109232: [CUDA][NFC] Fix a wrong assert message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12fee64daf57: [CUDA][NFC] Fix wrong assert information (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Okay, LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108753/new/ https://reviews.llvm.org/D108753 ___ cfe-commits mailing l

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 370590. dgoldman added a comment. Remove unnecessary build flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cpp clang-t

[clang-tools-extra] 2982bd9 - [clangd] Use the active file's language for hover code blocks

Author: David Goldman Date: 2021-09-03T11:38:27-04:00 New Revision: 2982bd9e9b58ea17bc047ffb9b28df6f92531287 URL: https://github.com/llvm/llvm-project/commit/2982bd9e9b58ea17bc047ffb9b28df6f92531287 DIFF: https://github.com/llvm/llvm-project/commit/2982bd9e9b58ea17bc047ffb9b28df6f92531287.diff

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2982bd9e9b58: [clangd] Use the active file's language for hover code blocks (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:25 // Checks if loop unroll is invoked by normal compile, but not thinlto compile. // SAMPLEPGO-LABEL: define {{(dso_local )?}}void @unroll It seems this test is expl

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

a.elovikov added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108424/new/ https://reviews.llvm.org/D108424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D109244: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library.

fcambus created this revision. fcambus added a reviewer: brad. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this change, passing -fprofile-instr-generate -fcoverage-mapping when building programs will attempt linking against

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman updated this revision to Diff 370609. dgoldman added a comment. Swap to ignore in FindTarget Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 Files: clang-tools-extra/clangd/FindTarget.cpp cla

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman added a comment. In D108556#2981712 , @kadircet wrote: > Hmm, it sounds like you want them to be treated one way during semantic > highlighting and another during other features, which is fine but somewhat > confusing. (e.g. we want to surface

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

ASDenysPetrov updated this revision to Diff 370611. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Adjusted the patch according to changes in the parent revision D104285 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

gulfem added a comment. We started seeing the following test failures in our Fuchsia builds after this patch: Failed Tests (10): libc++ :: libcxx/experimental/language.support/support.coroutines/dialect_support.pass.cpp libc++ :: std/experimental/language.support/support.coroutines/c

[clang] b9e57e0 - Revert "[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it"

Author: Jessica Paquette Date: 2021-09-03T10:28:07-07:00 New Revision: b9e57e030560fef9ddc51caca8bacfefccdf8a62 URL: https://github.com/llvm/llvm-project/commit/b9e57e030560fef9ddc51caca8bacfefccdf8a62 DIFF: https://github.com/llvm/llvm-project/commit/b9e57e030560fef9ddc51caca8bacfefccdf8a62.di

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

paquette added a comment. I just reverted this again because of a bot failure here: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/23380/consoleFull Please fix and recommit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:25 // Checks if loop unroll is invoked by normal compile, but not thinlto compile. // SAMPLEPGO-LABEL: define {{(dso_local )?}}void @unroll tejohnson wrote: > It see

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge added a comment. In D108972#2981893 , @kadircet wrote: > A stepping stone would be to just truncate all the template arguments (e.g. > `tuple, foo>` becomes `tuple<...>` even if `tuple, > foo<...>>` could fit under the limit). I was thinking the

[PATCH] D109128: [VFS] Use original path when falling back to external FS

JDevlieghere added a comment. I'm sure I'm missing something, but after rereading the patch several times I still don't see the functional change. It just looks like it's renaming every instance of `Path` to `CanonicalPath` and `Path_` to `Path`? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. In D109128#2982780 , @JDevlieghere wrote: > I'm sure I'm missing something, but after rereading the patch several times I > still don't see the functional change. It just looks like it's renaming every > instance of `Path` to `Ca

[clang] 655bea4 - [modules] Use `HashBuilder` and `MD5` for the module hash.

Author: Alexandre Rames Date: 2021-09-03T11:13:36-07:00 New Revision: 655bea4226b401a11164f99c6344e38d8742b8e4 URL: https://github.com/llvm/llvm-project/commit/655bea4226b401a11164f99c6344e38d8742b8e4 DIFF: https://github.com/llvm/llvm-project/commit/655bea4226b401a11164f99c6344e38d8742b8e4.dif

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

This revision was automatically updated to reflect the committed changes. Closed by commit rG655bea4226b4: [modules] Use `HashBuilder` and `MD5` for the module hash. (authored by arames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ htt

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang updated this revision to Diff 370630. weiwang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175 Files: clang/lib/Sema/SemaDecl.cpp clang/test/OpenMP/declare_target_messag

[clang] d98c34f - [clang] fix error recovery ICE on copy elision when returing invalid variable

Author: Matheus Izvekov Date: 2021-09-03T20:34:08+02:00 New Revision: d98c34f4d7950f531661ba3f498222ccf6239a0f URL: https://github.com/llvm/llvm-project/commit/d98c34f4d7950f531661ba3f498222ccf6239a0f DIFF: https://github.com/llvm/llvm-project/commit/d98c34f4d7950f531661ba3f498222ccf6239a0f.dif

[PATCH] D109191: [clang] fix error recovery ICE on copy elision when returing invalid variable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd98c34f4d795: [clang] fix error recovery ICE on copy elision when returing invalid variable (authored by mizvekov). Repository: rG LLVM Github Mon

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. I think I might have to apply this same logic to the other functions changed in the original commit as well, this seems to solve this isolated case, but I think there are some more cases that aren't currently fixed by this Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji created this revision. jsji added reviewers: jdenny, ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. jsji requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The test driver-fopenmp-extensions.c is failing on platf

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

ABataev added a comment. I think we can use just `clang_cc1` here instead of `%clang -c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370653. jsji added a comment. Use clang_cc1 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c Index: clan

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983002 , @ABataev wrote: > I think we can use just `clang_cc1` here instead of `%clang -c` Good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://re

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. I'm realizing more now that these changes break the original intent of rG0be9ca7c0f9a733f846bb6bc4e8e36d46b518162 as well, given that it seems like the core canonicalization of the path before passing

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. This test is meant to check that the driver processes these options correctly. -cc1 isn't the driver and often ignores either the positive or negative version of an option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983017 , @jdenny wrote: > This test is meant to check that the driver processes these options > correctly. -cc1 isn't the driver and often ignores either the positive or > negative version of an option. OK, I can reve

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. In D109255#2983018 , @jsji wrote: > In D109255#2983017 , @jdenny wrote: > >> This test is meant to check that the driver processes these options >> correctly. -cc1 isn't the driver and of

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ldionne reopened this revision. ldionne added a comment. This revision is now accepted and ready to land. Based on the commit description, I don't understand this change at all. Why do we want to tweak the name lookup just for `std::coroutine`? Yes, we do have an action item to finish coroutines

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ldionne reopened this revision. ldionne added a comment. This revision is now accepted and ready to land. (woops, this closed the rev when I committed the revert) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D1

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370658. jsji added a comment. Use driver + -fsyntax-only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c Index:

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

ABataev added a comment. In D109255#2983017 , @jdenny wrote: > This test is meant to check that the driver processes these options > correctly. -cc1 isn't the driver and often ignores either the positive or > negative version of an option. Better not

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. @ABataev Is this still OK for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. In D109255#2983052 , @ABataev wrote: > In D109255#2983017 , @jdenny wrote: > >> This test is meant to check that the driver processes these options >> correctly. -cc1 isn't the driver and o

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji updated this revision to Diff 370663. jsji added a comment. use `_cc1` for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c clang/test/Ope

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny added a comment. In D109255#2983063 , @jsji wrote: > In D109255#2983052 , @ABataev wrote: > >> In D109255#2983017 , @jdenny wrote: >> >>> This test is meant to chec

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jsji added a comment. > I probably won't get to it today, but I can work on it later. Sure, take your time. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

jdenny accepted this revision. jdenny added a comment. LGTM. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 ___ cfe-commits mailing list c

[clang] d364ecc - [NFC][OpenMP] Use clang_cc1 to driver tests

Author: Jinsong Ji Date: 2021-09-03T20:33:48Z New Revision: d364eccdd5a924d34284dca47ed8b029507167ce URL: https://github.com/llvm/llvm-project/commit/d364eccdd5a924d34284dca47ed8b029507167ce DIFF: https://github.com/llvm/llvm-project/commit/d364eccdd5a924d34284dca47ed8b029507167ce.diff LOG: [N

[PATCH] D109255: [NFC][OpenMP] Use clang_cc1 to driver tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd364eccdd5a9: [NFC][OpenMP] Use clang_cc1 to driver tests (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D105092: [RISCV] Add the tail policy argument to builtins/intrinsics.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2288 + (mask_type V0), + VLOpFrag, (XLenVT GPR:$policy))), + (!cast(inst#"_"#kind#"_"#vlmul.MX#"_MASK") I think t

[clang] 466451c - [clang] Allow the OpenBSD driver to link the libclang_rt.profile library.

Author: Frederic Cambus Date: 2021-09-03T17:18:40-04:00 New Revision: 466451c6616272d8c779618b92b0ae80f394a795 URL: https://github.com/llvm/llvm-project/commit/466451c6616272d8c779618b92b0ae80f394a795 DIFF: https://github.com/llvm/llvm-project/commit/466451c6616272d8c779618b92b0ae80f394a795.dif

[PATCH] D109244: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library.

This revision was automatically updated to reflect the committed changes. Closed by commit rG466451c66162: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library. (authored by fcambus, committed by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D109260: [RISCV] Add SiFive core E20

apivovarov created this revision. apivovarov added reviewers: MaskRay, evandro. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kit

[PATCH] D109260: [RISCV] Add SiFive core E20

craig.topper added a comment. Are you planning to add more CPUs? I think I'd be willing to accept them all as one patch instead of one small patch for each CPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109260/new/ https://reviews.llvm.org/D10

[clang] b989662 - OpenBSD also needs execinfo

Author: Brad Smith Date: 2021-09-03T17:33:48-04:00 New Revision: b989662eb000efb54b91b8c82d2b2713e2da20fc URL: https://github.com/llvm/llvm-project/commit/b989662eb000efb54b91b8c82d2b2713e2da20fc DIFF: https://github.com/llvm/llvm-project/commit/b989662eb000efb54b91b8c82d2b2713e2da20fc.diff LO

[PATCH] D109260: [RISCV] Add SiFive core E20

apivovarov added a comment. Another missing combination is: - e24 and e34 (rocket, rv32imafc) I can also add several cores which are similar to existing cores: - e21 (same as existing e31 - rocket, rv32imac) - s21 (same as existing s51 - rocket, rv64imac) - s54 (same as existing u54 - rocket, r

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. In D109210#2981912 , @whisperity wrote: > Uuuh.. I get the sentiment, but this change breaks the very essence of the > joke that the default generated code wants to pass on. It also does not > showcase that we can emit no

  1   2   >