kadircet accepted this revision.
kadircet added a subscriber: sammccall.
kadircet added a comment.
This revision is now accepted and ready to land.

Thanks! I was having some discussions with @sammccall about what we really want 
here. We think folding the arguments & dropping qualifiers until hint fits 
under the limit would be the most ideal but there's no rush. A stepping stone 
would be to just truncate all the template arguments (e.g. `tuple<foo<x>, 
foo<y>>` becomes `tuple<...>` even if `tuple<foo<...>, foo<...>>` could fit 
under the limit). Omitting is also fine initially, even though it's gonna feel 
weird (as if clangd couldn't find any hints) it is still better than extending 
the line to infinity!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108972/new/

https://reviews.llvm.org/D108972

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to