[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

balazske added inline comments. Comment at: clang/test/Analysis/return-ptr-range.cpp:17 return arr; // no-warning - } while (0); - return ptr; // expected-warning{{Returned pointer value points outside the original object (potential buffer overflow)}} + } + return ptr

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

MTC added a comment. I think we're a bit off track, and @Sockke wants to accomplish more than one goal in the same patch. I have summarized what we are currently discussing as follow shows: 1. Fix the wrong AutoFix which blocks the compilation. 2. Find more 'unrecommended' std::move usage and

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

balazske updated this revision to Diff 365693. balazske added a comment. Re-add empty while loops in tests, to have the original code. These loops were intentionally created and probably still needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:4159 +defm VMOVSHZ : avx512_move_scalar<"vmovsh", X86Movsh, X86vzload16, f16x_info, + [HasFP16]>, + VEX_LIG, T_MAP5XS, EVEX_CD8<16, C

[libunwind] 9ed1c7e - [Unwind] Split unwind.h

Author: Daniel Kiss Date: 2021-08-11T10:15:51+02:00 New Revision: 9ed1c7e4964382b95a5886279c0dfc7147a57b17 URL: https://github.com/llvm/llvm-project/commit/9ed1c7e4964382b95a5886279c0dfc7147a57b17 DIFF: https://github.com/llvm/llvm-project/commit/9ed1c7e4964382b95a5886279c0dfc7147a57b17.diff L

[libunwind] db126ae - [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI.

Author: Daniel Kiss Date: 2021-08-11T10:15:53+02:00 New Revision: db126ae243cd70e4f68fd50a7c619740e90e1dc6 URL: https://github.com/llvm/llvm-project/commit/db126ae243cd70e4f68fd50a7c619740e90e1dc6 DIFF: https://github.com/llvm/llvm-project/commit/db126ae243cd70e4f68fd50a7c619740e90e1dc6.diff L

[libunwind] 6b6d344 - [libunwind] Compile with -Wunused-but-set-variable

Author: Daniel Kiss Date: 2021-08-11T10:15:54+02:00 New Revision: 6b6d3447317673015f62206b2669c2d0a74132dc URL: https://github.com/llvm/llvm-project/commit/6b6d3447317673015f62206b2669c2d0a74132dc DIFF: https://github.com/llvm/llvm-project/commit/6b6d3447317673015f62206b2669c2d0a74132dc.diff L

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. With the introduction of `CVQualifierOrder` the need for `CVQualifierAlignment:` doesn't make so much sense CVQualifierAlignment: Left CVQualifierOrder: [ "inline", "static", "volatile", "const" ] I'm leaning toward introducing into the `CVQualifierOrder` al

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

steakhal accepted this revision. steakhal added inline comments. Comment at: clang/test/Analysis/return-ptr-range.cpp:17 return arr; // no-warning - } while (0); - return ptr; // expected-warning{{Returned pointer value points outside the original object (potential buff

[PATCH] D107632: [clangd] Avoid "expected one compiler job" by picking the first eligible job.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/Compiler.cpp:42 const clang::Diagnostic &Info) { + DiagnosticConsumer::Handl

[PATCH] D107887: scan-build-py: Force the opening in utf-8

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: phosek, isthismyaccount, aabbaabb. Herald added a subscriber: whisperity. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It fails on ubuntu bionic othe

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2938973 , @MyDeveloperDay wrote: > With the introduction of `CVQualifierOrder` the need for > `CVQualifierAlignment:` doesn't make so much sense > > CVQualifierAlignment: Left > CVQualifierOrder: [ "inlin

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365564. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. requested change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 added a comment. @rampitec besides the remarks, am I missing anything else in the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-com

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added a comment. In D106891#2938128 , @gandhi21299 wrote: > @rampitec besides the remarks, am I missing anything else in the patch? You should not use AMD specific code in the common code. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365625. gandhi21299 added a comment. - reverted the patch to the previous one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-a

[clang] 9f517fd - [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

Author: Balázs Kéri Date: 2021-08-11T13:04:55+02:00 New Revision: 9f517fd11ee9b9e49eabff7400cfe13b424e9b06 URL: https://github.com/llvm/llvm-project/commit/9f517fd11ee9b9e49eabff7400cfe13b424e9b06 DIFF: https://github.com/llvm/llvm-project/commit/9f517fd11ee9b9e49eabff7400cfe13b424e9b06.diff L

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f517fd11ee9: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange (authored by balazske). Changed prior to commit: https://revie

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman closed this revision. aaron.ballman added a comment. This was committed in 530ea28fefc4652823a187a149e8001cbf4af18f . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D1

[PATCH] D107893: [clang] [MinGW] Consider the per-target libc++ include directory too

mstorsjo created this revision. mstorsjo added reviewers: phosek, MaskRay. mstorsjo requested review of this revision. Herald added a project: clang. The existing logic for per-target libc++ include directories only seem to exist for the Gnu and Fuchsia drivers, added in ea12d779bc238c387511fe7462

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

curdeius added a comment. In D69764#2939037 , @HazardyKnusperkeks wrote: > In D69764#2938973 , @MyDeveloperDay > wrote: > >> I'm leaning toward introducing into the `CVQualifierOrder` allowing >> for some qualif

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:696 // Add transition for the failed state. Optional RetVal = makeRetVal(C, CE).castAs(); assert(RetVal && "Value should be NonLoc."); balazske wrote: > Szel

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

NeHuang added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 01d59c0 - [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

Author: Joseph Huber Date: 2021-08-11T08:50:47-04:00 New Revision: 01d59c0de822099c62f12f275c41338f6df9f5ac URL: https://github.com/llvm/llvm-project/commit/01d59c0de822099c62f12f275c41338f6df9f5ac DIFF: https://github.com/llvm/llvm-project/commit/01d59c0de822099c62f12f275c41338f6df9f5ac.diff

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG01d59c0de822: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107461/new/ https://reviews.llvm.org/D107461 ___ cfe-commits mailing list cfe-commi

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

NeHuang accepted this revision. NeHuang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107138/new/ https://reviews.llvm.org/D107138 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a subscriber: asb. MyDeveloperDay added a comment. > In D69764#2939037 , > @HazardyKnusperkeks wrote: > I would like to remove the CV, only QualifierOrder. Oh gosh, I agree here so much with both you and @curdeius , I keep miss sp

[PATCH] D107899: [PowerPC] Implement builtin for vbpermd

nemanjai created this revision. nemanjai added a reviewer: PowerPC. Herald added subscribers: shchenz, kbarton, hiraditya. nemanjai requested review of this revision. Herald added projects: clang, LLVM. The instruction has similar semantics to vbpermq but for doublewords. It was added in P9

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec created this revision. jmarrec added a reviewer: steveire. Herald added a subscriber: mgorny. jmarrec requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D10790

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec updated this revision to Diff 365735. jmarrec added a comment. Added content to the `clang-tools-extra/docs/clang-tidy/checks/misc-pod-const-ref-to-value.rst` file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107900/new/ https://reviews.llvm.org/D107900 Files: clang-tools-e

[PATCH] D106960: [OffloadArch] Library to query properties of current offload archicture

JonChesterfield added a comment. T Comment at: llvm/lib/OffloadArch/amdgpu/vendor_specific_capabilities.cpp:25 +// +#include "hsa-subset.h" +#include yaxunl wrote: > It would be much simpler to use HIP API to get device name and capabilities > e.g. gfx906:xna

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. Is it ready to load now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

Quuxplusone added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-pod-const-ref-to-value.rst:21 + + If set to `true`, this check will limit itself to the `builtinType()` types. Default is `false`. D107873 is related. I'd like to se

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

aaron.ballman added a comment. In D69764#2938973 , @MyDeveloperDay wrote: > With the introduction of `CVQualifierOrder` the need for > `CVQualifierAlignment:` doesn't make so much sense > > CVQualifierAlignment: Left > CVQualifierOrder: [ "inline", "

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei updated this revision to Diff 365738. pengfei marked 6 inline comments as done. pengfei added a comment. 1. Rebase to the first merged FP16 patch. 2. Address Yuanke's comments. 3. Add parentheses around casts. 4. Remove OptForSize predicate for vmovsh. 5. Add more immediate value for encod

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1860 +TARGET_BUILTIN(__builtin_ia32_minph512, "V32xV32xV32xIi", "ncV:512:", "avx512fp16") + +TARGET_BUILTIN(__builtin_ia32_minph256, "V16xV16xV16x", "ncV:256:", "avx512fp16,avx512vl")

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/ https://reviews.llvm.org/D105264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

yaxunl added a comment. This may break -save-temps since the input to clang-offload-bundler may not be temporary files when -save-temps is enabled. I think clang-offload-bundler is not the right place to decide whether a file is a temporary file. Whether a file is a temporary file should be det

[PATCH] D107899: [PowerPC] Implement builtin for vbpermd

bmahjour added inline comments. Comment at: clang/lib/Headers/altivec.h:17337 static __inline__ vector long long __ATTRS_o_ai vec_vbpermq(vector unsigned char __a, vector unsigned char __b) { return __builtin_altivec_vbpermq(__a, __b); This should be guarded

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 added a comment. In D107668#2939365 , @yaxunl wrote: > This may break -save-temps since the input to clang-offload-bundler may not > be temporary files when -save-temps is enabled. > > I think clang-offload-bundler is not the right place to decid

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some style nits (removing some top-level `const` we don't typically use, unnecessary paren expressions, and a typo fix), thank you for the check! =

[clang] 9eb99d2 - CodeGen: No need to check for isExternC if HasStrictReturn is already false

Author: Arnold Schwaighofer Date: 2021-08-11T07:42:48-07:00 New Revision: 9eb99d2e73b5598076fbdd8abceb3549afa8f0ae URL: https://github.com/llvm/llvm-project/commit/9eb99d2e73b5598076fbdd8abceb3549afa8f0ae DIFF: https://github.com/llvm/llvm-project/commit/9eb99d2e73b5598076fbdd8abceb3549afa8f0ae

[PATCH] D107841: CodeGen: No need to check for isExternC if HasStrictReturn is already false

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9eb99d2e73b5: CodeGen: No need to check for isExternC if HasStrictReturn is already false (authored by aschwaighofer). Repository: rG LLVM Github

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197 + else if (PatchedName.endswith("sh")) +PatchedName = IsVCMP ? "vcmpsh" : "cmpsh"; + else if (PatchedName.endswith("ph")) There is no cmpsh? =

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-pod-const-ref-to-value.cpp:3-5 +int f1(const int &i); +// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: argument 'i' is a trivially copyable type and should not be passed by const-reference bu

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang updated this revision to Diff 365761. NeHuang added a comment. Address review comment from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107646/new/ https://reviews.llvm.org/D107646 Files: llvm/lib/Target/PowerPC/PPCISelLowering

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to https://github.com/llvm/llvm-project/commit/f6bc614546e169bb1b17a29c422ebace038e6c62 where we handle the case where the semicolon is fol

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-pod-const-ref-to-value.rst:21 + + If set to `true`, this check will limit itself to the `builtinType()` types. Default is `false`. Quuxplusone wrote: > D107873 is related

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

jmarrec added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-const-parameter-value-or-ref.rst:90 +Passing a ``shared_ptr`` by reference-to-``const`` is also acceptable in certain +situaitons. As such, ``std::shared_ptr`` and ``boost::shared_pt

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens in declarations

aaron.ballman added a comment. In D107292#2923261 , @cjdb wrote: > Patch 2: expressions > > xor {} > bitand x // warning will suggest std::addressof in C++ land > and label An additional expression to cover, not that I think anyone would be this awful b

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. Really I still not understand why the previous `BugType` dependent `NoteTag` functions were bad design (except that it could make the code difficult to understand). If we would have the BugType available in the NoteTag, we could make the decision about what to display

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107646/new/ https://reviews.llvm.org/D107646 __

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.cpp:51-54 + if (!getLangOpts().C99) { +return llvm::None; + } + Comment at: clang-tools-extra/clang-tidy/readability/Alter

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke marked an inline comment as done. Sockke added a comment. Any thoughts? : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:439 + [&](const FieldDecl *F) { +if (!HasRecordClasMemberSet.count(F)) +{ MTC wrote: > I believe `DenseSet::contains

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 365765. MyDeveloperDay added a comment. - Remove the "CV" from the options - Add support for ordering static/inline/const/volatile around the type, allowing for mixing both left and right alignment at the same time QualifierAlignment: Custom Quali

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

wmi added a comment. Could you remind me the discriminator difference between debug info based AFDO and pseudo probe based AFDO? I forgot it. I am sure it is described in some patch but I havn't found it. Give me a pointer is good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

mstorsjo added a comment. I ran into a regression caused by this change, see https://bugs.llvm.org/show_bug.cgi?id=51442. This breaks building Qt tests with LLVM 13. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.o

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3896 - // These two forms of profiling info can't be used together. - if (const Arg *A1 = Args.getLastArg(options::OPT_fpseudo_probe_for_profiling)) -if (const Arg *A2 = Args.getLastArg(options::

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

hoy added a comment. In D107876#2939624 , @wmi wrote: > Could you remind me the discriminator difference between debug info based > AFDO and pseudo probe based AFDO? I forgot it. I am sure it is described in > some patch but I havn't found it. Give me a

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107703/new/ https://reviews.llvm.org/D107703 ___ cfe-commits mailing list

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec updated this revision to Diff 365778. jmarrec added a comment. Added a MaxSize option. defaults to 16. Also skip templates. like in D107873 Dealt with the `f(int &i)` case instead of `f(int& i)` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec updated this revision to Diff 365779. jmarrec added a comment. Forgot to run clang format on the changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107900/new/ https://reviews.llvm.org/D107900 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clan

[PATCH] D107893: [clang] [MinGW] Consider the per-target libc++ include directory too

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107893/new/ https://reviews.llvm.org/D107893 ___

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107907/new/ https://reviews.llvm.org/D107907 ___

[PATCH] D107850: [WIP][asan] Implemented custom calling convention similar used by HWASan for X86. The feature should be code complete. The tests are coming in a later revision.

kstoimenov updated this revision to Diff 365787. kstoimenov added a comment. Address lint comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/test/CodeGen/asan-use-callbacks.cpp llv

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Btw, I'm not certain why patch application is failing for you in the precommit CI: https://buildkite.com/llvm-project/diff-checks/builds/58571#c186a7d3-f5c9-4ad2-ae27-07408b1c5da

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

MaskRay added a comment. In D107684#2936034 , @mhjacobson wrote: > In D107684#2936033 , @MaskRay wrote: > >> `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. >> >> sysroot is usually a directory whic

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added a comment. In D107696#2939827 , @aaron.ballman wrote: > Btw, I'm not certain why patch application is failing for you in the > precommit CI: > https://buildkite.com/llvm-project/diff-checks/builds/58571#c186a7d3-f5c9-4ad2-ae27-07408

[PATCH] D107095: Implement #pragma clang header_unsafe

aaron.ballman added a comment. The technical bits all LGTM, thank you for the functionality! There was a comment on IRC that `header_unsafe` might be confusing to users as it may suggest that the *header* is unsafe rather than the use of the macro. I don't know if we resolved the naming questio

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne is this ok? any other changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D106614: [Clang] add btf_tag attribute

aaron.ballman added a comment. Assuming we're back on the same page again, I think the only thing left in this review is a commenting nit. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6846-6847 +return; + if (hasBTFTagAttr(D, Str)) +return; + yonghong-

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang created this revision. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when searching for header files (with relative paths) we concatenate the path to the module map with the header filename. However when searchin

[clang] 718c632 - Simplify dllexport class member code, NFC

Author: Reid Kleckner Date: 2021-08-11T11:42:20-07:00 New Revision: 718c63258202e8e674c47c9ece16f396065e7c2a URL: https://github.com/llvm/llvm-project/commit/718c63258202e8e674c47c9ece16f396065e7c2a DIFF: https://github.com/llvm/llvm-project/commit/718c63258202e8e674c47c9ece16f396065e7c2a.diff

[PATCH] D107843: [X86] Add parentheses around casts in some of the X86 intrinsic headers.

rsmith added a comment. I found a few more macro hygiene issues in these headers. Comment at: clang/lib/Headers/avx2intrin.h:23 #define _mm256_mpsadbw_epu8(X, Y, M) \ (__m256i)__builtin_ia32_mpsadbw256((__v32qi)(__m256i)(X), \ (__v32qi)

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

lei updated this revision to Diff 365816. lei added a comment. Add -W flag to new warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 Files: clang/include/clang/Basic/BuiltinsPPC.def clang

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

owenpan added a comment. I thought of it last time but didn't try hard to come up with a test case that would make a difference. :( Thanks for finding the hole! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107907/new/ https://reviews.llvm.org/D10

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2484-2490 + if (Next->Next && Next->Next->is(tok::identifier)) { +const FormatToken *Last = Line.Last; +if (Last && Last->is(tok::comment)) + Last = Last->getPreviousNonComment(); +if

[clang] a614a28 - [PowerPC] Do not define __PRIVILEGED__

Author: Stefan Pintilie Date: 2021-08-11T14:10:22-05:00 New Revision: a614a28772cbd8e0fc3c5fcf836493c2c8bc80da URL: https://github.com/llvm/llvm-project/commit/a614a28772cbd8e0fc3c5fcf836493c2c8bc80da DIFF: https://github.com/llvm/llvm-project/commit/a614a28772cbd8e0fc3c5fcf836493c2c8bc80da.dif

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa614a28772cb: [PowerPC] Do not define __PRIVILEGED__ (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:964-965 +bool match = +(EA->isError() && NewAttrSpellingIndex < ErrorAttr::GNU_warning) || +(EA->isWarning() && NewAttrSpellingIndex >= ErrorAttr::GNU_warning); +if (!match) {

[PATCH] D107900: Add a new clang-tidy check for trivially copyable types passed by const reference

cjdb added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-pod-const-ref-to-value.rst:21 + + If set to `true`, this check will limit itself to the `builtinType()` types. Default is `false`. jmarrec wrote: > Quuxplusone wrote: > > D1

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

ftynse accepted this revision. ftynse added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:364 + /// over all chunks that are executed on the same thread. Returning + /// CanonicalLoopInfo objec

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365852. 0x8000- added a comment. Removed extra 'const' and parentheses that are not congruent with the accepted code style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- added a comment. @aaron.ballman - thank you for the review; please submit on my behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai added a comment. Found another case that doesn't emit an error #if defined(FIRST) struct Indirect { int x; }; struct Direct { struct Indirect i; }; #elif defined(SECOND) struct Indirect { double a; }; struct Direct { struct Indirect i; }; #else stru

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance created this revision. nathanchance added reviewers: dblaikie, rsmith, nickdesaulniers. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Linux kernel has a macro called IS_ENABLED(), which evaluates to a constan

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365879. 0x8000- added a comment. Reformatted the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-

[PATCH] D107843: [X86] Add parentheses around casts in some of the X86 intrinsic headers.

craig.topper updated this revision to Diff 365880. craig.topper added a comment. Fix two functions I missed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107843/new/ https://reviews.llvm.org/D107843 Files: clang/lib/Headers/__wmmintrin_aes.h

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song added a comment. > Assuming I have that correct now, this approach looks correct to me (without > diagnosing the ignored duplicates). I agree that we don't need to diagnose the ignored duplicates. The following is an example, $ cat t.c int g __attribute__((section("a"))) __attrib

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song updated this revision to Diff 365882. yonghong-song added a comment. - fix a few nits in AttrDocs.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106614/new/ https://reviews.llvm.org/D106614 Files: clang/include/clang/Basic/Attr.t

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz added a reviewer: lebedev.ri. beanz added a subscriber: lebedev.ri. beanz added a comment. +@lebedev.ri @aaron.ballman thank you for all the feedback and support! I'm not really sure where to go on the naming. I'm not attached to `header_unsafe`, and totally understand the confusion. I do

[PATCH] D107939: [clang][Arm

sarahpurohit created this revision. sarahpurohit added a project: clang. Herald added a subscriber: kristof.beyls. sarahpurohit requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107939 Files: clang/lib/Dri

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365891. 0x8000- added a comment. One more format nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-tidy/r

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song updated this revision to Diff 365893. yonghong-song added a comment. - fix clant-format warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882 Files: clang/lib/Sema/SemaType.cpp clang

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei updated this revision to Diff 365895. pengfei marked 3 inline comments as done. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/ https://reviews.llvm.org/D105264 Files: clang/i

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197 + else if (PatchedName.endswith("sh")) +PatchedName = IsVCMP ? "vcmpsh" : "cmpsh"; + else if (PatchedName.endswith("ph")) LuoYuanke wrote: > There is

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei updated this revision to Diff 365899. pengfei added a comment. Update missing changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/ https://reviews.llvm.org/D105264 Files: clang/include/clang/Basic/BuiltinsX86.def clang/li

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:4838 { X86::VMULSDZrr_Intk,X86::VMULSDZrm_Intk, TB_NO_REVERSE }, + { X86::VMULSHZrr_Intk,X86::VMULSHZrm_Intk, TB_NO_REVERSE }, { X86::VMU

  1   2   >