bmahjour added inline comments.
================ Comment at: clang/lib/Headers/altivec.h:17337 static __inline__ vector long long __ATTRS_o_ai vec_vbpermq(vector unsigned char __a, vector unsigned char __b) { return __builtin_altivec_vbpermq(__a, __b); ---------------- This should be guarded under P8. It would also be good to add a `vec_vbpermd(vector unsigned long long ...)` counter part under `__POWER9_VECTOR__` for consistency. ================ Comment at: clang/lib/Headers/altivec.h:17349 +static __inline__ vector unsigned char __ATTRS_o_ai +vec_bperm(vector unsigned char __a, vector unsigned char __b) { + return __builtin_altivec_vbpermq(__a, __b); ---------------- `vbpermq` variants should be guarded under `__POWER8_VECTOR__` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107899/new/ https://reviews.llvm.org/D107899 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits