[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. As discussed offline, does not yield performance improvements. Putting on "Request Changes" so that I don't miss ongoing reviews (please let me know if that's OK with you). Rep

[PATCH] D106640: [clangd] Make dex iterator peek() and reachedEnd() nonvirtual

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Ditto (previous performance improvement attempt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106640/new/ https://reviews.llvm.o

[PATCH] D107047: [clangd] Fix the crash in getQualification

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107047/new/ https://reviews.llvm.org/D107047 __

[PATCH] D107047: [clangd] Fix the crash in getQualification

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f2d4af031c: [clangd] Fix the crash in getQualification (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e0f2d4a - [clangd] Fix the crash in getQualification

Author: Kirill Bobyrev Date: 2021-08-02T09:08:25+02:00 New Revision: e0f2d4af031c93b46f0920620ab6a798113b4b6e URL: https://github.com/llvm/llvm-project/commit/e0f2d4af031c93b46f0920620ab6a798113b4b6e DIFF: https://github.com/llvm/llvm-project/commit/e0f2d4af031c93b46f0920620ab6a798113b4b6e.diff

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal updated this revision to Diff 363387. pdhaliwal added a comment. Fixed compilation error for nvptx headers. Tested on both cuda and non-cuda systems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal added a comment. @ye-luo and @JonChesterfield can you please test the latest version of this patch? It should work now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 _

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

hans added a comment. In D74436#2917395 , @mibintc wrote: > In D74436#2917357 , @haowei wrote: > >> We are seeing float related unit tests failing in Fuchsia after this patch. >> What flags should we add to our bui

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

jyu2 added a comment. >>> I don't find any document about GCC and ICC's behavior and the generated code doesn't make much sense to me. Besides, if we change "=rm" to "=r" or "=m", GCC and ICC will report error differently. Which gives me an impression that the use of constraint is undefined behav

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

jansvoboda11 updated this revision to Diff 363411. jansvoboda11 added a comment. Move substitution to `clang/test/lit.cfg.py`, revert `%` prefixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107155/new/ https://reviews.llvm.org/D107155 Files: clang/test/lit.cfg.py Index: clang/t

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat updated this revision to Diff 363413. werat added a comment. Moved the comment to the first usage of `io.open`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106792/new/ https://reviews.llvm.org/D106792 Files: clang-tools-extra/clang-tidy/

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

jansvoboda11 added a comment. In D107155#2916664 , @dblaikie wrote: > Hmm, don't we have some other substitution feature that avoids the need to > add the %? (like, I think LLVM's tests don't usually use the % for many tool > names - but they still make

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. In D99353#2918629 , @protze.joachim wrote: > Any chance that we get this into llvm/13? Given that Release-13 branch has already been created (https://lists.llvm.org/pipermail/llvm-dev/2021-July/151956.html), this is very unl

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106792/new/ https://reviews.llvm.org/D106792

[clang-tools-extra] 307b1fd - [clang-tidy] Always open files using UTF-8 encoding

Author: Andy Yankovsky Date: 2021-08-02T11:36:04+02:00 New Revision: 307b1fddd4d84b559b154ff7744ae68bf9c6f503 URL: https://github.com/llvm/llvm-project/commit/307b1fddd4d84b559b154ff7744ae68bf9c6f503 DIFF: https://github.com/llvm/llvm-project/commit/307b1fddd4d84b559b154ff7744ae68bf9c6f503.diff

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG307b1fddd4d8: [clang-tidy] Always open files using UTF-8 encoding (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko updated this revision to Diff 363418. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/ContinuationIndenter.cpp clang/l

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107163/new/ https://reviews.llvm.org/D107163

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

sberg added a comment. Bisecting shows that this commit causes $ echo foo | clang -E -P - foo to emit a leading newline now. That breaks e.g. LibreOffice's `configure`, which uses `echo __clang_version__ | clang -E -P -` to obtain the value of that macro, and expects a single line of o

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

romanovvlad added a comment. In D104601#2917065 , @Meinersbur wrote: > Patch uploaded here: D107183 The patch resolves the issue. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D107261: [clang] [MinGW] Let the last of -mconsole/-mwindows have effect

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865, jeremyd2019. mstorsjo requested review of this revision. Herald added a project: clang. Don't just check for the existence of one, but check which one was specified last, if any. This fixes https://llvm.org/PR51296. Reposit

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

jansvoboda11 added a comment. In D105881#2906955 , @awarzynski wrote: > OK, that's fair enough. But what about the output from `clang --help` and > `clang -cc1 --help`? Let's look at -feliminate-unused-debug-types >

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler updated this revision to Diff 363442. ckandeler added a comment. Addressed lint comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107137/new/ https://reviews.llvm.org/D107137 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1022 LLVMStyle.BreakBeforeConceptDeclarations = true; + LLVMStyle.BreakBeforeInlineASMColon = FormatStyle::BBIAS_OnlyMultiline; LLVMStyle.BreakBeforeTernaryOperators = true; Are

[clang] 9988ab3 - [clang][NFC] Typo fixes. Test commit.

Author: Justas Janickas Date: 2021-08-02T13:25:08+01:00 New Revision: 9988ab3989a2e2e9cde3cc1ab4d7a44a87dee393 URL: https://github.com/llvm/llvm-project/commit/9988ab3989a2e2e9cde3cc1ab4d7a44a87dee393 DIFF: https://github.com/llvm/llvm-project/commit/9988ab3989a2e2e9cde3cc1ab4d7a44a87dee393.dif

[PATCH] D107267: [clang-format] don't break between function and function name in JS

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The commit https://github.com/llvm/llvm-project/commit/58494c856a15f5b0e886c7baf5d505ac6c05dfe5 updated detection of function declaration names. It had

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

aaron.ballman added a comment. In D107125#2917668 , @lunasorcery wrote: > Sure thing - would the suite in /clang/test/SemaCXX/ be the right place to > put that? Yeah, that'd be a great place for it. Thank you! Repository: rG LLVM Github Monorepo C

[PATCH] D107073: [analyzer] Disable direct binding from list initialization for constant arrays of local storage duration.

ASDenysPetrov updated this revision to Diff 363454. ASDenysPetrov added a comment. Fixed clang-tidy complaints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107073/new/ https://reviews.llvm.org/D107073 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/initia

[PATCH] D107269: [clan-format] detect function definitions more conservatively

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D105964 updated the detection of function definitions. It had the unfortunate effect to start marking object definitions with

[clang] b13fc73 - [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode.

Author: Justas Janickas Date: 2021-08-02T14:10:15+01:00 New Revision: b13fc7311eabca27b3baea99b7be6edef0213406 URL: https://github.com/llvm/llvm-project/commit/b13fc7311eabca27b3baea99b7be6edef0213406 DIFF: https://github.com/llvm/llvm-project/commit/b13fc7311eabca27b3baea99b7be6edef0213406.dif

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

This revision was automatically updated to reflect the committed changes. Topotuna marked an inline comment as done. Closed by commit rGb13fc7311eab: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode. (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGE

[clang] 12dc13b - prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

Author: Hans Wennborg Date: 2021-08-02T15:16:04+02:00 New Revision: 12dc13b73cf8c11da1bcc354c78bd6a9c92408e8 URL: https://github.com/llvm/llvm-project/commit/12dc13b73cf8c11da1bcc354c78bd6a9c92408e8 DIFF: https://github.com/llvm/llvm-project/commit/12dc13b73cf8c11da1bcc354c78bd6a9c92408e8.diff

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12dc13b73cf8: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124) (authored by hans). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

tstellar added a comment. @mstorsjo Yes, go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

tstellar added a comment. This is something we could merge, just need a code owner ack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353 ___ cfe-commits mailing li

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

tstellar added a comment. Do we have all the issues fixed in trunk yet or do we need to revert in the release/13.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. thanks @bsmith, just left one minor nit but otherwise LGTM Comment at: clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c:10 typedef svint32_t fixed_int32_t __attribute_

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. After the last refactor, I think this patch is mostly ready. This patch strips most of the ABI and _Float16 type related code from D105263 , which can be leaving with only AVX512-FP16 ISA enabling code. I think it should be more friendly

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall created this revision. sammccall added reviewers: kadircet, rsmith. Herald added a subscriber: usaxena95. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This more precise type is useful for tools, e.g. fix

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall added a comment. @rsmith: we have two open questions here... --- 1: Expressions whose types are no longer dependent. In the rare case where RHS is type-dependent and LHS is a known pointer, e.g. template int access(int *arr, Idx i) { return arr[i]; } we're now changing th

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/math.h:53 +#pragma omp begin declare variant match(device = {arch(amdgcn)}) + +#define __OPENMP_AMDGCN__ That's quite worrying. Declare variant match amdgcn is supposed to have t

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

pengfei added a comment. @jyu2, Thanks for the detailed information. > Besides, if we change "=rm" to "=r" > or "=m", GCC and ICC will report error differently. Which gives me an > impression that the use of constraint is undefined behavior. > To me it is defined behavior. Or I may missing some t

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield accepted this revision. JonChesterfield added a comment. Latest patch can only misfire on amdgpu so lets go with it and try to work out variant vs ifdef subsequently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https:

[clang] 713a5d1 - [OpenMP][AMDGCN] Initial math headers support

Author: Pushpinder Singh Date: 2021-08-02T14:38:52Z New Revision: 713a5d12cde58a5dff90cc3e2d1e67c2a78fe52f URL: https://github.com/llvm/llvm-project/commit/713a5d12cde58a5dff90cc3e2d1e67c2a78fe52f DIFF: https://github.com/llvm/llvm-project/commit/713a5d12cde58a5dff90cc3e2d1e67c2a78fe52f.diff L

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG713a5d12cde5: [OpenMP][AMDGCN] Initial math headers support (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:1839-1840 StringRef getString() const { -assert(getCharByteWidth() == 1 && - "This function is used in places that assume strings use char"); +assert(isUnevaluated() || +

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. > No matter what happens during analysis, as of now, the NoteTag message is > unambiguous at the point of the tags construction. The stream error state is designed to store a "superposition" of different error states. This is part of `evalFseek`: StateFailed = State

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. > Do we ever intend to create a warning for FERROR? Probably not (but there may be some not yet modeled stream operation where this may be useful.). This is when FERROR is set but not the indeterminate position. It indicates that the last operation failed but it is OK

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. > Will there ever be a way to get rid of the indeterminate position indicator > tag? Currently the `fseek` can reset this flag, and the `freopen` is another case for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1062

[PATCH] D107267: [clang-format] don't break between function and function name in JS

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107267/new/ https://reviews.llvm.org/D107267 ___

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song updated this revision to Diff 363480. yonghong-song edited the summary of this revision. yonghong-song added a comment. address Aaron and Andrii's comments: - warned and ignored if a btf_tag attribute is added to record forward declaration. - warned and ignored if a btf_tag attribu

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:95-96 + case '?': + case 'n': + case 't': +return true; aaron.ballman wrote: > Do you intend to miss a bunch of escapes like `\'` and `\r` (etc)? \' is there. I am less sure about

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 ___ cfe-commits mailing list cfe-comm

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

frasercrmck added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:100 + Optional> + getVScaleRange(const LangOptions &LangOpts) const; + This clang-tidy warning needs satisfied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. In D92928#2913552 , @ASDenysPetrov wrote: > Or, we can find another symbiotic way. You can make changes the way without > painfull part of thinking about IE. And I will prepare the next patch > adjusting it. Thus, revisions w

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 363484. gandhi21299 added a comment. refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu c

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 363490. gandhi21299 marked 3 inline comments as done. gandhi21299 added a comment. generalizing the description of the remark for conversion into CAS loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10689

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, kadircet wrote: > dgoldman wrote: > > kadircet wr

[clang] 97bcafa - [analyzer] Add control flow arrows to the analyzer's HTML reports

Author: Valeriy Savchenko Date: 2021-08-02T19:15:00+03:00 New Revision: 97bcafa28deb95ad32f83fe339d78454d899ca1b URL: https://github.com/llvm/llvm-project/commit/97bcafa28deb95ad32f83fe339d78454d899ca1b DIFF: https://github.com/llvm/llvm-project/commit/97bcafa28deb95ad32f83fe339d78454d899ca1b.d

[clang] 9e02f58 - [analyzer] Highlight arrows for currently selected event

Author: Valeriy Savchenko Date: 2021-08-02T19:15:01+03:00 New Revision: 9e02f58780ab8734e5d27a0138bd477d18ae64a1 URL: https://github.com/llvm/llvm-project/commit/9e02f58780ab8734e5d27a0138bd477d18ae64a1 DIFF: https://github.com/llvm/llvm-project/commit/9e02f58780ab8734e5d27a0138bd477d18ae64a1.d

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97bcafa28deb: [analyzer] Add control flow arrows to the analyzer's HTML reports (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHA

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e02f58780ab: [analyzer] Highlight arrows for currently selected event (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ ht

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 363495. adamcz added a comment. ActOnInializerError instead of SetInvalidDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2987 +if (ThisDecl) + ThisDecl->setInvalidDecl(); SkipUntil(tok::comma, StopAtSemi | StopBeforeMatch); hokein wrote: > it seems to me calling `Sema::ActOnInitiali

[libunwind] d6d0b65 - unwind: repair register restoration for OR1K

Author: Saleem Abdulrasool Date: 2021-08-02T16:36:37Z New Revision: d6d0b6559e97a3d0b258814e870d3e19f3a7ffcc URL: https://github.com/llvm/llvm-project/commit/d6d0b6559e97a3d0b258814e870d3e19f3a7ffcc DIFF: https://github.com/llvm/llvm-project/commit/d6d0b6559e97a3d0b258814e870d3e19f3a7ffcc.diff

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd added inline comments. Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck created this revision. frasercrmck added reviewers: craig.topper, rogfer01, HsiangKai, evandro, arcbbb, khchen. Herald added subscribers: vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, j

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tokens don't currently have a way to track their source-based spelling, which makes implementing some warnings difficult.

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

frasercrmck added a comment. In D106939#2915784 , @HsiangKai wrote: > In D106939#2915134 , @HsiangKai > wrote: > >> In D106939#2912807 , @frasercrmck >> wrote: >> >>> LG

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Although the alternative tokens `bitand` and `and` _can_ respectively be used in place of `&` and `&&` for declarations,

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2919077 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/43180/step_8.txt > > "The command line is too long" Maybe some arts could be passed via a response > file instead? Hi @thakis : Thank you.

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++'s alternative tokens are a good way to improve readability and minimise bugs by expressing intention using words inst

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added inline comments. Comment at: clang/test/Parser/warn-declare-references-with-symbols.cpp:2 +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -Wdeclare-references-with-symbols -verify %s + I'm pretty co

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

aaron.ballman added a comment. The usual community viewpoint on off-by-default diagnostics is that they're generally low value and not something that users will manually enable. Because I don't think this will ever be reasonable to enable by default due to it inherently being a matter of style,

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1552 + "use '%select{&|&&}0' when declaring %select{lvalue|rvalue and forwarding}1 references">, + InGroup>, DefaultWarn; + Pretty sure you don't need `DefaultWa

[PATCH] D107296: Treat inttypes.h as a built-in header

markrowe created this revision. markrowe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It wraps a system header. This allows the system module map to declare a module for it. https://bugs.llvm.org/show_bug.cgi?id=51307 Repository: rG

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

cor3ntin added a comment. A few questions, also for @aaron.ballman Can we have a "isDigraph" flag instead of keeping a pointer for the spelling? Do we maybe want to promote `and` etc to proper keywords and maybe add functions to check `isAndOrAmpAmp` ? so that we can in the future make `void f

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added a comment. @rsmith Ping again! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

aaron.ballman added a comment. You should always be able to go back to the token's spelling through the `SourceManager` object. Is there a reason why `SourceManager::getCharacterData()` is insufficient? I'm a bit worried about adding another pointer to `Token` because we sometimes store these i

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 363498. gandhi21299 added a comment. correction in the CUDA LIT check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-o

[clang] 635c5ba - [AMDGPU][HIP] Switch default DWARF version to 5

Author: Scott Linder Date: 2021-08-02T18:04:01Z New Revision: 635c5ba45baee5c6a8841fbac06f6868ddae5a6d URL: https://github.com/llvm/llvm-project/commit/635c5ba45baee5c6a8841fbac06f6868ddae5a6d DIFF: https://github.com/llvm/llvm-project/commit/635c5ba45baee5c6a8841fbac06f6868ddae5a6d.diff LOG:

[PATCH] D107190: [AMDGPU][HIP] Switch default DWARF version to 5

This revision was automatically updated to reflect the committed changes. Closed by commit rG635c5ba45bae: [AMDGPU][HIP] Switch default DWARF version to 5 (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107190/new/ https://

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

cjdb added a comment. In D107294#2920355 , @aaron.ballman wrote: > The usual community viewpoint on off-by-default diagnostics is that they're > generally low value and not something that users will manually enable. I was under the impression many warn

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

thakis added a comment. In D86671#2920294 , @dougpuob wrote: > In D86671#2919077 , @thakis wrote: > >> This breaks tests on windows: http://45.33.8.238/win/43180/step_8.txt >> >> "The command line is too long" Maybe

[PATCH] D107291: [clang][lexer] adds a way for tokens to track their physical spelling

cjdb abandoned this revision. cjdb added a comment. In D107291#2920408 , @aaron.ballman wrote: > You should always be able to go back to the token's spelling through the > `SourceManager` object. Is there a reason why > `SourceManager::getCharacterData

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5847-5849 +constexpr int AmpAmp = 1; +Diag(Loc, diag::warn_declare_references_with_symbols) +<< AmpAmp << AmpAmp; aaron.ballman wrote: > For consistency with the `Lv

[PATCH] D106614: [Clang] add btf_tag attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2019 +targets. This attribute may be attached to a struct/union, struct/union field, +function, function argument or variables declaration. If -g is specified, +the ``ARGUMENT`` info will be pr

[PATCH] D107294: [clang] adds warning to suggest users replace symbols with alt tokens

aaron.ballman added a comment. In D107294#2920477 , @cjdb wrote: > In D107294#2920355 , @aaron.ballman > wrote: > >> The usual community viewpoint on off-by-default diagnostics is that they're >> generally low v

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a subscriber: rsmith. awarzynski added a comment. In D99353#2919774 , @tstellar wrote: > This is something we could merge, just need a code owner ack. Let me add @rsmith as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5847-5849 +constexpr int AmpAmp = 1; +Diag(Loc, diag::warn_declare_references_with_symbols) +<< AmpAmp << AmpAmp; cjdb wrote: > aaron.ballman wrote: > > For

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 363534. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

cor3ntin added a comment. @Quuxplusone Are you happy with the fix? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 ___ cfe-commits mailing list cfe-commi

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

jyu2 added a comment. First I did not say "code doesn't make much sense to me". This is copy form your description. Okay, thank for explanation. So if I understand right, both gcc and icc generated code is not making sense to you. So instead, you want clang give error for this when output

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

jyu2 updated this revision to Diff 363538. jyu2 added a comment. Fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107200/new/ https://reviews.llvm.org/D107200 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_f

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aeubanks added a comment. you can reopen the revision via "Add Action..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-commits

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

dblaikie accepted this revision. dblaikie added a comment. Sounds good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107155/new/ https://reviews.llvm.org/D107155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363542. AMDChirag added a comment. minor fix in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cp

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz added a reviewer: lattner. beanz added a subscriber: lattner. beanz added a comment. +@lattner, Chris provided some post-commit feedback on the macro deprecation patch, I'll address his feedback here since I'm touching the same code. Chris' feedback is: > /clang/lib/Lex/Preprocessor.cpp:

  1   2   >