aaron.ballman added a comment.

You should always be able to go back to the token's spelling through the 
`SourceManager` object. Is there a reason why 
`SourceManager::getCharacterData()` is insufficient? I'm a bit worried about 
adding another pointer to `Token` because we sometimes store these in 
containers (like we do for cached tokens), so the overhead might be noticeable 
(or it might not, I don't know).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107291/new/

https://reviews.llvm.org/D107291

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to