[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mo

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet updated this revision to Diff 360835. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ https://reviews.llvm.org/D106527 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/

[clang] b88a68c - [OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has too few arguments.

Author: Alexey Bataev Date: 2021-07-22T08:44:37-07:00 New Revision: b88a68c45e1bd065d75d5173167e7a978ea0f0f2 URL: https://github.com/llvm/llvm-project/commit/b88a68c45e1bd065d75d5173167e7a978ea0f0f2 DIFF: https://github.com/llvm/llvm-project/commit/b88a68c45e1bd065d75d5173167e7a978ea0f0f2.diff

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 360840. cor3ntin added a comment. It turns out that explicit was doing the right thing (as outlined in P1401 ), but noexcept was not. I've reworked the handling of noexcept so that noexcept and explicit specifier use the same

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng marked 2 inline comments as done. kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:460 + +addExtension("e"); + } khchen wrote: > nit: add `break;` to avoid the implicit-fallthrough warning. Oh, thanks, it seems like

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 360842. kito-cheng marked an inline comment as done. kito-cheng added a comment. Changes: - Address @khchen's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105

[clang] b510e01 - [OpenCL][NFC] Refactors lang version check in test.

Author: Anastasia Stulova Date: 2021-07-22T16:47:38+01:00 New Revision: b510e0127da38d47b9224b082842e827c04947a8 URL: https://github.com/llvm/llvm-project/commit/b510e0127da38d47b9224b082842e827c04947a8 DIFF: https://github.com/llvm/llvm-project/commit/b510e0127da38d47b9224b082842e827c04947a8.d

[PATCH] D106254: [OpenCL][NFC] Refactors conditional versioning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb510e0127da3: [OpenCL][NFC] Refactors lang version check in test. (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/D1062

[clang] 26ea4a4 - [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

Author: Victor Huang Date: 2021-07-22T10:48:46-05:00 New Revision: 26ea4a4432431ce581e46746fa93981ad7f891d0 URL: https://github.com/llvm/llvm-project/commit/26ea4a4432431ce581e46746fa93981ad7f891d0 DIFF: https://github.com/llvm/llvm-project/commit/26ea4a4432431ce581e46746fa93981ad7f891d0.diff

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:5638 ImplicitConversionSequence ICS = - CCE == Sema::CCEK_ExplicitBool - ? TryContextuallyConvertToBool(S, From) - : TryCopyInitialization(S, From, T, -

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. NeHuang marked an inline comment as done. Closed by commit rG26ea4a443243: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility (authored by NeHua

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:680 foreach type = TypeList in { -foreach eew_list = EEWList in { +foreach eew_list = Xlen32EEWList in { defvar eew = eew_list[0]; There is no

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360855. dgoldman marked 3 inline comments as done. dgoldman added a comment. Rebase and remove TextMark files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files:

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. Removed the TextMarks file, just need to swap over how the insertions are done Comment at: clang-tools-extra/clangd/TextMarks.h:45 + : SM(SM), Out(Out) {} + void PragmaMark(SourceLocation Loc, StringRef Trivia) override { +if (isInsideMainFil

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:40 + +static const StringRef AllStdExts = "mafdqlcbjtpvn"; + Make this `static constexpr StringLiteral AllStdExts = "mafdqlcbjtpvn";` Comment at: llvm/lib/Support

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

lattner added a comment. > @lattner, thanks for the help. In this case, the real question is whether > there's any use case for !srcloc that involves writing it out into a bitcode > or IR file and then having a separate instance of clang load it back in again. > I think that no such case can

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaron.ballman added a comment. In D101566#2892163 , @aaronpuchert wrote: > Let's add @aaron.ballman to get a third opinion. The discussion is meandering > a bit, but you should understand the gist from the first comments or the bug > report. The questi

[PATCH] D106509: [OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)

jdenny added a comment. Thanks for the reviews. In D106509#2896351 , @ABataev wrote: > That's strange that we need to ignore `delete` modifier, It's not ignored in general: the standard (dynamic) OpenMP reference count is set to 0 (if it isn't already)

[PATCH] D106509: [OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)

jdoerfert added a comment. > That's fine for me, but don't the routines use llvm_omp_? That was before we "standardized" `ompx_` for OpenMP 5.2. > Should we also have that prefix in various enumerators in the implementation? > For example, what does OMP_MAP_HOLD become? I'd suggest `OMPX_MAP_H

[PATCH] D106571: [HIP] Fix visibility of __hip_fatbin

yaxunl created this revision. yaxunl added reviewers: tra, ashi1, scchan. yaxunl requested review of this revision. In -fgpu-rdc case, fat binary is embedded as global variable __hip_fatbin. It needs to have protected visibility to avoid conflict between shared libraries. https://reviews.llvm.or

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Do you build with assertions enabled? In D105703#2896056 , @fmayer wrote: > Sorry. broke a buildbot again: > https://lab.llvm.org/buildbot/#/builders/139/builds/7613/steps/6/logs/FAIL__Clang__asan_c > > I am not sure why I ca

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:414 INITIALIZE_PASS_BEGIN( HWAddressSanitizerLegacyPass, "hwasan", To fix that revert you need to add INITIALIZE_PASS_DEPENDENCY(StackSafetyGlobalIn

[PATCH] D106509: [OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)

jdenny added a comment. In D106509#2896956 , @jdoerfert wrote: >> That's fine for me, but don't the routines use llvm_omp_? > > That was before we "standardized" `ompx_` for OpenMP 5.2. Ah. Thanks. >> Should we also have that prefix in various enumerat

[PATCH] D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

flx updated this revision to Diff 360865. flx added a comment. Add test file for the new option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106173/new/ https://reviews.llvm.org/D106173 Files: clang-tools-extra/clang-tidy/performance/Unnecessa

[PATCH] D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

flx marked an inline comment as done. flx added a comment. I also added a file testing the new option. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst:53 + + A semicolon-separated list of names of types whose methods are n

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. > the following code doesn't emit any warnings This code doesn't seem to have any `unique_ptr`s in it? It's not like you're modeling this custom class as well? Can you try the same with the actual `unique_ptr`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

jrtc27 added inline comments. Comment at: clang/test/Driver/riscv-abi.c:68 -// RUN: %clang -target riscv64-unknown-elf %s -### -o %t.o -march=rv64d -mabi=lp64d 2>&1 \ +// RUN: %clang -target riscv64-unknown-elf %s -### -o %t.o -march=rv64ifd -mabi=lp64d 2>&1 \ // RUN: | Fi

[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

flx updated this revision to Diff 360868. flx added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106011/new/ https://reviews.llvm.org/D106011 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyI

[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:178-183 + if (VarTmplType->getReplacedParameter()->desugar().getCanonicalType() != + InitializerTmplType->getReplacedParameter() + ->desug

[clang] 2542c1a - [clang][driver][darwin] Add driver support for Mac Catalyst

Author: Alex Lorenz Date: 2021-07-22T10:20:19-07:00 New Revision: 2542c1a5a1306398d73c3c0c5d71cacf7c690093 URL: https://github.com/llvm/llvm-project/commit/2542c1a5a1306398d73c3c0c5d71cacf7c690093 DIFF: https://github.com/llvm/llvm-project/commit/2542c1a5a1306398d73c3c0c5d71cacf7c690093.diff L

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2542c1a5a130: [clang][driver][darwin] Add driver support for Mac Catalyst (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil updated this revision to Diff 360875. necipfazil marked 2 inline comments as done. necipfazil added a comment. Fix lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105909/new/ https://reviews.llvm.org/D105909 Files: clang/lib/CodeGe

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil added a comment. @morehouse PTAL Comment at: llvm/include/llvm/IR/LLVMContext.h:97 OB_clang_arc_attachedcall = 6, // "clang.arc.attachedcall" +OB_type = 7, // "type" }; morehouse wrote: > Do we need to update `LLVMContex

[PATCH] D106571: [HIP] Fix visibility of __hip_fatbin

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106571/new/ https://reviews.llvm.org/D106571 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-features'.

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:835 +llvm::RISCVISAInfo::filterISAStrings(Features); +std::vector Ops; +if (Features.empty()) { Why is this building a list? Just use a string so it's in the same format as

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse added inline comments. Comment at: llvm/include/llvm/IR/LLVMContext.h:97 OB_clang_arc_attachedcall = 6, // "clang.arc.attachedcall" +OB_type = 7, // "type" }; necipfazil wrote: > morehouse wrote: > > Do we need to update `L

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

DylanFleming-arm updated this revision to Diff 360879. DylanFleming-arm added a comment. Removed changes to RiscV code Added check that target isAArch64 before adding default value vscale_range attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-features'.

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/riscv-isa-features.ll:1 +; RUN: llc -o - < %s | FileCheck %s +; -mattr option would overwrite target-feature and module flag riscv-isa-features Use update_llc_test_checks for these.

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-features'.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-metadata-isa-features-empty-target-feature.cpp:9 +// We need to record extension target-feature in riscv-isa-features module flag metadata because there is some empty target-features attribute +// CHECK: !

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha updated this revision to Diff 360886. SaurabhJha added a comment. Add documentation for matrix broadcast initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 Files: clang/docs/Matri

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

stuartellis updated this revision to Diff 360887. stuartellis added a comment. Address review comments Added some comments to a couple of places Added new `FLANG_PLUGIN_SUPPORT` CMake flag to control exporting executable symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

leonardchan added a comment. Hi. I think this patch may have led to the test failure we're seeing on our clang builders (https://luci-milo.appspot.com/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8840986998954824016): Command Output (stderr): -- /b/s/w/ir/x/w/llvm-project/clang/test/D

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin created this revision. Herald added subscribers: s.egerton, simoncook, dschuff. cor3ntin requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Both C and C++ standard suggest that the macro __STDC_ISO_10646__ should be defined w

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

stuartellis marked 9 inline comments as done. stuartellis added inline comments. Comment at: flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:92 +unsigned diagID = ci.diagnostics().getCustomDiagID( +clang::DiagnosticsEngine::Error, "unable to find plugin '%0'"); +

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

arphaman added a comment. In D105960#2897245 , @leonardchan wrote: > Hi. I think this patch may have led to the test failure we're seeing on our > clang builders > (https://luci-milo.appspot.com/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b88409869

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

arphaman added a comment. I think this should be fixed if I add `-fuse-ld=` to the invocation. Let me commit that fix to see if it's fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://reviews.llvm.org/D105960 ___

[clang] 40d2d0c - [clang][test] Add -fuse-ld= to test case added in 2542c1a5a130 to resolve test failure with CLANG_DEFAULT_LINKER=lld

Author: Alex Lorenz Date: 2021-07-22T11:12:38-07:00 New Revision: 40d2d0c41298f1d8a178216e2534b29e3128cf37 URL: https://github.com/llvm/llvm-project/commit/40d2d0c41298f1d8a178216e2534b29e3128cf37 DIFF: https://github.com/llvm/llvm-project/commit/40d2d0c41298f1d8a178216e2534b29e3128cf37.diff L

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

arphaman added a comment. I think this should be fixed in 40d2d0c41298f1d8a178216e2534b29e3128cf37 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://reviews.llv

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added reviewers: aaron.ballman, rsmith, jyknight. aaron.ballman added a comment. Can you also add a test that explicitly uses `-fshort-wchar` to verify that we don't predefine the macro? Comment at: clang/lib/Frontend/InitPreprocessor.cpp:430-435 + // Because Cl

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

leonardchan added a comment. In D105960#2897310 , @arphaman wrote: > I think this should be fixed in 40d2d0c41298f1d8a178216e2534b29e3128cf37 > . Thanks. Confirmed the test passes loca

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. Looks good, could you also add a note in the relasenotes.rst? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:507 +CurFn->addFnAttr( +llvm::Attribute::getWithVScaleRangeArgs(getLLVMContext(), 0, 16)); } Thinking about this more, maybe these values should be returned from

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

anjankgk added a comment. Since Hubert is busy, I have requested Shimin to commit this in. Thanks Shimin! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106371/new/ https://reviews.llvm.org/D106371 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

anjankgk added a comment. Since Whitny and Chris are busy, I have requested Shimin to commit this in. Thanks Shimin! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106074/new/ https://reviews.llvm.org/D106074 ___ cfe-commits mailing list cfe-c

[clang] 178c2b4 - Correctly diagnose taking the address of a register variable in C

Author: Aaron Ballman Date: 2021-07-22T14:53:23-04:00 New Revision: 178c2b4c1eb12b2153adb384ac7f22a8791edc86 URL: https://github.com/llvm/llvm-project/commit/178c2b4c1eb12b2153adb384ac7f22a8791edc86 DIFF: https://github.com/llvm/llvm-project/commit/178c2b4c1eb12b2153adb384ac7f22a8791edc86.diff

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2897312 , @aaron.ballman wrote: > Can you also add a test that explicitly uses `-fshort-wchar` to verify that > we don't predefine the macro? There is one already! (init.c L288) Comment at: clang

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin updated this revision to Diff 360914. cor3ntin added a comment. Remove braces, improve comment (Thanks Aaron) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106577/new/ https://reviews.llvm.org/D106577 Files: clang/lib/Basic/Targets/OSTa

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 +if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); probinson wrote: > No... you want to chec

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360918. akhuang added a comment. Remove fno-use-ctor-homing flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: clang/include/clang/Basic/DebugInfoOptions.h

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D106577#2897450 , @cor3ntin wrote: > In D106577#2897312 , @aaron.ballman > wrote: > >> Can

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. David wrote: > think what I'm missing here: If -fno-standalone-debug is already in use/the > default and is causing missing types because parts of the program are bulit > without debug info, then I'm not sure what the rationale is for slicing > -fstandalone-debug into a

[clang-tools-extra] 00edae9 - [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

Author: Felix Berger Date: 2021-07-22T15:17:24-04:00 New Revision: 00edae9203c9a4f50da058d4bd25dc2e6a4930c1 URL: https://github.com/llvm/llvm-project/commit/00edae9203c9a4f50da058d4bd25dc2e6a4930c1 DIFF: https://github.com/llvm/llvm-project/commit/00edae9203c9a4f50da058d4bd25dc2e6a4930c1.diff

[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00edae9203c9: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. I'm not sure we should be populating this. The _value_ is determined by what libc supports, so it probably needs to be left up to libc to define it. In glibc, this define is set by the file /usr/include/stdc-predef.h, which GCC implicitly includes into all TUs whether

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang created this revision. akhuang added reviewers: dblaikie, probinson. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an opt out flag for constructor homing. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without debug

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang updated this revision to Diff 360926. akhuang added a comment. Herald added a subscriber: dang. add actual flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106582/new/ https://reviews.llvm.org/D106582 Files: clang/docs/UsersManual.rst

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko created this revision. ivanmurashko added reviewers: rsmith, DmitryPolukhin. ivanmurashko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a SIGSEGV at DeduceTemplateArgumentsByTypeMatch. See BUG description and reprod

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf719dff04396: [AIX] Clang's library integration support for 128-bit long double is incomplete… (authored by anjankgk, committed by scui). Repositor

[clang] f719dff - [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

Author: Anjan Kumar Guttahalli Krishna Date: 2021-07-22T15:32:48-04:00 New Revision: f719dff043962832f221dd8e28af2344a0ab80e0 URL: https://github.com/llvm/llvm-project/commit/f719dff043962832f221dd8e28af2344a0ab80e0 DIFF: https://github.com/llvm/llvm-project/commit/f719dff043962832f221dd8e28af2

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#2897522 , @jyknight wrote: > I'm not sure we should be populating this. > > The _value_ is determined by what libc supports, so it probably needs to be > left up to libc to define it. Why is the value determined

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without debug

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright to me. (bit awkward having a documented cc1 option - since the cc1 options aren't meant to be user facing - hadn't really thought about/noticed that when reviewing the docume

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

erichkeane added a comment. This seems appropriate of a fix, but it needs a lit test. I'm not particularly sure I know the repercussions of this patch, however perhaps that would help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ htt

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk created this revision. rnk added reviewers: mizvekov, dblaikie, MaskRay. Herald added subscribers: dexonsmith, hiraditya. rnk requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. DIEnumerator stores an APInt as of April 2020, so now we

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d669ec1: [AIX] Generate large code model relocations when mcmodel=medium on AIX (authored by anjankgk, committed by hubert.reinterpretcast). R

[clang] 7d669e6 - [AIX] Generate large code model relocations when mcmodel=medium on AIX

Author: Anjan Kumar Guttahalli Krishna Date: 2021-07-22T15:47:22-04:00 New Revision: 7d669ec1d67c1b4aecd90687013636d8037c URL: https://github.com/llvm/llvm-project/commit/7d669ec1d67c1b4aecd90687013636d8037c DIFF: https://github.com/llvm/llvm-project/commit/7d669ec1d67c1b4aecd906870

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

rnk added subscribers: dblaikie, MaskRay, LemonBoy. rnk added a comment. I decided it would be faster and more convenient to respond in the form of a code review for clang, so here it is: D106585 Assuming that goes through, go ahead and rebase onto that after i

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2897588 , @aaron.ballman wrote: > In D106577#2897522 , @jyknight > wrote: > >> I'm not sure we should be populating this. >> >> The _value_ is determined by what libc support

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a comment. In D106582#2897599 , @dblaikie wrote: > Looks alright to me. (bit awkward having a documented cc1 option - since the > cc1 options aren't meant to be user facing - hadn't really thought > about/noticed that when reviewing the do

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. In D106577#2897588 , @aaron.ballman wrote: > In D106577#2897522 , @jyknight > wrote: > >> I'm not sure we should be populating this. >> >> The _value_ is determined by what libc support

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

aaron.ballman added a comment. Pragmas and magic comments both have ergonomic issues, so it's really about the tradeoffs. Personally, I think it's more reasonable to support this as a pragma than as a magic-comment. Pragmas are a mystery to users, but they're less of a mystery than comments tha

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil updated this revision to Diff 360942. necipfazil added a comment. Verify type operand bundle usage - Check if type operand bundle id is drifted - Verify and complain if multiple type operand bundles are used - Add type operand bundle test to operand bundle verifier tests Repository:

[clang] 1b52e9b - [AIX] Define __LONGDOUBLE64 macro

Author: Jake Egan Date: 2021-07-22T16:05:14-04:00 New Revision: 1b52e9bac207cd4bdcd9091178527aa39049c270 URL: https://github.com/llvm/llvm-project/commit/1b52e9bac207cd4bdcd9091178527aa39049c270 DIFF: https://github.com/llvm/llvm-project/commit/1b52e9bac207cd4bdcd9091178527aa39049c270.diff LOG

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b52e9bac207: [AIX] Define __LONGDOUBLE64 macro (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105477/new/ https://reviews.llvm.org/

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil marked an inline comment as done. necipfazil added inline comments. Comment at: llvm/include/llvm/IR/LLVMContext.h:97 OB_clang_arc_attachedcall = 6, // "clang.arc.attachedcall" +OB_type = 7, // "type" }; morehouse wrote: >

[clang] 46667a1 - [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

Author: Paulo Matos Date: 2021-07-22T22:07:24+02:00 New Revision: 46667a10039b664b953eb70534c27627b35a267d URL: https://github.com/llvm/llvm-project/commit/46667a10039b664b953eb70534c27627b35a267d DIFF: https://github.com/llvm/llvm-project/commit/46667a10039b664b953eb70534c27627b35a267d.diff L

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46667a10039b: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR (authored by pmatos). Changed prior to commit: https://review

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko added a comment. @erichkeane, is it OK if the reproducer will be added as the LIT test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.llvm.org/D106583 ___ cfe-com

[PATCH] D106585: Fix clang debug info irgen of i128 enums

mizvekov added a comment. Small nit but otherwise LGTM :) Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3118 +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); } Comment at: ll

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

dblaikie added a comment. In D106582#2897678 , @akhuang wrote: > In D106582#2897599 , @dblaikie > wrote: > >> Looks alright to me. (bit awkward having a documented cc1 option - since the >> cc1 options aren't me

[clang-tools-extra] cb4c12b - [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

Author: Felix Berger Date: 2021-07-22T16:20:20-04:00 New Revision: cb4c12b6117a6f2989d5745854a94c75cb6a09ba URL: https://github.com/llvm/llvm-project/commit/cb4c12b6117a6f2989d5745854a94c75cb6a09ba DIFF: https://github.com/llvm/llvm-project/commit/cb4c12b6117a6f2989d5745854a94c75cb6a09ba.diff

[PATCH] D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

This revision was automatically updated to reflect the committed changes. flx marked an inline comment as done. Closed by commit rGcb4c12b6117a: [clang-tidy] performance-unnecessary-copy-initialization: Create option to… (authored by flx). Changed prior to commit: https://reviews.llvm.org/D106

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2896091 , @aaron.ballman wrote: > I think there is, but I'm an eternal optimist. :-) This LGTM, but you should > wait a day or two before landing it in case @dblaikie or @rsmith have > concerns. Of course. ===

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); Is the value already

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. Thanks for the first pass @aaron.ballman! Some clarifying questions, but I think I have enough of your other comments to work on while you ponder these. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:303 InGroup>; +def pp_pragma_include_in

[PATCH] D105876: OMPIRBuilder for Interop directive

jdoerfert added a comment. you need to squash your commits locally and update this revision with a single commit/diff. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6323-6327 + if (S.hasClausesOfKind() && + !(S.getSingleClause() || +S.getSingleClause() || +

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

erichkeane added a comment. In D106583#2897783 , @ivanmurashko wrote: > @erichkeane, is it OK if the reproducer be added as the LIT test? That is a typical mechanism way to go, but that reproducer is a little long. You should hopefully be able to simp

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb marked 2 inline comments as done. cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:307-310 +def pp_pragma_include_instead_unexpected_token : Warning< + "'#pragma include_instead' expects '%0' as its next token; got '%1' instead">, +

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: MaskRay. mibintc added a comment. More info about the test failure I'm seeing for clang/test/Index/preamble-reparse-changed-module.m It appears it might be a non-deterministic failure, perhaps some test dependencies are missing? Yesterday before I pushed my clang pa

<    1   2   3   >