[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

[Felix Berger via Phabricator via cfe-commits]

flx added inline comments.


================
Comment at: 
clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:178-183
+      if (VarTmplType->getReplacedParameter()->desugar().getCanonicalType() !=
+          InitializerTmplType->getReplacedParameter()
+              ->desugar()
+              .getCanonicalType()) {
+        return true;
+      }
----------------
ymandel wrote:
> nit: maybe just return the condition (instead of using if(...) return true)? 
> that is
> return VarTmpType->... != ...
Done. Was left over from when there were debug statements there ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106011/new/

https://reviews.llvm.org/D106011

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits