[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 358631. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmtOpe

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

nridge added a comment. Herald added a project: clang-tools-extra. I wonder, should these instructions be in an easier-to-find place, such as the clangd repo's own README (https://github.com/clangd/clangd/blob/master/README.md), or even a section of the clangd website (clangd.llvm.org)? I want

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp updated this revision to Diff 358637. quinnp added a comment. Removing a misleading comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/Co

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp updated this revision to Diff 358639. quinnp added a comment. Removing another comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:879-889 + // TODO: There are way too many flags that change this. Do we need to check + // them all? + bool DAZ = DriverArgs.hasArg(options::OPT_cl_denorms_are_zero) || + getD

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

bjope added a comment. I think you can create an upstream test case by looking at `clang/test/Analysis/ptr.cl`. It uses amdgcn and address space 256, which seems to have a different pointer size compared to address space zero for that specific target. So the test case (named with a .cl extensio

[PATCH] D105493: [clang] Change set type used for SourceLocation.

miyuki added inline comments. Comment at: clang/include/clang/Basic/SourceLocation.h:19 #include "llvm/ADT/StringRef.h" #include "llvm/Support/PointerLikeTypeTraits.h" #include Can this `#include` be removed? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, mibintc, jyknight, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. Clang implemented the _ExtInt datatype as a bit-precise integer type, which was then proposed to WG1

[PATCH] D105997: Implement _ExtInt conversion rules

erichkeane added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-erro

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

erichkeane added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-erro

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:879-889 + // TODO: There are way too many flags that change this. Do we need to check + // them all? + bool DAZ = DriverArgs.hasArg(options::OPT_cl_denorms_are_zero) || + getDefaultDen

[PATCH] D101441: Update libstdc++ hack comment

mizvekov added a comment. Here are my findings around this issue: https://godbolt.org/z/TE9rdxae8 So GCC started parsing this correctly from 9.4 to 10.1. It does not look like they have a workaround for their own older libstdc++. It seems to me this HACK is ready for removal. Is there something

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

NoQ added a comment. I think this is a plausible use case, previously I thought it's too much work but it seems reasonable last time I looked into it, so I'm glad to see it going on! Can you add a comment explaining that the new code is necessary for architectures with varying pointer bit widt

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

NoQ added a comment. We could color the special ==/!= 50% gray and/or replace it with a non-programming symbol such as ≃ and ≄. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104917/new/ https://reviews.llvm.org/D104917 ___

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637 _

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 358656. ASDenysPetrov added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h clang/lib/Stat

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831 +// 64bit version of popcntb for 64bit sized unsigned long. +let isCodeGenOnly = 1 in +def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), efriedma wrote: > I'

[PATCH] D101441: Update libstdc++ hack comment

urnathan added a comment. In D101441#2877463 , @mizvekov wrote: > > It seems to me this HACK is ready for removal. Is there something else I > might be missing? we want to support all the way back to gcc 4.8.3, IIRC that's the version in CentOS $SO

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; vsavchenko wrote: > ASDenysPetrov

[PATCH] D105997: Implement _ExtInt conversion rules

rsmith added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-error{{i

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov updated this revision to Diff 358661. ASDenysPetrov added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/APSIntType.h clang/include/clang/Stati

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman updated this revision to Diff 358663. aaron.ballman added a comment. Added more test coverage in C for conversion type results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; ASDenysPetrov wrote: > vsavchenko wr

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. I wanted to address your other points so we at least can be aligned as I respect your opinion. > I'm however even more wary of adding yet another tool that will be almost the > same as clang-format. Also agreed, but I see no other way forward. > It could work i

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

It would probably be better to make the config option names for passes that may mutate whitespace be prefixed with MaybeIncorrect than fork the tool. Scary options are better than forks. On Wed, Jul 14, 2021 at 6:42 PM MyDeveloperDay via Phabricator < revi...@reviews.llvm.org> wrote: > MyDevelope

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

efriedma added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831 +// 64bit version of popcntb for 64bit sized unsigned long. +let isCodeGenOnly = 1 in +def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), nemanjai wrote: > ef

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added a comment. Change LGTM, but I don't understand why the following tests are modified: - llvm/test/ThinLTO/X86/devirt2.ll - llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll - llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll Repository: rG LLVM

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

lei updated this revision to Diff 358665. lei added a comment. cleanup tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Targets/PP

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:879-889 + // TODO: There are way too many flags that change this. Do we need to check + // them all? + bool DAZ = DriverArgs.hasArg(options::OPT_cl_denorms_are_zero) || + getD

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

tlively updated this revision to Diff 358668. tlively marked 2 inline comments as done. tlively added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105950/new/ https://reviews.llvm.org/D105950 Files: clang/include/c

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:324 + PatFrag<(ops node:$ptr, node:$vec, node:$idx), + (vector_insert $vec, (i32 (extloadi8 $ptr)), $idx)>; +def load16_lane : aheejin wrote: > Why are i8 and

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added a comment. Thank you for working on this! We're testing the patch out internally to see if it solves issues for us with some of the failures we're seeing. Comment at: clang/lib/Sema/SemaStmt.cpp:3314 +return false; + const Decl *D = E.getReferencedDecl

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 358669. ASDenysPetrov added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h clang/include/clang/StaticAnalyze

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 358673. jamieschmeiser added a comment. Respond to review comments: create stub functions, return 0 from function and other fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers added a comment. Thanks all for the updates and comments. I'll address promptly and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please change `compact` in the title to `compat`. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:76-79 +BUILTIN(__builtin_ppc_mtfsb0, "vUi", "") +BUILTIN

[libunwind] 5099e01 - [runtimes] Inherit the TARGET_TRIPLE that may be set by LLVM

Author: Louis Dionne Date: 2021-07-14T14:29:29-04:00 New Revision: 5099e0156818665ae5381337f64ca68d659e0556 URL: https://github.com/llvm/llvm-project/commit/5099e0156818665ae5381337f64ca68d659e0556 DIFF: https://github.com/llvm/llvm-project/commit/5099e0156818665ae5381337f64ca68d659e0556.diff

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL co

[clang] 970e090 - [WebAssembly] Codegen for v128.loadX_lane instructions

Author: Thomas Lively Date: 2021-07-14T11:31:53-07:00 New Revision: 970e0900104d6f67a9c15fa9c913cf3eeba5d06a URL: https://github.com/llvm/llvm-project/commit/970e0900104d6f67a9c15fa9c913cf3eeba5d06a DIFF: https://github.com/llvm/llvm-project/commit/970e0900104d6f67a9c15fa9c913cf3eeba5d06a.diff

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG970e0900104d: [WebAssembly] Codegen for v128.loadX_lane instructions (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D105

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Other than missing llvm test is LGTM Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; fmayer wrote: > vitalybuka wrote: > > this patch mostly change code under

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831 +// 64bit version of popcntb for 64bit sized unsigned long. +let isCodeGenOnly = 1 in +def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), efriedma wrote: > ne

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha created this revision. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As part of https://bugs.llvm.org/show_bug.cgi?id=46251, this patch adds definition of matrix initialisation. I am not very familiar with this part

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

lei added a comment. please add sema checking for pwr8 builtins. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond.ll:80 +declare i32 @llvm.ppc.lharx(i8*) +define dso_local signext i16 @test_lharx(i16* %a) local_unnamed_addr #0 { +; CHECK-64-LAB

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 358685. ASDenysPetrov added a comment. Made`ignoreCast` non-virtual . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h clang/incl

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; vsavchenko wrote: > ASDenysPetrov

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov updated this revision to Diff 358689. kstoimenov added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105726/new/ https://reviews.llvm.org/D105726 Files: clang/docs/AddressSanitizer.rst clang/docs/Users

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 358690. jamieschmeiser added a comment. Respond to review comments: update comments and make functions not weak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/CGDeclCXX.c

[PATCH] D104420: thread_local support for AIX

jamieschmeiser added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2971 +isEmittedWithConstantInitializer(VD, true) && +!VD->needsDestruction(getContext())) { + // Emit a weak global function referring to the initialization function. --

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105726/new/ https://reviews.llvm.org/D105726 ___

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3314 +return false; + const Decl *D = E.getReferencedDeclOfCallee(); + if (!S.SourceMgr.isInSystemHeader(D->getLocation())) aaron.ballman wrote: > This can return `nullptr`, so we shoul

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

aaron.ballman added a comment. In D104601#2848366 , @Meinersbur wrote: > In D104601#2847400 , @aaron.ballman > wrote: > >> ... would add that it's very common for implementers to ask developers to >> run their

[libunwind] 850b57c - [runtimes] Bring back TARGET_TRIPLE

Author: Louis Dionne Date: 2021-07-14T15:15:22-04:00 New Revision: 850b57c5fbe7b44d18c9667bb31adfbe307453a6 URL: https://github.com/llvm/llvm-project/commit/850b57c5fbe7b44d18c9667bb31adfbe307453a6 DIFF: https://github.com/llvm/llvm-project/commit/850b57c5fbe7b44d18c9667bb31adfbe307453a6.diff

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

dexonsmith added a comment. Does this need an upgrade for old bitcode that has serialized 32-bit types? If not, can you explain why not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105491/new/ https://reviews.llvm.org/D105491 __

[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

HazardyKnusperkeks added a comment. This could be a way, but I will also state here that I prefer adding it to plain `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105943/new/ https://reviews.llvm.org/D105943 __

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3317-3321 + for (const DeclContext *DC = D->getDeclContext(); DC; DC = DC->getParent()) { +if (const auto *NS = dyn_cast(DC)) + if (NS->isStdNamespace()) +return true; + }

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2876916 , @MyDeveloperDay wrote: >> So yes, I'm in favour of landing this patch (though not exactly in the >> current form, I'd prefer more future-proof options for instance, not only >> handling const) > >

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

dexonsmith added a subscriber: aaron.ballman. dexonsmith added a comment. Thanks for splitting this out! It mostly looks good, just a few things inline. Comment at: clang/lib/Basic/DarwinSDKInfo.cpp:27-28 +return KV->getSecond(); + // If no exact entry found, try just the

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2877618 , @atomgalaxy wrote: > It would probably be better to make the config option names for passes that > may mutate whitespace be prefixed with MaybeIncorrect than fork the tool. > Scary options are better than

[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

MyDeveloperDay added a comment. In D105943#2877886 , @HazardyKnusperkeks wrote: > This could be a way, but I will also state here that I prefer adding it to > plain `clang-format`. I do too, and that is my preference, Perhaps this way we can establish

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 358702. mizvekov added a comment. - Small simplification to implementation, don't need to cast to NamespaceDecl. - Simplification to tests: Use some evil prep hackery to avoid needing multipe files. - Verify result of getReferencedDeclOfCallee is non-null.

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, assuming @aaron.ballman is happy! (a couple of optional nits inline) Comment at: clang/lib/Basic/DarwinSDKInfo.cpp:28 + // If no exact entry found, try just th

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie added a comment. In D105457#2876511 , @dyung wrote: > If it helps, I have so far been able to reduce the file to this which still > shows the failure when compiled with gcc 7.5: Could you provide the preprocessed input file - maybe that run thr

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! (Maybe leave a couple of days in case others have comments.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://rev

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

morehouse added a subscriber: MaskRay. morehouse added a comment. We should also tests for the new flags in clang/test/Driver/clang_f_opts.c. Comment at: clang/docs/CallGraphSection.rst:58 + +A type identifier may be repeated in different entries. The id value 0 is +reserved fo

[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, hokein. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This can happen when a template with two parameter types i

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added a comment. In D104058#2877631 , @nickdesaulniers wrote: > Change LGTM, but I don't understand why the following tests are modified: > > - llvm/test/ThinLTO/X86/devirt2.ll This is needed to fix two `missing symbol resolution` errors th

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 358717. jamieschmeiser added a comment. Remove accidental inclusion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenFunction.h c

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple cc1 jobs

jansvoboda11 updated this revision to Diff 358724. jansvoboda11 retitled this revision from "[clang][tooling] Accept Clang invocations with "-fno-integrated-as"" to "[clang][tooling] Accept Clang invocations with multiple cc1 jobs". jansvoboda11 edited the summary of this revision. jansvoboda11 a

[PATCH] D104536: WIP: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 updated this revision to Diff 358726. jansvoboda11 added a comment. Entirely disable `DepFS` when scanning PCHs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104536/new/ https://reviews.llvm.org/D104536 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorke

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In D105457#2877971 , @dblaikie wrote: > In D105457#2876511 , @dyung wrote: > >> If it helps, I have so far been able to reduce the file to this which still >> shows the failure when compile

[clang] ac500fd - [asan][clang] Add flag to outline instrumentation

Author: Kirill Stoimenov Date: 2021-07-14T13:36:34-07:00 New Revision: ac500fd18f0615c45d9d127bfb576ffa1e11425a URL: https://github.com/llvm/llvm-project/commit/ac500fd18f0615c45d9d127bfb576ffa1e11425a DIFF: https://github.com/llvm/llvm-project/commit/ac500fd18f0615c45d9d127bfb576ffa1e11425a.di

[PATCH] D105726: [asan][clang] Add flag to outline instrumentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac500fd18f06: [asan][clang] Add flag to outline instrumentation (authored by kstoimenov, committed by vitalybuka). Changed prior to commit: https:

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple cc1 jobs

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105695/new/ https://reviews.llvm.org/D105695 ___ cfe-commits mailing list cfe-

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In case it is useful, here is the full preprocessed file. F17936275: StmtPrinterTest.preproc.cpp.orig.gz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2068 +EmittedMDIdGeneralized = true; + } + This code also seems unnecessary as it puts metadata on function definitions. Comment at: clang/lib/CodeGen/CodeGen

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 358738. Conanap marked an inline comment as done. Conanap added a comment. Added more sema checking, test case update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. Thanks! I reduced it further to: template class function { public: template function(F) {} }; template void Foo(M, function = [](){}); void Bar() { Foo(42); Foo(42.0); } with gcc 7, this gives: /tmp/cccKjL8O.s: Assembler message

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. Making the default argument a non-lambda seems to be sufficient to avoid the error: template class function { public: template function(F) {} }; void DefaultFunc(); template void Foo(M, function = DefaultFunc); void Bar() { Foo(42);

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In D105457#2878292 , @nridge wrote: > Making the default argument a non-lambda seems to be sufficient to avoid the > error: > > template > class function { > public: > template > function(F) {} > }; > > void

[PATCH] D106019: [WebAssembly] Codegen for v128.storeX_lane instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge updated this revision to Diff 358750. nridge added a comment. Work around a gcc 7 bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 Files: clang/unittests/AST/ASTPrint.h clang/unittests/AST/D

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

morehouse added a subscriber: MaskRay. morehouse added a comment. Are comdats needed? Can we get proper dead stripping with just `SHF_LINK_ORDER`? @MaskRay recently updated the documentation for associated metadata to imply that our sym

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

nridge added a comment. In D105457#2878302 , @dyung wrote: > Interesting. If you can get me an updated patch, I can give it a try on my > machine with 7.5 to verify if you like. I posted an updated patch, if you can give that a whirl that would be great

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse added a comment. Also, have you looked into operand bundles instead of metadata? I don't know much about them, but they might help with the optimizations-dropping-metadata problem. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. T

[clang] 58494c8 - [clang-format] Make BreakAfterReturnType work with K&R C functions

Author: owenca Date: 2021-07-14T14:38:02-07:00 New Revision: 58494c856a15f5b0e886c7baf5d505ac6c05dfe5 URL: https://github.com/llvm/llvm-project/commit/58494c856a15f5b0e886c7baf5d505ac6c05dfe5 DIFF: https://github.com/llvm/llvm-project/commit/58494c856a15f5b0e886c7baf5d505ac6c05dfe5.diff LOG: [

[PATCH] D105964: [clang-format] Make AlwaysBreakAfterReturnType work with K&R C function definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58494c856a15: [clang-format] Make BreakAfterReturnType work with K&R C functions (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358760. ZarkoCA added a comment. - Add more RUN lines to test - change `if` condition to be one line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files: clang/in

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra marked an inline comment as done. tra added inline comments. Comment at: clang/test/CodeGen/builtins-nvptx-mma.py:84 + # It uses __mma_tf32_m16n16k8_ld_c but __mma_m16n16k8_st_c_f32. + make_ldst_ops(["m16n16k8"], ["a", "b", "c", "d"], ["tf32", "f32"])) ---

[PATCH] D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

alexfh added a comment. In D105890#2873969 , @thakis wrote: > I think this is incorrect. See D105892 and > https://reviews.llvm.org/D104915#2873851 . Don't blindly land changes to > suppress warnings – the warnings exi

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

george.burgess.iv added a comment. thanks for this! mostly just nits from me Comment at: clang/lib/AST/ExprConstant.cpp:15755 + +bool Expr::tryEvaluateStrLen(uint64_t &Result, ASTContext &Ctx) const { + Expr::EvalStatus Status; Looks like this is the second "t

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung accepted this revision. dyung added a comment. In D105457#2878352 , @nridge wrote: > In D105457#2878302 , @dyung wrote: > >> Interesting. If you can get me an updated patch, I can give it a try on my >> mac

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 358773. shafik marked 8 inline comments as done. shafik added a comment. - Removed virtual from `FindTypeForAutoReturnForDIE` - Added missing nullptr checks - Modernized the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://revie

[PATCH] D106019: [WebAssembly] Codegen for v128.storeX_lane instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a4229f70f81: [WebAssembly] Codegen for v128.storeX_lane instructions (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D10

[clang] 4a4229f - [WebAssembly] Codegen for v128.storeX_lane instructions

Author: Thomas Lively Date: 2021-07-14T16:15:25-07:00 New Revision: 4a4229f70f815a0a83e8e226ec1718af693faf4d URL: https://github.com/llvm/llvm-project/commit/4a4229f70f815a0a83e8e226ec1718af693faf4d DIFF: https://github.com/llvm/llvm-project/commit/4a4229f70f815a0a83e8e226ec1718af693faf4d.diff

<    1   2   3   >