[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

khchen added inline comments. Comment at: llvm/test/CodeGen/RISCV/module-target-abi-tests.ll:5 +; RUN: cat %s > %t.emptyabi +; RUN: echo '!0 = !{i32 1, !"target-abi", !""}' >> %t.emptyabi +; RUN: llc -mtriple=riscv32 < %t.emptyabi -o /dev/null jrtc27 wrote: > khc

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

HsiangKai added a comment. Ping. Is it possible to land these Zvlsseg patches before LLVM 13 branch created? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 __

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. That makes sense. Should I add it somewhere? Or do I need to talk to someone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 ___ cfe-c

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this re

[clang] 3697f26 - [docs] Fix linking issues in LibASTMatchers tutorial

Author: Georgy Komarov Date: 2021-07-05T12:11:25+03:00 New Revision: 3697f2683695a5e67184c4b348415f4da028133c URL: https://github.com/llvm/llvm-project/commit/3697f2683695a5e67184c4b348415f4da028133c DIFF: https://github.com/llvm/llvm-project/commit/3697f2683695a5e67184c4b348415f4da028133c.diff

[PATCH] D105409: [docs] Fix linking issues in LibASTMatchers tutorial

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jubnzv marked an inline comment as done. Closed by commit rG3697f2683695: [docs] Fix linking issues in LibASTMatchers tutorial (authored by jubnzv). Herald added a proj

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. D105423 implements the required support in LLT of opaque types for this patch to work again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 ___

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

fhahn requested changes to this revision. fhahn added a comment. This revision now requires changes to proceed. I think this has been addressed by some commits a while ago. Marking as changes requested to clear up review queue. Please feel free to update the patch in case there’s anything I miss

[PATCH] D105414: Add x86 and x86_64 to the BareMetal toolchain

abidh added a comment. You need to add some tests that check the functionality that you are adding. Look at clang/test/Driver/baremetal.cpp for an example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105414/new/ https://reviews.llvm.org/D105414

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

brunodf added a comment. This change is important make better use of `#pragma clang attribute` (which is cool!), but for some uses the check still seems to restrictive. Concretely, for an attribute where `Subjects` includes `FunctionLike`, I can only match it using the rule `hasType(functionTyp

[clang] 85255a0 - [C++][Sema] Ignore top-level qualifiers in casts

Author: Ole Strohm Date: 2021-07-05T12:22:08+01:00 New Revision: 85255a04e5729c03214c51177aa885c055f3e242 URL: https://github.com/llvm/llvm-project/commit/85255a04e5729c03214c51177aa885c055f3e242 DIFF: https://github.com/llvm/llvm-project/commit/85255a04e5729c03214c51177aa885c055f3e242.diff LO

[PATCH] D102689: [C++] Ignore top-level qualifiers in casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85255a04e572: [C++][Sema] Ignore top-level qualifiers in casts (authored by olestrohm). Changed prior to commit: https://reviews.llvm.org/D102689?

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang, mgorny. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Based on https://reviews.llvm.org/D100540.

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2849268 , @pekka.jaaskelainen wrote: > Does this break clSetKernelArg() for ARM CPUs in PoCL? I believe so far it > has worked for ARM - just wondering why you decide to drop it now? > > https://github.com/pocl/pocl

[clang-tools-extra] de8274a - [clangd] NFC: Remove outdated comment

Author: Kirill Bobyrev Date: 2021-07-05T13:58:54+02:00 New Revision: de8274a1b912687ca7b182ce28b34b0e66b2b0e3 URL: https://github.com/llvm/llvm-project/commit/de8274a1b912687ca7b182ce28b34b0e66b2b0e3 DIFF: https://github.com/llvm/llvm-project/commit/de8274a1b912687ca7b182ce28b34b0e66b2b0e3.diff

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

pekka.jaaskelainen added a comment. > The reason why we would like to fix it is that upstream clang has a crash > currently when OpenCL sources are compiled for any Arm CPU: > https://bugs.llvm.org/show_bug.cgi?id=50841. Do you have any other > suggestions to avoid this problem? > > FYI clang a

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

amyk added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1534 + Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>; } Is there an unintended change at the end? Comment at: llvm/lib/Target/PowerPC

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. In D92004#2857511 , @airlied wrote: > I'll have to rebase/rebuild my build env, I'll try and have something > rebasing this cleaner soon. Cool, thanks! If you could split/partition into multiple patches in some way it would be

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-compare-64bit-only.ll:39 + +attributes #0 = { noinline nounwind optnone "frame-pointer"="none" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "targ

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:830 -def POPCNTB : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), - "popcntb $rA, $rS", IIC_IntGeneral, - [(set i64:$rA, (int_ppc_popcntb i64:$rS))]>

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-error.c:11 + +long long lla, llb; +int ia, ib; nit: Have these variables as `extern` like the other patches do. Comment at: clang/test/CodeGen/builtins-ppc-xlcompa

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong reopened this revision. martong added a comment. This revision is now accepted and ready to land. I have changed the dump methods to order the equivalence classes and the disequality info available before printing them out. The ordering is done based on their string representation. This

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 356502. martong added a comment. Herald added a subscriber: mgrang. - Change the dump methods to order the equivalence classes and the disequality info available before printing them out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2583 + + llvm::SmallSet MembersStr; + for (std::pair ClassToSymbolSet : Members) Ah, `SmallSet` is not sorted :( I am gonna have to change this to either `std::

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 356504. martong added a comment. - Use std::set for ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMan

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Including clangFrontend has been discourage many times before, we don't want to add that to the list of dependencies please see D90121: clang-format: Add a consumer t

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

MyDeveloperDay added a comment. also D68554: [clang-format] Proposal for clang-format to give compiler style warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105408/new/ https://reviews.llvm.org/D105408 ___

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

MyDeveloperDay added a comment. Can you show `for (;;) {}` in your tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 ___ cfe-commits mailing list cfe-commits

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1724 + +let Predicates = [HasP8Altivec] in { + def : Pat<(int_ppc_stdcx xoaddr:$dst, g8rc:$A), lkail wrote: > IIRC, `l(w|d)arx`, `st(w|d)cx` are supported very early and don't n

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

xazax.hun requested changes to this revision. xazax.hun added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:350 +QualType Type = getInnerPointerType(C, E->getType()->getAsCXXRecordDecl()); +

[PATCH] D105354: [clang][AST] Add support for DecompositionDecl to ASTImporter.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2305-2309 + BindingDecl *ToD; + if (GetImportedOrCreateDecl(ToD, D, Importer.getToContext(), DC, Loc, + Name.getAsIdentifierInfo())) +return ToD; + So, we

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:240 +void test_icbt() { + __icbt(c); } From the document, `__icbt` only valid when -qarch is set to target pwr8 or higher processors. It looks like target cpu sema check

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

vsavchenko added a comment. I compared issues produced by this patch to the issues produced before that on all projects from `clang/utils/analyzer/projects`, and didn't find any difference. Performance measurements also show the we are within the same margins. F17774659: photo_2021-07-05 19.39.

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith, manojgupta, gbiv, ldionne, EricWF. Herald added a reviewer: george.burgess.iv. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ has started splicing standar

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. A few notes to reviewers: - The patch assumes everything is under a top-level `__libcxx` directory, because it seems there are other system headers that could be prefixed with `__`. libc++ currently has many top-level directories, following the trend of `__${STD_LIB_HEADE

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

Quuxplusone requested changes to this revision. Quuxplusone added a comment. This revision now requires changes to proceed. Step 1 should be to find out if this is even a problem at all. For example, try using one of these tools to compile a C++ program against GNU libstdc++, or against a librar

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

lebedev.ri added a comment. Why not solve this in the headers themselves? Just `#error` in implementation header if some macro isn't defined, and define said macro in parent header before including implementation detail headers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 356526. RedDocMD added a comment. Major bug fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Checke

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

Quuxplusone added a comment. I should add that if any particular library really wants to //enforce// "thou shalt not deep-link detail headers" (instead of just documenting it and/or relying on the user-programmer's common sense) they can do it pretty

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

Conanap updated this revision to Diff 356527. Conanap added a comment. Moved the pattern definitions and removed unnecessary guard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: llvm/include/ll

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

Conanap updated this revision to Diff 356528. Conanap added a comment. Properly updated the diff with arc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.de

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356532. Conanap added a comment. Changed test case file names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def cla

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356533. Conanap added a comment. Updated C test case name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2858291 , @Quuxplusone wrote: > Step 1 should be to find out if this is even a problem at all. For example, > try using one of these tools to compile a C++ program against GNU libstdc++, > or against a library like rang

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap marked 3 inline comments as done. Conanap added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing li

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. The latest version looks good to me, let's land this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 __

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang added a comment. Please add the sema check & error test case for the two 64 bit only builtins `ldarx` and `stdcx` Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64-only.ll:10 +declare i64 @llvm.ppc.ldarx(i8*) +define dso_local i64 @t

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

spatel added inline comments. Comment at: llvm/test/CodeGen/X86/stack-folding-fp-avx512fp16vl-fma.ll:193-194 +define <8 x half> @stack_fold_fmsub123ph(<8 x half> %a0, <8 x half> %a1, <8 x half> %a2) { + ;check-label: stack_fold_fmsub123ph: + ;check: vfmsub213ph {{-?[0-9]

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356542. Conanap added a comment. Added error test cases and sema checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsP

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. In D103615#2852430 , @krasimir wrote: > I'm unfamiliar with the altivec API. What's a reasonable source code update > that preserves the current default behavior `-altivec-src-compat=mixed` under > `-altivec-src-compat=xl`, i.e

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356545. Conanap added a comment. Updated 64 bit error test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

stefanp added a comment. Overall I think this is fine. I just have a few nits. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:11 +int test_lwarx(volatile int* a) { + // CHECK: entry: + // CHECK: %0 = bitcast i32* %a to i8* Please

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356546. Conanap marked 2 inline comments as done. Conanap added a comment. Updated IR test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/includ

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356549. Conanap added a comment. Changed to ForceXForm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356550. Conanap added a comment. Changed to ForceXForm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356551. Conanap added a comment. Changed to ForceXForm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356552. Conanap added a comment. Fixed incorrect diff update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clan

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond-64bit-only.c:1 +// RUN: not %clang_cc1 -triple=powerpc-unknown-aix -O2 -S -emit-llvm %s -o - 2>&1 |\ +// RUN: FileCheck %s --check-prefix=CHECK32-ERROR `-S`

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. @rsmith @thakis @efriedma If there are no more changes required, please approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commi

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356559. Conanap marked 4 inline comments as done. Conanap added a comment. Updated test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/c

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap marked an inline comment as done. Conanap added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing li

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. @davidxl @vsk 😃 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104556/new/ https://reviews.llvm.org/D104556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] 52f3467 - [AIX] Add _AIX73 version macro

Author: Jake Egan Date: 2021-07-05T16:28:48-04:00 New Revision: 52f34673ead32e6818d337207661597de52b9808 URL: https://github.com/llvm/llvm-project/commit/52f34673ead32e6818d337207661597de52b9808 DIFF: https://github.com/llvm/llvm-project/commit/52f34673ead32e6818d337207661597de52b9808.diff LOG

[PATCH] D105185: [AIX] Add _AIX73 version macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52f34673ead3: [AIX] Add _AIX73 version macro (authored by Jake-Egan, committed by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

mcgrathr added a comment. Frankly I don't think it makes sense to have __sanitizer_mallinfo and those other allocator functions declared in hwasan_interface_internal.h at all. Those are neither APIs that the compiler emits nor ones that anyone else should use. They are just implementation detai

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. Overall LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103544/new/ https://reviews.llvm.org/D103544 ___

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm with minor changes + clang-format. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:29 + // now. Otherwise, ShadowBounds will be a zero-initialized global. +

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap updated this revision to Diff 356562. Conanap added a comment. Removed entry from check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

amyk accepted this revision as: amyk. amyk added a comment. Also LGTM overall. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-m

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 ___

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

aaronpuchert added a comment. I'd leave it to @rsmith to decide whether this makes sense in Sema.h. I tend to follow the rule that if it's just used once I keep it local, but you might have good reasons for making it public. Comment at: clang/lib/Sema/SemaDecl.cpp:13316 + re

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

nemanjai accepted this revision. nemanjai added a comment. LGTM aside from a small nit. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

0x8000- added a comment. Is it possible to have this rebased on top of LLVM12 for those of us who find the trade-offs acceptable? I prefer a consistent formatting of const placement, and my code base does not have issues with the macros - if we find one that break the build, I'll suggest it

[clang] 9964b0e - [clang] Add -fdump-record-layouts-canonical option

Author: David Tenty Date: 2021-07-05T17:35:37-04:00 New Revision: 9964b0ef828b685dc575a50f75bb1780b84b95c8 URL: https://github.com/llvm/llvm-project/commit/9964b0ef828b685dc575a50f75bb1780b84b95c8 DIFF: https://github.com/llvm/llvm-project/commit/9964b0ef828b685dc575a50f75bb1780b84b95c8.diff L

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9964b0ef828b: [clang] Add -fdump-record-layouts-canonical option (authored by daltenty, committed by stevewan). Repository: rG LLVM Github Monorep

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov added a comment. In D105380#2858638 , @aaronpuchert wrote: > I tend to follow the rule that if it's just used once I keep it local, but > you might have good reasons for making it public. Well it is used twice. Notice how I replaced a pre-exis

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 356565. MyDeveloperDay removed reviewers: klimek, djasper. MyDeveloperDay added a comment. Rebase on clang12 as requested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangForma

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356568. mizvekov added a comment. - Use llvm::any_of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaD

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

0x8000- added a comment. In D69764#2858656 , @MyDeveloperDay wrote: > Rebase on clang12 as requested Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

Conanap marked 3 inline comments as done. Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machinein

[PATCH] D105446: [clang] fix constexpr code generation for user conversions.

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building the member call to a user conversion function during an implicit cast, the expression was not being checked for immediate invocation, so

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's VERSION_MAJOR after adding a LangOption, else builds with LLVM_APPEND_VC_REV=NO won't invalidate their module cache correctly. See e.g. https://reviews.llvm.org/rGb8b7a9dcdcbc Without that, tests are

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a reviewer: jdoerfert. Herald

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. I should note that I didn't use private headers in libc++'s `modules.modulemap` because it created a very noticeable impact to our test suite's run-time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105439/new/ https://revie

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:13314 -/// Determines if a variable's alignment is dependent. -static bool hasDependentAlignment(VarDecl *VD) { - if (VD->getTy

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356574. manas added a comment. Restore global cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/entrypoint.py Index: clang/u

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added a comment. In D105447#2858740 , @manas wrote: > Restore global cmake command Apparently, my initial observation of `LLVM_BUILD_RUNTIME=OFF` hogging up memory was false and I also didn't know what was the default value for this option. Hence

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas updated this revision to Diff 356575. manas edited the summary of this revision. manas added a comment. Edit summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 Files: clang/utils/analyzer/ent

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

mizvekov updated this revision to Diff 356576. mizvekov added a comment. - Move it to VarDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/new/ https://reviews.llvm.org/D105380 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.

[clang] e2904c8 - [clang] unbreak Index/preamble-reparse-changed-module.m with LLVM_APPEND_VC_REV=NO after 9964b0e

Author: Steven Wan Date: 2021-07-05T19:51:00-04:00 New Revision: e2904c8e0fa901adeefe579297cb2ece2757fb18 URL: https://github.com/llvm/llvm-project/commit/e2904c8e0fa901adeefe579297cb2ece2757fb18 DIFF: https://github.com/llvm/llvm-project/commit/e2904c8e0fa901adeefe579297cb2ece2757fb18.diff LO

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. In D105112#2858702 , @thakis wrote: > Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's > VERSION_MAJOR after adding a LangOption, else builds with > LLVM_APPEND_VC_REV=NO won't invalidate their module cach

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

thakis added a comment. Thanks for the fix :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] 2110638 - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-06T02:30:44+02:00 New Revision: 21106388eb96c87b3f580c42a322c76a61605261 URL: https://github.com/llvm/llvm-project/commit/21106388eb96c87b3f580c42a322c76a61605261 DIFF: https://github.com/llvm/llvm-project/commit/21106388eb96c87b3f580c42a322c76a61605261.dif

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG21106388eb96: [clang] fixes named return of variables with dependent alignment (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/n

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

stefanp accepted this revision. stefanp added a comment. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list cfe-commi

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

lkail accepted this revision. lkail added a comment. lgtm,thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list cfe-commits@lists

  1   2   >