[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/test/Analysis/constant-folding.c:330 +clang_analyzer_eval((c + d) == INT_MAX - 22); // expected-warning{{FALSE}} + } +} vsavchenko wrote: > manas wrote: > > vsavchenko wrote: > > > I don't see the cases where we

[PATCH] D104505: [HIP] Defer operator overloading errors

ro added a comment. This patch broke the Solaris/sparcv9 and Solaris/amd64 buildbots: /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema

[PATCH] D104899: [clang][tests] Specify unwindlib in aix-ld tests

tbaeder created this revision. tbaeder added a reviewer: tstellar. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang can be configured with a different default unwindlib, for example gcc. In that case, `-lunwind` will not be pre

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

sberg added a comment. And, again for the record, with a build of LibreOffice with clang-cl (and `-Xclang -std=c++2b`) on Windows, at least against the C++ standard library from Visual Studio 2019 version 16.20.2, I ran into two issues in the standard library itself, when using `std::getline` a

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, darwin. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=50525 AlignConsecutiveAssignments/Declarations ca

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD marked 4 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:301 + const OverloadedOperatorKind OOK = FD->getOverloadedOperator(); + if (!(OOK == OO_Equal || OOK == OO_ExclaimEqual || OOK == OO_Les

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong marked 2 inline comments as done. martong added a comment. Valeriy, thanks for the assiduous and quick review! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef &MemberSym : ClassMembers) { -SymbolRef SimplifiedMemberS

[clang] 0646e36 - [Analyzer][solver] Fix crashes during symbol simplification

Author: Gabor Marton Date: 2021-06-25T11:49:26+02:00 New Revision: 0646e3625499b08a3ac9efd48396f3b463a19139 URL: https://github.com/llvm/llvm-project/commit/0646e3625499b08a3ac9efd48396f3b463a19139 DIFF: https://github.com/llvm/llvm-project/commit/0646e3625499b08a3ac9efd48396f3b463a19139.diff

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG0646e3625499: [Analyzer][solver] Fix crashes during symbol simplification (authored by martong). Changed prior to commit: https://reviews.llvm.org/D104844?vs=35

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef &MemberSym : ClassMembers) { -SymbolRef SimplifiedMemberSym = ::simplify(State, MemberSym); +SymbolRef SimplifiedMemberSym = ::clang::ento::

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ye-luo, ronlieb, gregrodgers, jdoerfert. Herald added subscribers: guansong, yaxunl, jvesely. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. W

[PATCH] D104804: [AMDGPU] Add gfx1035 target

jhenderson added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:189 +# RUN: sed -e 's//64/' -e 's//AMDGCN_GFX1035/' %s | yaml2obj -o %t.o.AMDGCN_GFX1035 +# RUN: llvm-readobj -S --file-headers %t.o.AMDGCN_GFX1035 | FileCheck --check-prefixes=EL

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354459. RedDocMD added a comment. Refactored code, removed duplications, fixed tests, added some more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:466 + + clang_analyzer_eval(ptr == ptr); // expected-warning{{TRUE}} + clang_analyzer_eval(ptr > ptr); // expected-warning{{FALSE}} xazax.hun wrote: > Putting tests like this on the

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354460. RedDocMD added a comment. Removed dump statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h clan

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay added a comment. ping, if there are no other opinions I plan to land this sometime this weekend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 ___ cfe-commits mailing list cfe-commits@

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added a comment. Back from vacation! Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:420 + if (!File) +return false; // do not skip non-file locations + StringRef FileName(File->getName()); this is probably worth some explanation ==

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

ronlieb added subscribers: estewart08, ashi1. ronlieb added a comment. @estewart08 @ashi1 please review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 ___ cf

[PATCH] D104550: [analyzer] Implement getType for SVal

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SVals.cpp:154 + Optional VisitLocGotoLabel(loc::GotoLabel GL) { +return QualType{Context.VoidPtrTy}; + } NoQ wrote: > ASDenysPetrov wrote: > > vsavchenko wrote: > > > ASDenysPetr

[clang] e47027d - [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

Author: Stuart Brady Date: 2021-06-25T11:48:42+01:00 New Revision: e47027d091deb4a0774eab911411a27092a60916 URL: https://github.com/llvm/llvm-project/commit/e47027d091deb4a0774eab911411a27092a60916 DIFF: https://github.com/llvm/llvm-project/commit/e47027d091deb4a0774eab911411a27092a60916.diff

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

This revision was automatically updated to reflect the committed changes. Closed by commit rGe47027d091de: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart added a comment. On reflection, I don't think it makes sense to make use of DW_LANG_C_plus_plus_17 or DW_LANG_C_plus_plus_20 in Clang just yet, as these are generally not supported by other tooling. I am a bit confused by DWARF publishing these tags ahead of time, yet tooling having not

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. LGTM (besides comment fix) but I'm not too familiar with the vector side of things Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6967 + // NaN has all exp bits set and a non zero significand. Therefore: + // isnan(V) == ((exp mask - (ab

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 354467. whisperity added a comment. **NFC** Rebase and fix things broken by D104819 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20689/new/ https://reviews.llvm.org/D206

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal updated this revision to Diff 354471. pdhaliwal added a comment. Fix format errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Head

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D75041#2799036 , @whisperity wrote: > In D75041#2799023 , @martong wrote: > >> Perhaps all con

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman accepted this revision. aaron.ballman added a comment. This is a very involved check that I think is going to produce some interesting results for users, thank you for working so diligently on it! I think all of the patches in the series have now been accepted and this is ready to

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added a comment. In D69560#2840554 , @aaron.ballman wrote: > This is a very involved check that I think is going to produce some > interesting results for users, thank you for working so diligently on it! I > think all of the patches in the s

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added a comment. In D69560#2840579 , @whisperity wrote: > In D69560#2840554 , @aaron.ballman > wrote: > >> This is a very involved check that I think is going to produce some >> interesting results f

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a7bb8494e9c: [flang][driver] Add `-fno-analyzed-objects-for-unparse` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D103612?vs=354294&id=354474#toc Repository: rG LLVM G

[clang] 2a7bb84 - [flang][driver] Add `-fno-analyzed-objects-for-unparse`

Author: Andrzej Warzynski Date: 2021-06-25T13:28:12+01:00 New Revision: 2a7bb8494e9c58b44ad7142d8d309455cd669603 URL: https://github.com/llvm/llvm-project/commit/2a7bb8494e9c58b44ad7142d8d309455cd669603 DIFF: https://github.com/llvm/llvm-project/commit/2a7bb8494e9c58b44ad7142d8d309455cd669603.d

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko updated this revision to Diff 354475. vsavchenko marked 9 inline comments as done. vsavchenko added a comment. Address comments from review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104550/new/ https://reviews.llvm.org/D104550 Files

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 354478. whisperity marked 5 inline comments as done. whisperity added a comment. **NFC** Fix nits. Let's have one final run with the buildbots, just in case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D7504

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:249 + /// the conversion sequence. This method does **NOT** return Begin and End. + SmallVector getInvolvedTypesInSequence() const { +SmallVector Ret; ---

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong accepted this revision. martong added a comment. Looks acceptable to me as well. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D75041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

vsavchenko updated this revision to Diff 354479. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValu

[PATCH] D104716: [analyzer] Fix assertion failure on code with transparent unions

vsavchenko updated this revision to Diff 354480. vsavchenko added a comment. Use argument expression's type instead of SVal's type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104716/new/ https://reviews.llvm.org/D104716 Files: clang/lib/Static

[PATCH] D104716: [analyzer] Fix assertion failure on code with transparent unions

vsavchenko updated this revision to Diff 354481. vsavchenko marked 2 inline comments as done. vsavchenko added a comment. Remove printState from the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104716/new/ https://reviews.llvm.org/D104716 Fi

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

yaxunl added a comment. LGTM for HIP header changes. Pls make sure it passes internal CI (ePSDB). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 ___ cfe-commit

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

scchan added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:29 +#ifdef __OPENMP_AMDGCN__ +#define __DEVICE__ static constexpr __attribute__((always_inline, nothrow)) +#define __constant__ __attribute__((constant)) `__DEVICE__` should not imply

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen updated this revision to Diff 354487. steffenlarsen added a comment. Adjusted for comments and fixed formatting issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104847/new/ https://reviews.llvm.org/D104847 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. Herald added a reviewer: aaron.ballman. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl added a comment. In D104505#2840239 , @ro wrote: > This patch broke the Solaris/sparcv9 > and Solaris/amd64 > buildbots: > > > /

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen marked 4 inline comments as done. steffenlarsen added a comment. @tra Thank you for the quick response! I agree with your comments and have made changes accordingly. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:762 +// Builtins to support double and

[PATCH] D102507: [HIP] Support in device code

yaxunl added a comment. In D102507#2838981 , @tra wrote: > The key difference between C++ and CUDA/HIP, as implemented in clang, is that > `__host__` and `__device__` attributes are considered during function > overloading in CUDA and HIP, so `__host__

[PATCH] D104843: [clangd] Introduce a log-prefix flag to remote-index-server

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104843/new/ https://reviews.llvm.org/D104843 __

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong created this revision. martong added reviewers: steakhal, vsavchenko, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this re

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. In D103967#2822287 , @steakhal wrote: > I suspect that the exploded-graph-rewriter should be updated as well so that > the HTML dumps also carry this information. I've put that into a separate patch because that change has its o

[clang] 3193133 - [OpenCL] Do not include default header for preprocessor output as input

Author: Yaxun (Sam) Liu Date: 2021-06-25T10:01:51-04:00 New Revision: 3193133add7eeeaa3872c78aa959bacdc08e59d9 URL: https://github.com/llvm/llvm-project/commit/3193133add7eeeaa3872c78aa959bacdc08e59d9 DIFF: https://github.com/llvm/llvm-project/commit/3193133add7eeeaa3872c78aa959bacdc08e59d9.dif

[clang] 4921ecf - [clang] Fix build failure due to _S

Author: Yaxun (Sam) Liu Date: 2021-06-25T10:10:27-04:00 New Revision: 4921ecfc8194c11ec7c659ad1de11da6e8307361 URL: https://github.com/llvm/llvm-project/commit/4921ecfc8194c11ec7c659ad1de11da6e8307361 DIFF: https://github.com/llvm/llvm-project/commit/4921ecfc8194c11ec7c659ad1de11da6e8307361.dif

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3193133add7e: [OpenCL] Do not include default header for preprocessor output as input (authored by yaxunl). Herald added a subscriber: ldrumm. Herald

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl added a comment. fixed by 4921ecfc8194c11ec7c659ad1de11da6e8307361 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104505/new/ https://reviews.llvm.org/D104505 ___

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, rjmccall, lhames, teemperor, aprantl, sgraenitz, hfinkel. Herald added subscribers: dexonsmith, kbarton, nemanjai. v.g.vassilev requested review of this revision. https://reviews.llvm.org/D96033 contained a discussion regar

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 354498. quinnp added a comment. Added non-vsx implementation of builtins and non-vsx backend tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inclu

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

vsavchenko added a comment. LGTM, but I'm not really an expert in `exploded-graph-rewriter`. I think @NoQ should take a look. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:299 +self.equivalence_classes = ( +GenericMap({i: ", ".join(eq_classes

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 ___

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:329 + return *Ptr; +return C.getSValBuilder().conjureSymbolVal( +E, C.getLocationContext(), In case we conjure a new symbol, we want this stored i

[clang-tools-extra] 3aa6ca8 - [clangd] Call malloc_trim in clangd-index-server periodically

Author: Kadir Cetinkaya Date: 2021-06-25T16:49:31+02:00 New Revision: 3aa6ca8def510b5c10e76899ad9b78f5ba4ea19c URL: https://github.com/llvm/llvm-project/commit/3aa6ca8def510b5c10e76899ad9b78f5ba4ea19c DIFF: https://github.com/llvm/llvm-project/commit/3aa6ca8def510b5c10e76899ad9b78f5ba4ea19c.dif

[PATCH] D104841: [clangd] Call malloc_trim in clangd-index-server periodically

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3aa6ca8def51: [clangd] Call malloc_trim in clangd-index-server periodically (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES S

[clang-tools-extra] 8f2bf93 - [clangd] Introduce a log-prefix flag to remote-index-server

Author: Kadir Cetinkaya Date: 2021-06-25T16:51:29+02:00 New Revision: 8f2bf93b5bd6a1d31e28e4144827b3f6c413ac85 URL: https://github.com/llvm/llvm-project/commit/8f2bf93b5bd6a1d31e28e4144827b3f6c413ac85 DIFF: https://github.com/llvm/llvm-project/commit/8f2bf93b5bd6a1d31e28e4144827b3f6c413ac85.dif

[PATCH] D104843: [clangd] Introduce a log-prefix flag to remote-index-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f2bf93b5bd6: [clangd] Introduce a log-prefix flag to remote-index-server (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:336 + BinaryOperatorKind BOK; + switch (OOK) { + case OO_EqualEqual: Btw, if we do not have a helper yet to translate between these enums in the analyer, we sh

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

klausler added a comment. This patch may have broken the shared library buildbots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 ___ cfe-commits mailing list

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2837818 , @gnossier wrote: > Is this ready to merge soon? Hi @gnossier: I'm waiting for feedbacks from reviewer. Hi @aaron.ballman: Nathan is helping me to review this patch, but seems he is not here recently. Do you

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

awarzynski added a comment. In D103612#2840886 , @klausler wrote: > This patch may have broken the shared library buildbots. Sorry about that. A fix is on its way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added a comment. In D104261#2832892 , @aaron.ballman wrote: > I think the CI failure (libarcher.races::lock-unrelated.c) is not related to > this patch but is a tsan thing, but you may want to double-check that just in > case. Seems that

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of this revisio

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

awarzynski added a comment. I pushed a fix without a review: https://reviews.llvm.org/rGc3ebb53eabb7f851687f66ada88aa16f768d76ce. Please let me know if you prefer such changes to go through a regular review in the future! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:868 ThreadSafetyHandler &Handler) const override { -if (!managed() && !asserted() && !negative() && !isUniversal()) { +if (!asserted() && !negative() && !i

[PATCH] D81886: [AMDGPU] Add gfx1030 target

foad added inline comments. Herald added a subscriber: dexonsmith. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1245 + +def HasDsSrc2Insts : Predicate<"!Subtarget->hasDsSrc2Insts()">, + AssemblerPredicate<(all_of FeatureDsSrc2Insts)>; The `!` is obviously wrong

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

stephan.yichao.zhao added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:169 +// TODO(browneee): Removed this after testing and not hit. +CHECK(MEM_IS_SHADOW(s)); +// if (!MEM_IS_SHADOW(s)) { Based on the recent issue about using a repla

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

davidxl added inline comments. Comment at: clang/docs/UsersManual.rst:1881 conversion tool that can convert one to the other. So, a profile generated - via ``-fprofile-instr-generate`` must be used with ``-fprofile-instr-use``. + via ``-fprofile-generate`` must be used wi

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:185 +for (std::size_t J = 0; J < Param.size(); ++J) { + if (Arg[I] == Param[J]) { +if (I == 0 || J == 0) Should this be a c

[PATCH] D104716: [analyzer] Fix assertion failure on code with transparent unions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks again!~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104716/new/ https://reviews.llvm.org/D104716 ___

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9eaf0d120d32: [UpdateCCTestChecks] Support --check-globals (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9eaf0d1 - [UpdateCCTestChecks] Support --check-globals

Author: Joel E. Denny Date: 2021-06-25T13:17:56-04:00 New Revision: 9eaf0d120d3255c43789213c499513ba1be9dde7 URL: https://github.com/llvm/llvm-project/commit/9eaf0d120d3255c43789213c499513ba1be9dde7 DIFF: https://github.com/llvm/llvm-project/commit/9eaf0d120d3255c43789213c499513ba1be9dde7.diff

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour accepted this revision. bmahjour added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 ___

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

stephan.yichao.zhao added a comment. Thank you for making this work! Comment at: compiler-rt/lib/dfsan/dfsan.cpp:871 + +static void CheckMemoryLayoutSanity() { + uptr prev_end = 0; Please add a comment about that these CheckMemoryLayoutSanity, ... and InitSha

[PATCH] D104854: Introduce intrinsic llvm.isnan

craig.topper added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:662 + EVT NewResultVT = TLI.getTypeToTransformTo(*DAG.getContext(), ResultVT); + return DAG.getNode(N->getOpcode(), DL, NewResultVT, N->getOperand(0)); +} Don

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/49790/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___ cfe-commits mai

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. Oh I see this assumes that lit.site.cfg.py is below clang_obj_root. I guess that's my problem, looking… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

tra accepted this revision. tra added a comment. LGTM. Would you like me to land the patch on your behalf? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16397 unsigned NumEltsD; std::array Variants; A comment here describing expected arrangement of the va

[PATCH] D104931: [AArch64] Wire up ILP32 ABI support in Clang

Amanieu created this revision. Amanieu added reviewers: t.p.northover, aemerson, kristof.beyls. Herald added a subscriber: danielkiss. Amanieu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up to D94143

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841229 , @thakis wrote: > Oh I see this assumes that lit.site.cfg.py is below clang_obj_root. I guess > that's my problem, looking… Let me know if the patch isn't general enough, or if I can help in some other way.

[clang] fda790f - [clang] Make fewer assumptions about path to lit.site.cfg after 9eaf0d120d32

Author: Nico Weber Date: 2021-06-25T14:01:29-04:00 New Revision: fda790fbfa0cba426d5e3787429a51e09ec64c6d URL: https://github.com/llvm/llvm-project/commit/fda790fbfa0cba426d5e3787429a51e09ec64c6d DIFF: https://github.com/llvm/llvm-project/commit/fda790fbfa0cba426d5e3787429a51e09ec64c6d.diff LO

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. I landed a fix attempt for my thing in fda790fbfa0cba426d5e3787429a51e09ec64c6d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://revie

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

browneee updated this revision to Diff 354558. browneee marked 8 inline comments as done. browneee added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104896/new/ https://reviews.llvm.org/D104896 Files: clang/docs/

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:29 +#ifdef __OPENMP_AMDGCN__ +#define __DEVICE__ static constexpr __attribute__((always_inline, nothrow)) +#define __constant__ __attribute__((constant)) scchan wrote: > `__D

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841304 , @thakis wrote: > I landed a fix attempt for my thing in > fda790fbfa0cba426d5e3787429a51e09ec64c6d > . Thanks! Repository: rG LLVM Gi

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

delesley accepted this revision. delesley added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for the patch! Since you're adding a new warning, this may break some code somewhere, but since it's restricted to relockable managed locks, I'm not too wor

[PATCH] D104649: Thread safety analysis: Rename parameters of ThreadSafetyAnalyzer::intersectAndWarn (NFC)

delesley accepted this revision. delesley added a comment. Looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104649/new/ https://reviews.llvm.org/D104649 ___ cfe-commits mailing list cfe

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield updated this revision to Diff 354563. mbenfield added a comment. Accommodate the fact that APSInt::toString(unsigned) was removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104887/new/ https://reviews.llvm.org/D104887 Files: clang/

[clang] cc60fa2 - [UpdateCCTestChecks] Fix new test from 9eaf0d120d32

Author: Joel E. Denny Date: 2021-06-25T14:29:58-04:00 New Revision: cc60fa2685bdbff889df826a1bfd5e52ffd163c8 URL: https://github.com/llvm/llvm-project/commit/cc60fa2685bdbff889df826a1bfd5e52ffd163c8 DIFF: https://github.com/llvm/llvm-project/commit/cc60fa2685bdbff889df826a1bfd5e52ffd163c8.diff

[PATCH] D104854: Introduce intrinsic llvm.isnan

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:22039 + // Move FPSW to AX. + SDValue FPSW = DAG.getCopyToReg(DAG.getEntryNode(), DL, X86::FPSW, Test, + SDValue()); The code you copied thi

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

thakis added a comment. Another thing: https://reviews.llvm.org/harbormaster/unit/view/789318/ # command stderr: /var/lib/buildkite-agent/builds/llvm-project/clang/test/utils/update_cc_test_checks/check-globals.test:83:10: error: LIT-RUN: expected string not found in input LIT-RUN: PASS:

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2841457 , @thakis wrote: > Another thing: https://reviews.llvm.org/harbormaster/unit/view/789318/ > > # command stderr: > > /var/lib/buildkite-agent/builds/llvm-project/clang/test/utils/update_cc_test_checks/check-g

[PATCH] D104854: Introduce intrinsic llvm.isnan

efriedma added a comment. A few of the AArch64 sequences don't look ideal, but that's not the fault of your patch. I'd like to see some test coverage for all the floating-point types (half, bfloat16, ppc_fp128). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D81886: [AMDGPU] Add gfx1030 target

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1245 + +def HasDsSrc2Insts : Predicate<"!Subtarget->hasDsSrc2Insts()">, + AssemblerPredicate<(all_of FeatureDsSrc2Insts)>; foad wrote: > The `!` is obviously wrong in this definition, b

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

yaxunl created this revision. yaxunl added reviewers: arsenm, b-sumner, rampitec. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D104946 Files: clang/incl

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added a comment. While this patch resolves the issue captured in https://bugs.llvm.org/show_bug.cgi?id=50604, it actually introduces a *new* bug. Perhaps this is what you were alluding to? Here's a reproducer which doesn't fail on main (with or without the problematic b305

  1   2   >