[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2835147 , @ychen wrote: > In D97915#2832667 , @ChuanqiXu wrote: > >> In D97915#2832446 , @ychen wrote: >> >>> In D97915#2829581

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

frasercrmck added a comment. What's supposed to happen if the provided index is invalid? I'm suspecting we'd currently get a IR verification error on the insert/extract indices. I'm wondering if we can/should catch that earlier? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 354166. whisperity added a comment. Attempt to fix build failure on Windows buildbot (`operator new` was taking `unsigned long` instead of `size_t` in a test which resulted in hard error). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 354167. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Ana

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); manas wrote: >

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas marked an inline comment as not done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverfl

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); manas wrote: >

[clang] e76c008 - [analyzer] Added a test case for PR46264

Author: Denys Petrov Date: 2021-06-24T12:24:26+03:00 New Revision: e76c008c906af3dc093dd5c3ceaea577359b5432 URL: https://github.com/llvm/llvm-project/commit/e76c008c906af3dc093dd5c3ceaea577359b5432 DIFF: https://github.com/llvm/llvm-project/commit/e76c008c906af3dc093dd5c3ceaea577359b5432.diff

[PATCH] D104381: [analyzer] Added a test case for PR46264

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe76c008c906a: [analyzer] Added a test case for PR46264 (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); vsavchenko wrote: >

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. In D103314#2837907 , @uabelho wrote: > Hi, > > Another failed assertion that started appearing with this patch: > > clang --analyze bbi-57589.c > > which results in: > > clang: ../lib/Support/APInt.cpp:284: int llvm::APInt::co

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Just a ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added a comment. In D103314#2838065 , @martong wrote: > In D103314#2837907 , @uabelho wrote: > >> Hi, >> >> Another failed assertion that started appearing with this patch: >> >> clang --analyze bbi-5

[PATCH] D104843: [clangd] Introduce a log-prefix flag to remote-index-server

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); manas wrote: >

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 354180. whisperity added a comment. (Uploaded the prerequisite, wrong patch here by accident.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D75041 Files: clang-tools-e

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

whisperity updated this revision to Diff 354183. whisperity added a comment. **NFC** Fix lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 Files: clang-tools-extra/clang-tidy/bugprone/EasilySwappableP

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong created this revision. martong added reviewers: vsavchenko, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. mart

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. In D103314#2838065 , @martong wrote: > In D103314#2837907 , @uabelho wrote: > >> Hi, >> >> Another failed assertion that started appearing with this patch: >> >> clang --analyze bbi-5758

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); vsavchenko wrote: >

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

whisperity added a comment. //Gentle boop.// Bugzilla is offline for me right now (and rumour has it that it will be completely shut down in the near future), so it would be good to know what is the status of this patch and how it related to the mentioned (and //right now// unavailable) bug rep

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 354192. whisperity added a comment. **NC!** Recreate diff to try and get the buildbots running... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm.org/D96355 Files: clang-tool

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 354193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseTemplate.cpp cla

[clang] c5028f3 - [Clang] XFAIL sanitize-coverage-old-pm.c on 32bit Armv8l

Author: Muhammad Omair Javaid Date: 2021-06-24T15:48:13+05:00 New Revision: c5028f3473ed50a7433fe278984cd1a755b338b9 URL: https://github.com/llvm/llvm-project/commit/c5028f3473ed50a7433fe278984cd1a755b338b9 DIFF: https://github.com/llvm/llvm-project/commit/c5028f3473ed50a7433fe278984cd1a755b338

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 354197. saiislam added a comment. Generalized padding of Triple fields of Bundle Entry ID while generating command for clang-offload-bundler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://r

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D90399: [clang-tidy] non-portable-integer-constant check

whisperity added inline comments. Herald added a subscriber: cfe-commits. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:38 #include "NoEscapeCheck.h" +#include "NonportableintegerconstantCheck.h" #include "NotNullTerminatedResultCheck.h" -

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 354203. whisperity added a comment. **NC** Fix lint mishap that occurred during previous rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm.org/D96355 Files: clang-tools

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

aaron.ballman added a comment. In D104777#2837794 , @dblaikie wrote: > In D104777#2837347 , @brunodefraine > wrote: > >> In D104777#2836669 , @dblaikie >> wrote: >> >>>

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

dexonsmith added a comment. Given how large this is, would it be reasonable to split this up a bit more? What I might do if this were my patch: get a review of the API change + the manual changes in one patch (assuming there aren't many manual changes), then land the remaining mechanical change

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2837136 , @mstorsjo wrote: > In D104556#2837104 , @rnk wrote: > >> Swift wanted the same thing, so I think the answer is yes, we should ask. > > What would the benefit of that b

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

MaskRay added inline comments. Comment at: llvm/include/llvm/ADT/StringRef.h:192 -/// equals_lower - Check for string equality, ignoring case. +/// equals_insensitive - Check for string equality, ignoring case. LLVM_NODISCARD https://llvm.org/docs/

[PATCH] D104804: [AMDGPU] Add gfx1035 target

foad added inline comments. Comment at: clang/test/Driver/amdgpu-mcpu.cl:138 // GFX1034: "-target-cpu" "gfx1034" +// GFX1034: "-target-cpu" "gfx1035" Typo in check prefix. Why didn't this make the test fail? Comment at: llvm/lib/Target/AMD

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo added a comment. In D104819#2837421 , @dexonsmith wrote: > Given how large this is, would it be reasonable to split this up a bit more? > > What I might do if this were my patch: get a review of the API change + the > manual changes in one patc

[PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

mstorsjo updated this revision to Diff 354178. mstorsjo added a comment. Reduced this patch only to updating of the StringRef class itself and its unit test, removing the mechanical changes. Removed superfluous method name duplication in doxygen comments. Repository: rG LLVM Github Monorepo

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + I don't like the idea of duplicating it into every `assume` method.

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay updated this revision to Diff 354205. MyDeveloperDay added a comment. Fix `parseBracedList()` to do what `parseStructuralElement()` does (with regard to breaking `AfterFunction`, I'm not completely convinced `AfterFunction` should have been reused for that but might be too late to

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen created this revision. steffenlarsen added a reviewer: tra. Herald added subscribers: hiraditya, yaxunl, jholewinski. steffenlarsen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Adds NVPTX builti

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 354210. whisperity added a comment. **NC** Rebase, buildbots, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D75041 Files: clang-tools-extra/clang-tidy/bugprone/Eas

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

MyDeveloperDay added a comment. @HazardyKnusperkek Its probably my "bad" I should said "LGTM but maybe wait for the others to comment", but I'm fundamentally ok I think with the change. (we'll just revert if it breaks stuff! ;-)) We are free to add review comments after the fact, @owenpan has

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 354218. whisperity added a comment. **NC** Rebase & more buildbot shenanigans so we can get a pass! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78652/new/ https://reviews.llvm.org/D78652 Files: clang-to

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/AST/ASTContext.cpp:2570-2571 +getSubobjectSizeInBits(const FieldDecl *Field, const ASTContext &Context) { + if (Field->getType()->isRecordType()) { +const RecordDecl *RD = Fiel

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov updated this revision to Diff 354225. ASDenysPetrov added a comment. Added assertions. Added two helper functions for `castTo` method. Moved some distinct code to them. Fixed clang-tidy complaints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. Thanks for the latest changes! Comment at: clang/docs/LanguageExtensions.rst:526 +The matrix type extension also supports operations between a matrix and a scalar. + I'm not a native speaker, but I am not sure if `between` is the best

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 354229. whisperity added a comment. **NC** Rebase and buildbot trigger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97297/new/ https://reviews.llvm.org/D97297 Files: clang-tools-extra/clang-tidy/bugpron

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Somehow the builds are failing even though this patch contains no code changes. Comment at: clang/docs/LanguageExtensions.rst:526 +The matrix type extension also supports operations between a matrix and a scalar. + fhahn wrote: >

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. In D104198#2838416 , @SaurabhJha wrote: > Somehow the builds are failing even though this patch contains no code > changes. There a few reasons as to why the tests may fail unrelated to the patch (flaky tests, infrastructure iss

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 354231. SaurabhJha added a comment. Address round 2 comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index: cl

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 354232. SaurabhJha added a comment. Rebase with latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index: cla

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff created this revision. sepavloff added reviewers: efriedma, kpn, thopre, jonpa, cameron.mcinally, RKSimon, craig.topper. Herald added subscribers: jdoerfert, pengfei, hiraditya. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cf

[PATCH] D97204: [RFC] Clang 64-bit source locations

simon_tatham added a comment. Hmmm. Two people have pointed out to me that my strategy of having a 32-bit `SourceLocations::LowBits` and an 0- or 32-bit `SourceLocations::OptionalHighBits` doesn't actually work, because an empty struct still takes at least 1 byte. So this version of the patch w

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. In D104616#2835061 , @xazax.hun wrote: > In D104616#2835030 , @RedDocMD > wrote: > >> Looks like I have wasted a good deal of effort. :( > > Sorry about that! :( If we learned anything n

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2838468 , @thopre wrote: > Are you planning to do this for the other FP test builtin (isinf, isfinite, > isinf_sign, isnormal)? Yes, they have similar problems. If someone would like to implement them it would be n

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 ___ cfe-commits mailing list cfe-comm

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM,thanks. Comment at: clang/docs/LanguageExtensions.rst:546 + +The matrix type extension supports compound assignments for addition, subtraction, and multiplication between

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! Pls make sure it passes internal CI (ePSDB) before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 __

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. In D93525#2838535 , @yaxunl wrote: > LGTM. Thanks! Pls make sure it passes internal CI (ePSDB) before committing. Sure, I will take care of it. Thanks! Any comments @jdoerfert ? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Thanks, the build is also passing now so I will land this in a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 ___ cfe-commits

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2837417 , @tlively wrote: > In D104797#2836475 , @pmatos wrote: > >> @tlively Do you think it would be ok to re-add the code removed in >> `ac81cb7e` but only error if the point

[clang] cd256c8 - Add documentation for compound assignment and type conversion of matrix types

Author: Saurabh Jha Date: 2021-06-24T15:50:58+01:00 New Revision: cd256c8bcc9723f0ce7a32957f26600c966fa07c URL: https://github.com/llvm/llvm-project/commit/cd256c8bcc9723f0ce7a32957f26600c966fa07c DIFF: https://github.com/llvm/llvm-project/commit/cd256c8bcc9723f0ce7a32957f26600c966fa07c.diff L

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added a subscriber: aeubanks. tlively added a comment. The opaque pointers project is documented here: https://llvm.org/docs/OpaquePointers.html. It's been making very slow progress for the past few years but has recently been picking up steam under the direction of @aeubanks. Search ll

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. Sorry, I committed this without the `Differential Revision: https://reviews.llvm.org/D104198` line. Is there a way to change the commit message after it is in main? I could not push after `git commit --amend` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104854: Introduce intrinsic llvm.isnan

jdoerfert added a comment. In D104854#2838495 , @sepavloff wrote: > In D104854#2838468 , @thopre wrote: > >> Are you planning to do this for the other FP test builtin (isinf, isfinite, >> isinf_sign, isnormal)? >

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2838653 , @tlively wrote: > The opaque pointers project is documented here: > https://llvm.org/docs/OpaquePointers.html. It's been making very slow > progress for the past few years but has recently been picking up ste

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + vsavchenko wrote: > I don't like the idea of duplicating it into every

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. In D104198#2838658 , @SaurabhJha wrote: > Sorry, I committed this without the `Differential Revision: > https://reviews.llvm.org/D104198` line. Is there a way to change the commit > message after it is in main? I could not push a

[PATCH] D90399: [clang-tidy] non-portable-integer-constant check

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/NonportableintegerconstantCheck.cpp:54 + +MaskStr = StringRef(MaskStr.lower()); +if (!MaskStr.consume_front("0x")) You are assigning a pointer to a temporal std::string. It

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added a comment. In D104198#2838665 , @fhahn wrote: > In D104198#2838658 , @SaurabhJha > wrote: > >> Sorry, I committed this without the `Differential Revision: >> https://reviews.llvm.org/D104198` li

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha closed this revision. SaurabhJha added a comment. This is closed by this commit https://github.com/llvm/llvm-project/commit/cd256c8bcc9723f0ce7a32957f26600c966fa07c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://revie

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong added a comment. > I don't really get why we get not simplified symbol to begin with. This is because of the Environment bindings. I.e.` b1` is bound to `$a0 - $b0 + $c` when we evaluate `int b1 = (unsigned)a1 + c;`. This binding is not changed/updated, so when we evaluate the division

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added a comment. In D104844#2838674 , @martong wrote: >> I don't really get why we get not simplified symbol to begin with. > > This is because of the Environment bindings. I.e.` b1` is bound to `$a0 - $b0 > + $c` when we evaluate `int b1 = (u

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2838659 , @jdoerfert wrote: > In D104854#2838495 , @sepavloff > wrote: > >> In D104854#2838468 , @thopre wrote: >> >>> Are you plann

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert accepted this revision. jdoerfert added a comment. Looks reasonable to me. We can always refine it as we go. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:137 +/// * GPUArch (Optional) - Processor name, like gfx906 or sm_30 +/// In presence of

[PATCH] D104854: Introduce intrinsic llvm.isnan

craig.topper added a comment. Doesn't gcc also fold isnan to false under fast math? If we diverge here that means your code would only work correctly with clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D1

[PATCH] D102507: [HIP] Support in device code

yaxunl added a comment. In D102507#2833594 , @ldionne wrote: > In D102507#2830688 , @yaxunl wrote: > >> In D102507#2792087 , @rsmith wrote: >> >>> @ldionne How should we g

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong updated this revision to Diff 354274. martong added a comment. - Use simplify from RangedConstraintManager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104844/new/ https://reviews.llvm.org/D104844 Files: clang/include/clang/StaticAnaly

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2314-2315 + if (SymbolRef SimplifiedSym = simplify(St, Sym)) +Sym = SimplifiedSym; + vsavchenko wrote: > martong w

[PATCH] D104844: [Analyzer][solver] Fix crashes during symbol simplification

vsavchenko added a comment. Awesome, thanks for swiftly addressing it! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1981 for (const SymbolRef &MemberSym : ClassMembers) { -SymbolRef SimplifiedMemberSym = ::simplify(State, MemberSym); +SymbolRe

[PATCH] D104550: [analyzer] Implement getType for SVal

ASDenysPetrov added a comment. I'm in favor of this patch. It will help simplify `SValBuilder::evalCast`, which takes an optional parameter `OriginalTy` and acts differently based on whether it has been passed or has not. Since `sizeof(SVal)` became bigger (x1.5). I'm wondering of how much this

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy added a comment. In D104831#2837712 , @MaskRay wrote: >> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >> supported x86_64 triplets so that it can be used with the --gcc-toolchain >> option to bypass this process and force-p

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko added a comment. In D104550#2838827 , @ASDenysPetrov wrote: > I'm in favor of this patch. It will help simplify `SValBuilder::evalCast`, > which takes an optional parameter `OriginalTy` and acts differently based on > whether it has been pas

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

MaskRay added a comment. In D104831#2838835 , @hoy wrote: > In D104831#2837712 , @MaskRay wrote: > >>> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >>> supported x86_64 triplets so that

[PATCH] D104381: [analyzer] Added a test case for PR46264

NoQ added a comment. I bisected. This bug was fixed intentionally by D85817 , forgot to close I guess. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104381/new/ https://reviews.llvm.org/D104381 ___

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2838754 , @craig.topper wrote: > Doesn't gcc also fold isnan to false under fast math? If we diverge here that > means your code would only work correctly with clang. GCC does the same transformation, ICC and MSVC

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 updated this revision to Diff 354270. aakanksha555 marked 4 inline comments as done. aakanksha555 added a comment. Addressed feedback; fixed typo and missing check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https:

[PATCH] D104804: [AMDGPU] Add gfx1035 target

foad added a comment. Looks OK. Have you run check-llvm and check-clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https://reviews.llvm.org/D104804 ___ cfe-commits mailing list cfe-commit

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

awarzynski updated this revision to Diff 354294. awarzynski added a subscriber: PeteSteinfeld. awarzynski added a comment. Rename the new flag as `-fno-analyzed-objects-for-unparse` Based on the discussion, I've renamed the flag to better reflect the intention. Does it make more sense now? Note

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 added a comment. In D104804#2838883 , @foad wrote: > Looks OK. Have you run check-llvm and check-clang? I did, no other failing tests observed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D102507: [HIP] Support in device code

tra added a comment. The key difference between C++ and CUDA/HIP, as implemented in clang, is that `__host__` and `__device__` attributes are considered during function overloading in CUDA and HIP, so `__host__ void foo()`, `__device__ void foo()` and `__host__ __device__ void foo()` are three

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

craig.topper updated this revision to Diff 354297. craig.topper added a comment. Add constant argument range checking to SemaChecking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104822/new/ https://reviews.llvm.org/D104822 Files: clang/include

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 354300. mibintc added a comment. Rebasing. Hope this clears lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 Files: llvm/docs/LangRef.rst llvm/include/ll

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354301. mibintc added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/Builtins.def

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

Anastasia added a comment. LGTM! Thanks I agree we should have the same behavior for both options. Technically `-finclude-default-header` could be added in both steps but it is only effective in parsing the sources and does nothing otherwise. But it seems cleaner to align it with the header in

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

dblaikie added a comment. In D104777#2838211 , @aaron.ballman wrote: > In D104777#2837794 , @dblaikie > wrote: > >> In D104777#2837347 , >> @brunodefraine wrote: >> >>>

[clang] 3453f3d - [AMDGPU] Add gfx1035 target

Author: Aakanksha Patil Date: 2021-06-24T14:32:41-04:00 New Revision: 3453f3dd46f5214e028cb33818b10c5d995cd858 URL: https://github.com/llvm/llvm-project/commit/3453f3dd46f5214e028cb33818b10c5d995cd858 DIFF: https://github.com/llvm/llvm-project/commit/3453f3dd46f5214e028cb33818b10c5d995cd858.dif

[PATCH] D104804: [AMDGPU] Add gfx1035 target

MaskRay added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:189 +# RUN: sed -e 's//64/' -e 's//AMDGCN_GFX1035/' %s | yaml2obj -o %t.o.AMDGCN_GFX1035 +# RUN: llvm-readobj -S --file-headers %t.o.AMDGCN_GFX1035 | FileCheck --check-prefixes=ELF-A

[PATCH] D104804: [AMDGPU] Add gfx1035 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3453f3dd46f5: [AMDGPU] Add gfx1035 target (authored by aakanksha555). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354323. RedDocMD added a comment. Removed re-invention, added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartP

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. We have a failing test here (test at line 473). Which makes me wonder if the `handleComparision` function is at all called. This is something I need to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ htt

  1   2   >