foad added inline comments.
================ Comment at: clang/test/Driver/amdgpu-mcpu.cl:138 // GFX1034: "-target-cpu" "gfx1034" +// GFX1034: "-target-cpu" "gfx1035" ---------------- Typo in check prefix. Why didn't this make the test fail? ================ Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:177 case GK_GFX1034: return ELF::EF_AMDGPU_MACH_AMDGCN_GFX1034; case GK_NONE: return ELF::EF_AMDGPU_MACH_NONE; } ---------------- Please update this switch too. ================ Comment at: llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll:91 ; RUN: llc -mtriple=amdgcn-amd-amdhsa --amdhsa-code-object-version=3 -mcpu=gfx1034 < %s | FileCheck --check-prefixes=V3-GFX1034 %s +; RUN: llc -mtriple=amdgcn-amd-amdhsa --amdhsa-code-object-version=3 -mcpu=gfx1035 < %s | FileCheck --check-prefixes=V3-GFX1035 %s ---------------- You've added a RUN line here but no checks that use the new prefix. (Doesn't that make llvm-lit complain?) ================ Comment at: llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll:183 ; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1034 < %s | FileCheck --check-prefixes=GFX1034 %s ; V3-GFX600: .amdgcn_target "amdgcn-amd-amdhsa--gfx600" ---------------- Add a RUN line here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https://reviews.llvm.org/D104804 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
