[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

darwin added a comment. In D104044#2816397 , @MyDeveloperDay wrote: > I think we can agree its complicated, how about you take your unit tests and > show us what the "code change" looks like to fix the bug > > If that gets overly convoluted then perhaps

[clang] 54bd95c - [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba

Author: Krasimir Georgiev Date: 2021-06-15T10:28:36+02:00 New Revision: 54bd95cd96bc7305219b594f95d7d1f447ee4c94 URL: https://github.com/llvm/llvm-project/commit/54bd95cd96bc7305219b594f95d7d1f447ee4c94 DIFF: https://github.com/llvm/llvm-project/commit/54bd95cd96bc7305219b594f95d7d1f447ee4c94.d

[PATCH] D104209: [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba

This revision was automatically updated to reflect the committed changes. Closed by commit rG54bd95cd96bc: [clang-format] distinguish function type casts after… (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104209/new/ https:

[clang] bbebf38 - [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

Author: Valeriy Savchenko Date: 2021-06-15T11:37:35+03:00 New Revision: bbebf38b736a12c9582f9ae59c8e245a6ed68cb8 URL: https://github.com/llvm/llvm-project/commit/bbebf38b736a12c9582f9ae59c8e245a6ed68cb8 DIFF: https://github.com/llvm/llvm-project/commit/bbebf38b736a12c9582f9ae59c8e245a6ed68cb8.d

[clang] 85f475c - [analyzer] Extract ControlDependencyHandler

Author: Valeriy Savchenko Date: 2021-06-15T11:37:36+03:00 New Revision: 85f475c979aa49b1b833c9e66af9cb35eafd02c7 URL: https://github.com/llvm/llvm-project/commit/85f475c979aa49b1b833c9e66af9cb35eafd02c7 DIFF: https://github.com/llvm/llvm-project/commit/85f475c979aa49b1b833c9e66af9cb35eafd02c7.d

[clang] 1639dcb - [analyzer] Extract NilReceiverHandler

Author: Valeriy Savchenko Date: 2021-06-15T11:37:36+03:00 New Revision: 1639dcb2798469c4372e50bcb6b4cf36ecffd9ce URL: https://github.com/llvm/llvm-project/commit/1639dcb2798469c4372e50bcb6b4cf36ecffd9ce DIFF: https://github.com/llvm/llvm-project/commit/1639dcb2798469c4372e50bcb6b4cf36ecffd9ce.d

[clang] 40cb73b - [analyzer] Extract ArrayIndexHandler

Author: Valeriy Savchenko Date: 2021-06-15T11:37:36+03:00 New Revision: 40cb73bd20735051eb8f2d43735097d2ff46f0a7 URL: https://github.com/llvm/llvm-project/commit/40cb73bd20735051eb8f2d43735097d2ff46f0a7 DIFF: https://github.com/llvm/llvm-project/commit/40cb73bd20735051eb8f2d43735097d2ff46f0a7.d

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbebf38b736a: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103

[clang] 2e49067 - [analyzer] Extract InterestingLValueHandler

Author: Valeriy Savchenko Date: 2021-06-15T11:37:36+03:00 New Revision: 2e490676ea2eb419e7b2f54e1e2e537d5244ebbc URL: https://github.com/llvm/llvm-project/commit/2e490676ea2eb419e7b2f54e1e2e537d5244ebbc DIFF: https://github.com/llvm/llvm-project/commit/2e490676ea2eb419e7b2f54e1e2e537d5244ebbc.d

[clang] 6e6a26b - [analyzer] Extract InlinedFunctionCallHandler

Author: Valeriy Savchenko Date: 2021-06-15T11:37:36+03:00 New Revision: 6e6a26b8f0ea8300d5a814e4150e225c33ec25de URL: https://github.com/llvm/llvm-project/commit/6e6a26b8f0ea8300d5a814e4150e225c33ec25de DIFF: https://github.com/llvm/llvm-project/commit/6e6a26b8f0ea8300d5a814e4150e225c33ec25de.d

[PATCH] D103677: [analyzer] Extract ControlDependencyHandler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85f475c979aa: [analyzer] Extract ControlDependencyHandler (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 16f7a95 - [analyzer] Simplify the process of producing notes for stores

Author: Valeriy Savchenko Date: 2021-06-15T11:37:36+03:00 New Revision: 16f7a952ec3e0f362690c6449951866100c6f76c URL: https://github.com/llvm/llvm-project/commit/16f7a952ec3e0f362690c6449951866100c6f76c DIFF: https://github.com/llvm/llvm-project/commit/16f7a952ec3e0f362690c6449951866100c6f76c.d

[PATCH] D103902: [analyzer] Extract NilReceiverHandler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1639dcb27984: [analyzer] Extract NilReceiverHandler (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D103902?vs=35&

[PATCH] D103914: [analyzer] Extract ArrayIndexHandler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40cb73bd2073: [analyzer] Extract ArrayIndexHandler (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D103914?vs=351113&i

[PATCH] D103917: [analyzer] Extract InterestingLValueHandler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e490676ea2e: [analyzer] Extract InterestingLValueHandler (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D103917?vs=3

[PATCH] D103961: [analyzer] Extract InlinedFunctionCallHandler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e6a26b8f0ea: [analyzer] Extract InlinedFunctionCallHandler (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D103961?vs

[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16f7a952ec3e: [analyzer] Simplify the process of producing notes for stores (authored by vsavchenko). Changed prior to commit: https://reviews.llv

[clang] eadd54f - [analyzer] Decouple NoteTag from its Factory

Author: Valeriy Savchenko Date: 2021-06-15T11:58:13+03:00 New Revision: eadd54f2741f9dc7307512382a7c8fb49aa840d0 URL: https://github.com/llvm/llvm-project/commit/eadd54f2741f9dc7307512382a7c8fb49aa840d0 DIFF: https://github.com/llvm/llvm-project/commit/eadd54f2741f9dc7307512382a7c8fb49aa840d0.d

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeadd54f2741f: [analyzer] Decouple NoteTag from its Factory (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:777 static bool classof(const ProgramPointTag *T) { return T->getTagKind() == &Kind; } NoQ wrote: > vsavchenko wrote: > > NoQ wrote: > > >

[PATCH] D68891: Remove unnecessary triple from test

JohnTitor added a subscriber: rnk. JohnTitor added a comment. ping @rnk Seems you added this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing list cfe-co

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

lebedev.ri added a comment. The test is still intermittently failing on bots. Is there some non-determinism in the change? It may be a good idea to revert this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko updated this revision to Diff 352075. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104136/new/ https://reviews.llvm.org/D104136 Files: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCoun

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression..

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { +LangTag = llvm::dwarf::DW_LANG_OpenCL; shchenz wrote: > I think for

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, xazax.hun, r.stahl. ASDenysPetrov added a project: clang. Herald added subscribers: manas, steakhal, martong, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. ASDenys

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. Do we actually need this lit test? Mostly we only add lit tests when we add a new command line argument, I feel your are just testing what we also test in the unittests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Wawha added a comment. In D104222#2817147 , @MyDeveloperDay wrote: > @Wawha do you have a project that perhaps uses this work your did? I would > like to ensure I didn't break anything @MyDeveloperDay Good idea! I just test on my code, and I see 2 type

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2818606 , @sberg wrote: > (In a build prior to > https://reviews.llvm.org/rGc60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 "Revert > '[clang] NRVO: Improvements and handling of more cases.'") I see the > following (reduced

[clang] 69cfa17 - Clearly specify that these are partially implemented features

Author: Aaron Ballman Date: 2021-06-15T07:28:29-04:00 New Revision: 69cfa178b77d91205cf8cf45fa00e28b1730d0a1 URL: https://github.com/llvm/llvm-project/commit/69cfa178b77d91205cf8cf45fa00e28b1730d0a1 DIFF: https://github.com/llvm/llvm-project/commit/69cfa178b77d91205cf8cf45fa00e28b1730d0a1.diff

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { +LangTag = llvm::dwarf::DW_LANG_OpenCL; stuart wrote: > shchenz wro

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

shchenz created this revision. shchenz added reviewers: dblaikie, aprantl, Esme, stuart, PowerPC. shchenz added a project: debug-info. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This partially reverts the change in https://revi

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ae766e78e0: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 45ae766 - [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

Author: Alexey Bataev Date: 2021-06-15T04:58:02-07:00 New Revision: 45ae766e78e07434f68305d1b56bf3ee65ebbcef URL: https://github.com/llvm/llvm-project/commit/45ae766e78e07434f68305d1b56bf3ee65ebbcef DIFF: https://github.com/llvm/llvm-project/commit/45ae766e78e07434f68305d1b56bf3ee65ebbcef.diff

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith updated this revision to Diff 352101. bsmith marked an inline comment as done. bsmith added a comment. - Ensure user input is sanitized for when asserts are not enabled - Fix clang format issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:298-299 + bool LittleEndian, + unsigned MinSVEVectorSizeInBitsOverride = 0, + unsigned MaxSVEVectorSizeInBitsOverride = 0); ---

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

christophe-calmejane added a comment. Hi, Due to the pandemic, I wasn't able to look at https://reviews.llvm.org/D44609 which got broken since it was pushed to LLVM. Nevertheless I commented in that post with a rather complete unit tests that should pass if any changes are to be pushed to that

[clang] 304b9c2 - [Matrix] Add tests for fast-math flags & matrix codegen.

Author: Florian Hahn Date: 2021-06-15T13:22:34+01:00 New Revision: 304b9c25d58d611287c51c50cc0fe4a8c16f6f0d URL: https://github.com/llvm/llvm-project/commit/304b9c25d58d611287c51c50cc0fe4a8c16f6f0d DIFF: https://github.com/llvm/llvm-project/commit/304b9c25d58d611287c51c50cc0fe4a8c16f6f0d.diff

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Ok, looks good to me! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103792/new/ https://reviews.llvm.org/D103792

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn updated this revision to Diff 352108. fhahn added a comment. In D102478#2817768 , @erichkeane wrote: > Just a couple of nits here, basically see how much we can put in the 'cheap > to check' branch. Thanks! I moved the suggested bits inside the t

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. I think, at this point, the sensible thing to do is to pull the test. As @MyDeveloperDay points out it isn't really adding any value above and beyond the unit tests. If it were non-determinism in the change itself the unit tests would catch it. They test the same formatt

[PATCH] D104295: removes redundant test

feg208 created this revision. feg208 added reviewers: MyDeveloperDay, HazardyKnusperkeks, vitalybuka. feg208 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This lit test is causing intermittent failures on buildbots. It isn't testing anyt

[PATCH] D104242: Alters a lit test to simplify and avoid a buildbot error

feg208 added a comment. I put up a separate commit that just removes the test. I think this would resolve the builder issues but I don't think its worth even trying. We should abandon this (I think) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:339 +void makeUniqueForOverwriteReturnsNullUniquePtr() { + auto P = std::make_unique_for_overwrite(); // expected-note {{std::unique_ptr 'P' cons

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 352127. RedDocMD added a comment. Fixed up meaning of make_unique_for_overwrite, use `getConjuredHeapSymbolVal`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 File

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

jlpeyton accepted this revision. jlpeyton added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Wawha added a comment. Hi @christophe-calmejane. I test your code with a old version (few time after the merge of https://reviews.llvm.org/D44609), and the latest version (commit: e0c382a9d5a0 ), and in both cases I have the s

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

christophe-calmejane added a comment. In D104222#2819324 , @Wawha wrote: > Hi @christophe-calmejane. > I test your code with a old version (few time after the merge of > https://reviews.llvm.org/D44609), and the latest version (commit: > e0c382a9d5a0 >

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:216-220 +// TODO: ExprEngine should do this for us. +auto &Engine = State->getStateManager().getOwningEngine(); +State = Engine.updateObjectsUnderConstruction( +

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. @Wawha your cases could be covered by the following (in mustBreakBefore) if (Style.BraceWrapping.BeforeLambdaBody && Right.is(TT_LambdaLBrace) && Left.isOneOf(tok::star, tok::amp, tok::ampamp)) { return true; } As I think its the presence of & and *

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart marked an inline comment as done. stuart added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { +LangTag = llvm::dwarf::DW_LANG_OpenCL;

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. @christophe-calmejane are you able to post your .clang-format styles that you are using, I'm struggling to see where its not matching your style (other than brace styles on the function and argument placing) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

stuart added a comment. This looks good to me. @jzzheng22 informs me there was a comment in D99250 to the effect that DW_LANG_C_plus_plus_03 is not emitted, at all - it too was introduced in DWARF 5. I wonder if this should be addressed in a separate commit?

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay updated this revision to Diff 352136. MyDeveloperDay added a comment. Add some of the failing cases identified by @Wawha CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 Files: clang/lib/Format/TokenAnnotator.cpp clang/unitte

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart planned changes to this revision. stuart added a comment. Changes will be required to align this with D104291 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 __

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Wawha added a comment. In D104222#2819358 , @MyDeveloperDay wrote: > @Wawha your cases could be covered by the following (in mustBreakBefore) > > if (Style.BraceWrapping.BeforeLambdaBody && Right.is(TT_LambdaLBrace) && > Left.isOneOf(tok::star, t

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, rsmith. Herald added a subscriber: dexonsmith. serge-sans-paille requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D104300: [analyzer] Handle `std::swap`

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, teemperor, xazax.hun. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this re

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352146. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Basic/IdentifierTable.h clang/lib/Basic/IdentifierTable.cpp clang/lib/Parse/ParseExprCXX.cpp clang/test/Se

[PATCH] D104300: [analyzer] Handle `std::swap`

RedDocMD added a comment. I am not entirely satisfied with the note that is being emitted currently from the `std::swap` handling (its ripped off from the note emitted for `std::unique_ptr::swap`). Any suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D104300: [analyzer] Handle `std::swap`

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:94-103 const auto *RecordDecl = MethodDecl->getParent(); - if (!RecordDecl || !RecordDecl->getDeclContext()->isStdNamespace()) + return isStdSmartPtr(RecordDecl); +} + +bool

[PATCH] D104300: [analyzer] Handle `std::swap`

vsavchenko added a comment. It looks like new functionality is VERY much like `handleSwap`, and we should definitely merge common parts. Also, I think that commit title should be more specific than "Handle std::swap". It should at least mention the checker. Repository: rG LLVM Github Monor

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352153. kda added a comment. - attempting to make documentation pretty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files: clang/docs/AddressSanitizer.rst clang/d

[PATCH] D104295: removes redundant test

feg208 added a comment. If I could get someone to land this commit on my behalf I'd be obliged. I am working on the getting commit rights since that seems to be a pretty significant impediment to developing in llvm land but as of now I can't land this myself. name: Fred Grim email: fg...@apple

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new option will run the semantic checks and then dump the parse tree and a

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Wawha added a comment. In D104222#2819422 , @MyDeveloperDay wrote: > Add some of the failing cases identified by @Wawha Thank for the fix. I test and discover a new case with a regression: auto createObj = [this] -> std::unique_ptr

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

Quuxplusone added a comment. @sberg: Thanks for the example! @mizvekov's comments are correct, but I wanted to put some more comments here for posterity. (I'll also try to find a place for this real-world example in the next revision of p2266

[clang] a6948da - DirectoryWatcher: close a possible window of race on Windows

Author: Saleem Abdulrasool Date: 2021-06-15T09:15:17-07:00 New Revision: a6948da86ad7e78d66b26263c2681ef6385cc234 URL: https://github.com/llvm/llvm-project/commit/a6948da86ad7e78d66b26263c2681ef6385cc234 DIFF: https://github.com/llvm/llvm-project/commit/a6948da86ad7e78d66b26263c2681ef6385cc234.

[clang] e32a92c - Remove unnecessary triple from test

Author: Yuki Okushi Date: 2021-06-15T09:49:45-07:00 New Revision: e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed URL: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed DIFF: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed.diff L

[PATCH] D68891: Remove unnecessary triple from test

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68891/new/ https://reviews.llvm.org/D68891 ___ cfe-commits mailing li

[PATCH] D68891: Remove unnecessary triple from test

This revision was automatically updated to reflect the committed changes. Closed by commit rGe32a92c6fe8e: Remove unnecessary triple from test (authored by JohnTitor, committed by rnk). Changed prior to commit: https://reviews.llvm.org/D68891?vs=224680&id=352167#toc Repository: rG LLVM Githu

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104279/new/ https://reviews.llvm.org/D104279 _

[PATCH] D104311: [clang] Fix a race condition in the build of clangInterpreter

stella.stamenova created this revision. stella.stamenova added a reviewer: v.g.vassilev. Herald added a subscriber: mgorny. stella.stamenova requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The library depends on Attributes.inc, so it has to

Re: [PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

On Mon, Jun 14, 2021 at 4:52 PM Wei Mi wrote: > > > On Mon, Jun 14, 2021 at 4:04 PM Xinliang David Li > wrote: > >> >> >> On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> lebedev.ri added a subscriber: MaskRay. >>> lebedev.ri added a comm

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

waltl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:761 + // There's no libpthread or librt on Android. + if (!TC.getTriple().isAndroid()) { CmdArgs.push_back("-lpthread"); Just to be super cautious, can be keep this line an

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld added a comment. Thanks for doing this. These changes look good, but I can't get them to build successfully. I'm using the GNU 9.3 C++ compiler. My build fails to link the bin/flang-new executable. Here's an excerpt of the error messages: [4436/4439] Generating ../../../../i

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

lebedev.ri updated this revision to Diff 352176. lebedev.ri retitled this revision from "[NewPM] Remove SpeculateAroundPHIs pass from pipeline" to "[NewPM] Remove SpeculateAroundPHIs pass". lebedev.ri added a comment. Herald added a subscriber: mgorny. On Tue, Jun 15, 2021 at 8:14 PM Wei Mi wrot

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

aeubanks accepted this revision. aeubanks added a comment. looks good, we can always revive the pass later if somebody wants it for some reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 ___

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 352178. ggeorgakoudis added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Rebase to NewGlobalization and amend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/n

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

lebedev.ri added a comment. I see. Going to land this now. Thanks for looking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 ___ cfe-commits mailing list cfe-

[clang] e523645 - [NewPM] Remove SpeculateAroundPHIs pass

Author: Roman Lebedev Date: 2021-06-15T20:35:55+03:00 New Revision: e52364532afb2748c324f360bc1cc12605d314f3 URL: https://github.com/llvm/llvm-project/commit/e52364532afb2748c324f360bc1cc12605d314f3 DIFF: https://github.com/llvm/llvm-project/commit/e52364532afb2748c324f360bc1cc12605d314f3.diff

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe52364532afb: [NewPM] Remove SpeculateAroundPHIs pass (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld added a comment. Stay tuned a little, I think I spotted the problem ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 ___ cfe-commits mailing li

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Looks great! Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 _

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

leonardchan updated this revision to Diff 352186. leonardchan marked 2 inline comments as done. leonardchan retitled this revision from "[compiler-rt][hwasan] Add SHADOW_OFFSET macro" to "[compiler-rt][hwasan] Add GetShadowOffset function". Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

lebedev.ri added a comment. (This is not offload-specific, right?) This does not bring any compatibility issues, right? Does this bring any compatibility issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D10

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 352189. ychen added a comment. - Merge D102145 by @ChuanqiXu's request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc006b3e5dc3: [compiler-rt][hwasan] Add GetShadowOffset function (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 352191. SaurabhJha added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst Index: cla

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 352192. SaurabhJha added a comment. Document matrix scalar division Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/LanguageExtensions.rst In

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay updated this revision to Diff 352193. MyDeveloperDay added a comment. Add support for TemplateCloser before LambdaBrace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittes

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan updated this revision to Diff 352194. leonardchan added a comment. Rebase and remove `__hwasan_shadow_memory_dynamic_address`. We don't need to set it anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.l

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D104082#2818281 , @ahatanak wrote: > C++ non-virtual thunks and global initialization functions > (`_GLOBAL__sub_I_*`) have only linkage names.

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:217 + if (&BR.getBugType() != smartptr::getNullDereferenceBugType() || + !BR.isInteresting(FirstArgThisRegion)) +return; vsavchenk

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD added a comment. The current implementation of how notes are emitted in `handleSwap` is broken. Consider the following code: #include void foo() { auto ptr1 = std::unique_ptr(new int(10)); auto ptr2 = std::unique_ptr(new int(13)); ptr1.swap(ptr2); ptr1.reset();

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD updated this revision to Diff 352201. RedDocMD added a comment. Refactored common code, removed note emission Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 Files: clang/lib/StaticAnalyzer/Che

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD added a comment. I have gotten rid of notes for the time being. The trouble is that, we were not figuring out whether the null-pointer de-reference was occurring due to the null value being swapped with the current pointer. We just //assumed// that. So I am guessing we would need a visi

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

MaskRay added a comment. For the function attributing disabling instrumentation of -fprofile-generate/-fprofile-instr-generate/-fcs-profile-generate/-fprofile-arcs, how about `no_profile`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104253/new/

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers updated this revision to Diff 352208. nickdesaulniers added a comment. - fixup double fn attr in test as per @melver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104253/new/ https://reviews.llvm.org/D104253 Files: clang/lib/Cod

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

HazardyKnusperkeks added a comment. Just asking: Would it be different if there is `auto`, `decltype(auto)`, `decltype(a+b)`, `typename` or `template` as trailing return type? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 __

  1   2   >