stuart added inline comments.
================ Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { + LangTag = llvm::dwarf::DW_LANG_OpenCL; ---------------- shchenz wrote: > I think for non-strict DWARF mode, we still can generate `DW_LANG_OpenCL` for > the DWARF version lower than 5? Seems we also need to fix above > `DW_LANG_C_plus_plus_14` and `DW_LANG_C_plus_plus_11` If we have a `-gstrict-dwarf` option for this, then it would seem better to add `DW_LANG_C_plus_plus_17` and `DW_LANG_C_plus_plus_20` definitions and generate those for the `!CGM.getCodeGenOpts().DebugStrictDwarf` case. //C++ for OpenCL// would then use one of the more recent language tag values for the time being (without any special logic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits