[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:79 + if (!Deduced.isNull()) { +SourceRange R = D->getReturnTypeSourceRange(); +// For operator auto(), have to get location of `auto` a different way. sammccall

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

nridge updated this revision to Diff 351788. nridge added a comment. Put hint in trailing return type position Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103789/new/ https://reviews.llvm.org/D103789 Files: clang-tools-extra/clangd/InlayHints.

[PATCH] D99810: [ifs] Prepare llvm-ifs for elfabi/ifs merging.

phosek accepted this revision. phosek added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/InterfaceStub/ELFObjHandler.h:25 namespace elfabi { Shouldn't this be in namespace `ifs`? Comment a

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

RKSimon added reviewers: pengfei, craig.topper. RKSimon added a comment. This leaves the question - what hardware should we align each of the CK_x86_64_v* targets with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104116/new/ https://reviews.llvm

[clang] 669771c - [clang][deps] NFC: Preserve the original frontend action

Author: Jan Svoboda Date: 2021-06-14T10:49:25+02:00 New Revision: 669771cfe75b48ac4c195ce9e8824319be973f4d URL: https://github.com/llvm/llvm-project/commit/669771cfe75b48ac4c195ce9e8824319be973f4d DIFF: https://github.com/llvm/llvm-project/commit/669771cfe75b48ac4c195ce9e8824319be973f4d.diff L

[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

This revision was automatically updated to reflect the committed changes. Closed by commit rG669771cfe75b: [clang][deps] NFC: Preserve the original frontend action (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D103461?vs=349229&id=351795#toc Repository: rG LLV

[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

jansvoboda11 added a comment. In D103461#2815913 , @dexonsmith wrote: > Okay, LGTM. (Sorry for the delay, I've been out.) > > In D103461#2793254 , @jansvoboda11 > wrote: > >> My reason for the FIXME is that we c

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

hans added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:7 + +class EqDefaultCompare { + int unused_; The test case feels a little strange to me, I mean the member variable is still pretty unused even though I suppose the compari

[clang] 78668c8 - [clang][modules][pch] Allow loading PCH with different modules cache path

Author: Jan Svoboda Date: 2021-06-14T11:04:56+02:00 New Revision: 78668c822af9504f77a554f5924e1097365d9c33 URL: https://github.com/llvm/llvm-project/commit/78668c822af9504f77a554f5924e1097365d9c33 DIFF: https://github.com/llvm/llvm-project/commit/78668c822af9504f77a554f5924e1097365d9c33.diff L

[PATCH] D103802: [clang][modules][pch] Allow loading PCH with different modules cache path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78668c822af9: [clang][modules][pch] Allow loading PCH with different modules cache path (authored by jansvoboda11). Repository: rG LLVM Github Mon

[clang] 9223209 - [clang][deps] Handle precompiled headers' AST files

Author: Jan Svoboda Date: 2021-06-14T11:28:39+02:00 New Revision: 9223209be11e93c1b701054c6fff88d46ee54658 URL: https://github.com/llvm/llvm-project/commit/9223209be11e93c1b701054c6fff88d46ee54658 DIFF: https://github.com/llvm/llvm-project/commit/9223209be11e93c1b701054c6fff88d46ee54658.diff L

[PATCH] D103524: [clang][deps] Handle precompiled headers' AST files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9223209be11e: [clang][deps] Handle precompiled headers' AST files (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D104209: [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/commit/21c18d5a04316891110cecc2bf37ce51533decba improved the detection of multiplication in function all argument

[clang] a83ef21 - Fix -Wswitch warning after 092c303955cd18be6c0b923b1c0a1b96e2c91893.

Author: Haojian Wu Date: 2021-06-14T11:52:49+02:00 New Revision: a83ef21ff82e4283044fd31470fc6c1bc4b99c51 URL: https://github.com/llvm/llvm-project/commit/a83ef21ff82e4283044fd31470fc6c1bc4b99c51 DIFF: https://github.com/llvm/llvm-project/commit/a83ef21ff82e4283044fd31470fc6c1bc4b99c51.diff LO

[clang] 4629554 - [clang][deps] Handle modular dependencies present in PCH

Author: Jan Svoboda Date: 2021-06-14T11:59:35+02:00 New Revision: 4629554f0b664c94ada7c44fe40855d7a9a39820 URL: https://github.com/llvm/llvm-project/commit/4629554f0b664c94ada7c44fe40855d7a9a39820 DIFF: https://github.com/llvm/llvm-project/commit/4629554f0b664c94ada7c44fe40855d7a9a39820.diff L

[PATCH] D103526: [clang][deps] Handle modular dependencies present in PCH

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4629554f0b66: [clang][deps] Handle modular dependencies present in PCH (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.o

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

MyDeveloperDay added a comment. I think we can agree its complicated, how about you take your unit tests and show us what the "code change" looks like to fix the bug If that gets overly convoluted then perhaps we can bring the idea forward of a more generalised approach. Repository: rZORG L

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

MyDeveloperDay added a comment. This issue was resolved by https://github.com/llvm/llvm-project/commit/d5e9ff4fe20e66d53a245645c95f0bb816b747cb could you please close out this review Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43957/new/ https://reviews.llvm.

[clang] 8ddbb44 - [Analyzer][solver] Simplify existing eq classes and constraints when a new constraint is added

Author: Gabor Marton Date: 2021-06-14T12:19:09+02:00 New Revision: 8ddbb442b6e87efc9c6599280740c6f4fc40963d URL: https://github.com/llvm/llvm-project/commit/8ddbb442b6e87efc9c6599280740c6f4fc40963d DIFF: https://github.com/llvm/llvm-project/commit/8ddbb442b6e87efc9c6599280740c6f4fc40963d.diff

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ddbb442b6e8: [Analyzer][solver] Simplify existing eq classes and constraints when a new… (authored by martong). Changed prior to commit: https://

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. > This patch is the first step of a sequence of patches, and not intended to be > commited as a standalone change. Although I planned to commit this in a lock-step when subsequent patches are also accepted, it makes sense to commit now since it's an obvious improvement

[clang] 35fa3e6 - [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library

Author: Jan Svoboda Date: 2021-06-14T12:23:32+02:00 New Revision: 35fa3e60d1612dcc4f8e233b046423d948ca9a9b URL: https://github.com/llvm/llvm-project/commit/35fa3e60d1612dcc4f8e233b046423d948ca9a9b DIFF: https://github.com/llvm/llvm-project/commit/35fa3e60d1612dcc4f8e233b046423d948ca9a9b.diff L

[PATCH] D104012: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps` to `DependencyScanning` library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35fa3e60d161: [clang][deps] Move stripping of diagnostic serialization from `clang-scan-deps`… (authored by jansvoboda11). Repository: rG LLVM Git

[clang] d8bab69 - [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library

Author: Jan Svoboda Date: 2021-06-14T12:23:33+02:00 New Revision: d8bab69ead22a10dc4cdb2e36f6ea6fdfe774e2e URL: https://github.com/llvm/llvm-project/commit/d8bab69ead22a10dc4cdb2e36f6ea6fdfe774e2e DIFF: https://github.com/llvm/llvm-project/commit/d8bab69ead22a10dc4cdb2e36f6ea6fdfe774e2e.diff L

[clang] cf7d970 - [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library

Author: Jan Svoboda Date: 2021-06-14T12:23:33+02:00 New Revision: cf7d9704688db746b26d739a6e154ad54b6b676e URL: https://github.com/llvm/llvm-project/commit/cf7d9704688db746b26d739a6e154ad54b6b676e DIFF: https://github.com/llvm/llvm-project/commit/cf7d9704688db746b26d739a6e154ad54b6b676e.diff L

[PATCH] D104030: [clang][deps] Move invocation adjustments from `clang-scan-deps` to `DependencyScanning` library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8bab69ead22: [clang][deps] Move invocation adjustments from `clang-scan-deps` to… (authored by jansvoboda11). Changed prior to commit: https://re

[clang] 6c6dcfc - [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library

Author: Jan Svoboda Date: 2021-06-14T12:23:33+02:00 New Revision: 6c6dcfc4ce750bb7dc15d0a4ad631c66beed70d4 URL: https://github.com/llvm/llvm-project/commit/6c6dcfc4ce750bb7dc15d0a4ad631c66beed70d4 DIFF: https://github.com/llvm/llvm-project/commit/6c6dcfc4ce750bb7dc15d0a4ad631c66beed70d4.diff L

[PATCH] D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf7d9704688d: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to… (authored by jansvoboda11). Repository: rG LLVM Github Monor

[PATCH] D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c6dcfc4ce75: [clang][deps] Move enabling system header deps from `clang-scan-deps` to… (authored by jansvoboda11). Repository: rG LLVM Github Mon

[clang] 1d8882b - [clang][deps] Fix failing modules.cpp test

Author: Jan Svoboda Date: 2021-06-14T12:55:56+02:00 New Revision: 1d8882b5e44e577f226b7a5a83c27df3b16b3ab6 URL: https://github.com/llvm/llvm-project/commit/1d8882b5e44e577f226b7a5a83c27df3b16b3ab6 DIFF: https://github.com/llvm/llvm-project/commit/1d8882b5e44e577f226b7a5a83c27df3b16b3ab6.diff L

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. Herald added a subscriber: sstefan1. Tracking a possible bug, https://bugs.llvm.org/show_bug.cgi?id=50702 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/new/ https://reviews.llvm.org/D44609

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. namespace test { class Test { public: Test() = default; }; } // namespace test Getting miss formatted when BeforeLambdaBody is true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/new/ http

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3741 tok::colon, tok::l_square, tok::at) || + (Style.BraceWrapping.BeforeLambdaBody && Right.is(tok::l_brace)) || (Left.is(tok::r_paren) &&

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2069-2070 +// this point. +// TODO: Shouldn't we track control dependencies of every bug location, +// rather than only tracked expressions? +if (LVState->getAnalysi

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:367-368 +/// \param Origin Only adds notes when the last store happened in a +///different stackframe to this one. Disregarded if the tracking kind +///

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3312 + auto ShortLambdaOption = Style.AllowShortLambdasOnASingleLine; + if (Style.BraceWrapping.BeforeLambdaBody && + (isAllmanBraceIncludedBreakableLambda(Left, ShortLambdaOption) || ---

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:194 CompilerInstance &I, DependencyConsumer &C, - std::map> - OriginalPrebuiltModuleFiles); +

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:367-368 +/// \param Origin Only adds notes when the last store happened in a +///different stackframe to this one. Disregarded if the tracking kind +//

[clang] 41115ef - [clang][deps] NFC: Check the correct context hashes in tests

Author: Jan Svoboda Date: 2021-06-14T13:58:19+02:00 New Revision: 41115efca642981c2165cdf9ef2b2148605faa12 URL: https://github.com/llvm/llvm-project/commit/41115efca642981c2165cdf9ef2b2148605faa12 DIFF: https://github.com/llvm/llvm-project/commit/41115efca642981c2165cdf9ef2b2148605faa12.diff L

[clang] 80c0c63 - [clang][deps] Prevent unintended modifications of the original TU command-line

Author: Jan Svoboda Date: 2021-06-14T13:58:19+02:00 New Revision: 80c0c639687ef52f5c432ea059ff9cb53125d08e URL: https://github.com/llvm/llvm-project/commit/80c0c639687ef52f5c432ea059ff9cb53125d08e DIFF: https://github.com/llvm/llvm-project/commit/80c0c639687ef52f5c432ea059ff9cb53125d08e.diff L

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80c0c639687e: [clang][deps] Prevent unintended modifications of the original TU command-line (authored by jansvoboda11). Changed prior to commit:

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

thakis added a comment. Either this or your concurrent commit broke check-clang: http://45.33.8.238/linux/48839/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104036/new/

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5961-5962 if (Error Err = ImportDeclParts(D, DC, LexicalDC, Name, ToD, Loc)) return std::move(Err); Do you think that the alternative approach that is used with `TypedefNameDecl`

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

jansvoboda11 added a comment. In D104036#2816602 , @thakis wrote: > Either this or your concurrent commit broke check-clang: > http://45.33.8.238/linux/48839/step_7.txt > > Please take a look and revert for now if it takes a while to fix. This test has

[clang] f39dcf8 - [clang][deps] NFC: Fix an XFAIL test on Windows

Author: Jan Svoboda Date: 2021-06-14T14:37:26+02:00 New Revision: f39dcf85f994b464946cd6702bbceadc518ce904 URL: https://github.com/llvm/llvm-project/commit/f39dcf85f994b464946cd6702bbceadc518ce904 DIFF: https://github.com/llvm/llvm-project/commit/f39dcf85f994b464946cd6702bbceadc518ce904.diff L

[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

mgartmann updated this revision to Diff 351838. mgartmann marked 5 inline comments as done. mgartmann added a comment. - removed empty configs from tests - moved documentation to Google's check - extended matchers so that namespaces for classes and conversion operators can be specified - adjusted

[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

mgartmann added inline comments. Comment at: clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp:28-30 + std::string FullOperatorName = + Node.getParent()->getNameAsString().append("::").append( + Node.getNameAsString()); aaron.ballma

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2263-2264 Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) { addHighPriorityHandler(); + addLowPriorityHandler(); // TODO: split trackExpressionValue and Fi

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2263-2264 Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) { addHighPriorityHandler(); + addLowPriorityHandler(); // TODO: split trackExpressionValue and F

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, Wawha, krasimir. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=50702 I believe D44609: [clang-format] N

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

Szelethus added a comment. I know I'm late to the party, and am just mostly thinking aloud. Awesome patch series! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:331-341 +/// Visitor that tracks expressions and values. +class TrackingBugR

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2263-2264 Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) { addHighPriorityHandler(); + addLowPriorityHandler(); // TODO: split trackExpressionValue and Fi

[clang] f95ff81 - [clang][deps] NFC: Handle `DependencyOutputOptions` only once

Author: Jan Svoboda Date: 2021-06-14T15:16:08+02:00 New Revision: f95ff81627212a8db9f942aafa91392096538847 URL: https://github.com/llvm/llvm-project/commit/f95ff81627212a8db9f942aafa91392096538847 DIFF: https://github.com/llvm/llvm-project/commit/f95ff81627212a8db9f942aafa91392096538847.diff L

[clang] 85208b9 - [clang][deps] NFC: Stop using moved-from object

Author: Jan Svoboda Date: 2021-06-14T15:16:08+02:00 New Revision: 85208b96b85f6f3e502cf4b7fd5f440434d1c7e5 URL: https://github.com/llvm/llvm-project/commit/85208b96b85f6f3e502cf4b7fd5f440434d1c7e5 DIFF: https://github.com/llvm/llvm-project/commit/85208b96b85f6f3e502cf4b7fd5f440434d1c7e5.diff L

[PATCH] D104106: [clang][deps] NFC: Stop using moved-from object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85208b96b85f: [clang][deps] NFC: Stop using moved-from object (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104104: [clang][deps] NFC: Handle `DependencyOutputOptions` only once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf95ff8162721: [clang][deps] NFC: Handle `DependencyOutputOptions` only once (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

serge-sans-paille added a comment. In D104116#2816291 , @RKSimon wrote: > This leaves the question - what hardware should we align each of the > CK_x86_64_v* targets with? I'm not quite sure I get it. If I understand correctly, each `CK_x86_64_v*` impl

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added subscribers: rjmccall, hans. hans added a comment. We're seeing new build errors in Chromium after this (http://crbug.com/1219457). Here's a reduced example: $ cat /tmp/a.mm #include struct Callback { // Move-only! Callback(const Callback&) = delete; Callback& op

[PATCH] D98068: Remove asserts for LocalInstantiationScope

yaxunl added a comment. ping I will provide a detailed description of the issue: What happen are: First, fun1 is instantiated as `fun1<0,1>`, which calls lambda function `f(f, Number<1>)`. This causes lambda function `f` instantiated as `f(f, Number<1>)`. clang uses LocalInstantiationScope t

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone added a comment. @hans: FYI, that looks related to the immediately following D99005 , not D99696 specifically. I suspect that reverting D99005 (but leaving D99696

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added a comment. > @hans: FYI, that looks related to the immediately following D99005 > , not D99696 > specifically. No, my test case passes at 0d9e8f5f4b68252c6caa1ef81a30777b2f5d7242

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. Thanks for the patch! some comments inline. Comment at: clang/docs/LanguageExtensions.rst:527 +The matrix type extension supports compound assignments for addition, subtraction, and multiplication, provided +their types are consistent. +

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann updated this revision to Diff 351869. mgartmann marked 10 inline comments as done. mgartmann added a comment. - changed name of check to `cppcoreguidelines-virtual-class-destructor` - removed matcher for class or struct in AST matcher - changed string concatenations to use `llvm::twine`

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann added a comment. Thanks a lot for your feedback, @aaron.ballman! I was able to incorporate it in the updated diff. On your advice, I also ran this check on a large open source project using the `run-clang-tidy.py` script. I decided to do it on the llvm project itself as follows: m

[clang] c60dd3b - Revert "[clang] NRVO: Improvements and handling of more cases."

Author: Hans Wennborg Date: 2021-06-14T16:46:58+02:00 New Revision: c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 URL: https://github.com/llvm/llvm-project/commit/c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 DIFF: https://github.com/llvm/llvm-project/commit/c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72.diff

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added a comment. Since it seems more discussion is needed here, I've reverted in c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 . Since they were hard to tease apart, the revert is for both D99696

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Wawha added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3760 - (isAllmanBraceIncludedBreakableLambda(Left, ShortLambdaOption) || - isAllmanBraceIncludedBreakableLambda(Right, ShortLambdaOption))) { -return true; Without this co

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

Szelethus added a comment. Sorry for the absence, took my time to catch up with this series! Really interesting insight into how a new interface is being designed! I need some time to digest things, but can't wait to help on the remaining patches. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added a comment. In D103605#2816979 , @Szelethus wrote: > Sorry for the absence, took my time to catch up with this series! Really > interesting insight into how a new interface is being designed! I need some > time to digest things, but can'

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

rjmccall added a comment. When `__block` variables get moved to the heap, they're supposed to be moved if possible, not copied. It looks like PerformMoveOrCopyInitialization requires NRVO info to be passed in to ever do a move. Maybe it's being passed in wrong when building `__block` copy exp

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. @Wawha do you have a project that perhaps uses this work your did? I would like to ensure I didn't break anything Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 _

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5961-5962 if (Error Err = ImportDeclParts(D, DC, LexicalDC, Name, ToD, Loc)) return std::move(Err); martong wrote: > Do you think that the alternative approach that is used with

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay updated this revision to Diff 351895. MyDeveloperDay added a comment. Remove unused functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

lichray added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode(&InitializingVar .bind("declStmt")), +Body

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

stella.stamenova added a comment. This change is generating warnings when building with clang: /usr/bin/clang++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Basic -I/mnt/vss/_w

[PATCH] D103087: [clang-tidy] performances-unnecessary-* checks: Extend isOnlyUsedAsConst to expressions and catch const methods returning non-const references/pointers.

ymandel added a comment. In D103087#2813901 , @flx wrote: > In D103087#2793673 , @ymandel wrote: > >> I have some concerns about the cost of this checks as it used matching over >> entire contexts quite extensive

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Added support for CXXRewrittenBinaryOperator as a condition in ran

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith updated this revision to Diff 351910. bsmith marked 7 inline comments as done. bsmith added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Move attribute/command line logic into AArch64TargetMachine. - Fix issue with subtarget key appending integers. - A

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:226 + : SVEVectorBitsMaxOpt), TargetTriple(TT), FrameLowering(), InstrInfo(initializeSubtargetDependencies(FS, CPU)), TSInfo(), sd

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

feg208 created this revision. feg208 added reviewers: HazardyKnusperkeks, Bigcheese. feg208 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D104242 Files: clang/lib/Format/W

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104125/new/ https://reviews.llvm.org/D104125 _

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:298-299 + bool LittleEndian, + unsigned MinSVEVectorSizeInBitsOverride = 0, + unsigned MaxSVEVectorSizeInBitsOverride = 0); ---

[clang] 20f7b5f - [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

Author: Michael Benfield Date: 2021-06-14T10:25:59-07:00 New Revision: 20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7 URL: https://github.com/llvm/llvm-project/commit/20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7 DIFF: https://github.com/llvm/llvm-project/commit/20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7.di

[PATCH] D103623: [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20f7b5f3f9c8: [Clang] Test case for -Wunused-but-set-variable, warn for volatile. (authored by mbenfield, committed by george.burgess.iv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. > A crash (https://bugs.llvm.org/show_bug.cgi?id=50663) in 12.0.1 is fixed by > your changes here when merged to the 12 branch, I'm not sure if this needs to > be backported to 12 I guess it might depend on if we think it's critical > enough or if there will more 12 rele

[clang] 44f197e - [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive

Author: Alexey Bataev Date: 2021-06-14T10:36:27-07:00 New Revision: 44f197e94b83d389b59ce6a2a1977f972e6d34e3 URL: https://github.com/llvm/llvm-project/commit/44f197e94b83d389b59ce6a2a1977f972e6d34e3 DIFF: https://github.com/llvm/llvm-project/commit/44f197e94b83d389b59ce6a2a1977f972e6d34e3.diff

[PATCH] D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44f197e94b83: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target… (authored by ABataev). Herald added a project: clang. Heral

[clang] d650ccf - [NFC] Remove unused variable

Author: Vitaly Buka Date: 2021-06-14T10:57:26-07:00 New Revision: d650ccf6390bb1e4454dd735cfcec9eda9af8ca3 URL: https://github.com/llvm/llvm-project/commit/d650ccf6390bb1e4454dd735cfcec9eda9af8ca3 DIFF: https://github.com/llvm/llvm-project/commit/d650ccf6390bb1e4454dd735cfcec9eda9af8ca3.diff L

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a subscriber: tstellar. MyDeveloperDay added a comment. I think we've missed the deadline for 12.0.1 which I believe was last friday. I did a practice merge and it didn't quite go in cleanly to 12.0.X branch Normally we would mark the bug in the bug tracker for the next rele

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan updated this revision to Diff 351931. leonardchan marked 10 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.llvm.org/D103936 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104240/new/ https://reviews.llvm.org/D104240 ___

[PATCH] D98068: Exampt asserts for recursive lambdas about LocalInstantiationScope

yaxunl updated this revision to Diff 351934. yaxunl retitled this revision from "Remove asserts for LocalInstantiationScope" to "Exampt asserts for recursive lambdas about LocalInstantiationScope". yaxunl edited the summary of this revision. yaxunl added a comment. re-enable the assert but with e

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan created this revision. leonardchan added reviewers: eugenis, vitalybuka, pcc. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This allows for other implementations to defi

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

bmahjour added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:248 + enum class VectorCompareCompatKind { +// Default clang behaviour. +// All vector compares produce scalars except vector Pixel and vector bool. How about adding `Def

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse Most of this code can actually be reused f

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, melver, void. Herald added a subscriber: wenlei. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. noprofile IR attribute already exists to preve

[clang] 4e15560 - [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

Author: Alexey Bataev Date: 2021-06-14T11:50:27-07:00 New Revision: 4e155608796b79d7e369f4e42980ce670bff7172 URL: https://github.com/llvm/llvm-project/commit/4e155608796b79d7e369f4e42980ce670bff7172 DIFF: https://github.com/llvm/llvm-project/commit/4e155608796b79d7e369f4e42980ce670bff7172.diff

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e155608796b: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops. (authored by ABataev). Repository: rG LLVM Github Mon

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan updated this revision to Diff 351953. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files: compiler-rt/lib/hwasan/hwasan_thread.cpp compiler-rt/lib/hwasan/hwasan_thread.h Index: compiler

  1   2   >