[clang] fcf8827 - [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C

Author: ShihPo Hung Date: 2021-06-04T15:33:14+08:00 New Revision: fcf8827a98beb1f8baea883451508d9cd91f57bc URL: https://github.com/llvm/llvm-project/commit/fcf8827a98beb1f8baea883451508d9cd91f57bc DIFF: https://github.com/llvm/llvm-project/commit/fcf8827a98beb1f8baea883451508d9cd91f57bc.diff L

[PATCH] D103603: [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf8827a98be: [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C (authored by arcbbb). Repository: rG LLVM

[clang] 21c18d5 - [Format] Fix incorrect pointer detection

Author: Yilong Guo Date: 2021-06-04T09:39:23+02:00 New Revision: 21c18d5a04316891110cecc2bf37ce51533decba URL: https://github.com/llvm/llvm-project/commit/21c18d5a04316891110cecc2bf37ce51533decba DIFF: https://github.com/llvm/llvm-project/commit/21c18d5a04316891110cecc2bf37ce51533decba.diff LO

[PATCH] D103589: [Format] Fix incorrect pointer detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG21c18d5a0431: [Format] Fix incorrect pointer detection (authored by Nuu, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103589/new

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

steakhal added a comment. There is so much fancy stuff going on upstream. Awesome to see. I'm trying to catch up ASAP, I'm finally done with my master's thesis. In D103096#2798238 , @NoQ wrote: > Additionally, presence of cast symbols is extremely valuab

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. In D98726#2719100 , @RedDocMD wrote: > Judging by this line > > in the `LikelyFalse

[PATCH] D103228: [PoC][RISCV] Using pragma to register vector intrinsic

kito-cheng updated this revision to Diff 349784. kito-cheng added a comment. Changes: - Using less invasive way to add intrinsic functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103228/new/ https://reviews.llvm.org/D103228 Files: clang/

[PATCH] D103228: [PoC][RISCV] Using pragma to register vector intrinsic

kito-cheng updated this revision to Diff 349785. kito-cheng added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reupload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103228/new/ https://reviews.llvm.org/D103228

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

steakhal added a comment. Overall I think it's a useful checker not only for checking the `getenv()` but a bunch of other functions as well, which might return a pointer to a statically allocated buffer. The implementation could be polished a bit but it's ok I think. About the produced reports,

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:282 + +if (c >= -20 && d >= -40) { + clang_analyzer_eval((c + d) < -1); // expected-warning{{TRUE}} manas wrote: > vsavchenko wrote: > > Great, it's good to check negati

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added a comment. In D103440#2797991 , @manas wrote: >> I also would like to see tests where the ranges are not going all the way to >> either INT_MIN or INT_MAX (if we talk about int), but overflow still might >> happen, and cases where overf

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

sdesmalen added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-v-lifetime.cpp:17 +// CHECK-NEXT:[[TMP1:%.*]] = bitcast * [[REF_TMP]] to i8* +// CHECK-NEXT:call void @llvm.lifetime.start.p0i8(i64 -1, i8* [[TMP1]]) #[[ATTR3]] +// CHECK-NEXT:[[CALL:%.*]] =

[PATCH] D103184: [AArch64] handle -Wa,-march=

DavidSpickett accepted this revision. DavidSpickett added a comment. > LGTM; any additional thoughts @DavidSpickett ? A couple of additional tests just to be safe but otherwise LGTM. Comment at: clang/test/Driver/aarch64-target-as-march.s:29 +// RUN: FileCheck --check-prefix=M

[PATCH] D103677: [analyzer] Extract ControlDependencyHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

mstorsjo added inline comments. Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast i8* %argp.cur to double* rnk wrote: > These tests will s

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

azabaznov added a comment. In D102853#2773890 , @Anastasia wrote: > LGTM! Although I think it would be better if we set `__IMAGE_SUPPORT__` > conditionally also for earlier OpenCL versions. It has always been defined for SPIR target only. Should we wait

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/test/Analysis/constant-folding.c:282 + +if (c >= -20 && d >= -40) { + clang_analyzer_eval((c + d) < -1); // expected-warning{{TRUE}} vsavchenko wrote: > manas wrote: > > vsavchenko wrote: > > > Great, it's g

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 349796. manas added a comment. Fix for cases involving residual paths and add case for overflowing range near extremum of a type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org

[PATCH] D103317: [Analyzer][engine][solver] Simplify complex constraints

martong added a comment. In D103317#2794099 , @ASDenysPetrov wrote: >> ! In D103317#2793797 , @vsavchenko >> wrote: > > > >> I replied to you earlier that assignments are not producing constraints. >> The anal

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Nuu created this revision. Nuu added reviewers: djasper, HazardyKnusperkeks, curdeius, MyDeveloperDay. Nuu added a project: clang-format. Nuu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://llvm.org/PR50568 When an

[PATCH] D103317: [Analyzer][engine][solver] Simplify complex constraints

vsavchenko added a comment. In D103317#2794099 , @ASDenysPetrov wrote: >> ! In D103317#2793797 , @vsavchenko >> wrote: > > > >> I replied to you earlier that assignments are not producing constraints. >> The a

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added a comment. In D103605#2798171 , @NoQ wrote: > Ok. Oof. Whoa. That's amazing. > > Let me re-iterate to make sure that my understanding of this patchset is > correct. > > **Chapter 1.** //"A is correlated with B (ρ = 0.56), given C, assumi

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon created this revision. bcahoon added reviewers: rampitec, kzhuravl. Herald added subscribers: foad, dexonsmith, kerbowa, rupprecht, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, emaste, arsenm, jholewinski. Herald added a reviewer: jhenderson. Herald added a reviewer: M

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

raj.khem added a comment. http://sprunge.us/FJzZXL is a file from harfbuzz and it warns a.cc:28670:32: error: variable 'supp_size' set but not used [-Werror,-Wunused-but-set-variable] unsigned int size0, size1, supp_size = 0; I do not have -Werror enabled but it still is reported as err

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2798079 , @raj.khem wrote: > http://sprunge.us/FJzZXL is a file from harfbuzz and it warns > > a.cc:28670:32: error: variable 'supp_size' set but not used > [-Werror,-Wunused-but-set-variable] > unsigned int s

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. In D100581#2798079 , @raj.khem wrote: > http://sprunge.us/FJzZXL is a file from harfbuzz and it warns > > a.cc:28670:32: error: variable 'supp_size' set but not used > [-Werror,-Wunused-but-set-variable] > unsigned i

[PATCH] D103663: [AMDGPU] Add gfx1013 target

foad added a comment. Please also update `llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103663/new/ https://reviews.llvm.org/D103663 ___ cfe-commits m

[PATCH] D103663: [AMDGPU] Add gfx1013 target

foad added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:389 - xnack scratch - *pal-amdpal* + ``gfx1013`` ``amdgcn`` dGPU - cumode - Absolute - *rocm-amdhsa* *TB

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. TestTU now prints errors to llv

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8768 + verifyFormat("void f() { a.operator()(a * a); }"); + verifyFormat("void f() { a->operator()(a & a); }"); } can you add void f() { a.operator()(*a * *a); } Reposit

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:243 + bool OperatorCalledAsMemberFunction = + Prev->Previous && Prev->Previous->isOneOf(tok::period, tok::arrow); + Contexts.back().IsExpression = OperatorCalledAsMemberFuncti

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause. NFC.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103665/new/ https://reviews.llvm.org/D103665 ___

[PATCH] D103666: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103666/new/ https://reviews.llvm.org/D103666 ___

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SjoerdMeijer added a comment. Perhaps for bonus points, update the Clang documentation in https://clang.llvm.org/docs/LanguageExtensions.html#matrix-types with some examples? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101696/new/ https://revie

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

aganea added a comment. Thanks for the quick fix! Would you mind fixing the two failing tests please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/ https://reviews.llvm.org/D103664 ___ cfe-co

[PATCH] D103082: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

bsmith updated this revision to Diff 349827. bsmith marked an inline comment as done. bsmith added a comment. - Remove unnecessary complexity when zero-extending dupq operands into a vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103082/new/

Re: [PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

For sure, will do. On Fri, Jun 4, 2021 at 12:59 PM Sjoerd Meijer via Phabricator < revi...@reviews.llvm.org> wrote: > SjoerdMeijer added a comment. > > Perhaps for bonus points, update the Clang documentation in > https://clang.llvm.org/docs/LanguageExtensions.html#matrix-types with > some exampl

[clang] ceb6238 - [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

Author: Balázs Kéri Date: 2021-06-04T14:24:44+02:00 New Revision: ceb62388f2d8bd8deed447ebfed77ac7d9be293d URL: https://github.com/llvm/llvm-project/commit/ceb62388f2d8bd8deed447ebfed77ac7d9be293d DIFF: https://github.com/llvm/llvm-project/commit/ceb62388f2d8bd8deed447ebfed77ac7d9be293d.diff L

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rGceb62388f2d8: [clang][AST] Set correct DeclContext in ASTImporter lookup table for… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman updated this revision to Diff 349833. aaron.ballman added a comment. Update based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103611/new/ https://reviews.llvm.org/D103611 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/varargs.cpp Index:

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman added a comment. In D103611#2797044 , @efriedma wrote: > I'm a little nervous about using C type merging in C++; it's not designed to > support C++ types, so it might end up crashing or something like that. I > think I'd prefer to explici

[clang] 93a0581 - [clang][deps] Add argument for customizing PCM paths

Author: Jan Svoboda Date: 2021-06-04T14:45:18+02:00 New Revision: 93a058190cc67c18bf4e0af9d871d56106b80a49 URL: https://github.com/llvm/llvm-project/commit/93a058190cc67c18bf4e0af9d871d56106b80a49 DIFF: https://github.com/llvm/llvm-project/commit/93a058190cc67c18bf4e0af9d871d56106b80a49.diff L

[PATCH] D103516: [clang][deps] Add argument for customizing PCM paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93a058190cc6: [clang][deps] Add argument for customizing PCM paths (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D

[clang] 20bd214 - [flang][driver] Add support for `-module-suffix`

Author: Andrzej Warzynski Date: 2021-06-04T13:58:04+01:00 New Revision: 20bd2142d46536f4ffd61f28a029d6bda68f1a7f URL: https://github.com/llvm/llvm-project/commit/20bd2142d46536f4ffd61f28a029d6bda68f1a7f DIFF: https://github.com/llvm/llvm-project/commit/20bd2142d46536f4ffd61f28a029d6bda68f1a7f.d

[clang] de07b1e - [clang][deps] Support object files

Author: Jan Svoboda Date: 2021-06-04T14:58:42+02:00 New Revision: de07b1e84d8de948304766df602fee2b845e9532 URL: https://github.com/llvm/llvm-project/commit/de07b1e84d8de948304766df602fee2b845e9532 DIFF: https://github.com/llvm/llvm-project/commit/de07b1e84d8de948304766df602fee2b845e9532.diff L

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

This revision was automatically updated to reflect the committed changes. Closed by commit rG20bd2142d465: [flang][driver] Add support for `-module-suffix` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/ https://r

[PATCH] D103519: [clang][deps] Support object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde07b1e84d8d: [clang][deps] Support object files (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D103519?vs=349245&i

[clang] b5dea87 - [HIP] Fix spack HIP device lib detection

Author: Yaxun (Sam) Liu Date: 2021-06-04T09:12:41-04:00 New Revision: b5dea8701ba98425991d4f1ec3d87bdb98789e04 URL: https://github.com/llvm/llvm-project/commit/b5dea8701ba98425991d4f1ec3d87bdb98789e04 DIFF: https://github.com/llvm/llvm-project/commit/b5dea8701ba98425991d4f1ec3d87bdb98789e04.dif

[PATCH] D103281: [HIP] Fix spack HIP device lib detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5dea8701ba9: [HIP] Fix spack HIP device lib detection (authored by yaxunl). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

martong added a comment. In D103605#2798171 , @NoQ wrote: > Ok. Oof. Whoa. That's amazing. > > Let me re-iterate to make sure that my understanding of this patchset is > correct. > > **Chapter 1.** //"A is correlated with B (ρ = 0.56), given C, assuming

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. In D103314#2790868 , @vsavchenko wrote: > Awesome! > I know, I said that we are ready to land, but I think I was too excited about > this change. We probably should have some data on how it performs on > real-life codebases. J

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349854. Jake-Egan marked 3 inline comments as done. Jake-Egan added a comment. Use LangStandard::isC11() and one C99 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D1

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2792160 , @tra wrote: > In D101630#2792052 , @yaxunl wrote: > >> I think for intermediate outputs e.g. preprocessor expansion, IR, and >> assembly, probably it makes sense not t

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349855. Jake-Egan added a comment. Use LangStandard::isC11() and one C99 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files: clang/lib/Basic/Targets/OSTa

[clang] 86c2449 - [OpenCL][NFC] Test commit: tidy up whitespace in comment

Author: Stuart Brady Date: 2021-06-04T14:44:12+01:00 New Revision: 86c24493ea666a0ef91b7af884d616b0a181e849 URL: https://github.com/llvm/llvm-project/commit/86c24493ea666a0ef91b7af884d616b0a181e849 DIFF: https://github.com/llvm/llvm-project/commit/86c24493ea666a0ef91b7af884d616b0a181e849.diff

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:122 #define FB(Name, K) MIX_##Name = (1ull << (K##ull - 1ull)) whisperity wrote: > martong wrote: > > FB stands for FunnyBitmask? Could you p

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:75 + if (llvm::sys::fs::createUniqueDirectory("module-cache", ModuleCachePath)) +llvm_unreachable("Failed to create temp directory for module-cache"); CI.getHeaderSearchOpts().Modul

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added reviewers: rsmith, rjmccall. aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point +

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong added a comment. Perhaps all conversion related logic should go into their own implementation file? Seems like it adds up to roughly 1000 lines. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:1171 +

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:550-551 + if (isUselessSugar(LType.getTypePtr())) { +LLVM_DEBUG(llvm::dbgs() + << "--- calculateMixability. LHS is useless sugar.\n"); retu

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. question for @aaron.ballman Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated. If

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity marked 5 inline comments as done. whisperity added a comment. In D75041#2799023 , @martong wrote: > Perhaps all conversion related logic should go into their own implementation > file? Seems like it adds up to roughly 1000 lines. That's agains

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated. If unsafe floating p

[PATCH] D103587: [AIX] Transfer predefined macros

cebowleratibm requested changes to this revision. cebowleratibm added a comment. This revision now requires changes to proceed. I think it makes sense to split the __STDC macro changes and __TOS_AIX__ into different patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349868. awarzynski added a comment. Rebase on top of main, revert one small change uploaded accidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files: c

[clang] 827b5c2 - [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

Author: Alexey Bataev Date: 2021-06-04T07:32:14-07:00 New Revision: 827b5c21545aaa820403e9b5cced8c0181349ee2 URL: https://github.com/llvm/llvm-project/commit/827b5c21545aaa820403e9b5cced8c0181349ee2 DIFF: https://github.com/llvm/llvm-project/commit/827b5c21545aaa820403e9b5cced8c0181349ee2.diff

[PATCH] D103642: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG827b5c21545a: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper`… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D103646: [OPENMP]Fix PR50129: omp cancel parallel not working as expected.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit below. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:538 +omp::Directive CanceledDirective, +

[clang] f917c5b - Revert test fixups after e9a9c850989e (which reverted a14fc74).

Author: Nico Weber Date: 2021-06-04T10:42:25-04:00 New Revision: f917c5b8d40b7894d52d56052bb18f8e989bad9e URL: https://github.com/llvm/llvm-project/commit/f917c5b8d40b7894d52d56052bb18f8e989bad9e DIFF: https://github.com/llvm/llvm-project/commit/f917c5b8d40b7894d52d56052bb18f8e989bad9e.diff LO

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

adamcz marked an inline comment as done. adamcz added a comment. I didn't put much thought into where --check-lines goes. It's an interesting thought. I think having all the flags in one place is more valuable than trying to split them in some way. We contain all flags in the same place, close

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

adamcz updated this revision to Diff 349878. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103538/new/ https://reviews.llvm.org/D103538 Files: clang-tools-extra/clangd/tool/Check.cpp clang-tools-extra/cl

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. wco Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7155 -if (EH.Asynch) - CmdArgs.push_back("-fasync-exceptions"); } Not really sure I understand this change. Isn't the case that if I compile with -EHa, I want the -fasy

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

jlpeyton accepted this revision. jlpeyton added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 ___ cfe-commits mailing list cfe-commits

[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

kadircet added a comment. > Sorry I've lost my context - did we decide to move forward with this patch? I don't think we've came to a conclusion, just decided to postpone until needed. I believe the `cases` design is really a good fit for making tweaks expose multiple code actions. But we've a

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349881. awarzynski added a comment. Fix build and test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files: clang/include/clang/Driver/Options.td fla

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12821 +/// Determine whether an expression is constant without emitting diagnostic. +static bool isConstantExpression(Sema &SemaRef, Expr *E) { + struct ConstTripcountDiagnoser : public Sema::VerifyICEDiagn

[PATCH] D103097: Add DWARF address spaces mapping for SPIR

stuart added inline comments. Comment at: clang/test/CodeGenOpenCL/spir-debug-info-pointer-address-space.cl:22 +// CHECK-DAG: distinct !DIGlobalVariable(name: "FileVar5", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: {{[0-9]+}}, type: ![[DWARF_ADDRESS_SPACE_GLOBAL]], isLocal: fa

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

balazske added a comment. I have not too deep knowledge about checker development but still found (hopefully valid) issues, even if only a part of them. Comment at: clang/docs/analyzer/checkers.rst:2117 +// envp may no longer point to the current environment +/

[clang-tools-extra] eba3ee0 - [clangd] Run code completion on each token coverd by --check-lines

Author: Adam Czachorowski Date: 2021-06-04T17:51:42+02:00 New Revision: eba3ee04d450230f7ac1f88b1abd7b09c600c82d URL: https://github.com/llvm/llvm-project/commit/eba3ee04d450230f7ac1f88b1abd7b09c600c82d DIFF: https://github.com/llvm/llvm-project/commit/eba3ee04d450230f7ac1f88b1abd7b09c600c82d.d

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

This revision was automatically updated to reflect the committed changes. Closed by commit rGeba3ee04d450: [clangd] Run code completion on each token coverd by --check-lines (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103538/n

[clang] b109172 - [clang] use a different name for generated test cdb

Author: Mikhail Goncharov Date: 2021-06-04T18:12:58+02:00 New Revision: b109172d993edacd9853a8bbb8128a94da014399 URL: https://github.com/llvm/llvm-project/commit/b109172d993edacd9853a8bbb8128a94da014399 DIFF: https://github.com/llvm/llvm-project/commit/b109172d993edacd9853a8bbb8128a94da014399.d

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

rjmccall added a comment. Thanks, Akira. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/ https://reviews.llvm.org/D98799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-v-lifetime.cpp:3 +// REQUIRES: riscv-registered-target +// RUN: %clang_cc1 -std=c++11 -triple riscv64 -target-feature +experimental-v \ +// RUN: -emit-llvm -O1 -o - %s | FileCheck %s

[PATCH] D103611: Correct the behavior of va_arg checking in C++

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103611/new/ https://reviews.llvm.org/D103611 ___ cfe-commits mailing list cfe-commi

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2798975 , @yaxunl wrote: > For sure we will need -fgpu-bundle-device-output to control bundling of > intermediate files. Then adding -emit-gpu-object and -emit-gpu-bundle may be > redundant and can cause confusion. What i

[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103040/new/ https://reviews.llvm.org/D103040 ___

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2799409 , @tra wrote: > In D101630#2798975 , @yaxunl wrote: > >> For sure we will need -fgpu-bundle-device-output to control bundling of >> intermediate files. Then adding -emit

[clang] 4d9f852 - CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include variable name

Author: Konstantin Zhuravlyov Date: 2021-06-04T13:10:00-04:00 New Revision: 4d9f8527dbfbc998baf35eec868c9dec1f8d1224 URL: https://github.com/llvm/llvm-project/commit/4d9f8527dbfbc998baf35eec868c9dec1f8d1224 DIFF: https://github.com/llvm/llvm-project/commit/4d9f8527dbfbc998baf35eec868c9dec1f8d12

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d9f8527dbfb: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include… (authored by kzhuravl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 333987b - [OpenCL] Add DWARF address spaces mapping for SPIR

Author: Jason Zheng Date: 2021-06-04T18:10:54+01:00 New Revision: 333987b0458926332e9a1f96869ef47da25fa9b1 URL: https://github.com/llvm/llvm-project/commit/333987b0458926332e9a1f96869ef47da25fa9b1 DIFF: https://github.com/llvm/llvm-project/commit/333987b0458926332e9a1f96869ef47da25fa9b1.diff L

[PATCH] D103097: Add DWARF address spaces mapping for SPIR

This revision was automatically updated to reflect the committed changes. Closed by commit rG333987b04589: [OpenCL] Add DWARF address spaces mapping for SPIR (authored by jzzheng22, committed by stuart). Changed prior to commit: https://reviews.llvm.org/D103097?vs=348910&id=349910#toc Reposito

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 updated this revision to Diff 349912. jcai19 added a comment. Address the comments and add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 Files: clang/lib/Driver/ToolChains/Arch/AArc

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 added a comment. In D103184#2798398 , @DavidSpickett wrote: >> LGTM; any additional thoughts @DavidSpickett ? > > A couple of additional tests just to be safe but otherwise LGTM. > > Also please include in the commit message the "rules" that we're

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers requested changes to this revision. nickdesaulniers added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/aarch64-target-as-march.s:29 +// RUN: FileCheck --check-prefix=MULTIPLE-VALUES %s + +// MULTIPLE-VALUES: "-targe

[PATCH] D103587: [AIX] Transfer __TOS_AIX__ predefined macro

Jake-Egan updated this revision to Diff 349913. Jake-Egan added a comment. Use this patch to target only __TOS_AIX__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files: clang/lib/Basic/Targets/OSTar

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2799425 , @yaxunl wrote: > But how do we control emitting LLVM IR with or without bundle? `-emit-llvm > -emit-gpu-object` or `-emit-llvm -emit-gpu-bundle`? `-emit-*` is usually for > specifying a specific file type. Hmm.

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay updated this revision to Diff 349915. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Re-upload after revert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103372/new/ https://reviews.llvm.org/

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay added a comment. @vsk Do you mind investigating macOS `Posix/instrprof-dynamic-one-shared.test` and `Posix/instrprof-dynamic-two-shared.test` failures on https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8845381350758503248/+/steps/package_clang/0/stdout ? :

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2799472 , @tra wrote: > In D101630#2799425 , @yaxunl wrote: > >> But how do we control emitting LLVM IR with or without bundle? `-emit-llvm >> -emit-gpu-object` or `-emit-llvm -

  1   2   >