aaron.ballman added a comment. In D103611#2797044 <https://reviews.llvm.org/D103611#2797044>, @efriedma wrote:
> I'm a little nervous about using C type merging in C++; it's not designed to > support C++ types, so it might end up crashing or something like that. I > think I'd prefer to explicitly convert enum types to their underlying type. I got lulled into thinking `mergeTypes()` worked for C++ because it handles references and cites the C++ standard first thing. But I see later that it also claims some C++ types are unreachable. So I switched to the underlying type for the enumeration, good suggestion! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103611/new/ https://reviews.llvm.org/D103611 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
