[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100976/new/ https://reviews.llvm.org/D100976 ___ cfe-co

[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2db090a2ebd7: [llvm][AsmPrinter] Restore source location to register clobber warning (authored by DavidSpickett). Repository: rG LLVM Github Monor

[clang] 2db090a - [llvm][AsmPrinter] Restore source location to register clobber warning

Author: David Spickett Date: 2021-05-14T08:22:57Z New Revision: 2db090a2ebd76f120bfae4fbe4b7241667aa585e URL: https://github.com/llvm/llvm-project/commit/2db090a2ebd76f120bfae4fbe4b7241667aa585e DIFF: https://github.com/llvm/llvm-project/commit/2db090a2ebd76f120bfae4fbe4b7241667aa585e.diff LOG

[PATCH] D102473: [clang][deps] Stop assuming the TU's context hash

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The context hash of modular dependencies can be different from the context hash of the or

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra updated this revision to Diff 345381. AbbasSabra added a comment. Updating D102280 : [analyzer] Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102280/new/ https://reviews.llvm.org/D1022

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra marked 2 inline comments as done. AbbasSabra added a comment. > Please, add these reviewers for your upcoming [analyzer] patches. Thanks, I was planning to add reviewers after making sure that the pre-checks are green. > Nice to see some fixes for visual c++ stuff. Thanks for the qu

[PATCH] D102473: [clang][deps] Stop assuming the TU's context hash

jansvoboda11 updated this revision to Diff 345383. jansvoboda11 added a comment. Use `std::unordered_map` again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102473/new/ https://reviews.llvm.org/D102473 Files: clang/include/clang/Tooling/Depende

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added a comment. Do you have any good (mature, big enough) open-source projects for these msvc constructs? Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:352 + case Stmt::SEHLeaveStmtClass: case Stmt::ContinueStmtClass: AbbasSa

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy updated this revision to Diff 345386. condy added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang/codegen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D10

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

MyDeveloperDay added a comment. In D102392#2756779 , @curdeius wrote: > LGTM. Not blocking, but I'd add foo4 example from the description as a test > case (with a link to the bug maybe). Of course I should have added that too! let me do that! Reposito

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 345333. shchenz added a comment. 1: add the FIXME for the duplicated tags issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: llvm/lib/CodeGen/AsmPrinter/D

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. Thanks for your comments! @dblaikie @aprantl . I think we have an agreement that we should handle the strict dwarf tag in the backend. And for duplicated tags issue, since it may need a while to fix, I have added a TODO in the code change and also update to test case to

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, rsmith, erichkeane. Herald added subscribers: dexonsmith, tschuett. fhahn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. The matrix extension requires the indices

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder created this revision. tbaeder added a reviewer: tejohnson. Herald added subscribers: dang, inglorion. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current behavior was introduced in https://github.com/llvm/llvm-proj

[PATCH] D102473: [clang][deps] Stop assuming the TU's context hash

jansvoboda11 updated this revision to Diff 345399. jansvoboda11 added a comment. Shuffle lines around to minimize diff in the next patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102473/new/ https://reviews.llvm.org/D102473 Files: clang/incl

[PATCH] D102473: [clang][deps] Stop assuming the TU's context hash

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:147 const Module *TopLevelModule = Imported->getTopLevelModule(); - MDC.ModularDeps[MDC.ContextHash + TopLevelModule->getFullModuleName()] - .ImportedByMainFile =

[PATCH] D102482: [clang][deps] NFC: Report modules' context hash

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch eagerly constructs and modifies CompilerInvocation of modular dependencies in

[clang] 0566f97 - [clang][NFC] remove unused return value

Author: Nathan Sidwell Date: 2021-05-14T05:25:47-07:00 New Revision: 0566f979619cf49a62804a7e3530438f1319fa7c URL: https://github.com/llvm/llvm-project/commit/0566f979619cf49a62804a7e3530438f1319fa7c DIFF: https://github.com/llvm/llvm-project/commit/0566f979619cf49a62804a7e3530438f1319fa7c.diff

[PATCH] D102480: [clang][NFC] remove unused return value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0566f979619c: [clang][NFC] remove unused return value (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To reduce the number of explicit builds of a single module, we can try to squash multiple

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn created this revision. fhahn added reviewers: jroelofs, ab, scanon, arphaman. Herald added subscribers: dexonsmith, dang. fhahn requested review of this revision. Herald added a project: clang. Support for Darwin's libsystem_m's vector functions has been added to LLVM in 93a9a8a8d90f

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

Rin updated this revision to Diff 345411. Rin added a comment. Remove unnecessary comment and add more bitreverse tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102397/new/ https://reviews.llvm.org/D102397 Files: clang/lib/CodeGen/CGBuiltin

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 345412. jansvoboda11 added a comment. Undo changes to `modules-full.cpp` test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Lex/He

[PATCH] D102473: [clang][deps] NFC: Stop assuming the TU's context hash

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:182 /// Direct and transitive modular dependencies of the main source file. - std::unordered_map ModularDeps; + std::unordered_map ModularDeps; /// Options

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345416. urnathan added a comment. Herald added subscribers: cfe-commits, usaxena95, kadircet. Herald added a project: clang-tools-extra. Address the build failure --thanks for explaining, it wasn;t clear what else I should try and build. Grepping showed no

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

mibintc added a comment. In my premerge testing, I see this fail which looks like the check string is incorrect: command stderr: C:\ws\w16e2-2\llvm-project\premerge-checks\llvm\test\Other\new-pm-lto-defaults.ll:84:21: error: CHECK-O23SZ-NEXT: expected string not found in input ; CHECK

[PATCH] D102491: [clang][modules] Build inferred modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enables explicitly building inferred modules. Effectively a cherry-pick of htt

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com

[clang] 7cd2833 - [PowerPC] Add vec_vupkhpx and vec_vupklpx for XL compatibility

Author: Nemanja Ivanovic Date: 2021-05-14T08:02:00-05:00 New Revision: 7cd2833311ab614775bc695e7bb808159a02e2a9 URL: https://github.com/llvm/llvm-project/commit/7cd2833311ab614775bc695e7bb808159a02e2a9 DIFF: https://github.com/llvm/llvm-project/commit/7cd2833311ab614775bc695e7bb808159a02e2a9.di

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra updated this revision to Diff 345422. AbbasSabra added a comment. Updating D102280 : [analyzer] rename test file + make sure that statements after "__leave" are not reached Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. I split out the support for building inferred modules explicitly: D102491 . Patch with changes to the dependency scanner will follow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. In D102280#2759167 , @steakhal wrote: > Do you have any good (mature, big enough) open-source projects for these msvc > constructs? https://github.com/microsoft/winfile and https://github.com/chakra-core/ChakraCore seem to b

[clang] 3d59f9d - [ARM][AArch64] Correct __ARM_FEATURE_CRYPTO macro and crypto feature

Author: David Candler Date: 2021-05-14T14:19:46+01:00 New Revision: 3d59f9d22440645ca0237dfc5d91ca09f749174b URL: https://github.com/llvm/llvm-project/commit/3d59f9d22440645ca0237dfc5d91ca09f749174b DIFF: https://github.com/llvm/llvm-project/commit/3d59f9d22440645ca0237dfc5d91ca09f749174b.diff

[PATCH] D102406: [ARM][AArch64] Correct __ARM_FEATURE_CRYPTO macro and crypto feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d59f9d22440: [ARM][AArch64] Correct __ARM_FEATURE_CRYPTO macro and crypto feature (authored by dcandler). Repository: rG LLVM Github Monorepo CH

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn created this revision. fhahn added reviewers: jroelofs, ab, scanon, arphaman. fhahn requested review of this revision. Herald added a project: clang. Building on D102489 , default to Darwin_libsystem_m veclib on iOS based targets. Repository: rG LLVM Gi

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345426. urnathan added a comment. I stupidly tested that on the stack, not just the first diff. This removes the reference to bits from a later patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 File

[PATCH] D102495: [clang][deps] Support inferred modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for inferred modules to the dependency scanner. Effectively a che

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

dmgreen added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:556 } +if (Name.startswith("aarch64.neon.rbit")) { + NewFn = Intrinsic::getDeclaration(F->getParent(), Intrinsic::bitreverse, Do we have a test for the autoupgrade, to show that

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 345432. flip1995 added a comment. - [MC] Don't check if constructed MOFI is a nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101921/new/ https://reviews.llvm.org/D101921 Files: clang/lib/Parse/ParseS

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

aaronpuchert added a subscriber: aaron.ballman. aaronpuchert added a comment. @aaron.ballman, what do you think about this? We can't really prevent anyone from writing `.getValueKind() == VK_*Value` instead of `.is*Value()`, so this change will make things consistent only for now. In D100733#26

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12577-12578 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits; + OriginalInits.emplace_back(); if (!OMPLoopBasedDirective::doForAllLoops( `SmallVe

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added a comment. Some previous comments were not addressed yet Comment at: clang/include/clang/AST/OpenMPClause.h:972-974 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + Make it private

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

arphaman added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( Can you add an IRGen testcase that verifies that TLII is setting the vecLib c

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345435. AbbasSabra marked 4 inline comments as done. AbbasSabra added a comment. Updating D102273 : [analyzer] Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} vsavchenko wrote: > But actually, it's

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( arphaman wrote: > Can you add an IRGen testcase that verifies that TLII is settin

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m"); ---

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

arphaman added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( fhahn wrote: > arphaman wrote: > > Can you add an IRGen testcase that verifies

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr

aaronpuchert added a comment. Again, I'm not sure if it helps to use `getDecltypeForParenthesizedExpr` where we don't actually have the `decltype` of a parenthesized expression. It's probably not entirely coincidental, but things aren't defined this way. Comment at: clang/lib

[clang-tools-extra] ed33911 - [clangd] Always default to raw pch format

Author: Kadir Cetinkaya Date: 2021-05-14T16:34:57+02:00 New Revision: ed339111bff690c6ba87d5e25c50bcad6793a309 URL: https://github.com/llvm/llvm-project/commit/ed339111bff690c6ba87d5e25c50bcad6793a309 DIFF: https://github.com/llvm/llvm-project/commit/ed339111bff690c6ba87d5e25c50bcad6793a309.dif

[PATCH] D102418: [clangd] Always default to raw pch format

This revision was automatically updated to reflect the committed changes. Closed by commit rGed339111bff6: [clangd] Always default to raw pch format (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102418/new/ https://reviews.ll

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

olestrohm updated this revision to Diff 345436. olestrohm added a comment. Added a codegen test and clarified what some parts are testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102248/new/ https://reviews.llvm.org/D102248 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CodeGe

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:306 +// Set conditionally to provide correct diagnostics for 'double' type +llvm::StringRef FP64Feature( +getLangOpts().OpenCLVersion >= 300 ? "__opencl_c_fp64" : "cl_khr_fp64"); ---

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

vsavchenko added a comment. Thanks for addressing my comments! I still have some left though Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:171 + const Decl *D = LocCtxt->getDecl(); + const auto *MD = dyn_cast_or_null(D); + assert(MD && MD->getParent()->isLambda

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} AbbasSabra wrote: > vsavchenko wrote: >

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors

olestrohm updated this revision to Diff 345442. olestrohm added a comment. Fixed the code style and added some comments to the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101519/new/ https://reviews.llvm.org/D101519 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sem

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/test/CodeGenOpenCLCXX/addrspace-constructors.clcpp:22 + +// CHECK: @cx1 = dso_local addrspace(2) constant %struct.X zeroinitializer, al

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Just remember to reflect your final change in the commit message description. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101519/new/ https://reviews.llvm.or

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark created this revision. danlark added a reviewer: rsmith. danlark requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix ternary operator in for loop argument, it was by mistake not set as CanBeForRangeDecl and led to incorrect codegen

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn updated this revision to Diff 345449. fhahn added a comment. Add end-to-end test, as suggested. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102489/new/ https://reviews.llvm.org/D102489 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m"); --

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( arphaman wrote: > fhahn wrote: > > arphaman wrote: > > > Can you add an IRGen tes

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

lebedev.ri added a comment. This should have codegen, and maybe AST, tests. Comment at: clang/test/Parser/cxx2a-init-statement.cpp:18 + for (int i = 0; int x = i < 2 ? 1 : 0; i++) {} + This isn't cxx2a-specific isn't it? Isn't this valid even in C99? Repos

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark added a comment. In D102502#2759776 , @lebedev.ri wrote: > This should have codegen, and maybe AST, tests. Will add shortly Comment at: clang/test/Parser/cxx2a-init-statement.cpp:18 + for (int i = 0; int x = i < 2 ? 1 : 0;

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. Hi @hubert.reinterpretcast, Would you mind testing this patch: diff diff --git a/clang/lib/Interpreter/Interpreter.cpp b/clang/lib/Interpreter/Interpreter.cpp index 8de38c0afcd9..79acb5bd6898 100644 --- a/clang/lib/Interpreter/Interpreter.cpp +++ b/clang/

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Ideally we should avoid the ifdef, but we don't have a good proxy for case sensitivity of the filesystem here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102339/new/ https://revie

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark updated this revision to Diff 345458. danlark added a comment. - Add codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseTentative.cpp clang/test/CodeGenCX

[PATCH] D102125: [Matrix] Implement static cast for matrix types

SaurabhJha added a comment. I am planning to commit this on Sunday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102125/new/ https://reviews.llvm.org/D102125 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D102507: [HIP] Support in device code

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: mgorny. yaxunl requested review of this revision. This patch adds wrapper headers for `` and a few others which is required to support ``. The basic idea is to make template functions defined in these headers h

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark updated this revision to Diff 345460. danlark added a comment. - Add codegen and AST tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseTentative.cpp clang/test/

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark added a comment. Done, please, take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D102508: [HIP] Add test libstd_functional

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added a subscriber: mgorny. yaxunl requested review of this revision. This patch adds a test for using in HIP device code. Repository: rT test-suite https://reviews.llvm.org/D102508 Files: External/HIP/CMakeLists.txt

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D100733#2759592 , @aaronpuchert wrote: > @aaron.ballman, what do you think about this? We can't really prevent anyone > from writing `.getValueKind() == VK_*Value` instead of `.is

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

rsmith added a comment. Thanks, nice catch! Can we also add an assert when parsing a `for` statement that we actually find a range if the tentative parse said we were expecting one? Comment at: clang/test/CodeGenCXX/for-loop-init-ternary-operator-statement.cpp:1 +// RUN: %cla

[PATCH] D102508: [HIP] Add test libstd_functional

ashi1 added a comment. Looks good, let me verify on HIP builder. Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102508/new/ https://reviews.llvm.org/D102508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D102508: [HIP] Add test libstd_functional

yaxunl added a comment. In D102508#2759905 , @ashi1 wrote: > Looks good, let me verify on HIP builder. It depends on https://reviews.llvm.org/D102507 Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102508/new/ https:

[PATCH] D102508: [HIP] Add test libstd_functional

ashi1 added a comment. In D102508#2759906 , @yaxunl wrote: > In D102508#2759905 , @ashi1 wrote: > >> Looks good, let me verify on HIP builder. > > It depends on https://reviews.llvm.org/D102507 Okay, let's wait f

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2759808 , @v.g.vassilev wrote: > Hi @hubert.reinterpretcast, > > Would you mind testing this patch: Running it now. I've applied the first diff here to the base of my previously reported result to minimi

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

Rin updated this revision to Diff 345465. Rin added a comment. Add AutoUpgrade test and move bitreverse lowering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102397/new/ https://reviews.llvm.org/D102397 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM, but you should wait a bit before landing in case @rsmith or one of the other reviewers has concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

ymandel added a comment. Hi Felix, Can you clarify your concern over the warning? Is it the case that the warning is not present before the fix and is only triggered after the fix? I'm concerned that removing the call may have unintended side effects and I would think it might better to leave

[clang] 769cc33 - [OpenCL] Simplify use of C11 atomic types.

Author: Anastasia Stulova Date: 2021-05-14T17:43:00+01:00 New Revision: 769cc335e6e63e5eac0c0ac849de44714326e20b URL: https://github.com/llvm/llvm-project/commit/769cc335e6e63e5eac0c0ac849de44714326e20b DIFF: https://github.com/llvm/llvm-project/commit/769cc335e6e63e5eac0c0ac849de44714326e20b.d

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG769cc335e6e6: [OpenCL] Simplify use of C11 atomic types. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang.

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 345470. pzheng added a comment. Address @MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345471. AbbasSabra marked 7 inline comments as done. AbbasSabra added a comment. Updating D102273 : [analyzer] Apply code review part 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] b7d1ab7 - [HWASan] Add aliasing flag and enable HWASan to use it.

Author: Matt Morehouse Date: 2021-05-14T09:47:20-07:00 New Revision: b7d1ab75cf474fb3ffc7e7173762c4d83eb2ef8e URL: https://github.com/llvm/llvm-project/commit/b7d1ab75cf474fb3ffc7e7173762c4d83eb2ef8e DIFF: https://github.com/llvm/llvm-project/commit/b7d1ab75cf474fb3ffc7e7173762c4d83eb2ef8e.diff

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d1ab75cf47: [HWASan] Add aliasing flag and enable HWASan to use it. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102288/new/ htt

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG with some nits. After fixes, please wait one day or so in case there are further comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5500 + SmallString<128

[PATCH] D102507: [HIP] Support in device code

tra added a subscriber: rsmith. tra added a comment. In effect this patch applies `__host__ __device__` to a subset of the standard library headers and whatever headers *they* happen to include. While it may happen to work, I'm not at all confident that it does not create interesting issues. C

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

scott.linder updated this revision to Diff 345475. scott.linder added a comment. Add constexpr convenience variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100671/new/ https://reviews.llvm.org/D100671 Files: clang/include/clang/Basic/Dire

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

scanon added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m"); -

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2759808 , @v.g.vassilev wrote: > Hi @hubert.reinterpretcast, > > Would you mind testing this patch: Does the test try to generate native object files in some way? There is functionality (with some limita

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} vsavchenko wrote: > AbbasSabra wrote: >

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/lib/Sema/Sema.cpp:306 +// Set conditionally to provide correct diagnostics for 'double' type +llvm::StringRef FP64Feature( +getLangOpts().OpenCLVersion >= 300 ? "__opencl_c_fp64" : "cl_khr_fp64"); ---

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345482. AbbasSabra added a comment. Updating D102273 : [analyzer] Update comments + fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added inline comments. Comment at: clang/docs/SYCLSupport.rst:96 - global_space, constant_space + * - ``__attribute__((opencl_global_device))`` + - global_space I think we should extend conversion rules too. Repository: rG LLVM Github Mo

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan updated this revision to Diff 345484. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102374/new/ https://reviews.llvm.org/D102374 Files: clang/include/clang/Basic/TargetCXXABI.h clang/incl

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added a comment. In D102280#2759480 , @AbbasSabra wrote: > In D102280#2759167 , @steakhal > wrote: > >> Do you have any good (mature, big enough) open-source projects for these >> msvc constructs? > >

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx added a comment. In D102175#2759945 , @ymandel wrote: > Hi Felix, > Can you clarify your concern over the warning? Is it the case that the > warning is not present before the fix and is only triggered after the fix? > I'm concerned that removing th

[clang-tools-extra] fde5b24 - [clangd] Make unit test compatible with gtest 1.10.0

Author: Benjamin Kramer Date: 2021-05-14T19:37:46+02:00 New Revision: fde5b24963f42c8f21e32e1c5b19e81ddc52e575 URL: https://github.com/llvm/llvm-project/commit/fde5b24963f42c8f21e32e1c5b19e81ddc52e575 DIFF: https://github.com/llvm/llvm-project/commit/fde5b24963f42c8f21e32e1c5b19e81ddc52e575.dif

  1   2   >