tra added a subscriber: rsmith.
tra added a comment.

In effect this patch applies `__host__ __device__` to a subset of the standard 
library headers and whatever headers *they* happen to include. While it may 
happen to work, I'm not at all confident that it does not create interesting 
issues.

Considering that the patch only works with libc++ anyways, perhaps it's time to 
make (parts) of libc++ itself usable from CUDA/HIP, instead of hacking around 
it in the wrappers?

@rsmith Richard, who would be the right person to discuss the standard library 
changes we may need?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102507/new/

https://reviews.llvm.org/D102507

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D102507: ... Yaxun Liu via Phabricator via cfe-commits
    • [PATCH] D102... Artem Belevich via Phabricator via cfe-commits
    • [PATCH] D102... Yaxun Liu via Phabricator via cfe-commits
    • [PATCH] D102... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to