[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

vsavchenko added a comment. In D102213#2755963 , @NoQ wrote: > I totally agree that changing forFunction() to work correctly is the right > solution but backwards compatibility breakage is very real because > forFunction() accepts a Matcher whereas forC

[clang] 3f4c518 - [clang-repl] Add exhaustive list of libInterpreter dependencies.

Author: Vassil Vassilev Date: 2021-05-13T07:18:01Z New Revision: 3f4c5185926ad2a07a642b8b0b7a4accffeb7e36 URL: https://github.com/llvm/llvm-project/commit/3f4c5185926ad2a07a642b8b0b7a4accffeb7e36 DIFF: https://github.com/llvm/llvm-project/commit/3f4c5185926ad2a07a642b8b0b7a4accffeb7e36.diff LO

[clang] 6045cb8 - Use an allow list on reserved macro identifiers

Author: serge-sans-paille Date: 2021-05-13T09:23:47+02:00 New Revision: 6045cb89e5e8223eea4d7f9c3a3e0d8d25ff909f URL: https://github.com/llvm/llvm-project/commit/6045cb89e5e8223eea4d7f9c3a3e0d8d25ff909f DIFF: https://github.com/llvm/llvm-project/commit/6045cb89e5e8223eea4d7f9c3a3e0d8d25ff909f.d

[PATCH] D102168: Use an allow list on reserved macro identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6045cb89e5e8: Use an allow list on reserved macro identifiers (authored by serge-sans-paille). Herald added a project: clang. Repository: rG LLVM

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2700326 , @alok wrote: > In D99160#2699038 , @dblaikie wrote: > >> In D99160#2698980 , @alok wrote: >> >>> In D99160#2671899

[clang] b2186a6 - [clang-repl] Add final set of missing library dependencies.

Author: Vassil Vassilev Date: 2021-05-13T08:06:58Z New Revision: b2186a69c169c7e39c2a769ba859f656aa4cef1b URL: https://github.com/llvm/llvm-project/commit/b2186a69c169c7e39c2a769ba859f656aa4cef1b DIFF: https://github.com/llvm/llvm-project/commit/b2186a69c169c7e39c2a769ba859f656aa4cef1b.diff LO

[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

DavidSpickett updated this revision to Diff 345073. DavidSpickett added a comment. - Use diagnose instead of adding methods to LLVMContext - clang-format the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102244/new/ https://reviews.llvm.o

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

MyDeveloperDay added a comment. This fix seems to cause a regression. (https://bugs.llvm.org/show_bug.cgi?id=50326) causing ColumLimit to not be observed in the following example size_t foo = (*(function))( F, Bar, F, Ba, FoLong, BaLong, Foo

[clang] 39e4676 - [PowerPC] Provide doubleword vector predicate form comparisons on Power7

Author: Nemanja Ivanovic Date: 2021-05-13T04:56:56-05:00 New Revision: 39e4676ca798d9aba58823515ac9d48eb64863be URL: https://github.com/llvm/llvm-project/commit/39e4676ca798d9aba58823515ac9d48eb64863be DIFF: https://github.com/llvm/llvm-project/commit/39e4676ca798d9aba58823515ac9d48eb64863be.di

[clang] 4624412 - [clang-repl] Fix ClangReplInterpreterTests unittest dependency.

Author: Vassil Vassilev Date: 2021-05-13T10:32:08Z New Revision: 4624412367f9b591fe90ecec8feed7209cd222ac URL: https://github.com/llvm/llvm-project/commit/4624412367f9b591fe90ecec8feed7209cd222ac DIFF: https://github.com/llvm/llvm-project/commit/4624412367f9b591fe90ecec8feed7209cd222ac.diff LO

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=50326 D93626: [clang-format] PR48535 clang-format Incorre

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 344849. flip1995 added a comment. Herald added subscribers: lldb-commits, atanasyan, jrtc27. Herald added a project: LLDB. rebased and addressed review comments: - [MC] Remove MOFI argument from MCContext constructor - [MC] Remove getTextSectionAlignment fun

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added a comment. Can `createMCObjectFileInfo` return `MCObjectFileInfo` instead of `std::unique_ptr`? Comment at: clang/lib/Parse/ParseStmtAsm.cpp:590 + if (!MAI || !MII || !MOFI || !STI) { Diag(AsmLoc, diag::err_msasm_unable_to_create_target)

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

aprantl added a comment. Doing this in the backend SGTM, assuming all of @dblaikie's comments are addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 __

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie added a comment. In D100630#2755936 , @aprantl wrote: > Doing this in the backend SGTM, assuming all of @dblaikie's comments are > addressed. The complication is that if we naively lower DW_TAG_rvalue_reference to DW_TAG_reference, then we'll

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0ca4c46ca35: [Debug-Info] add -gstrict-dwarf support in backend (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D100826?vs=339840&id=345022#toc Repository: rG LLVM Github Mo

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. In D101921#2754426 , @MaskRay wrote: > Can `createMCObjectFileInfo` return `MCObjectFileInfo` instead of > `std::unique_ptr`? `createMCObjectfileInfo` returns a `MCObjectFileInfo *` similar to every other `create*` function in

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581 RTLIB::POWI_F128, RTLIB::POWI_PPCF128); if (!TLI.getLibcallName(LC)) { efriedma wrote: > T

[PATCH] D102369: [ASTMatchers][NFC] Remove runtime checks where compile time is sufficient

aaron.ballman added a comment. I'm not opposed, but I don't know that this is really an improvement. We've gone from a pretty simple code pattern to needing to spell out the type twice with a type_trait, and all that we save is a call to `isa<>` within the casting operation. While I agree this

[PATCH] D101139: Create install targets for scan-build-py.

wanders added a comment. In D101139#2743346 , @aabbaabb wrote: > Renamed lib to libexec and add custom rules to copy files to build output. That rename was a bit too fast I think. I would expect the libraries (libear & libscanbuild) to be in lib/. The in

[PATCH] D102369: [ASTMatchers][NFC] Remove runtime checks where compile time is sufficient

njames93 added a comment. In D102369#2756493 , @aaron.ballman wrote: > I'm not opposed, but I don't know that this is really an improvement. We've > gone from a pretty simple code pattern to needing to spell out the type twice > with a type_trait, and

[PATCH] D102369: [ASTMatchers][NFC] Remove runtime checks where compile time is sufficient

aaron.ballman added a comment. In D102369#2756516 , @njames93 wrote: > In D102369#2756493 , @aaron.ballman > wrote: > >> I'm not opposed, but I don't know that this is really an improvement. We've >> gone from a

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/extend-arg-64.c:19 + +int vararg(int, ...); + mibintc wrote: > aaron.ballman wrote: > > Can you also add a test for K&R C functions? e.g., `int knr();` `sum = > > knr(sum, u32, s32, u16, s16, u8

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

aaronpuchert added a comment. Ping @aaron.ballman, also for the parent change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102026/new/ https://reviews.llvm.org/D102026 ___ cfe-commits mailing list cfe-

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2199 +// Take the exclusive capability to reduce further warnings. +return B.kind() == LK_Exclusive; + } else { The old code was looking at `LDat1.kind() != LK_Exclusive

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

Mordante added a comment. I tried to build the libc++ benchmarks locally and the benchmark with target `to_chars_libcxx` fails to properly execute. Bi-section let to this commit. Can the change in the linker flags affect libc++? I also see the scheduled builds of libc++ fail at Buildkite https:

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

aaron.ballman added a comment. In general, I think this makes sense, but I'd like to hear from @delesley as well. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2198 +// For managed capabilities, the destructor should unlock in the right mode +// anyway. For asserted

[clang-tools-extra] e07753c - [clang-tidy] Fix test that requires Windows platofrm

Author: Georgy Komarov Date: 2021-05-13T15:51:53+03:00 New Revision: e07753c8814dba100dcae44e2b47947b340ad0e8 URL: https://github.com/llvm/llvm-project/commit/e07753c8814dba100dcae44e2b47947b340ad0e8 DIFF: https://github.com/llvm/llvm-project/commit/e07753c8814dba100dcae44e2b47947b340ad0e8.diff

[PATCH] D102337: [clang-tidy] Fix test that requires Windows platofrm

This revision was automatically updated to reflect the committed changes. Closed by commit rGe07753c8814d: [clang-tidy] Fix test that requires Windows platofrm (authored by jubnzv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102337/new/ https://r

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

Rin created this revision. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. Rin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D10

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

dmgreen added a comment. Sounds good. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:4134 -defm RBIT : SIMDTwoVectorB<1, 0b01, 0b00101, "rbit", int_aarch64_neon_rbit>; +//defm RBIT : SIMDTwoVectorB<1, 0b01, 0b00101, "rbit", int_aarch64_neon_rbit>; +defm RBIT :

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

aganea added a comment. In D102339#2755867 , @thakis wrote: > We share obj files built on linux and on windows. So that's a goal for us. Hello @thakis, I believe you don't use this codepath to generate the cache key, do you? I thought you had a custom p

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

ostannard added a comment. There is also a test failure on the aarch64 2-stage bot (https://lab.llvm.org/buildbot/#/builders/7/builds/2720) which I've bisected to this change, so I'll revert it for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 92260d7 - Revert "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions"

Author: Oliver Stannard Date: 2021-05-13T14:31:17+01:00 New Revision: 92260d7a186425510e96b7036b467a6889d08d97 URL: https://github.com/llvm/llvm-project/commit/92260d7a186425510e96b7036b467a6889d08d97 DIFF: https://github.com/llvm/llvm-project/commit/92260d7a186425510e96b7036b467a6889d08d97.dif

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Not blocking, but I'd add foo4 example from the description as a test case (with a link to the bug maybe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D102191: [PowerPC] Add clang option -m[no-]prefixed

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102191/new/ https://reviews.llvm.org/D102191 __

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

saudi updated this revision to Diff 344947. saudi added a comment. Updated for comments from @rnk, except for the canonicalization part. Are you suggesting that the `DependencyCollector` should be called with the already canonicalized paths? There are a few code paths leading to the `Dependency

[clang] 395607a - Reapply [ConstantFold] Fold more operations to poison

Author: Juneyoung Lee Date: 2021-05-13T16:04:12+02:00 New Revision: 395607af3cb80f25ee05420ea5ae0ad0be948533 URL: https://github.com/llvm/llvm-project/commit/395607af3cb80f25ee05420ea5ae0ad0be948533 DIFF: https://github.com/llvm/llvm-project/commit/395607af3cb80f25ee05420ea5ae0ad0be948533.diff

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2199 +// Take the exclusive capability to reduce further warnings. +return B.kind() == LK_Exclusive; + } else { aaron.ballman wrote: > The old code was looking at `LDat1.

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2754542 , @njames93 wrote: > In D86671#2750957 , @dougpuob wrote: > >> Hi @njames93: >> Could you do me a favor? Because it is my first patch, something I'm not >> sure. I'm conf

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Analysis/ThreadSafety.cpp:2199 +// Take the exclusive capability to reduce further warnings. +return B.kind() == LK_Exclusiv

[PATCH] D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I second that ColumnLimit breaking test case. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102392/new/ https://reviews.llvm.org/D102392

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Everybody0523 added a comment. Expected Z behavior LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. In D102339#2756726 , @aganea wrote: > In D102339#2755867 , @thakis wrote: > >> We share obj files built on linux and on windows. So that's a goal for us. > > Hello @thakis, I believe you do

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

vsavchenko updated this revision to Diff 345145. vsavchenko added a comment. Modify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102240/new/ https://reviews.llvm.org/D102240 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345154. mibintc added a comment. I responded to most all @aaron.ballman 's review comments, may need a little more wordsmithing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.or

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

vsavchenko added a comment. In D102240#2750976 , @steakhal wrote: > Dam, we will be always haunted by these. Yep, it was one place where we didn't expect a null state, but after one of the later patches, it became possible. 🤞it's the final one. > Looks

[PATCH] D102406: [ARM][AArch64] Correct __ARM_FEATURE_CRYPTO macro and crypto feature

dcandler created this revision. dcandler added reviewers: t.p.northover, lenary. Herald added subscribers: danielkiss, kristof.beyls. dcandler requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch contains a couple of minor corrections

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a comment. Thanks! The last remaining question to me is whether this should be a target-specific option or whether it makes sense to allow it as an option for any target. Comment at: clang/include/clang/Basic/LangOptions.def:418-419 +ENUM_LANGOPT(ExtendInt

[clang] 8fa168f - Parse vector bool when stdbool.h and altivec.h are included

Author: Zarko Todorovski Date: 2021-05-13T11:48:32-04:00 New Revision: 8fa168fc50ba4f63b79773c947ef5b3e43d5c02f URL: https://github.com/llvm/llvm-project/commit/8fa168fc50ba4f63b79773c947ef5b3e43d5c02f DIFF: https://github.com/llvm/llvm-project/commit/8fa168fc50ba4f63b79773c947ef5b3e43d5c02f.di

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa168fc50ba: Parse vector bool when stdbool.h and altivec.h are included (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org

[clang] 6a67e05 - [HIP] Add __builtin_amdgcn_groupstaticsize

Author: Aaron En Ye Shi Date: 2021-05-13T15:50:08Z New Revision: 6a67e05a26eb5f58665bd6d063b9f389e7dd28a7 URL: https://github.com/llvm/llvm-project/commit/6a67e05a26eb5f58665bd6d063b9f389e7dd28a7 DIFF: https://github.com/llvm/llvm-project/commit/6a67e05a26eb5f58665bd6d063b9f389e7dd28a7.diff LO

[PATCH] D102403: [HIP] Add __builtin_amdgcn_groupstaticsize

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a67e05a26eb: [HIP] Add __builtin_amdgcn_groupstaticsize (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. @v.g.vassilev, the test does not appear to be appropriately set up for builds that default to a non-native target: https://lab.llvm.org/staging/#/builders/126/builds/371/steps/5/logs/FAIL__Clang__execute_cpp Can you fix or revert until there is a fix? Re

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2757077 , @hubert.reinterpretcast wrote: > @v.g.vassilev, the test does not appear to be appropriately set up for builds > that default to a non-native target: > https://lab.llvm.org/staging/#/builders/126/builds/3

[clang] 2ed7db0 - [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains

Author: Joe Ellis Date: 2021-05-13T16:09:50Z New Revision: 2ed7db0d206b6af2fffa4cb2704264b76ca61266 URL: https://github.com/llvm/llvm-project/commit/2ed7db0d206b6af2fffa4cb2704264b76ca61266 DIFF: https://github.com/llvm/llvm-project/commit/2ed7db0d206b6af2fffa4cb2704264b76ca61266.diff LOG: [In

[PATCH] D101986: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ed7db0d206b: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains (authored by joechrisellis). Repository: rG LLVM Github Mon

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

Szelethus closed this revision. Szelethus added a comment. Pushed this to the 12.0.0 release branch, just forgot to close it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commits mailing lis

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 345173. AndreyChurbanov added a comment. Fixed one more codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 Files: clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757039 , @aaron.ballman wrote: > Thanks! The last remaining question to me is whether this should be a > target-specific option or whether it makes sense to allow it as an option for > any target. I thought the pat

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2757107 , @v.g.vassilev wrote: > In D96033#2757077 , > @hubert.reinterpretcast wrote: > >> @v.g.vassilev, the test does not appear to be appropriately set up for >> builds

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757179 , @v.g.vassilev wrote: > In D96033#2757107 , @v.g.vassilev > wrote: > >> In D96033#2757077 , >> @hubert.reinterpr

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D102240#2756967 , @vsavchenko wrote: > I couldn't transform `c == b` into a condition, so it crashes. Well, that's interesting. It might worth

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added a comment. @tra Thanks a ton for the review! This is my first LLVM patch so I only know as much as the Code Review documentation tells me. Is there a process for chasing up additional reviews? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100124/new/ https://review

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. In D102213#2756254 , @vsavchenko wrote: >> Additionally, forCallable(functionDecl()) is not equivalent to forFunction() >> (the former silently matches less stuff). > > I'm not sure I understand this one. Can you please show an exa

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

vsavchenko added a comment. In D102213#2757253 , @NoQ wrote: > In D102213#2756254 , @vsavchenko > wrote: > >>> Additionally, forCallable(functionDecl()) is not equivalent to >>> forFunction() (the former silentl

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

tra added a comment. In D100124#2757251 , @steffenlarsen wrote: > @tra Thanks a ton for the review! This is my first LLVM patch so I only know > as much as the Code Review documentation tells me. Is there a process for > chasing up additional reviews?

[PATCH] D102418: [clangd] Always default to raw pch format

kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Clang would emit a fatal error whe

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a comment. In D101640#2757178 , @mibintc wrote: > In D101640#2757039 , @aaron.ballman > wrote: > >> Thanks! The last remaining question to me is whether this should be a >> target-specific op

[clang] 9469ff1 - [PowerPC] Add clang option -m[no-]prefixed

Author: Lei Huang Date: 2021-05-13T12:02:10-05:00 New Revision: 9469ff15b77905245e26fe7f166fc127d813a0c0 URL: https://github.com/llvm/llvm-project/commit/9469ff15b77905245e26fe7f166fc127d813a0c0 DIFF: https://github.com/llvm/llvm-project/commit/9469ff15b77905245e26fe7f166fc127d813a0c0.diff LOG

[PATCH] D102191: [PowerPC] Add clang option -m[no-]prefixed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9469ff15b779: [PowerPC] Add clang option -m[no-]prefixed (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102244/new/ https://reviews.llvm.org/D102244

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman added a comment. In D102213#2755064 , @NoQ wrote: > I'm also mildly worried that Function is not the technically correct term. > Maybe we should mark the old matcher as deprecated instead? Thank you for the explanations as to why there's a

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

lhames added a comment. In D96033#2757222 , @hubert.reinterpretcast wrote: > ... > I have a local build I can apply a patch to. Hi Hubert, Could you apply the following patch and let me know the output from the failing test? I'm trying to work out whe

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added a comment. In D100124#2757306 , @tra wrote: > Do you have ability to commit to LLVM? If not, I can land the patch on your > behalf. Not to my knowledge, so please do. Thanks again! https://reviews.llvm.org/D100394 is from my colleag

[clang] 7c2afd5 - Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:10:46-07:00 New Revision: 7c2afd5899df876eaf5ffb485194dc58e92daf89 URL: https://github.com/llvm/llvm-project/commit/7c2afd5899df876eaf5ffb485194dc58e92daf89 DIFF: https://github.com/llvm/llvm-project/commit/7c2afd5899df876eaf5ffb485194dc58e92d

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c2afd5899df: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added a subscriber: marco-c. MaskRay added a comment. In D102090#2756605 , @Mordante wrote: > I tried to build the libc++ benchmarks locally and the benchmark with target > `to_chars_libcxx` fails to properly execute. Bi-section let to this commi

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

This revision was automatically updated to reflect the committed changes. Closed by commit rG45212dec01b9: [analyzer][solver] Prevent use of a null state (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102240/new/ https://rev

[clang] 45212de - [analyzer][solver] Prevent use of a null state

Author: Valeriy Savchenko Date: 2021-05-13T20:16:29+03:00 New Revision: 45212dec01b9be90596d8d6fa7586ce8c84e2622 URL: https://github.com/llvm/llvm-project/commit/45212dec01b9be90596d8d6fa7586ce8c84e2622 DIFF: https://github.com/llvm/llvm-project/commit/45212dec01b9be90596d8d6fa7586ce8c84e2622.d

[clang] 23e9146 - Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:22:40-07:00 New Revision: 23e9146fba298d38142337b615e17067fb8ccb91 URL: https://github.com/llvm/llvm-project/commit/23e9146fba298d38142337b615e17067fb8ccb91 DIFF: https://github.com/llvm/llvm-project/commit/23e9146fba298d38142337b615e17067fb8c

[PATCH] D101670: Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23e9146fba29: Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC (authored by dexonsmith). Repository: rG LLVM Github Mo

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345208. NoQ marked 2 inline comments as done. NoQ added a comment. Address review comments. Add a deprecation notice to `forFunction()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files: clang/docs/LibA

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7597 +/// but does not match 'int y = 2'. +AST_MATCHER_P(Stmt, forCallable, internal::Matcher, InnerMatcher) { + const auto &Parents = Finder->getASTContext().getParents(Node); ---

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. OK, I agree with Aaron that having a separate matcher is reasonable. Thanks for the patient explanation :) LGTM from my side then. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 70aa462 - [NFC][Clang][Codegen] Add tests with wrong attributes on this/return of thunks

Author: Roman Lebedev Date: 2021-05-13T20:32:40+03:00 New Revision: 70aa4623de9fe2f609eab8969d7ef76b4c80084b URL: https://github.com/llvm/llvm-project/commit/70aa4623de9fe2f609eab8969d7ef76b4c80084b DIFF: https://github.com/llvm/llvm-project/commit/70aa4623de9fe2f609eab8969d7ef76b4c80084b.diff

[clang] a624cec - [Clang][Codegen] Do not annotate thunk's this/return types with align/deref/nonnull attrs

Author: Roman Lebedev Date: 2021-05-13T20:33:08+03:00 New Revision: a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4 URL: https://github.com/llvm/llvm-project/commit/a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4 DIFF: https://github.com/llvm/llvm-project/commit/a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4.diff

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

morehouse updated this revision to Diff 345210. morehouse marked 4 inline comments as done. morehouse added a comment. Herald added a subscriber: dang. - Use -mlam option instead of -fsanitize=lam. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10228

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri abandoned this revision. lebedev.ri added a comment. Oh, i forgot that this review was here. I've just relanded this in rG16d03818412415c56efcd482d18c0cbdf712524c , after workarounding the thunk issue in rGa624cec56

[clang] 7c57a9b - Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:39:40-07:00 New Revision: 7c57a9bd7d4c976b7a824472c427433359200e02 URL: https://github.com/llvm/llvm-project/commit/7c57a9bd7d4c976b7a824472c427433359200e02 DIFF: https://github.com/llvm/llvm-project/commit/7c57a9bd7d4c976b7a824472c42743335920

[PATCH] D101672: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c57a9bd7d4c: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC (authored by dexonsmith). Repository: rG LLVM Github Mon

[PATCH] D102214: [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Now, when we are done with `forCallable`, let's get to this one. It looks great to me, thanks for fixing it! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://r

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-non-type-vector.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-aix-xcoff -target-feature +altivec -fsyntax-only %s + Can you add tests for 64bit BE/LE linux and 32bit AIX/BE linux in this th

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

NoQ added a comment. Thx for the fix! In D102240#2757223 , @steakhal wrote: > In D102240#2756967 , @vsavchenko > wrote: > >> I couldn't transform `c == b` into a condition, so it crashes. > > Well, that's intere

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. I would be great if someone with commit rights could push this through since I don't have commit rights :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 __

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345220. NoQ added a comment. Make examples for `forCallable()` more relatable given that the original matcher is now deprecated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files: clang/docs/LibASTMatch

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345221. NoQ added a comment. Fix typo in documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h clang/

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Finally dealt with the other issues I need to take care. Let's resume the discussion. I printed out the decls that are duplicated. The list of very long, but the top ones all seem from glibc headers. For example (the number after 'c:' is the duplication count), stat

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757342 , @lhames wrote: > Hi Hubert, > > Could you apply the following patch and let me know the output from the > failing test? I'm trying to work out whether the JIT is getting the triple or > the data

  1   2   >