tra added a comment. In D100124#2757251 <https://reviews.llvm.org/D100124#2757251>, @steffenlarsen wrote:
> @tra Thanks a ton for the review! This is my first LLVM patch so I only know > as much as the Code Review documentation tells me. Is there a process for > chasing up additional reviews? Generally, you don't need approvals from *all* the reviewers on the list. My rule of thumb is to give the patch few days, and wait for the LGTM from someone who owns the code (this is hard to establish sometimes) or from someone familiar with the code. In this case my LGTM is sufficient and the patch has been out long enough for the interested parties to raise concerns if there were any. Do you have ability to commit to LLVM? If not, I can land the patch on your behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100124/new/ https://reviews.llvm.org/D100124 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
