[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1854 const Option &O = A->getOption(); -if (O.matches(OPT_mabi_EQ_vec_default)) - Diags.Report(diag::err_aix_default_altivec_abi) - << A->getSpelling() << T.str(); -

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 sunfish wrote: > tlively w

[clang] c711aa0 - [amdgpu-arch] Guard hsa.h with __has_include

Author: Pushpinder Singh Date: 2021-05-10T07:33:30Z New Revision: c711aa0f6f9d9400fbe619c7f0d6d4aa723b3a64 URL: https://github.com/llvm/llvm-project/commit/c711aa0f6f9d9400fbe619c7f0d6d4aa723b3a64 DIFF: https://github.com/llvm/llvm-project/commit/c711aa0f6f9d9400fbe619c7f0d6d4aa723b3a64.diff L

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

This revision was automatically updated to reflect the committed changes. Closed by commit rGc711aa0f6f9d: [amdgpu-arch] Guard hsa.h with __has_include (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102067/new/ https://review

[clang] 7f78e40 - [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

Author: Pushpinder Singh Date: 2021-05-10T07:54:23Z New Revision: 7f78e409d0280c62209e1a7dc8c6d1409acc9184 URL: https://github.com/llvm/llvm-project/commit/7f78e409d0280c62209e1a7dc8c6d1409acc9184 DIFF: https://github.com/llvm/llvm-project/commit/7f78e409d0280c62209e1a7dc8c6d1409acc9184.diff L

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f78e409d028: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point

kadircet updated this revision to Diff 343993. kadircet added a comment. - Fix typo in comment - Handle the \#elif case too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102069/new/ https://reviews.llvm.org/D102069 Files: clang/lib/Lex/PPDirect

[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point

kadircet updated this revision to Diff 343996. kadircet added a comment. - Fix lit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102069/new/ https://reviews.llvm.org/D102069 Files: clang/lib/Lex/PPDirectives.cpp clang/test/CodeCompletion/crash

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM as this is opt in with a command line option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101873/new/ https://reviews.llvm.org/

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

njames93 added a comment. In D101239#2746675 , @h-joo wrote: > In D101239#2746644 , @njames93 > wrote: > >> LGTM, thanks. > > @njames93, I appreciate your time for the review. May I ask one more thing? > I do n

[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102069/new/ https://reviews.llvm.org/D102069

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo added a comment. In D101239#2747370 , @njames93 wrote: > In D101239#2746675 , @h-joo wrote: > >> In D101239#2746644 , @njames93 >> wrote: >> >>> LGTM, thanks. >> >>

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

krasimir added a comment. Do we have some widely used code style that requires the new option (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options)? I agree with @MyDeveloperDay that this option as-is is likely not addressing all the cases where we would want

[clang] 761f3d1 - [clang][PreProcessor] Cutoff parsing after hitting completion point

Author: Kadir Cetinkaya Date: 2021-05-10T11:24:27+02:00 New Revision: 761f3d16753ecea625173729dd8c53df022cd4ab URL: https://github.com/llvm/llvm-project/commit/761f3d16753ecea625173729dd8c53df022cd4ab DIFF: https://github.com/llvm/llvm-project/commit/761f3d16753ecea625173729dd8c53df022cd4ab.dif

[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG761f3d16753e: [clang][PreProcessor] Cutoff parsing after hitting completion point (authored by kadircet). Repository: rG LLVM Github Monorepo CHA

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344013. mgartmann added a comment. Remove trailing whitespaces from documentation file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files: clang-tools-extra/cla

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added a comment. In D69560#2747092 , @alexfh wrote: > BTW, any ideas why "patch application failed"? (See the Build status in the > Diff Detail section) > > It would be really nice to get pre-merge checks to work for the patch. Put simply, I t

[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

OikawaKirie created this revision. OikawaKirie added reviewers: akyrtzi, martong, steakhal. OikawaKirie added a project: clang. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. OikawaKiri

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 343983. shchenz added a comment. Herald added subscribers: llvm-commits, hiraditya, nemanjai. Herald added a project: LLVM. update according to @dblaikie comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2745272 , @dblaikie wrote: > Mixed feelings - is this the only place where we're changing behavior for > strict-DWARF in the frontend/clang? (maybe it'd be better to do it all in the > same place, down in the backend

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100782/new/ https://reviews.llvm.org/D100782 ___ cfe-commits mailing list cfe-comm

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Maybe give this a couple of days to see if any other reviewers have further input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10207

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

nemanjai added a comment. This seems fine to me now but I'll defer to front end experts for approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 ___ cfe-co

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ChuanqiXu added a comment. Since D97915 would fix the problem that the variables in the frame may not be aligned, I think this option `fcoroutines-aligned-alloc` won't affect normal programmers other than language lawyers. Do you think so? Repository: rG LL

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344023. mgartmann added a comment. Updated diff to fix the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files: clang-tools-extra/clang-tidy/misc/AvoidStdI

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

ckandeler added a comment. ping. Any chance of getting this pushed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/reinterpret-cast.clcpp:15 + int4 i4; + auto i4_to_i3 = reinterpret_cast(i4); // expected-error{{reinterpret_cast from vector 'int4' (vector of 4 'int' values) to vector 'int3' (vector of 3 'int' values) of

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

gregmiller added a comment. In D101030#2746957 , @jdoerfert wrote: > In D101030#2746770 , @gregmiller > wrote: > >> In D101030#2745513 , @jdoerfert >> wrote: >> >>> In D

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > dblaikie wrote: > > > > hoy wrote: > > >

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Minor wordsmithing on the documentation changes, but more importantly: why is the correct fix to the documentation as opposed to changing the default max working group

[clang] 08de6e3 - clang: Fix tests after 7f78e409d028 if clang is not called clang-13

Author: Nico Weber Date: 2021-05-10T08:49:26-04:00 New Revision: 08de6e3adaf6e991f5a40357f4634e5b70ec3fde URL: https://github.com/llvm/llvm-project/commit/08de6e3adaf6e991f5a40357f4634e5b70ec3fde DIFF: https://github.com/llvm/llvm-project/commit/08de6e3adaf6e991f5a40357f4634e5b70ec3fde.diff LO

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344030. mgartmann added a comment. Change encoding of patch to UTF-8 in order to fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files: clang-tools-extra

[clang-tools-extra] f088af3 - [clangd] Fix data type of WorkDoneProgressReport::percentage

Author: Christian Kandeler Date: 2021-05-10T14:57:20+02:00 New Revision: f088af37e6b570dd070ae4e6fc14e22d21cda3be URL: https://github.com/llvm/llvm-project/commit/f088af37e6b570dd070ae4e6fc14e22d21cda3be DIFF: https://github.com/llvm/llvm-project/commit/f088af37e6b570dd070ae4e6fc14e22d21cda3be.

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf088af37e6b5: [clangd] Fix data type of WorkDoneProgressReport::percentage (authored by ckandeler, committed by kadircet). Repository: rG LLVM Gi

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

kadircet added a comment. done, sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

ckandeler added a comment. No problem, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 344043. mgartmann added a comment. Revert `ReleaseNotes.rst` to a point where the build worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files: clang-tools-e

[clang] 230953d - [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

Author: Alexey Bataev Date: 2021-05-10T06:34:11-07:00 New Revision: 230953d5771f6f3ce6bf86b8bb6ae4d5eb75a218 URL: https://github.com/llvm/llvm-project/commit/230953d5771f6f3ce6bf86b8bb6ae4d5eb75a218 DIFF: https://github.com/llvm/llvm-project/commit/230953d5771f6f3ce6bf86b8bb6ae4d5eb75a218.diff

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG230953d5771f: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

zahen added a comment. > If no one has ideas in the next few days, I'll "accept" and commit for you. > (Feel free to ping me; there's a good chance I'll lose track of this > otherwise; usual ping rate is 1x/week, but happy for you to ping me sooner on > this...) @dexonsmith Ping as requested.

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:369 +def err_opencl_extension_and_feature_differs : Error< + "Options %0 and %1 are set to different values which is illegal in OpenCL C 3.0">; } We don't normally

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Adding cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman added a comment. Some additional ones to allow from MSDN: `_CRT_SECURE_NO_WARNINGS`, `_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES`, `_CRT_NONSTDC_NO_WARNINGS`, (https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160). Comm

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:125 + if (II->isReserved(Lang) != ReservedIdentifierStatus::NotReserved) { +static constexpr std::array ReservedMacro = { +"_ATFILE_SOURCE", "_BSD_SOURCE","_FILE_OFFSET_BITS", -

[PATCH] D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols

aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Adding cfe-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102164/new/ https://reviews.llvm.org/D102164 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ychen added a comment. In D102147#2747611 , @ChuanqiXu wrote: > Since D97915 would fix the problem that the > variables in the frame may not be aligned, I think this option > `fcoroutines-aligned-alloc` won't affect nor

[clang] 5c7b43a - [clang][AArch32] Correctly align HA arguments when passed on the stack

Author: Momchil Velikov Date: 2021-05-10T16:28:46+01:00 New Revision: 5c7b43aa8298a389b906d72c792941a0ce57782e URL: https://github.com/llvm/llvm-project/commit/5c7b43aa8298a389b906d72c792941a0ce57782e DIFF: https://github.com/llvm/llvm-project/commit/5c7b43aa8298a389b906d72c792941a0ce57782e.dif

[PATCH] D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c7b43aa8298: [clang][AArch32] Correctly align HA arguments when passed on the stack (authored by chill). Herald added a project: clang. Herald added

[PATCH] D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You probably should change `Syndicate` to `Synchronize` in the commit message when you land it, though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102164/new/

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from the single quotes in the diagnostic. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:548 +def err_aix_unsupported_tls_model : Error<"The tls model %0 is not yet supported on A

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Christopher - had a chance to look into this any further? Roman - I'm OK either way on that. I don't think it's the most costly false positive - not too much code is probably freeing via a reference (rather than a pointer) to allocated memory. On Fri, Apr 30, 2021 at 10:08 AM Roman Lebedev wrot

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, hokein. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It is not useful to keep the statement around and can lead

[clang] 91a919e - [NFC] Synchronize reserved identifier code between macro and variables / symbols

Author: serge-sans-paille Date: 2021-05-10T17:46:51+02:00 New Revision: 91a919e8994a2c47b3feaf906f83122776ae2cae URL: https://github.com/llvm/llvm-project/commit/91a919e8994a2c47b3feaf906f83122776ae2cae DIFF: https://github.com/llvm/llvm-project/commit/91a919e8994a2c47b3feaf906f83122776ae2cae.d

[PATCH] D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91a919e8994a: [NFC] Synchronize reserved identifier code between macro and variables / symbols (authored by serge-sans-paille). Herald added a projec

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 344078. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Simplify option logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/l

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 344080. ZarkoCA added a comment. - Fix previous diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp cl

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1854 const Option &O = A->getOption(); -if (O.matches(OPT_mabi_EQ_vec_default)) - Diags.Report(diag::err_aix_default_altivec_abi) -

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:110 CODEGENOPT(StackSizeSection , 1, 0) ///< Set when -fstack-size-section is enabled. +CODEGENOPT(StackUsage, 1, 0) ///< Set when -fstack-usage is enabled. CODEGENOPT(ForceDwarfFr

[PATCH] D101479: [Driver] Support libc++ in MSVC

amccarth added a comment. In D101479#2733354 , @mstorsjo wrote: > Not sure if we want the desicion between static and shared libc++ be coupled > with `/MT` and `/MD`, as one can quite plausibly want to use e.g. a static > libc++ with `/MD`. I don't und

[clang] 68a20c7 - [clang] Support -fpic -fno-semantic-interposition for AArch64

Author: Fangrui Song Date: 2021-05-10T09:43:33-07:00 New Revision: 68a20c7f36d1d51cc46c0bd17384c16bc7818fa2 URL: https://github.com/llvm/llvm-project/commit/68a20c7f36d1d51cc46c0bd17384c16bc7818fa2 DIFF: https://github.com/llvm/llvm-project/commit/68a20c7f36d1d51cc46c0bd17384c16bc7818fa2.diff

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG68a20c7f36d1: [clang] Support -fpic -fno-semantic-interposition for AArch64 (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101873/new/

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman added a comment. Let me start off by saying: thanks, I think this is really useful functionality. As a ridiculously obvious example, Annex K has an integer type alias `errno_t` and it would incredibly handy to be able to mark that as `[[nodiscard]]` to strongly encourage checking

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D102122: Support warn_unused_result on typedefs

dblaikie added a comment. In D102122#2748206 , @aaron.ballman wrote: > Let me start off by saying: thanks, I think this is really useful > functionality. As a ridiculously obvious example, Annex K has an integer type > alias `errno_t` and it would incr

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur created this revision. Meinersbur added a reviewer: ABataev. Meinersbur added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. The PreInits of a loo

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:128-129 +llvm::function_ref Callback, +llvm::function_ref +OnTransformationCallback) { CurStmt = CurStmt->IgnoreContainers(); Do we need `bool` return in the callback? I se

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:128-129 +llvm::function_ref Callback, +llvm::function_ref +OnTransformationCallback) { CurStmt = CurStmt->IgnoreContainers(); ABataev wrote: > Do we need `bool` return i

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344119. Meinersbur added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/include/clang/AST/StmtOpenMP.h clang

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma added a comment. In D102015#2743634 , @rjmccall wrote: > Objective-C object types also have aggregate evaluation kind. Those can only > be used as value types in an old, fragile ObjC ABI, but I believe we haven't > yet formally decided to remo

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:245 .flag("+fno-exceptions")); + // Use the default Itanium C++ ABI. + Multilibs.push_ba

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

SilensAngelusNex created this revision. SilensAngelusNex requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102185 Files: clang/include/clang/Tooling/Transformer/RangeSelector

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

NoQ added a comment. I completely agree with that as well, these are 100% true positives, which is why I left them as fixmes. The reason why I think we can't have them is that we don't have an appropriate alias analysis implemented. Namely, we have two analyses, one inside the checker that leav

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2748189 , @amccarth wrote: > In D101479#2733354 , @mstorsjo > wrote: > >> Not sure if we want the desicion between static and shared libc++ be coupled >> with `/MT` and `/MD`

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

SilensAngelusNex updated this revision to Diff 344132. SilensAngelusNex added a comment. Fix typo in `name`'s doc comment and add `TypeLoc` to the list of expected types in `name`'s `typeError`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102185/

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344134. Meinersbur added a comment. - Don't return false for void lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/include/clang/AST/StmtOpenM

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2744861 , @yaxunl wrote: > [snip] it is the convention for compiler to have one output. > The compilation is like a pipeline. If we break it into stages, users would > expect to use the output from one stage as input for

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 344135. pzheng added a comment. Address a few more comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D102122#2748271 , @dblaikie wrote: > In D102122#2748206 , @aaron.ballman > wrote: > >> Let me start off by saying: thanks, I think this is

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 2 inline comments as done. pzheng added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:110 CODEGENOPT(StackSizeSection , 1, 0) ///< Set when -fstack-size-section is enabled. +CODEGENOPT(StackUsage, 1, 0) ///< Set when -fstack-us

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8975 +} +return false; })) No need for `return false;` Comment at: clang/lib/Sema/SemaOpenMP.cpp:12607 + PreInits.push_back

[clang] 18f3a14 - [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max)

Author: Craig Topper Date: 2021-05-10T12:11:13-07:00 New Revision: 18f3a14e1328c813fa5dbacc9bb931d22f0669cd URL: https://github.com/llvm/llvm-project/commit/18f3a14e1328c813fa5dbacc9bb931d22f0669cd DIFF: https://github.com/llvm/llvm-project/commit/18f3a14e1328c813fa5dbacc9bb931d22f0669cd.diff

[PATCH] D102086: [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max)

This revision was automatically updated to reflect the committed changes. Closed by commit rG18f3a14e1328: [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max) (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344145. Meinersbur added a comment. - Remove unused 'this' capture Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma added a comment. In D102015#2748441 , @efriedma wrote: >> ...I'm confused about why this code is doing what it's doing with cleanups, >> though. Why does it only apply when the parameter is indirect? I believe >> `isParamDestroyedInCallee()`

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx updated this revision to Diff 344149. flx added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102175/new/ https://reviews.llvm.org/D102175 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializatio

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 344161. reikdas added a comment. Fix failing test on windows triple and do some code cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang-tools-extra/clangd/Hover.cpp clang/include/clang

[PATCH] D102191: [PowerPC] Add clang option -m[no-]prefixed

lei created this revision. lei added reviewers: stefanp, nemanjai, power-llvm-team. Herald added subscribers: dang, shchenz. lei requested review of this revision. Herald added a project: clang. Add user-facing front end option to turn off power10 prefixed instructions. Repository: rG LLVM Git

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie added a comment. Does this cause duplicate DW_TAG_reference_types in the output, if the input IR Has both DW_TAG_reference_type and DW_TAG_rvalue_reference_types? Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:391 + // version. + dwarf::Tag FixedTag = (dwarf:

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + aaron.ballman wrote: > dblaikie wrote: > > hoy wrote: > > > dblaikie wrote: > > > > dblaikie wrote: >

[PATCH] D99409: [clang] Speedup line offset mapping computation

probinson added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1255 -#ifdef __SSE2__ -#include -#endif +// Check if mutli-byte word x has bytes between m and n, included. This may also +// catch bytes equal to n + 1. Typo: multi-byte. Also, I

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma updated this revision to Diff 344193. efriedma added a comment. Use isRecordType() instead of checking for an atomic type. Fix the caller side as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102015/new/ https://reviews.llvm.org/D1

[PATCH] D102196: [NewPM] Add options to PrintPassInstrumentation

aeubanks created this revision. Herald added subscribers: nikic, hiraditya. aeubanks requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. To bring D99599

[clang-tools-extra] 43f4331 - [clang-tidy] Aliasing: Add support for captures.

Author: Artem Dergachev Date: 2021-05-10T14:00:30-07:00 New Revision: 43f4331edfb595979f6854351d24f9a9219595fa URL: https://github.com/llvm/llvm-project/commit/43f4331edfb595979f6854351d24f9a9219595fa DIFF: https://github.com/llvm/llvm-project/commit/43f4331edfb595979f6854351d24f9a9219595fa.dif

[clang-tools-extra] 9b292e0 - [clang-tidy] Aliasing: Add more support for captures.

Author: Artem Dergachev Date: 2021-05-10T14:00:30-07:00 New Revision: 9b292e0edcd4e889dbcf4bbaad6c1cc80fffcfd1 URL: https://github.com/llvm/llvm-project/commit/9b292e0edcd4e889dbcf4bbaad6c1cc80fffcfd1 DIFF: https://github.com/llvm/llvm-project/commit/9b292e0edcd4e889dbcf4bbaad6c1cc80fffcfd1.dif

[clang-tools-extra] 91ca326 - [clang-tidy] Aliasing: Add support for aggregates with references.

Author: Artem Dergachev Date: 2021-05-10T14:00:31-07:00 New Revision: 91ca3269a1b544db1303b496101fd9d6fe953277 URL: https://github.com/llvm/llvm-project/commit/91ca3269a1b544db1303b496101fd9d6fe953277 DIFF: https://github.com/llvm/llvm-project/commit/91ca3269a1b544db1303b496101fd9d6fe953277.dif

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43f4331edfb5: [clang-tidy] Aliasing: Add support for captures. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b292e0edcd4: [clang-tidy] Aliasing: Add more support for captures. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101787/new/ htt

[PATCH] D101791: [clang-tidy] Aliasing: Add support for aggregates with references.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91ca3269a1b5: [clang-tidy] Aliasing: Add support for aggregates with references. (authored by dergachev.a). Changed prior to commit: https://revie

[PATCH] D102196: [NewPM] Add options to PrintPassInstrumentation

aeubanks updated this revision to Diff 344201. aeubanks added a comment. assert Indent >= 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102196/new/ https://reviews.llvm.org/D102196 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Driver/d

  1   2   >