Meinersbur added inline comments.
================
Comment at: clang/lib/AST/StmtOpenMP.cpp:128-129
+ llvm::function_ref<bool(unsigned, Stmt *)> Callback,
+ llvm::function_ref<bool(OMPLoopBasedDirective *)>
+ OnTransformationCallback) {
CurStmt = CurStmt->IgnoreContainers();
----------------
ABataev wrote:
> Do we need `bool` return in the callback? I see that it returns `false`
> always.
I added it to be consistent with the other callback. Going to remove it.
================
Comment at: clang/lib/AST/StmtOpenMP.cpp:132-140
+ while (true) {
+ if (auto *Dir = dyn_cast<OMPTileDirective>(CurStmt)) {
+ if (OnTransformationCallback(Dir))
+ return false;
+ CurStmt = Dir->getTransformedStmt();
+ continue;
+ }
----------------
ABataev wrote:
> ```
> while (auto *Dir = dyn_cast<OMPTileDirective>(CurStmt)) {
> if (OnTransformationCallback(Dir))
> return false;
> CurStmt = Dir->getTransformedStmt();
> }
> ```
With OMPUnrollDirective added, there are two conditions of the while loop. Of
course, I can change the structure again with the unroll patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102180/new/
https://reviews.llvm.org/D102180
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
