[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-Bsymbolic-functions") +endif() ---

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added a comment. In D102090#2745331 , @tstellar wrote: > Does this change mean that LD_PRELOAD will no longer work? Are there any > other downsides to adding these flags? The downside is that it will behave more like Windows dll and Mach-O dyli

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-Bsymbolic-functions") +endif() --

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek requested changes to this revision. phosek added inline comments. This revision now requires changes to proceed. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHAR

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay updated this revision to Diff 343758. MaskRay added a comment. Don't affect -DBUILD_SHARED_LIBS=on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090 Files: clang/tools/clang-shlib/CMakeLists.txt

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:243 +if(${CMAKE_SYSTEM_NAME} MATCHES "DragonFly|FreeBSD|Fuchsia|Linux|NetBSD|OpenBSD") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

gregmiller added a comment. Hello, We are maintaining a downstream version of the monorepo based on the LLVM main branch. We have not transitioned to the new PM yet. In a recent attempt to merge the latest upstream commits into our monorepo we came across the following test failures after your

[clang] 167906c - [BareMetal] Ensure that sysroot always comes after library paths

Author: Petr Hosek Date: 2021-05-07T14:42:02-07:00 New Revision: 167906c10932f5eda97b480ee084b17746c362e7 URL: https://github.com/llvm/llvm-project/commit/167906c10932f5eda97b480ee084b17746c362e7 DIFF: https://github.com/llvm/llvm-project/commit/167906c10932f5eda97b480ee084b17746c362e7.diff LO

[PATCH] D102093: [NewPM] Move analysis invalidation/clearing logging to instrumentation

aeubanks created this revision. aeubanks added reviewers: asbirlea, ychen. Herald added subscribers: dexonsmith, steven_wu, zzheng, hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We're trying to move D

[PATCH] D102093: [NewPM] Move analysis invalidation/clearing logging to instrumentation

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102093/new/ https://reviews.llvm.org/D102093 ___

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

craig.topper added inline comments. Comment at: llvm/test/CodeGen/Generic/pre-ra-sched.c:1 +// RUN: clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s You can't run clang from an llvm

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, cebowleratibm, sfertile. Herald added subscribers: shchenz, nemanjai. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The default Altivec ABI was implem

[PATCH] D101797: [NewPM] Hide pass manager debug logging behind -debug-pass-manager-verbose

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Need a test for pass managers debug output. Comment at: llvm/test/Other/pass-pipeline-parsing.ll:145 ; RUN: opt -disable-output -debug-pass-manager -debug-pass-manager

[clang] 6f71310 - [NewPM] Move analysis invalidation/clearing logging to instrumentation

Author: Arthur Eubanks Date: 2021-05-07T15:25:31-07:00 New Revision: 6f7131002b6a821fc9b245ec5179910f171e3358 URL: https://github.com/llvm/llvm-project/commit/6f7131002b6a821fc9b245ec5179910f171e3358 DIFF: https://github.com/llvm/llvm-project/commit/6f7131002b6a821fc9b245ec5179910f171e3358.diff

[PATCH] D102093: [NewPM] Move analysis invalidation/clearing logging to instrumentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f7131002b6a: [NewPM] Move analysis invalidation/clearing logging to instrumentation (authored by aeubanks). Repository: rG LLVM Github Monorepo

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added a comment. In D101030#2745429 , @gregmiller wrote: > Hello, We are maintaining a downstream version of the monorepo based on the > LLVM main branch. We have not transitioned to the new PM yet. In a recent > attempt to merge the latest u

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

craig.topper added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 +if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) +

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

craig.topper added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 +if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) +

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei updated this revision to Diff 343780. haowei added a comment. Rebase the change to resolve presubmit errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100139/new/ https://reviews.llvm.org/D100139 Files: clang/cmake/caches/Fuchsia-stag

[clang] 0ad4948 - NFC: Move TypeList implementation up the file

Author: Weston Carvalho Date: 2021-05-08T00:35:13+01:00 New Revision: 0ad494838b8576de14144776490faa710fa2a099 URL: https://github.com/llvm/llvm-project/commit/0ad494838b8576de14144776490faa710fa2a099 DIFF: https://github.com/llvm/llvm-project/commit/0ad494838b8576de14144776490faa710fa2a099.dif

[clang] 1f65f42 - Make `hasTypeLoc` matcher support more node types.

Author: Weston Carvalho Date: 2021-05-08T00:35:22+01:00 New Revision: 1f65f42dd37ab6a950d3ec110e3efca0ace1b615 URL: https://github.com/llvm/llvm-project/commit/1f65f42dd37ab6a950d3ec110e3efca0ace1b615 DIFF: https://github.com/llvm/llvm-project/commit/1f65f42dd37ab6a950d3ec110e3efca0ace1b615.dif

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f65f42dd37a: Make `hasTypeLoc` matcher support more node types. (authored by SilensAngelusNex, committed by stephenkelly). Changed prior to commit:

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 added a comment. In D101911#2738994 , @ABataev wrote: > Hi Ethan, try this patch if it fixes the issue. Tested this on gfx906 and v100, the main reproducer now passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D101911: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

estewart08 accepted this revision. estewart08 added a comment. This revision is now accepted and ready to land. LGTM as a temporary workaround until SPMD properly assigns team private variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101911/

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343794. pzheng added a comment. Addess @MaskRay's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang/include/clang/B

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a subscriber: aaron.ballman. dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > dblaikie wrote: > > > ho

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 7 inline comments as done. pzheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + MaskRay wrote: > CC1 need

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343795. pzheng added a comment. Minor update to some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan updated this revision to Diff 343800. TaoPan added a comment. Move test back to clang/test/CodeGen/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101601/new/ https://reviews.llvm.org/D101601 Files: clang/test/CodeGen/pre-ra-sched.c llvm

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 +if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) + ret

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. I see. LGTM, but let's wait one or more days to see if others object it. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:275-276 + return createFastDAGS

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:275-276 + return createFastDAGScheduler(IS, OptLevel); +if (TLI->getSchedulingPreference() == Sched::Linearize) + return createDAGLinearizer(IS, OptLevel); assert(TLI->

[PATCH] D102062: [analyzer][ctu] Append ctu-dir to ctu-invocation-list for non-absolute paths

OikawaKirie added a comment. In D102062#2744267 , @steakhal wrote: > On second thought the current behavior is reasonable. The behavior of all CTU affairs are related to the `ctu-dir` rather than CWD, such as loading the external function map file and l

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie added a comment. In D101763#2741629 , @steakhal wrote: > Okay, so you 'just' want an indication for the given open call. What about > using `strace`? > `strace -e trace=openat %clang_cc1 ... 2>&1 | grep '"invocations.yaml"' | > FileCheck %s`

<    1   2