[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. Right, sorry for the late reply, @NoQ. I will get to it once I get these assignments off my head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 __

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334604. tbaeder added a comment. I know it's been a while, but here's an update on that patch. Now that I've got https://reviews.llvm.org/D97362 and https://reviews.llvm.org/D97371 pushed, this is a much simpler change and does not break any of the existin

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334605. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/ParsedAttr.h clang/lib/Parse/ParseDecl.cpp clang/test/AST/sourceranges.cpp c

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

rogfer01 added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1486 + BuiltinType::Kind K, unsigned NF) { + auto TypeIter = llvm::find_if(Types, [&K](Type *Ty) { + if (Ty->isBuiltinType()) { -

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske reopened this revision. balazske added a comment. This revision is now accepted and ready to land. Test should be updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 __

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 334609. balazske added a comment. Split the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cp

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

steakhal accepted this revision. steakhal added inline comments. Comment at: clang/test/Analysis/pthreadlock_state.c:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.unix.PthreadLock,debug.ExprInspection 2>&1 %s | FileCheck %s + AFAIK `core` should be enab

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

Hi, On Tue, Mar 30, 2021 at 7:52 PM David Blaikie wrote: > Is there a more reliable remark that could be tested for? (Clang shouldn't > be testing all remarks - just that the remark infrastructure in general is > wired up (specific remarks should be tested in llvm) - so picking some > really sta

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing created this revision. tianqing added reviewers: pengfei, LuoYuanke, craig.topper. Herald added a subscriber: hiraditya. tianqing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add __uintr_frame structure and use

[PATCH] D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing

azabaznov added a comment. Thanks for feedback! Locally I get really nice result (I am using Ubuntu 20.04): $ llvm-lit SemaOpenCL/compare-header-and-tablegen.cl -- Testing: 1 tests, 1 workers -- FAIL: Clang :: SemaOpenCL/compare-header-and-tablegen.cl (1 of 1)

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2662656 , @hvdijk wrote: > I have also updated the summary to provide a more complete explanation of the > changes, and hope the revised summary will answer @MaskRay's questions. In D52050#2662648

[clang] 1d463c2 - [Driver] Fix architecture triplets and search paths for Linux x32

Author: Harald van Dijk Date: 2021-04-01T09:47:56+01:00 New Revision: 1d463c2a386099597a8e2d26b9b964bc8fda8042 URL: https://github.com/llvm/llvm-project/commit/1d463c2a386099597a8e2d26b9b964bc8fda8042 DIFF: https://github.com/llvm/llvm-project/commit/1d463c2a386099597a8e2d26b9b964bc8fda8042.dif

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d463c2a3860: [Driver] Fix architecture triplets and search paths for Linux x32 (authored by hvdijk). Changed prior to commit: https://reviews.llv

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 334619. balazske added a comment. Add 'core' to enabled checks in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files: clang/lib/StaticAnalyzer/Checkers/Pthr

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2663205 , @glaubitz wrote: > I think, however, we should bump the rest of the paths to 10.2.0 if possible. I updated all the Linux trees that were on 4.6.0. The only remaining 4.6.0 trees are for Hurd, which seems to me

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2663247 , @hvdijk wrote: > In D52050#2663205 , @glaubitz wrote: > >> I think, however, we should bump the rest of the paths to 10.2.0 if possible. > > I updated all the Linux tree

[PATCH] D99711: [RISCV] [2/2] Add intrinsic for Zbc extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, kito-cheng, asb, jrtc27, Jim. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMos

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

Naghasan added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + ABataev wrote: > bader wrote: > > Na

[clang] df4fa53 - [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

Author: Balázs Kéri Date: 2021-04-01T11:59:00+02:00 New Revision: df4fa53fddb61c2514e7e09fb7cdde53edced958 URL: https://github.com/llvm/llvm-project/commit/df4fa53fddb61c2514e7e09fb7cdde53edced958 DIFF: https://github.com/llvm/llvm-project/commit/df4fa53fddb61c2514e7e09fb7cdde53edced958.diff L

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf4fa53fddb6: [clang][Checkers] Extend PthreadLockChecker state dump (NFC). (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/

[PATCH] D99712: [RISCV] [2/2] Add intrinsic for Zbc extension

LevyHsu created this revision. LevyHsu added reviewers: craig.topper, kito-cheng, asb, jrtc27, Jim. LevyHsu added projects: clang, LLVM. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, usaxena95, s.egerton, benna, psnobl, kadircet, jocewei, PkmX, arphama

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

martong accepted this revision. martong added a comment. LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99658/new/ https://reviews.llvm.org/D99658 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D99659: [analyzer][taint] Extent of heap regions should get taint sometimes

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. I like it, looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99659/new/ https://reviews.llvm.org/D99659 ___

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

mgartmann updated this revision to Diff 334632. mgartmann marked an inline comment as done. mgartmann added a comment. Add isInStdNamespace to matcher so that only global objects in namespace `std` are matched and add corresponding tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

mgartmann added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:25 + .bind("match"), + this); +} mgartmann wrote: > riccibruno wrote: > > Will this match `my_namespace::cin`? > Yes, at the moment

[PATCH] D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker.

balazske created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of this revi

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok updated this revision to Diff 334636. alok added a comment. Re-based and minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99160/new/ https://reviews.llvm.org/D99160 Files: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp llvm/lib/Target/X86/X86FastISel.cpp llvm/test/Co

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff created this revision. gargaroff added reviewers: serge-sans-paille, dblaikie, jyknight, JDevlieghere, yln, efriedma, ctetreau. Herald added a subscriber: mgorny. gargaroff requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This wil

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

gargaroff added a comment. This still breaks for us. The `find_package(Python3 ...)` from `Tooling/CMakeLists.txt` does not look for the minimum version and overrides the version that was already found through `llvm/CMakeLists.txt`. I opened D99715 to fix this

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff added a comment. Although I find it strange, that `find_package` is called again, even though it is already set through `llvm/CMakeLists.txt`, this patch does not try to refactor this in any way. The sole purpose is to make tests executable again in our downstream setup. Repository:

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

riccibruno added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:25 + .bind("match"), + this); +} mgartmann wrote: > mgartmann wrote: > > riccibruno wrote: > > > Will this match `my_namespace::cin

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) djtodoro

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok updated this revision to Diff 334642. alok added a comment. Updated to address comments from @djtodoro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99238/new/ https://reviews.llvm.org/D99238 Files: clang/include/clang/Basic/CodeGenOptions.def clang/lib/Frontend/CompilerInvoca

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

eugenis added a comment. I'm not working on this currently, but I would appreciate and support such change. It's a big diff, but IMHO it is the cleanest, most maintainable approach. Gui, WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/n

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

ldionne added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION ${LIBCXX_INSTALL_HE

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION ${LIBCXX_INSTALL_HEA

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION ${LIBCXX_INSTALL_HEA

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/${CMAKE_I

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334576. Ericson2314 added a comment. Put on top of D99697 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-ext

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfcd21876adc: [debug-info] support new tuning debugger type DBX for XCOFF DWARF (authored by shchenz). Changed prior to commit: https://reviews.ll

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

shchenz added inline comments. Comment at: llvm/include/llvm/Target/TargetOptions.h:112 +SCE, // Tune debug info for SCE targets (e.g. PS4). +DBX // Tune debug info for dbx. }; aprantl wrote: > Nit: It would be nice to reformat all these com

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

shchenz created this revision. shchenz added reviewers: dblaikie, aprantl, jsji, probinson, echristo, PowerPC. shchenz added a project: debug-info. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For DBX, it does not handle column i

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 334644. khchen added a comment. Fix vfrdiv. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/ https://reviews.llvm.org/D99668 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

skatkov added a comment. First iteration: style comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:124 if (BBGuards) for (auto &BB : *BBGuards) { if (BB.second.isPoisoned()) redundant {} consider using any_of

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

skatkov added a comment. Consider landing tests update for "-verify-cfg-preserved=0" in a separate commit. This will significantly reduce the size of review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://reviews.llvm.org/D91327 __

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Naghasan added inline comments. Comment at: clang/docs/SYCLSupport.md:909 +| `__attribute__((opencl_local))` | local_space | +| `__attribute__((opencl_private))` | private_space | + bader wrote: > Anastasia wrote: > > Since SYCL spec has constant AS you should ex

[PATCH] D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker.

martong added a comment. The tests are really promising! :) Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:117 +namespace { +SVal getDynamicSizeWithOffset(ProgramStateRef State, const MemRegion *MRegion) { + SValBuilder &SvalBuilder = State->getStateMan

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c:35 +vint16mf4_t test_vwadd_vx_i16mf4(vint8mf8_t op1, int8_t op2, size_t vl) { + return vwadd_vx(op1, op2, vl); +} craig.topper wrote: > Why do scalars require _w

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 334647. khchen added a comment. Address Craig's comments. Sorry for a lot of typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/ri

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 334648. khchen added a comment. update missed part for Log2LMUL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/riscv_vector.td cla

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

ABataev added a comment. In D99689#2662875 , @jdoerfert wrote: > In D99689#2662860 , @ABataev wrote: > >> In D99689#2662856 , @jdoerfert >> wrote: >> >>> In D99689#2662852 <

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. Thank you for picking this back up! Comment at: clang/include/clang/Parse/Parser.h:2708 + bool MaybeParseGNUAttributes(ParsedAttributes &attrs, SourceLocation *endLoc = nullptr, aaron.ballman wro

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

serge-sans-paille added a comment. Did you try just removing that `find_package`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715 ___ cfe-commits mailing list cfe

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 334659. khchen added a comment. rebase and refine multiclass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https://reviews.llvm.org/D99669 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334660. serge-sans-paille added a comment. Do not use lexical parent, as suggested by @rsmith Add test case for extern function worward-declared in function body, as suggested by @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff added a comment. In D99715#2663588 , @serge-sans-paille wrote: > Did you try just removing that `find_package`? Simply removing it also works. I just wasn't sure whether it might be required by something else, but if not I can go ahead and cha

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334662. serge-sans-paille added a comment. Warn on friend functions. I failed to support friend classes, but they are only declared and not defined, so that should be fine, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ h

[clang] 7c541a1 - [OpenCL][Docs] Added a label for C++ libs section and example link

Author: Anastasia Stulova Date: 2021-04-01T13:55:23+01:00 New Revision: 7c541a195f651aa8d6aa270db83932a6ac7fac78 URL: https://github.com/llvm/llvm-project/commit/7c541a195f651aa8d6aa270db83932a6ac7fac78 DIFF: https://github.com/llvm/llvm-project/commit/7c541a195f651aa8d6aa270db83932a6ac7fac78.d

[PATCH] D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker.

balazske added a comment. It works not reliable for all data types. If `char` is used instead of `int` (in the test), the allocated size may be larger than the intended size of the array, probably because memory alignment adjustments. In the following case it is possible to index "past the end"

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski updated this revision to Diff 334667. awarzynski marked 3 inline comments as done. awarzynski added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99292/new/ https://reviews.llvm.org/D99292 Files: clang/inclu

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:142 + /// + /// \param [in] ppOpts The preprocessor options + void collectMacroDefinitions(); kiranchandramohan wrote: > Nit: Misplaced? Don't see any params here.

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334668. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/ParsedAttr.h clang/lib/Parse/ParseDecl.cpp clang/test/AST/sourceranges.cpp c

[PATCH] D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker.

martong added a comment. In D99714#2663677 , @balazske wrote: > It works not reliable for all data types. If `char` is used instead of `int` > (in the test), the allocated size may be larger than the intended size of the > array, probably because memory

[PATCH] D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:117 +namespace { +SVal getDynamicSizeWithOffset(ProgramStateRef State, const MemRegion *MRegion) { + SValBuilder &SvalBuilder = State->getStateManager().getSValBuilder(); --

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

mgartmann added a comment. In D99646#2661651 , @njames93 wrote: > Is it not wise to also check the c standard library. > So check for function refs to these names in the global or std namespace. > `printf`, `vprintf`, `puts`, `putchar`, `scanf`, `scanf`, `

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + Naghasan wrote: > ABataev wrote: > > ba

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

njames93 added a comment. In D99646#2663733 , @mgartmann wrote: > Hi @njames93, > I can see your point, I am going to add this functionality. > > However, I do not completely understand what you mean with //check for > function refs to these names in the

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. In D88978#2660274 , @arsenm wrote: > Is this still needed? Yes, I just got a little bogged down in the OMP code and haven't gotten back to it to finish it up. I anticipate needing to do this to soon, though. Repository:

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334689. bader marked 3 inline comments as done. bader added a comment. Applied code review suggestions from @Naghasan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Fil

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl created this revision. pestctrl added reviewers: akyrtzi, rsmith. pestctrl added a project: clang. pestctrl requested review of this revision. Herald added a subscriber: cfe-commits. I noticed this bug because attributes were being dropped from tentative definitions after the second tenta

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:383 + "identifier %0 is reserved because %select{" + "|" // passing 0 for %1 is not valid but we need that | to make the enum order match the diagnostic + "it starts with '_' at

[PATCH] D99190: [SYCL] Add design document for SYCL mode

Naghasan added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + bader wrote: > Naghasan wrote: > > A

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

craig.topper added a comment. A user interrupt is different than a regular interrupt right? It doesn't make sense that we would change the behavior of the interrupt calling convention just because the the user interrupt instructions are enabled. That would occur just from passing a -march for a

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

LuoYuanke added a comment. In D99708#2663989 , @craig.topper wrote: > A user interrupt is different than a regular interrupt right? It doesn't make > sense that we would change the behavior of the interrupt calling convention > just because the the user

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked an inline comment as not done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +se

[clang] 1ea9fa8 - [clang][parser] Set source ranges for GNU-style attributes

Author: Timm Bäder Date: 2021-04-01T17:25:23+02:00 New Revision: 1ea9fa8c507ec360cf43faf46d13b149e37c950d URL: https://github.com/llvm/llvm-project/commit/1ea9fa8c507ec360cf43faf46d13b149e37c950d DIFF: https://github.com/llvm/llvm-project/commit/1ea9fa8c507ec360cf43faf46d13b149e37c950d.diff LO

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ea9fa8c507e: [clang][parser] Set source ranges for GNU-style attributes (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 908a267 - Revert "[clang][parser] Set source ranges for GNU-style attributes"

Author: Timm Bäder Date: 2021-04-01T17:32:40+02:00 New Revision: 908a267b5a3b8dff1cd2af0f5971c05c30aaccb0 URL: https://github.com/llvm/llvm-project/commit/908a267b5a3b8dff1cd2af0f5971c05c30aaccb0 DIFF: https://github.com/llvm/llvm-project/commit/908a267b5a3b8dff1cd2af0f5971c05c30aaccb0.diff LO

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. Damn. Reverted again for the time being. The libc++ build seems to fail and I won't have time to look into that this week. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 __

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. In D75844#2664119 , @tbaeder wrote: > Damn. Reverted again for the time being. The libc++ build seems to fail and I > won't have time to look into that this week. :( Thank you for the quick revert! From looking at the test

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. Yep. I'll try to come up with a test and a fix next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list cf

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION ${CMAKE_INSTAL

[PATCH] D99190: [SYCL] Add design document for SYCL mode

bader marked an inline comment as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. +

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

aaron.ballman added a comment. The CI is showing build failures and there are some clang-tidy nits to be addressed as well. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:29 + // Is this: long r = int(x) * int(y); ? + //

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

hjl.tools added a comment. In D99708#2664076 , @LuoYuanke wrote: > In D99708#2663989 , @craig.topper > wrote: > >> A user interrupt is different than a regular interrupt right? It doesn't >> make sense that we wou

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen updated this revision to Diff 334720. cchen added a comment. Update codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/parallel_ast

[PATCH] D99738: [HIP] remove overloaded abs in header

yaxunl created this revision. yaxunl added reviewers: tra, JonChesterfield, ashi1. yaxunl requested review of this revision. This function seems to be introduced by accident by https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1 Such overloaded abs function did n

[PATCH] D99738: [HIP] remove overloaded abs in header

yaxunl added a comment. I have tested removing this did not cause regressions in our CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99738/new/ https://reviews.llvm.org/D99738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 ___ c

[PATCH] D99738: [HIP] remove overloaded abs in header

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99738/new/ https://reviews.llvm.org/D99738 ___ cfe-commits mailing list cfe-c

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

amccarth added a comment. In D99580#2660040 , @kamleshbhalui wrote: > In D99580#2659858 , @amccarth wrote: > >> It looks like the code change is for everyone, but the new test is specific >> to mingw. > > For Linu

[clang] 56b39af - [OpenMP51][DOCS] Mark "add present modifier in defaultmap clause" as

Author: cchen Date: 2021-04-01T11:02:23-05:00 New Revision: 56b39afb58627507ffbc7eaa749781a30b750c03 URL: https://github.com/llvm/llvm-project/commit/56b39afb58627507ffbc7eaa749781a30b750c03 DIFF: https://github.com/llvm/llvm-project/commit/56b39afb58627507ffbc7eaa749781a30b750c03.diff LOG: [O

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

craig.topper added a comment. In D99708#2664164 , @hjl.tools wrote: > In D99708#2664076 , @LuoYuanke wrote: > >> In D99708#2663989 , @craig.topper >> wrote: >> >>> A user in

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/ https://reviews.llvm.org/D99668 _

[clang] 85ff35a - [HIP] remove overloaded abs in header

Author: Yaxun (Sam) Liu Date: 2021-04-01T12:23:29-04:00 New Revision: 85ff35a9529a1ea9ed7ab8cda10761d66705d518 URL: https://github.com/llvm/llvm-project/commit/85ff35a9529a1ea9ed7ab8cda10761d66705d518 DIFF: https://github.com/llvm/llvm-project/commit/85ff35a9529a1ea9ed7ab8cda10761d66705d518.dif

[PATCH] D99738: [HIP] remove overloaded abs in header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85ff35a9529a: [HIP] remove overloaded abs in header (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D99688: [CUDA][HIP] rename -fcuda-flush-denormals-to-zero

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:2 // Checks that cuda compilation does the right thing when passed -// -fcuda-flush-denormals-to-zero. This shoul

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

hjl.tools added a comment. In D99708#2664218 , @craig.topper wrote: > In D99708#2664164 , @hjl.tools wrote: > >> In D99708#2664076 , @LuoYuanke >> wrote: >> >>> In D99708#2

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

craig.topper added a comment. In D99708#2664351 , @hjl.tools wrote: > In D99708#2664218 , @craig.topper > wrote: > >> In D99708#2664164 , @hjl.tools >> wrote: >> >>> In D99

  1   2   >