yaxunl created this revision. yaxunl added reviewers: tra, JonChesterfield, ashi1. yaxunl requested review of this revision.
This function seems to be introduced by accident by https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1 Such overloaded abs function did not exist before the refactoring, and does not exist in https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/__clang_cuda_cmath.h Conceptually it also does not make sense, since it adds something like double abs(int x) { return ::abs((double)x); } It caused regressions in CuPy. https://reviews.llvm.org/D99738 Files: clang/lib/Headers/__clang_hip_cmath.h Index: clang/lib/Headers/__clang_hip_cmath.h =================================================================== --- clang/lib/Headers/__clang_hip_cmath.h +++ clang/lib/Headers/__clang_hip_cmath.h @@ -323,7 +323,6 @@ } #endif -__HIP_OVERLOAD1(double, abs) __HIP_OVERLOAD1(double, acos) __HIP_OVERLOAD1(double, acosh) __HIP_OVERLOAD1(double, asin)
Index: clang/lib/Headers/__clang_hip_cmath.h =================================================================== --- clang/lib/Headers/__clang_hip_cmath.h +++ clang/lib/Headers/__clang_hip_cmath.h @@ -323,7 +323,6 @@ } #endif -__HIP_OVERLOAD1(double, abs) __HIP_OVERLOAD1(double, acos) __HIP_OVERLOAD1(double, acosh) __HIP_OVERLOAD1(double, asin)
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
