[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

HazardyKnusperkeks added a comment. In D99031#2640425 , @aybassiouny wrote: >> How about verifyFormat? Would that fail without your patch? > > @HazardyKnusperkeks sorry, but not sure that I understand your point. Are you > suggesting to use verifyFormat i

[clang] f263418 - [Driver] Gnu.cpp: remove obsoleted i386 triple detection from end-of-life distribution versions

Author: Fangrui Song Date: 2021-03-22T00:23:55-07:00 New Revision: f26341840253e15ab07c9e765733803fd3e4 URL: https://github.com/llvm/llvm-project/commit/f26341840253e15ab07c9e765733803fd3e4 DIFF: https://github.com/llvm/llvm-project/commit/f26341840253e15ab07c9e765733803fd3e4.diff

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu added a comment. In D98548#2625593 , @tmatheson wrote: > This seems quite an early point to bail out, so it will prevent some > errors/warnings associated with initialization from being emitted. For > example, this warning is currently emitted bu

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

vsavchenko updated this revision to Diff 332211. vsavchenko added a comment. Re-write the test using %clang_analyze_cc1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98948/new/ https://reviews.llvm.org/D98948 Files: clang/lib/StaticAnalyzer/Core

[clang] 3085bda - [analyzer][solver] Fix infeasible constraints (PR49642)

Author: Valeriy Savchenko Date: 2021-03-22T11:02:02+03:00 New Revision: 3085bda2b348f6a8b4e0bd1d230af4e9c900c9c4 URL: https://github.com/llvm/llvm-project/commit/3085bda2b348f6a8b4e0bd1d230af4e9c900c9c4 DIFF: https://github.com/llvm/llvm-project/commit/3085bda2b348f6a8b4e0bd1d230af4e9c900c9c4.d

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3085bda2b348: [analyzer][solver] Fix infeasible constraints (PR49642) (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Given that it did not change any reports in our testbench it seems to be safe to land it. It clearly improves the API significantly, so I'm not opposing. Really good work @vsavchenko. PS:

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! one final nit: `getInsertArgumentAdjuster` defaults the position to `ArgumentInsertPosition::END` when there's a single argument to insert. so you can drop those. CHANGES

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

kadircet added a comment. (also please let me know if I should land this for you, preferably with an email address to attribute the commit to) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98824/new/ https://reviews.llvm.org/D98824 ___ cfe-c

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder updated this revision to Diff 332213. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 Files: clang/lib/Parse/ParseStmt.cpp clang/test/CodeGenObjC/attr-nomerge.m Index: clang/test/CodeGenObjC/attr-nomerge.m ===

[clang] 82f6e0d - [Driver] -m32: Add /usr/include/i386-linux-gnu for Debian

Author: Fangrui Song Date: 2021-03-22T01:27:06-07:00 New Revision: 82f6e0dde29e6c6da27f64db5992eb539a57d21b URL: https://github.com/llvm/llvm-project/commit/82f6e0dde29e6c6da27f64db5992eb539a57d21b DIFF: https://github.com/llvm/llvm-project/commit/82f6e0dde29e6c6da27f64db5992eb539a57d21b.diff

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2637186 , @steakhal wrote: > Ah, I wanted to give it a go, but the bots caught an assertion failure for > the parent revision of this. See the details at the Bugzilla ticket >

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2640687 , @steakhal wrote: > Given that it did not change any reports in our testbench it seems to be safe > to land it. > > It clearly improves the API significantly, so I'm not opposing. > Really good work @vsavchen

[clang-tools-extra] f51ab18 - Make clangd CompletionModel usable even with non-standard (but supported) layout

Author: serge-sans-paille Date: 2021-03-22T10:05:25+01:00 New Revision: f51ab1871655a9a96134c2636c37dcb5a6b01ac3 URL: https://github.com/llvm/llvm-project/commit/f51ab1871655a9a96134c2636c37dcb5a6b01ac3 DIFF: https://github.com/llvm/llvm-project/commit/f51ab1871655a9a96134c2636c37dcb5a6b01ac3.d

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added a comment. In D86465#2640765 , @vsavchenko wrote: > I do have a bit of a struggle here. This is a unit-test and thus should be > compiled for all of the supported architectures by all of the supported > compilers. > Is there a `__has_feat

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius added a comment. I'll fix the formatting with the next update. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1445-1461 + unsigned TokKind = 0; + switch (Tok.getKind()) { + case tok::kw_mutable: TokKind = 0; break; + case tok::arrow: TokKind = 1; brea

[clang] 20d9326 - [OpenCL] Use -fdeclare-opencl-builtins for some tests

Author: Sven van Haastregt Date: 2021-03-22T09:46:28Z New Revision: 20d93267e18463292d54791f3c19211a85b27227 URL: https://github.com/llvm/llvm-project/commit/20d93267e18463292d54791f3c19211a85b27227 DIFF: https://github.com/llvm/llvm-project/commit/20d93267e18463292d54791f3c19211a85b27227.diff

[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

balazske added a comment. In D98951#2637807 , @shafik wrote: > Can we add a test for the `getCapturedVLAType` case? The test is added here: D99062 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D99063: [clang-format] Fix ObjC method indent after f7f9f94b

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit https://github.com/llvm/llvm-project/commit/f7f9f94b2e2b4c714bac9036f6b73a3df42daaff changed the indent of ObjC method arguments from +4 to +2,

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2637186 , @steakhal wrote: > Ah, I wanted to give it a go, but the bots caught an assertion failure for > the parent revision of this. See the details at the Bugzilla ticket >

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. LG! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98951 ___ cfe-

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 332236. Max_S added a comment. Fixed interaction between Before and After configurations options. Before handles the case of two access modifiers specification following each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LGTM! Thanks! Comment at: clang/unittests/AST/ASTImporterTest.cpp:6213-6216 + R"(void declToImport(int N) { + int VLA[N]; +

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S marked 4 inline comments as done. Max_S added a comment. > The tests in line 9462 and 9466 require some additional implementation. > EmptyLineAfterAccessModifier is adding the three lines since it is configured > to do so, but EmptyLineBeforeAccessModifier would remove these lines. Since

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Hmm, the new test seems to cause an assertion failure in llvm code generation in Windows. Is anything known about that? Is the test case wrong in some way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added a comment. In D86465#2640875 , @vsavchenko wrote: > This is not only a compiler feature, it also should be supported by the > target architecture: > https://godbolt.org/z/ddjYYx9x6 It's getting complicated then xD. I guess we should comple

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2640954 , @steakhal wrote: > In D86465#2640875 , @vsavchenko > wrote: > >> This is not only a compiler feature, it also should be supported by the >> target architecture: >> h

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added a comment. In D86465#2640958 , @vsavchenko wrote: > In D86465#2640954 , @steakhal wrote: > >> It's getting complicated then xD. I guess we should complement unittests >> with LIT tests? >> You can kn

[clang] 02b51e5 - [analyzer][solver] Redesign constraint ranges data structure

Author: Valeriy Savchenko Date: 2021-03-22T13:52:35+03:00 New Revision: 02b51e5316cd501ede547d0223e0f5416ebd9845 URL: https://github.com/llvm/llvm-project/commit/02b51e5316cd501ede547d0223e0f5416ebd9845 DIFF: https://github.com/llvm/llvm-project/commit/02b51e5316cd501ede547d0223e0f5416ebd9845.d

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02b51e5316cd: [analyzer][solver] Redesign constraint ranges data structure (authored by vsavchenko). Changed prior to commit: https://reviews.llvm

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added a comment. In D91949#2503646 , @MyDeveloperDay wrote: > I think the revision whilst it does what is needed to structs doesn't address > the many other times this forms appear. I think we need something a little > more extensi

[PATCH] D99018: [clang][flang] Moke the definition of `-module-dir` restricted to Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b002b12f2d: [clang][flang] Moke the definition of `-module-dir` restricted to Flang (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] b3b002b - [clang][flang] Moke the definition of `-module-dir` restricted to Flang

Author: Andrzej Warzynski Date: 2021-03-22T11:06:50Z New Revision: b3b002b12f2d6ebdb80b678dec0d14786cbef15a URL: https://github.com/llvm/llvm-project/commit/b3b002b12f2d6ebdb80b678dec0d14786cbef15a DIFF: https://github.com/llvm/llvm-project/commit/b3b002b12f2d6ebdb80b678dec0d14786cbef15a.diff

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5075 + "};", + Style); +} MyDeveloperDay wrote: > I wonder if there should be other options > > i.e. > > ``` > struct new_struct struct_na

[clang-tools-extra] f71404c - [clangd] Replace usages of dummy with more descriptive words

Author: Kadir Cetinkaya Date: 2021-03-22T12:49:24+01:00 New Revision: f71404c37c32902b66cf802bc18984be184d583e URL: https://github.com/llvm/llvm-project/commit/f71404c37c32902b66cf802bc18984be184d583e DIFF: https://github.com/llvm/llvm-project/commit/f71404c37c32902b66cf802bc18984be184d583e.dif

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 332250. balazske added a comment. Add regular expression to test, removed space characters from line endings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files:

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3812-3821 AST_POLYMORPHIC_MATCHER_P_OVERLOAD( hasType, AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, TypedefNameDecl, -ValueDecl), +

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/pthreadlock_state.c:55 + // CHECK-NEXT: "mtx: conj_$11{int, LC1, S1874, #1}", + // CHECK-NEXT: "" + // CHECK-NEXT:]} steakhal wrote: > Out

[clang] 2bbc9bc - [OpenCL] Support template parameters for as_type

Author: Sven van Haastregt Date: 2021-03-22T11:59:05Z New Revision: 2bbc9bccf095b92b3ed1ab9669fab8a7dc96ee6d URL: https://github.com/llvm/llvm-project/commit/2bbc9bccf095b92b3ed1ab9669fab8a7dc96ee6d DIFF: https://github.com/llvm/llvm-project/commit/2bbc9bccf095b92b3ed1ab9669fab8a7dc96ee6d.diff

[PATCH] D98855: [OpenCL] Support template parameters for as_type

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bbc9bccf095: [OpenCL] Support template parameters for as_type (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D98855?vs=331517&id=332251#toc Repository: rG LLVM Github Monore

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

steakhal added inline comments. Comment at: clang/test/Analysis/pthreadlock_state.c:70 + // CHECK-NEXT: "Mutexes in unresolved possibly destroyed state:", + // CHECK-NEXT: "SymRegion{reg_$12}: conj_$15{int, LC1, S1921, #1}", + // CHECK-NEXT: "" --

[PATCH] D98030: [IR] Add vscale_range IR function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48f5a392cb73: [IR] Add vscale_range IR function attribute (authored by bsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 48f5a39 - [IR] Add vscale_range IR function attribute

Author: Bradley Smith Date: 2021-03-22T12:05:06Z New Revision: 48f5a392cb73d99a58f01448926f6964ab5b0d0a URL: https://github.com/llvm/llvm-project/commit/48f5a392cb73d99a58f01448926f6964ab5b0d0a DIFF: https://github.com/llvm/llvm-project/commit/48f5a392cb73d99a58f01448926f6964ab5b0d0a.diff LOG:

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. Just a ping for you, guys, to let me move in this direction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh accepted this revision. svenvh added a comment. LGTM; just one minor comment, which you can address as part of your commit. Comment at: clang/test/CodeGenOpenCLCXX/addrspace-with-class.clcpp:2 +// RUN: %clang_cc1 %s -triple spir-unknown-unknown -emit-llvm -O0 -o - | Fil

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:60 + return RegexAndScope{ + .Regex = llvm::Regex(Name), + .MatchQualifiedName = Name.contains("::"), I do

[clang] 9cd7c41 - [analyzer] Don't include private gtest headers

Author: Dmitri Gribenko Date: 2021-03-22T13:31:38+01:00 New Revision: 9cd7c4130635a6f0c94046f529fb1ee19118bbfb URL: https://github.com/llvm/llvm-project/commit/9cd7c4130635a6f0c94046f529fb1ee19118bbfb DIFF: https://github.com/llvm/llvm-project/commit/9cd7c4130635a6f0c94046f529fb1ee19118bbfb.dif

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1445-1461 + unsigned TokKind = 0; + switch (Tok.getKind()) { + case tok::kw_mutable: TokKind = 0; break; + case tok::arrow: TokKind = 1; break; + case tok::kw___attribute: +

[PATCH] D99072: [NFC] Formatting changes

abhina.sreeskantharajan created this revision. Herald added subscribers: thopre, hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch addresses some formatting changes from the comm

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia closed this revision. Anastasia added a comment. Committed to the release branch in https://github.com/llvm/llvm-project/commit/00441b8f4e5b7daa39ac6cbeb45ebfe54662b08d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98076/new/ https://reviews.llvm.org/D98076 _

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

jnykiel updated this revision to Diff 332268. jnykiel added a comment. Thanks. About committing/attribution, I'm not sure how it's supposed to work - I've asked a co-worker (@aganea) to commit this, but if he can't do it, please do it instead. I'm Janusz Nykiel, email address janusz.nykiel at ub

[clang] ce9bade - [clang][ASTImporter] Add import API for 'const Type *' (NFC).

Author: Balázs Kéri Date: 2021-03-22T14:38:49+01:00 New Revision: ce9bade1f2c6249cf4179842aeb5e7e3bb34ceec URL: https://github.com/llvm/llvm-project/commit/ce9bade1f2c6249cf4179842aeb5e7e3bb34ceec DIFF: https://github.com/llvm/llvm-project/commit/ce9bade1f2c6249cf4179842aeb5e7e3bb34ceec.diff L

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rGce9bade1f2c6: [clang][ASTImporter] Add import API for 'const Type *' (NFC). (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2638824 , @MaskRay wrote: > The recommended named parameter form is probably `/*Param=*/something`. It is > liked by both > https://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman added a comment. In D55212#2640260 , @arichardson wrote: > I completely forgot about this patch. @aaron.ballman are you still happy for > me to commit this? I think where we left off is that this causes a slight regression in behavior beca

[PATCH] D99072: [NFC] Formatting changes

anirudhp accepted this revision. anirudhp added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99072/new/ https://reviews.llvm.org/D99072 _

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder updated this revision to Diff 332283. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 Files: clang/lib/Parse/ParseStmt.cpp clang/test/CodeGenObjC/attr-nomerge.m Index: clang/test/CodeGenObjC/attr-nomerge.m ===

[PATCH] D55212: Handle alloc_size attribute on function pointers

erik.pilkington accepted this revision. erik.pilkington added a comment. In D55212#2641301 , @aaron.ballman wrote: > I think folks will have a chance to react if we apply it to trunk now, but I > am wondering if anyone's had a chance to investigate usage

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

dcandler created this revision. dcandler added reviewers: t.p.northover, rsanthir.quic, SjoerdMeijer, efriedma, peter.smith, labrinea. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. dcandler requested review of this revision. Herald added projects: clang, LLVM. Herald added subscr

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. In D55212#2641402 , @erik.pilkington wrote: > In D55212#2641301 , @aaron.ballman > wrote: > >> I think folks will have a chance to react if we a

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 332293. balazske added a comment. Simplified the test somewhat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files: clang/lib/StaticAnalyzer/Checkers/PthreadLockC

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski added a comment. Thank you for adding this @arnamoy10 ! I think that in order to match the semantics of `-Werror` from `f18`, this patch needs to be extended a bit. In the following two cases, `f18` will exit immediately, whereas `flang-new -fc1` will happily carry-on: - https://g

[PATCH] D98812: [OPENMP]Map data field with l-value reference types.

ABataev updated this revision to Diff 332296. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98812/new/ https://reviews.llvm.org/D98812 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/targe

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc2

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 332303. ffrankies added a comment. Implemented changes requested by @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp clang-

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies marked 7 inline comments as done. ffrankies added a comment. @aaron.ballman If there are no more changes, can you please commit this on my behalf? My github username is ffrankies . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen updated this revision to Diff 332307. khchen added a comment. Remove half type in TypeList. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/ https://reviews.llvm.org/D98848 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

kadircet added a comment. SG, will wait for Alexandre to land this then! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98824/new/ https://reviews.llvm.org/D98824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332312. glaubitz retitled this revision from "[Sparc] Define the same macros for -mcpu=v9 as GCC on Linux" to "[Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs". glaubitz edited the summary of this revision. Repository: rG LLVM Gi

Re: [clang] c2f9086 - [Driver] Gnu.cpp: drop an unneeded special rule related to sysroot

Hi Fangrui, This change seems to have broken the link on Android: https://lab.llvm.org/buildbot/#/builders/77/builds/4777 Could you please take a look? ld.lld: error: /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/lib/

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

ctetreau added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:31-35 +namespace TypeSizeClOpt { +/// The ScalableErrorAsWarning is a temporary measure to suppress errors from +/// using the wrong interface. +extern cl::opt ScalableErrorAsWarning; +} // namespace

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

bjope added a comment. Hi! My users have found problems with miscompiles that seem to originate from this patch. As a background, my target has 16-bit int, and 32-bit long. And the calling convention is not that an i16 is passed as the low bits in a 32-bit register that would be used for an i

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332320. glaubitz edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Targets/Sparc.cpp clang/test/Preprocesso

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 created this revision. usaxena95 added reviewers: kadircet, sammccall. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. `expandedTokens(SourceRange)` used to do a binary search to get the expanded tokens bel

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. For reference, here is what GCC defines on Linux with regards to SPARC: glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep arch glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep LP glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep v9 #de

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv32-zbr.c:5 + +#include + I don't think this include is needed. You're calling the __builtin names directly. Comment at: clang/test/CodeGen/RISCV/rvb-

[PATCH] D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTH! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98959/new/ https://reviews.llvm.org/D98959 __

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

brad added a comment. In D98574#2641697 , @glaubitz wrote: > `-m32` is not supported on OpenBSD at all: > > openbsd# echo | gcc -E -dM -m32 - > :0: error: -m32 is not supported by this configuration > openbsd# Yes. OpenBSD has no 32-bit

[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

craig.topper added a comment. Please note I asked that this patch be separate from D99009 because the rvintrin.h file name may not be the final filename we want to use. This https://github.com/riscv/riscv-c-api-doc/pull/14 suggests it should be riscv_intrinsic

Re: [clang] c2f9086 - [Driver] Gnu.cpp: drop an unneeded special rule related to sysroot

Same error on the Android Chrome bots, although I didn't check if this commit was the issue. https://ci.chromium.org/ui/p/chromium/builders/ci/ToTAndroid/16087/overview On Mon, Mar 22, 2021 at 9:11 AM Matt Morehouse via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Fangrui, > > This chang

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332339. glaubitz edited the summary of this revision. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Ta

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. I have updated the patch now with the result that clang should behave as GCC now on Linux, NetBSD and OpenBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 332340. curdeius added a comment. - Use a generic message. - Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://reviews.llvm.org/D98433 Files: clang/include/clang/Basic/Diagnos

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen updated this revision to Diff 332341. khchen added a comment. update tests, remove target-feature zfh. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/ https://reviews.llvm.org/D98848 Files: clang/include/clang/Basic/riscv_vector.

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

rjmccall added a comment. Windows exceptions code-generation is quite different; I don't know whether Clang supports ObjC on Windows in general. It'd be fine if you add a `-triple` argument to this test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.or

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

aaron.ballman added a comment. In D97371#2641800 , @rjmccall wrote: > Windows exceptions code-generation is quite different; I don't know whether > Clang supports ObjC on Windows in general. It'd be fine if you add a > `-triple` argument to this test.

[clang] e421a74 - [ASTImporter] Fix import of ObjCPropertyDecl that share the same name

Author: Raphael Isemann Date: 2021-03-22T18:05:50+01:00 New Revision: e421a74108ee86afec133c77258470d3ed7dcc90 URL: https://github.com/llvm/llvm-project/commit/e421a74108ee86afec133c77258470d3ed7dcc90 DIFF: https://github.com/llvm/llvm-project/commit/e421a74108ee86afec133c77258470d3ed7dcc90.dif

[PATCH] D99077: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe421a74108ee: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name (authored by teemperor). Herald added a subscriber: cfe-commits.

[clang-tools-extra] 5a87f81 - new altera unroll loops check

Author: Frank Derry Wanye Date: 2021-03-22T13:09:53-04:00 New Revision: 5a87f81fe9aee996dfe3a84dd833f0a48e093e7f URL: https://github.com/llvm/llvm-project/commit/5a87f81fe9aee996dfe3a84dd833f0a48e093e7f DIFF: https://github.com/llvm/llvm-project/commit/5a87f81fe9aee996dfe3a84dd833f0a48e093e7f.d

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit on your behalf in 5a87f81fe9aee996dfe3a84dd833f0a48e093e7f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://revie

[clang] 5184f69 - Revert "[Driver] Gnu.cpp: drop an unneeded special rule related to sysroot"

Author: Arthur Eubanks Date: 2021-03-22T10:16:19-07:00 New Revision: 5184f69041166257e4c6a15e572d12c676cd0c31 URL: https://github.com/llvm/llvm-project/commit/5184f69041166257e4c6a15e572d12c676cd0c31 DIFF: https://github.com/llvm/llvm-project/commit/5184f69041166257e4c6a15e572d12c676cd0c31.diff

Re: [clang] c2f9086 - [Driver] Gnu.cpp: drop an unneeded special rule related to sysroot

I reverted this and the related change in 625fd7e54205077. The regression range did point to this and the related change. On Mon, Mar 22, 2021 at 9:42 AM Arthur Eubanks wrote: > Same error on the Android Chrome bots, although I didn't check if this > commit was the issue. > https://ci.chromium.o

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

StephenTozer added a comment. Apart from the one comment, LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1644-1650 + Opts.EnableDIPreservationVerify = Args.hasArg(OPT_fverify_debuginfo_preserve); + // Ignore the option if the -fverify-debuginfo-preserve wasn't e

[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99062/new/ https://reviews.llvm.org/D99062 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

shafik added a comment. Thank you for adding the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies added a comment. Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tra added a comment. In D98902#2640477 , @tianshilei1992 wrote: > In D98902#2636308 , @jdoerfert wrote: > >> @tra, so you think we should not do this? The user will see a link error >> late I assume, might be bett

  1   2   >