[PATCH] D97872: [clang] Don't assert in EmitAggregateCopy on trivial_abi types

rnk added inline comments. Comment at: clang/test/CodeGenCXX/trivial_abi.cpp:267 +// PR42961 +Small (*fp)() = []() -> Small {}; Please check for the IR for the `__invoke` member of the lambda class. I think it's at least a bit interesting that we create two allo

[clang] dca5737 - Move ObjCARCUtil.h back to llvm/Analysis

Author: Akira Hatanaka Date: 2021-03-08T16:35:24-08:00 New Revision: dca5737945b9a52d0c66c7ec0cbaa2e15ada69cf URL: https://github.com/llvm/llvm-project/commit/dca5737945b9a52d0c66c7ec0cbaa2e15ada69cf DIFF: https://github.com/llvm/llvm-project/commit/dca5737945b9a52d0c66c7ec0cbaa2e15ada69cf.diff

[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 updated this revision to Diff 329163. tianshilei1992 added a comment. update doc in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134 Files: clang/include/clang/Basic/AttrDocs.td clan

[PATCH] D97872: [clang] Don't assert in EmitAggregateCopy on trivial_abi types

aeubanks updated this revision to Diff 329165. aeubanks added a comment. check IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97872/new/ https://reviews.llvm.org/D97872 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGenCXX/trivial_abi

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs added a comment. In D97068#2611696 , @ggeorgakoudis wrote: > In D97068#2611269 , @thakis wrote: > >> Looks like this breaks tests on mac: http://45.33.8.238/macm1/5075/step_6.txt >> >> Please take a look,

[clang] a24644b - Revert "Run non-filechecked commands in update_cc_test_checks.py"

Author: Jon Roelofs Date: 2021-03-08T17:26:24-08:00 New Revision: a24644bb1ce09b40c2d751569dd5bb37ea9c995d URL: https://github.com/llvm/llvm-project/commit/a24644bb1ce09b40c2d751569dd5bb37ea9c995d DIFF: https://github.com/llvm/llvm-project/commit/a24644bb1ce09b40c2d751569dd5bb37ea9c995d.diff L

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs reopened this revision. jroelofs added a comment. This revision is now accepted and ready to land. Reverted in a24644bb1ce09b40c2d751569dd5bb37ea9c995d to get the bots green again. Feel free to re-land with a fix. R

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. @jroelofs, thank you very much for the much useful information. I will try to replicate the problem with the apple triple and fix it, if possible, or otherwise use your patch to avoid the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added a comment. In D93594#2606157 , @RKSimon wrote: > @yubing I've reverted this as it was failing on a lot of buildbots: > http://lab.llvm.org:8011/#/builders/109/builds/9867 Hi, @RKSimon @nicolasvasilache , it seems we haven't told libLLVMX86C

[PATCH] D97990: [clang] Always provide relevant subobject for 'no viable comparison'

mizvekov updated this revision to Diff 329178. mizvekov added a comment. Now this a patch just about improving the diagnostic as rsmith suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97990/new/ https://reviews.llvm.org/D97990 Files: cl

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

mizvekov added a comment. You are absolutely right, my bad!! So we stealth fix this revision to improve the message :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97990/new/ https://reviews.llvm.org/D97990 __

[PATCH] D98134: [WIP][RFC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 updated this revision to Diff 329191. tianshilei1992 added a comment. update llvm doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134 Files: clang/include/clang/Basic/AttrDocs.td clang/in

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. In D93938#2610568 , @curdeius wrote: > I hadn't had another look, because the CI still shows the test `AfterEnum` to > be failing. I know the test fails; it's due to a separate bug wherein `AfterEnum: true` and `AllowShortEnumsOn

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 329204. yubing added a comment. Fix buildfail when it is -DBUILD_SHARED_LIBS=ON Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2612908 , @atirit wrote: > In D93938#2610568 , @curdeius wrote: > >> I hadn't had another look, because the CI still shows the test `AfterEnum` >> to be failing. > > I

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 329207. ffrankies added a comment. - Ran `git-clang-format HEAD^` - Addressed comments automatically added by the Lint: Pre-merge Checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tools

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

curdeius added a comment. In D93938#2612952 , @HazardyKnusperkeks wrote: > In my opinion you should then, either temporarily deactivate the test, or fix > the bug first. A failing test blocks the pipeline and confuses everyone > working on the project.

Re: [PATCH] D93938: [clang-format] Fixed AfterEnum handling

+1 we are not going to land this with a failing or removed test On Tue, 9 Mar 2021 at 07:29, Marek Kurdej via Phabricator < revi...@reviews.llvm.org> wrote: > curdeius added a comment. > > In D93938#2612952 , > @HazardyKnusperkeks wrote: > > > In my opini

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. In D93938#2612952 , @HazardyKnusperkeks wrote: > In my opinion you should then, either temporarily deactivate the test, or fix > the bug first. A failing test blocks the pipeline and confuses everyone > working on the project.

[PATCH] D98237: Option for empty lines after an access modifier.

Max_S created this revision. Max_S requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current logic for access modifiers in classes ignores the option 'MaxEmptyLinesToKeep=1'. It is therefore impossible to have a coding style that reques

<    1   2